[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533896432 @cjwmorgan-sol Thank you very much for your feedback. 👍 I've added message tracing support to our backlog https://issues.apache.org/jira/browse/AMQNET-613 @michaelandrepearce It would be great if we have this merged any time soon. 😄 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open closed principle. I don't know how it looks like in the real world applications, but I assume that RuntimeException is the base for all the exception that people are normally throwing. I'm not particularly happy with the idea of pretending that .NET SystemExceptions are equivalent of Java Run-time Exceptions, and treating them differently. All .NET exceptions are run-time exceptions. There is no concept of checked exceptions (glory be) in .NET world, hence I wouldn't pay too much attention to them. Taking into account what Michael said, my inclination would be not to add this logging after all. We can address this problem (if there is a real problem) in the future by implementing message tracing system, but for now I wound give it a rest. Especially after I saw that some people are throwing exceptions from listener's callbacks in order to reject messages and this is, for whatever reason, valid scenario to them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open closed principle. I don't know how it looks like in the real world applications, but I assume that RuntimeException is the base for all the exception that people are normally throwing. I'm not particularly happy with the idea of pretending that .NET SystemExceptions are equivalent of Java Run-time Exceptions, and treating them differently. All .NET exceptions are run-time exceptions. There concept of checked exceptions doesn't exist (glory be) in .NET world, hence I wouldn't pay too much attention to them. Taking into account what Michael said, my inclination would be not to add this logging after all. We can address this problem (if there is a real problem) in the future by implementing message tracing system, but for now I wound give it a rest. Especially after I saw that some people are throwing exceptions from listener's callbacks in order to reject messages and this is, for whatever reason, valid scenario to them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-533690118 I'm not a Java expert, but what I remember from Uncle Bob's Clean Code I read years ago, you shouldn't use checked exception as they violate open closed principle. I don't know how it looks like in the real world applications, but I assume that RuntimeException is the base for all the exception that people are normally throwing. I'm not particularly happy with the idea of pretending that .NET SystemExceptions are equivalent of Java Run-time Exceptions, and treating them differently. All .NET exceptions are run-time exceptions. There concept of checked exceptions doesn't exist (glory be) in .NET world, hence I wouldn't pay too much attention to them. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-532892930 @cjwmorgan-sol @michaelandrepearce Where are we with this one? Are we coming to any conclusions? I don't know if I am to make any adjustments or what. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530998160 That's understandable, but I was referring to the @cjwmorgan-sol suggestion to log this scenario: https://github.com/apache/activemq-nms-amqp/blob/fe657101365e13fb9606962fdc1fcb3160f00116/src/NMS.AMQP/NmsMessageConsumer.cs#L255-L262 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [activemq-nms-amqp] Havret edited a comment on issue #28: NO-JIRA: Extend logging
Havret edited a comment on issue #28: NO-JIRA: Extend logging URL: https://github.com/apache/activemq-nms-amqp/pull/28#issuecomment-530553439 @cjwmorgan-sol There weren't any logs there, because in qpid-jms there weren't any logs. I don't see any reason why wouldn't we have them included. The only question is, what level of logging should we use. @michaelandrepearce Any thoughts? BTW. qpid-jms uses tracer to handle this particular situation, but this is something they've introduced just recently. And this is definitely not the same kind of tracer that we have in NMS. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
