[GitHub] [hive] jcamachor merged pull request #1119: HIVE-23699: Cleanup HIVEQUERYRESULTFILEFORMAT handling

jcamachor merged pull request #1119: URL: https://github.com/apache/hive/pull/1119 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] belugabehr closed pull request #1203: HIVE-22674: Replace Base64 in serde Package

belugabehr closed pull request #1203: URL: https://github.com/apache/hive/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] belugabehr commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

belugabehr commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r451242285 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1336,6 +1341,9 @@ public static long

[GitHub] [hive] StefanXiepj commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

StefanXiepj commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r451232462 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1336,6 +1341,9 @@ public static long

[GitHub] [hive] StefanXiepj commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

StefanXiepj commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r451260035 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1336,6 +1341,9 @@ public static long

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451282795 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java ## @@ -123,13 +123,13 @@ public void

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451288969 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -198,6 +446,29 @@

[GitHub] [hive] pvary commented on pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on pull request #1221: URL: https://github.com/apache/hive/pull/1221#issuecomment-655300805 One more thing: Do I remember correctly, that all the logs are on debug level? I think it would be good to have 1 or 2 log lines in info level, just t confirm that everything is

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451283245 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/filtercontext/DatabaseFilterContext.java ## @@ -0,0 +1,78 @@ +/*

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451290794 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451289748 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -312,5 +578,13 @@ private

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451285302 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451286260 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451283728 ## File path: ql/src/test/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/TestHiveMetaStoreAuthorizer.java ## @@ -283,4 +284,50 @@ public

[GitHub] [hive] pvary commented on pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on pull request #1221: URL: https://github.com/apache/hive/pull/1221#issuecomment-655295871 I have done a first sweeping review. A few asks: * Beware of HMS API changes * Check for memory consumption * Check for performance * Use checkstyle format check As

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451282859 ## File path: ql/src/test/org/apache/hadoop/hive/ql/metadata/TestSessionHiveMetastoreClientGetPartitionsTempTable.java ## @@ -123,13 +123,13 @@ public void

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451284085 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ## @@ -427,7 +428,7 @@

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451284051 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java ## @@ -416,7 +417,7 @@

[GitHub] [hive] pvary commented on a change in pull request #1221: HIVE-23786: HMS server side filter with Ranger

pvary commented on a change in pull request #1221: URL: https://github.com/apache/hive/pull/1221#discussion_r451287139 ## File path: ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/metastore/HiveMetaStoreAuthorizer.java ## @@ -85,38 +97,268 @@ public final

[GitHub] [hive] dlavati commented on pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654658403 I've seen some additional usage, however I'm not sure how these are utilized, thus I left it in so far: ```

[GitHub] [hive] klcopp commented on pull request #1175: HIVE-23760: Upgrading to Kafka 2.5 Clients

klcopp commented on pull request #1175: URL: https://github.com/apache/hive/pull/1175#issuecomment-654663659 Moved to https://github.com/apache/hive/pull/1216 This is an automated message from the Apache Git Service. To

[GitHub] [hive] klcopp closed pull request #1175: HIVE-23760: Upgrading to Kafka 2.5 Clients

klcopp closed pull request #1175: URL: https://github.com/apache/hive/pull/1175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [hive] klcopp opened a new pull request #1216: HIVE-23760: Upgrading to Kafka 2.5 Clients

klcopp opened a new pull request #1216: URL: https://github.com/apache/hive/pull/1216 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [hive] kgyrtkirk commented on pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

kgyrtkirk commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-654663722 I don't see the need for thiswhat's wrong with

[GitHub] [hive] kgyrtkirk commented on pull request #1207: HIVE-23483: Remove DynamicSerDe

kgyrtkirk commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654658790 > Looks like my new commit messed up the labeling (fyi @kgyrtkirk) > The checkout step for

[GitHub] [hive] dengzhhu653 edited a comment on pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

dengzhhu653 edited a comment on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-654678113 > I don't see the need for thiswhat's wrong with

[GitHub] [hive] dengzhhu653 commented on pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

dengzhhu653 commented on pull request #1205: URL: https://github.com/apache/hive/pull/1205#issuecomment-654678113 > I don't see the need for thiswhat's wrong with

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

kgyrtkirk commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r450655717 ## File path: serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/StandardConstantMapObjectInspector.java ## @@ -40,8 +41,10 @@ protected

[GitHub] [hive] mustafaiman commented on pull request #1192: HIVE-23780: Fail dropTable if acid cleanup fails

mustafaiman commented on pull request #1192: URL: https://github.com/apache/hive/pull/1192#issuecomment-654621572 @pvary can you review again? The existing tests used a hack to create transactional metastore tables on the spot when they were accessed the first time. When this happened

[GitHub] [hive] dlavati commented on pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654666554 > > Looks like my new commit messed up the labeling (fyi @kgyrtkirk) > > The checkout step for

[GitHub] [hive] dlavati edited a comment on pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati edited a comment on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654666554 > > Looks like my new commit messed up the labeling (fyi @kgyrtkirk) > > The checkout step for

[GitHub] [hive] kishendas opened a new pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

kishendas opened a new pull request #1217: URL: https://github.com/apache/hive/pull/1217 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] kgyrtkirk commented on a change in pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

kgyrtkirk commented on a change in pull request #1205: URL: https://github.com/apache/hive/pull/1205#discussion_r450699040 ## File path: service/src/java/org/apache/hive/service/server/HiveServer2OomHookRunner.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache Software

[GitHub] [hive] kgyrtkirk opened a new pull request #1215: HIVE-23806 avoid stat clear

kgyrtkirk opened a new pull request #1215: URL: https://github.com/apache/hive/pull/1215 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] dlavati commented on pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654656802 Looks like my new commit messed up the labeling (fyi @kgyrtkirk) The checkout step for

[GitHub] [hive] dlavati commented on pull request #1207: HIVE-23483: Remove DynamicSerDe

dlavati commented on pull request #1207: URL: https://github.com/apache/hive/pull/1207#issuecomment-654657249 @ashutoshc, @pgaref could you please take a look at this? Thank you! This is an automated message from the Apache

[GitHub] [hive] pvary commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r450752554 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableOperation.java ## @@ -62,7 +62,8 @@ public int execute() throws HiveException

[GitHub] [hive] pvary commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r450752554 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableOperation.java ## @@ -62,7 +62,8 @@ public int execute() throws HiveException

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450787844 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] dengzhhu653 commented on a change in pull request #1205: HIVE-23800: Make HiveServer2 oom hook interface

dengzhhu653 commented on a change in pull request #1205: URL: https://github.com/apache/hive/pull/1205#discussion_r450788257 ## File path: service/src/java/org/apache/hive/service/server/HiveServer2OomHookRunner.java ## @@ -0,0 +1,102 @@ +/* + * Licensed to the Apache

[GitHub] [hive] kgyrtkirk opened a new pull request #1218: [wip] explore HIVE-18138 revert

kgyrtkirk opened a new pull request #1218: URL: https://github.com/apache/hive/pull/1218 ## NOTICE Please create an issue in ASF JIRA before opening a pull request, and you need to set the title of the pull request which starts with the corresponding JIRA issue number. (e.g.

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450754328 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r450754893 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3580,7 +3592,19 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450765905 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -383,6 +475,7 @@ public Void

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r45058 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnDbUtil.java ## @@ -313,6 +313,41 @@ private

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450789075 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2032,28 +2077,61 @@ public

[GitHub] [hive] pvary commented on pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on pull request #1219: URL: https://github.com/apache/hive/pull/1219#issuecomment-654819192 Could you please validate your fix with the flaky test checker jenkins, and add the relevant url? Thanks, Peter

[GitHub] [hive] pvary commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450823301 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -568,6 +568,7 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450822761 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestAcidTxnCleanerService.java ## @@ -148,16 +149,16

[GitHub] [hive] pvargacl commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvargacl commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450829187 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -568,6 +568,7 @@ public

[GitHub] [hive] pvargacl opened a new pull request #1220: HIVE-23413: Create a new config to skip all locks

pvargacl opened a new pull request #1220: URL: https://github.com/apache/hive/pull/1220 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450754040 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450753396 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450801959 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvargacl opened a new pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvargacl opened a new pull request #1219: URL: https://github.com/apache/hive/pull/1219 Fix flaky test This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450756822 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/Msck.java ## @@ -229,102 +239,168 @@ public int

[GitHub] [hive] pvary commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450822656 ## File path: standalone-metastore/metastore-server/src/test/java/org/apache/hadoop/hive/metastore/txn/TestAcidTxnCleanerService.java ## @@ -135,7 +136,7 @@

[GitHub] [hive] pvargacl commented on pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvargacl commented on pull request #1219: URL: https://github.com/apache/hive/pull/1219#issuecomment-654826153 @pvary It is already running :) http://ci.hive.apache.org/job/hive-flaky-check/64/ This is an automated message

[GitHub] [hive] pvary commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450844285 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -568,6 +568,7 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1219: HIVE-23525: TestAcidTxnCleanerService is unstable

pvary commented on a change in pull request #1219: URL: https://github.com/apache/hive/pull/1219#discussion_r450844111 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -568,6 +568,7 @@ public

[GitHub] [hive] pvary commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

pvary commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r450777027 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3917,12 +3972,26 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450785863 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450785738 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450786917 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2015,8 +2019,49 @@ public

[GitHub] [hive] pvargacl commented on a change in pull request #1087: HIVE-23671: MSCK repair should handle transactional tables

pvargacl commented on a change in pull request #1087: URL: https://github.com/apache/hive/pull/1087#discussion_r450793830 ## File path: standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java ## @@ -2032,28 +2077,61 @@ public

[GitHub] [hive] WangGuangxin opened a new pull request #865: [HIVE-22634]Improperly SemanticException when filter is optimized to False on a partition table

WangGuangxin opened a new pull request #865: URL: https://github.com/apache/hive/pull/865 When filter is optimized to False on a partition table, it will throw improperly SemanticException reporting that there is no partition predicate found. The step to reproduce is ``` set

[GitHub] [hive] WangGuangxin closed pull request #865: [HIVE-22634]Improperly SemanticException when filter is optimized to False on a partition table

WangGuangxin closed pull request #865: URL: https://github.com/apache/hive/pull/865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] dengzhhu653 edited a comment on pull request #1149: HIVE-23727: Improve SQLOperation log handling when cleanup

dengzhhu653 edited a comment on pull request #1149: URL: https://github.com/apache/hive/pull/1149#issuecomment-648507858 @belugabehr can you please take a look at the changes? thanks This is an automated message from the

[GitHub] [hive] belugabehr closed pull request #1203: HIVE-22674: Replace Base64 in serde Package

belugabehr closed pull request #1203: URL: https://github.com/apache/hive/pull/1203 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] belugabehr commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

belugabehr commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r450931946 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1336,6 +1341,9 @@ public static long

[GitHub] [hive] vineetgarg02 commented on a change in pull request #1212: HIVE-23807 Wrong results with vectorization enabled

vineetgarg02 commented on a change in pull request #1212: URL: https://github.com/apache/hive/pull/1212#discussion_r450945185 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/expressions/CastStringToDate.java ## @@ -116,14 +118,16 @@ public void

[GitHub] [hive] ramesh0201 commented on pull request #1177: HIVE-23665 Rewrite last_value to first_value to enable streaming results

ramesh0201 commented on pull request #1177: URL: https://github.com/apache/hive/pull/1177#issuecomment-654936523 hi @jcamachor, i have updated the PR to include the changes suggested. This is an automated message from the

[GitHub] [hive] belugabehr commented on a change in pull request #1209: HIVE-22412: StatsUtils throw NPE when explain

belugabehr commented on a change in pull request #1209: URL: https://github.com/apache/hive/pull/1209#discussion_r450931946 ## File path: ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java ## @@ -1336,6 +1341,9 @@ public static long

[GitHub] [hive] jcamachor commented on pull request #865: [HIVE-22634]Improperly SemanticException when filter is optimized to False on a partition table

jcamachor commented on pull request #865: URL: https://github.com/apache/hive/pull/865#issuecomment-654920582 @WangGuangxin , can we add the test to the PR? This is an automated message from the Apache Git Service. To

[GitHub] [hive] belugabehr closed pull request #1118: HIVE-23363: Upgrade DataNucleus dependency to 5.2

belugabehr closed pull request #1118: URL: https://github.com/apache/hive/pull/1118 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] nrg4878 commented on pull request #1117: HIVE-23388: CTAS queries should use target's location for staging (Na…

nrg4878 commented on pull request #1117: URL: https://github.com/apache/hive/pull/1117#issuecomment-654941642 Fix has been merged. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [hive] nrg4878 closed pull request #1117: HIVE-23388: CTAS queries should use target's location for staging (Na…

nrg4878 closed pull request #1117: URL: https://github.com/apache/hive/pull/1117 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451058731 ## File path: ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java ## @@ -3580,7 +3592,19 @@ public boolean dropPartition(String dbName, String

[GitHub] [hive] belugabehr closed pull request #1199: HIVE-23795: Add Additional Debugging Help for Import SQL

belugabehr closed pull request #1199: URL: https://github.com/apache/hive/pull/1199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] kishendas commented on a change in pull request #1217: Hive 23767 : Pass ValidWriteIdList in get_* HMS API requests from HMS Client

kishendas commented on a change in pull request #1217: URL: https://github.com/apache/hive/pull/1217#discussion_r451057776 ## File path: ql/src/java/org/apache/hadoop/hive/ql/ddl/table/create/CreateTableOperation.java ## @@ -62,7 +62,8 @@ public int execute() throws

[GitHub] [hive] belugabehr closed pull request #1197: HIVE-23793: Review of QueryInfo Class

belugabehr closed pull request #1197: URL: https://github.com/apache/hive/pull/1197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [hive] sam-an-cloudera opened a new pull request #1221: HIVE-23786: HMS server side filter with Ranger

sam-an-cloudera opened a new pull request #1221: URL: https://github.com/apache/hive/pull/1221 HIVE-23786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and