[GitHub] [hive] ashish-kumar-sharma commented on pull request #2128: HIVE-23571: Add ValidWriteIdList to SharedCache.TableWrapper

ashish-kumar-sharma commented on pull request #2128: URL: https://github.com/apache/hive/pull/2128#issuecomment-839420970 @kishendas Could you please review this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…

ArkoSharma commented on a change in pull request #2135: URL: https://github.com/apache/hive/pull/2135#discussion_r630741577 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java ## @@ -33,6 +33,7 @@ private String dumpDir;

[GitHub] [hive] kasakrisz closed pull request #2227: HIVE-25063: Enforce hive.default.nulls.last when enforce bucketing

kasakrisz closed pull request #2227: URL: https://github.com/apache/hive/pull/2227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] kasakrisz commented on pull request #2227: HIVE-25063: Enforce hive.default.nulls.last when enforce bucketing

kasakrisz commented on pull request #2227: URL: https://github.com/apache/hive/pull/2227#issuecomment-839410390 SMB join expects nulls first behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [hive] jcamachor opened a new pull request #2263: HIVE-25105: Support Parquet as MV storage format

jcamachor opened a new pull request #2263: URL: https://github.com/apache/hive/pull/2263 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] kasakrisz merged pull request #2231: HIVE-25071: Number of reducers limited to fixed 1 when updating/deleting

kasakrisz merged pull request #2231: URL: https://github.com/apache/hive/pull/2231 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…

ArkoSharma commented on a change in pull request #2135: URL: https://github.com/apache/hive/pull/2135#discussion_r630735633 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java ## @@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws

[GitHub] [hive] kasakrisz opened a new pull request #2257: HIVE-25066: Show whether a materialized view supports incremental review or not

kasakrisz opened a new pull request #2257: URL: https://github.com/apache/hive/pull/2257 ### What changes were proposed in this pull request? 1. Analyze Materialized view definition plan and check if can be transformed to incremental rebuild plan when when loading and parsing

[GitHub] [hive] lcspinter opened a new pull request #2258: HIVE-25100: Use default values of Iceberg client pool configuration

lcspinter opened a new pull request #2258: URL: https://github.com/apache/hive/pull/2258 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How was

[GitHub] [hive] lcspinter commented on pull request #2258: HIVE-25100: Use default values of Iceberg client pool configuration

lcspinter commented on pull request #2258: URL: https://github.com/apache/hive/pull/2258#issuecomment-838088760 @marton-bod @pvary Could you please review this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [hive] maheshk114 merged pull request #2071: HIVE-24883 : Add support for complex types columns in Hive Joins

maheshk114 merged pull request #2071: URL: https://github.com/apache/hive/pull/2071 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] marton-bod commented on pull request #2258: HIVE-25100: Use default values of Iceberg client pool configuration

marton-bod commented on pull request #2258: URL: https://github.com/apache/hive/pull/2258#issuecomment-838270410 cc @szlta -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [hive] aasha commented on a change in pull request #2249: HIVE-25092. Add a shell script to fetch the statistics of replication data copy tasks.

aasha commented on a change in pull request #2249: URL: https://github.com/apache/hive/pull/2249#discussion_r630018046 ## File path: bin/replstats.sh ## @@ -0,0 +1,95 @@ +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements.

[GitHub] [hive] stoty opened a new pull request #2259: [WIP] HIVE-25101: Remove HBase libraries from HBase distribution

stoty opened a new pull request #2259: URL: https://github.com/apache/hive/pull/2259 ### What changes were proposed in this pull request? - Mark all HBase dependencies as provided, so that they are not include in the distribution package - Add the hbase mapredcp jars to AUX_PARAM in

[GitHub] [hive] rbalamohan commented on a change in pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

rbalamohan commented on a change in pull request #2242: URL: https://github.com/apache/hive/pull/2242#discussion_r629967730 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorMapOperator.java ## @@ -885,20 +885,7 @@ public void process(Writable value)

[GitHub] [hive] ArkoSharma commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…

ArkoSharma commented on a change in pull request #2135: URL: https://github.com/apache/hive/pull/2135#discussion_r630740615 ## File path: ql/src/java/org/apache/hadoop/hive/ql/parse/repl/load/log/IncrementalLoadLogger.java ## @@ -33,6 +33,7 @@ private String dumpDir;

[GitHub] [hive] aasha commented on a change in pull request #2240: HIVE-25086: Create Ranger Deny Policy for replication db in all cases.

aasha commented on a change in pull request #2240: URL: https://github.com/apache/hive/pull/2240#discussion_r629863116 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/RangerDenyTask.java ## @@ -0,0 +1,150 @@ +/* + * Licensed to the Apache Software Foundation

[GitHub] [hive] belugabehr closed pull request #1801: HIVE-24555: Improve Hive Class Logging/Error Handling

belugabehr closed pull request #1801: URL: https://github.com/apache/hive/pull/1801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] abstractdog commented on pull request #2242: HIVE-21935: Hive Vectorization : degraded performance with vectorize UDF

abstractdog commented on pull request #2242: URL: https://github.com/apache/hive/pull/2242#issuecomment-838819612 the change makes sense to me, could you confirm that this use-case is covered by a q.test? I was looking for qtests, I found similar ones but only with struct type

[GitHub] [hive] lcspinter opened a new pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

lcspinter opened a new pull request #2261: URL: https://github.com/apache/hive/pull/2261 ### What changes were proposed in this pull request? Introduce a caching layer to store iceberg table objects used within the same query. The entries are saved with the following key format

[GitHub] [hive] dengzhhu653 closed pull request #1998: HIVE-24802: Show operation log at webui

dengzhhu653 closed pull request #1998: URL: https://github.com/apache/hive/pull/1998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] kgyrtkirk commented on pull request #2237: HIVE-25083: Extra reviewer pattern

kgyrtkirk commented on pull request #2237: URL: https://github.com/apache/hive/pull/2237#issuecomment-838604654 @pgaref probably the `'**/llap/**'` pattern might be also interesting for you - but it's great to see that you are using this stuff! :D -- This is an automated message

[GitHub] [hive] pgaref opened a new pull request #2262: HIVE-25103: Update row.serde exclude defaults

pgaref opened a new pull request #2262: URL: https://github.com/apache/hive/pull/2262 Change-Id: I3db47765cf7dcc524c43bb94a3dca223590ffcda ### What changes were proposed in this pull request? HIVE-16222 introduced row.serde.inputformat.excludes setting to disable

[GitHub] [hive] marton-bod opened a new pull request #2260: Do not exclude avatica and protobuf for Iceberg

marton-bod opened a new pull request #2260: URL: https://github.com/apache/hive/pull/2260 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service,

[GitHub] [hive] pgaref merged pull request #2237: HIVE-25083: Extra reviewer pattern

pgaref merged pull request #2237: URL: https://github.com/apache/hive/pull/2237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [hive] lcspinter commented on pull request #2261: HIVE-25102: Cache Iceberg table objects within same query

lcspinter commented on pull request #2261: URL: https://github.com/apache/hive/pull/2261#issuecomment-838467872 @marton-bod @pvary @szlta Could you please review this PR? Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] kishendas commented on pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

kishendas commented on pull request #2238: URL: https://github.com/apache/hive/pull/2238#issuecomment-839289414 Can you please fill these ? What changes were proposed in this pull request? Why are the changes needed? Does this PR introduce any user-facing change?

[GitHub] [hive] kishendas commented on a change in pull request #2238: HIVE-25085: MetaStore Clients no longer shared across sessions.

kishendas commented on a change in pull request #2238: URL: https://github.com/apache/hive/pull/2238#discussion_r630589315 ## File path: service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java ## @@ -408,18 +400,10 @@ private synchronized void

[GitHub] [hive] pkumarsinha commented on a change in pull request #2135: HIVE-24956: Add debug logs for time taken in the incremental event pr…

pkumarsinha commented on a change in pull request #2135: URL: https://github.com/apache/hive/pull/2135#discussion_r630468790 ## File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java ## @@ -681,6 +682,7 @@ private int executeIncrementalLoad() throws

[GitHub] [hive] belugabehr opened a new pull request #1801: HIVE-24555: Improve Hive Class Logging/Error Handling

belugabehr opened a new pull request #1801: URL: https://github.com/apache/hive/pull/1801 ### What changes were proposed in this pull request? ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? ### How

[GitHub] [hive] kishendas commented on pull request #2211: HIVE-23931: Send ValidWriteIdList and tableId to get_*_constraints HMS APIs

kishendas commented on pull request #2211: URL: https://github.com/apache/hive/pull/2211#issuecomment-839040001 @ashish-kumar-sharma Please ping me, once you add the test cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [hive] pkumarsinha commented on a change in pull request #2101: HIVE-24909: Skip the repl events from getting logged in notification log

pkumarsinha commented on a change in pull request #2101: URL: https://github.com/apache/hive/pull/2101#discussion_r630392694 ## File path: ql/src/java/org/apache/hadoop/hive/ql/lockmgr/DbTxnManager.java ## @@ -584,6 +600,7 @@ public void rollbackTxn() throws LockException {