[GitHub] [arrow] kou closed pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou closed pull request #7914: URL: https://github.com/apache/arrow/pull/7914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670257310 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] jianxind commented on pull request #7903: ARROW-9643: [C++] Only register the SIMD variants when it's supported.

2020-08-06 Thread GitBox
jianxind commented on pull request #7903: URL: https://github.com/apache/arrow/pull/7903#issuecomment-670254114 Ping, @wesm @pitrou @emkornfield Sorry to bother you, but can we prioritize this fix as it's a critical panic bug? The fix is simple enough.

[GitHub] [arrow] github-actions[bot] commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670217938 Revision: e1a789f86597061542fcb62809e0f564de7c3213 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670217197 @github-actions crossbow submit wheel-win-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670207073 Revision: fce50299d70ae19b06e5088398caca6fe65ac826 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670206054 @github-actions crossbow submit wheel-win-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670202398 https://issues.apache.org/jira/browse/ARROW-9666 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670201548 Revision: acd9467c8b8d336a239f0afd94f92f01440723de Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou commented on pull request #7914: URL: https://github.com/apache/arrow/pull/7914#issuecomment-670200451 @github-actions crossbow submit wheel-win-* This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] kou opened a new pull request #7914: ARROW-9666: [Python][wheel][Windows] Fix wheel build for Windows

2020-08-06 Thread GitBox
kou opened a new pull request #7914: URL: https://github.com/apache/arrow/pull/7914 It's caused by ARROW-9412 https://github.com/apache/arrow/pull/7842 . This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] Marwes commented on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use Vec

2020-08-06 Thread GitBox
Marwes commented on pull request #7176: URL: https://github.com/apache/arrow/pull/7176#issuecomment-670161388 Sorry, I suspect I won't have time to do any further changes to this for at least a month. This is an automated

[GitHub] [arrow] github-actions[bot] commented on pull request #7913: ARROW-9665: [R] head/tail/take for Datasets

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7913: URL: https://github.com/apache/arrow/pull/7913#issuecomment-670157352 https://issues.apache.org/jira/browse/ARROW-9665 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #7913: ARROW-9665: [R] head/tail/take for Datasets

2020-08-06 Thread GitBox
nealrichardson opened a new pull request #7913: URL: https://github.com/apache/arrow/pull/7913 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] trxcllnt commented on pull request #7909: ARROW-9659: [C++] Fix RecordBatchStreamReader when source is CudaBufferReader

2020-08-06 Thread GitBox
trxcllnt commented on pull request #7909: URL: https://github.com/apache/arrow/pull/7909#issuecomment-670138897 @pitrou I'm not a huge fan of the changes in this PR, but they seemed like the least invasive option considering the alternatives: * Avoided using `ViewOrCopy` because

[GitHub] [arrow] github-actions[bot] commented on pull request #7912: Ruby gem no doc tweak

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7912: URL: https://github.com/apache/arrow/pull/7912#issuecomment-670074457 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] Rajpratik71 opened a new pull request #7912: Ruby gem no doc tweak

2020-08-06 Thread GitBox
Rajpratik71 opened a new pull request #7912: URL: https://github.com/apache/arrow/pull/7912 Optimization tweak for ruby gems no doc while gems installation using "--no-document" . Also removal of depricated "--no-ri" and "--no-rdoc". More detail can be found at

[GitHub] [arrow] github-actions[bot] commented on pull request #7911: ARROW-9606: [C++][Dataset] Support `"a"_.In(<>).Assume()`

2020-08-06 Thread GitBox
github-actions[bot] commented on pull request #7911: URL: https://github.com/apache/arrow/pull/7911#issuecomment-670033979 https://issues.apache.org/jira/browse/ARROW-9606 This is an automated message from the Apache Git

[GitHub] [arrow] pitrou commented on pull request #7909: ARROW-9659: [C++] Fix RecordBatchStreamReader when source is CudaBufferReader

2020-08-06 Thread GitBox
pitrou commented on pull request #7909: URL: https://github.com/apache/arrow/pull/7909#issuecomment-670027426 Thanks for spotting this. I think we should find a proper way of dealing with validation of non-CPU arrays (for example by viewing the data on the CPU, using

[GitHub] [arrow] bkietz closed pull request #7900: ARROW-9573: [Python][Dataset] Provide read_table(ignore_prefixes=)

2020-08-06 Thread GitBox
bkietz closed pull request #7900: URL: https://github.com/apache/arrow/pull/7900 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] bkietz opened a new pull request #7911: ARROW-9606: [C++][Dataset] Support "a"_.In(<>).Assume()"

2020-08-06 Thread GitBox
bkietz opened a new pull request #7911: URL: https://github.com/apache/arrow/pull/7911 @mpjdem This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] andygrove commented on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use Vec

2020-08-06 Thread GitBox
andygrove commented on pull request #7176: URL: https://github.com/apache/arrow/pull/7176#issuecomment-669973140 Hi @Marwes ... just checking in on status. Are you able to make the proposed changes? This is an automated

[GitHub] [arrow] andygrove closed pull request #7798: ARROW-9523 [Rust] Improve filter kernel performance

2020-08-06 Thread GitBox
andygrove closed pull request #7798: URL: https://github.com/apache/arrow/pull/7798 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove closed pull request #7899: ARROW-9632: [Rust] add a func "new" for ExecutionContextSchemaProvider

2020-08-06 Thread GitBox
andygrove closed pull request #7899: URL: https://github.com/apache/arrow/pull/7899 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove closed pull request #7905: ARROW-9656: [Rust] [DataFusion] Better error messages for unsupported EXTERNAL TABLE types

2020-08-06 Thread GitBox
andygrove closed pull request #7905: URL: https://github.com/apache/arrow/pull/7905 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove commented on pull request #7894: ARROW-9631: [Rust] Make arrow not depend on flight

2020-08-06 Thread GitBox
andygrove commented on pull request #7894: URL: https://github.com/apache/arrow/pull/7894#issuecomment-669969605 @vertexclique The release scripts now need updating. I spent some time trying to fix them myself this morning but I am out of time for now. To reproduce locally you can

[GitHub] [arrow] bkietz commented on pull request #7907: ARROW-9644: [C++][Dataset] Don't apply ignore_prefixes to partition base_dir

2020-08-06 Thread GitBox
bkietz commented on pull request #7907: URL: https://github.com/apache/arrow/pull/7907#issuecomment-669950497 (again, moot for python since the two directories are identical) Since the user's selection of paths is really based in `selector.base_dir`, I think it'd be more approprate to

[GitHub] [arrow] praveenbingo closed pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

2020-08-06 Thread GitBox
praveenbingo closed pull request #7872: URL: https://github.com/apache/arrow/pull/7872 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] pereverges opened a new issue #7910: OSError: Could not connect to socket

2020-08-06 Thread GitBox
pereverges opened a new issue #7910: URL: https://github.com/apache/arrow/issues/7910 When creating a lot of clients, It seems that plasma can not connect all of them to the store. I got the following error: File "pyarrow/_plasma.pyx", line 852, in pyarrow._plasma.connect

[GitHub] [arrow] rymurr commented on a change in pull request #7248: ARROW-8402: [Java] Support ValidateFull methods in Java

2020-08-06 Thread GitBox
rymurr commented on a change in pull request #7248: URL: https://github.com/apache/arrow/pull/7248#discussion_r466313682 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorBufferVisitor.java ## @@ -0,0 +1,221 @@ +/* + * Licensed to the

[GitHub] [arrow] sagnikc-dremio commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

2020-08-06 Thread GitBox
sagnikc-dremio commented on a change in pull request #7872: URL: https://github.com/apache/arrow/pull/7872#discussion_r466306802 ## File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc ## @@ -234,6 +234,37 @@ DIV_FLOAT(float64) #undef DIV_FLOAT +#define

[GitHub] [arrow] liyafan82 commented on pull request #7248: ARROW-8402: [Java] Support ValidateFull methods in Java

2020-08-06 Thread GitBox
liyafan82 commented on pull request #7248: URL: https://github.com/apache/arrow/pull/7248#issuecomment-669837093 @rymurr @emkornfield Thanks a lot for your feedback. If there are no more comments, I will merge it tomorrow.

[GitHub] [arrow] pprudhvi commented on a change in pull request #7872: ARROW-9607: [C++][Gandiva] Add bitwise_and(), bitwise_or() and bitwise_not() functions for integers

2020-08-06 Thread GitBox
pprudhvi commented on a change in pull request #7872: URL: https://github.com/apache/arrow/pull/7872#discussion_r466223016 ## File path: cpp/src/gandiva/precompiled/arithmetic_ops.cc ## @@ -234,6 +234,37 @@ DIV_FLOAT(float64) #undef DIV_FLOAT +#define BITWISE_AND(TYPE)

[GitHub] [arrow] vertexclique commented on pull request #7894: ARROW-9631: [Rust] Make arrow not depend on flight

2020-08-06 Thread GitBox
vertexclique commented on pull request #7894: URL: https://github.com/apache/arrow/pull/7894#issuecomment-669776709 Yes, that's true, enabled it. Resolved. This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] kou commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
kou commented on pull request #7842: URL: https://github.com/apache/arrow/pull/7842#issuecomment-669764587 Thanks for testing this! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] tobim commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
tobim commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r466202760 ## File path: cpp/cmake_modules/FindSnappy.cmake ## @@ -15,25 +15,33 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [arrow] tobim commented on a change in pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
tobim commented on a change in pull request #7842: URL: https://github.com/apache/arrow/pull/7842#discussion_r466201256 ## File path: cpp/cmake_modules/FindSnappy.cmake ## @@ -15,25 +15,33 @@ # specific language governing permissions and limitations # under the License.

[GitHub] [arrow] tobim commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
tobim commented on pull request #7842: URL: https://github.com/apache/arrow/pull/7842#issuecomment-669758096 I just tested this overnight and luckily everything works for my needs. This is an automated message from the

[GitHub] [arrow] tobim commented on pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
tobim commented on pull request #7842: URL: https://github.com/apache/arrow/pull/7842#issuecomment-669758390 @kou thank you for seeing this through! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] jorisvandenbossche commented on pull request #7907: ARROW-9644: [C++][Dataset] Don't apply ignore_prefixes to partition base_dir

2020-08-06 Thread GitBox
jorisvandenbossche commented on pull request #7907: URL: https://github.com/apache/arrow/pull/7907#issuecomment-669754731 And the "partition base directory" is automatically set if a user does something like `ds.dataset("_shouldnt_be_ignored/dataset/")` ?

[GitHub] [arrow] kou closed pull request #7842: ARROW-9412: [C++] Add non-bundled dependencies to INTERFACE_LINK_LIBRARIES of static libarrow

2020-08-06 Thread GitBox
kou closed pull request #7842: URL: https://github.com/apache/arrow/pull/7842 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the