[GitHub] [arrow-datafusion] lvheyang edited a comment on pull request #716: #699 fix return type conflict when calling builtin math fuctions

lvheyang edited a comment on pull request #716: URL: https://github.com/apache/arrow-datafusion/pull/716#issuecomment-879595756 Thanks for your kind help! @alamb I added test cases in context.rs, test SQLs: 1. `SELECT sqrt(f64) FROM t` 2. `SELECT sqrt(f32) FROM t` // would panic

[GitHub] [arrow-datafusion] lvheyang edited a comment on pull request #716: #699 fix return type conflict when calling builtin math fuctions

lvheyang edited a comment on pull request #716: URL: https://github.com/apache/arrow-datafusion/pull/716#issuecomment-879595756 Thanks for your kind help! @alamb I added test cases in context.rs, test SQLs: 1. `SELECT sqrt(f64) FROM t` 2. `SELECT sqrt(f32) FROM t` // would be

[GitHub] [arrow-datafusion] lvheyang commented on pull request #716: #699 fix return type conflict when calling builtin math fuctions

lvheyang commented on pull request #716: URL: https://github.com/apache/arrow-datafusion/pull/716#issuecomment-879595756 Thanks for your kind help! @alamb I added test cases in context.rs, test SQLs: 1. `SELECT sqrt(f64) FROM t` 2. `SELECT sqrt(f32) FROM t` 3. `SELECT

[GitHub] [arrow] cyb70289 commented on a change in pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed

cyb70289 commented on a change in pull request #10719: URL: https://github.com/apache/arrow/pull/10719#discussion_r669292380 ## File path: cpp/src/arrow/testing/gtest_util.cc ## @@ -907,7 +910,7 @@ class GatingTask::Impl : public std::enable_shared_from_this { double

[GitHub] [arrow] westonpace commented on a change in pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on a change in pull request #10693: URL: https://github.com/apache/arrow/pull/10693#discussion_r669276514 ## File path: python/pyarrow/_hdfs.pyx ## @@ -93,9 +93,10 @@ cdef class HadoopFileSystem(FileSystem): Instantiate HadoopFileSystem object

[GitHub] [arrow-rs] nevi-me merged pull request #545: Fix build, Make the js package a feature that can be enabled for wasm, rather than always on

nevi-me merged pull request #545: URL: https://github.com/apache/arrow-rs/pull/545 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-rs] nevi-me closed issue #544: Error building on master - error: cyclic package dependency: package `ahash v0.7.4` depends on itself. Cycle

nevi-me closed issue #544: URL: https://github.com/apache/arrow-rs/issues/544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] westonpace commented on pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on pull request #10693: URL: https://github.com/apache/arrow/pull/10693#issuecomment-879575972 I believe I have addressed all comments. I also noticed that IpcWriteOptions was undocumented so I added it in. -- This is an automated message from the Apache Git

[GitHub] [arrow] westonpace commented on a change in pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on a change in pull request #10693: URL: https://github.com/apache/arrow/pull/10693#discussion_r669270057 ## File path: docs/source/python/dataset.rst ## @@ -456,20 +456,163 @@ is materialized as columns when reading the data and can be used for

[GitHub] [arrow] westonpace commented on a change in pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on a change in pull request #10693: URL: https://github.com/apache/arrow/pull/10693#discussion_r669269421 ## File path: docs/source/python/dataset.rst ## @@ -456,20 +456,163 @@ is materialized as columns when reading the data and can be used for

[GitHub] [arrow] westonpace commented on a change in pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on a change in pull request #10693: URL: https://github.com/apache/arrow/pull/10693#discussion_r669268967 ## File path: docs/source/python/dataset.rst ## @@ -456,20 +456,163 @@ is materialized as columns when reading the data and can be used for

[GitHub] [arrow] github-actions[bot] commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed

github-actions[bot] commented on pull request #10719: URL: https://github.com/apache/arrow/pull/10719#issuecomment-879572131 Revision: 3a1f4e47a3c7af582d67e013bed3bd712d87dba8 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] cyb70289 commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed

cyb70289 commented on pull request #10719: URL: https://github.com/apache/arrow/pull/10719#issuecomment-879571834 @github-actions crossbow submit test-ubuntu-20.04-cpp-thread-sanitizer -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] ursabot edited a comment on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

ursabot edited a comment on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879533552 Benchmark runs are scheduled for baseline = 780e95c512d63bbea1e040af0eb44a0bf63c4d72 and contender = 64ecb2a73c76e30091428af5e03d538766b12c74. Results will be available

[GitHub] [arrow] cyb70289 commented on a change in pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

cyb70289 commented on a change in pull request #10663: URL: https://github.com/apache/arrow/pull/10663#discussion_r669261083 ## File path: cpp/src/arrow/flight/serialization_internal.cc ## @@ -201,9 +193,7 @@ grpc::Status FlightDataSerialize(const FlightPayload& msg,

[GitHub] [arrow] ursabot edited a comment on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

ursabot edited a comment on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879533552 Benchmark runs are scheduled for baseline = 780e95c512d63bbea1e040af0eb44a0bf63c4d72 and contender = 64ecb2a73c76e30091428af5e03d538766b12c74. Results will be available

[GitHub] [arrow] westonpace commented on a change in pull request #10693: ARROW-13224: [Python][Doc] Documentation missing for pyarrow.dataset.write_dataset

westonpace commented on a change in pull request #10693: URL: https://github.com/apache/arrow/pull/10693#discussion_r669252727 ## File path: docs/source/python/dataset.rst ## @@ -456,20 +456,163 @@ is materialized as columns when reading the data and can be used for

[GitHub] [arrow] cyb70289 commented on a change in pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

cyb70289 commented on a change in pull request #10663: URL: https://github.com/apache/arrow/pull/10663#discussion_r669247552 ## File path: cpp/src/arrow/flight/serialization_internal.cc ## @@ -201,9 +193,7 @@ grpc::Status FlightDataSerialize(const FlightPayload& msg,

[GitHub] [arrow] cyb70289 commented on a change in pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

cyb70289 commented on a change in pull request #10663: URL: https://github.com/apache/arrow/pull/10663#discussion_r669232404 ## File path: cpp/src/arrow/flight/client.cc ## @@ -688,11 +688,12 @@ class GrpcStreamWriter : public FlightStreamWriter { Status

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10604: ARROW-13190: [C++] [Gandiva] Change behavior of INITCAP function

anthonylouisbsb commented on a change in pull request #10604: URL: https://github.com/apache/arrow/pull/10604#discussion_r669245436 ## File path: cpp/src/gandiva/gdv_function_stubs.cc ## @@ -635,30 +638,31 @@ const char* gdv_fn_initcap_utf8(int64_t context, const char* data,

[GitHub] [arrow] ursabot edited a comment on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

ursabot edited a comment on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879533552 Benchmark runs are scheduled for baseline = 780e95c512d63bbea1e040af0eb44a0bf63c4d72 and contender = 64ecb2a73c76e30091428af5e03d538766b12c74. Results will be available

[GitHub] [arrow] ursabot commented on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

ursabot commented on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879533552 Benchmark runs are scheduled for baseline = 780e95c512d63bbea1e040af0eb44a0bf63c4d72 and contender = 64ecb2a73c76e30091428af5e03d538766b12c74. Results will be available as each

[GitHub] [arrow] dianaclarke commented on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

dianaclarke commented on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879533345 @ursabot please benchmark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed

github-actions[bot] commented on pull request #10719: URL: https://github.com/apache/arrow/pull/10719#issuecomment-879528937 https://issues.apache.org/jira/browse/ARROW-13332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] westonpace opened a new pull request #10719: ARROW-13332: [C++] TSAN failure in TestAsyncUtil.ReadaheadFailed

westonpace opened a new pull request #10719: URL: https://github.com/apache/arrow/pull/10719 Minor cleanup fix from my earlier fix of this test in #10602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-datafusion] mcassels opened a new issue #723: ABS() function in WHERE clause gives unexpected results

mcassels opened a new issue #723: URL: https://github.com/apache/arrow-datafusion/issues/723 **Describe the bug** ABS(col - x) in WHERE clause of query sometimes does not filter results correctly. The test file has a float column with high-precision values. We want to use `ABS(col - x)

[GitHub] [arrow] kou commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kou commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879506199 It's strange... Can we confirm which OpenSSL is used for this case? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] ZMZ91 commented on pull request #10606: ARROW-13005: [C++] Add support for take implementation on dense union type

ZMZ91 commented on pull request #10606: URL: https://github.com/apache/arrow/pull/10606#issuecomment-879501530 Hi @bkietz and @pitrou, could you help check what else to update in this pr? Or we may merge it? Thanks. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10604: ARROW-13190: [C++] [Gandiva] Change behavior of INITCAP function

anthonylouisbsb commented on a change in pull request #10604: URL: https://github.com/apache/arrow/pull/10604#discussion_r669203451 ## File path: cpp/src/gandiva/gdv_function_stubs.cc ## @@ -427,7 +427,8 @@ CAST_VARLEN_TYPE_FROM_NUMERIC(VARBINARY) #undef

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

anthonylouisbsb commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669196394 ## File path: cpp/src/gandiva/string_function_holder_test.cc ## @@ -212,6 +213,189 @@ TEST_F(TestLikeHolder, TestMultipleEscapeChar) { auto

[GitHub] [arrow] westonpace commented on pull request #10629: ARROW-13218: [Doc] Document/clarify conventions for timestamp storage

westonpace commented on pull request #10629: URL: https://github.com/apache/arrow/pull/10629#issuecomment-879491179 Any remaining comments or suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

anthonylouisbsb commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669196057 ## File path: cpp/src/gandiva/string_function_holder.h ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow-datafusion] Jimexist commented on pull request #687: #554: Lead/lag window function with offset and default value arguments

Jimexist commented on pull request #687: URL: https://github.com/apache/arrow-datafusion/pull/687#issuecomment-879487452 > @Jimexist do you think this PR is ready? Do you need help reviewing ? looks okay after rebasing. -- This is an automated message from the Apache Git Service.

[GitHub] [arrow-datafusion] djKooks edited a comment on pull request #442: Change return type of 'DataFrame.collect()'

djKooks edited a comment on pull request #442: URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879483480 @alamb sure~ But because I'm still on reviewing the project, so want to make sure I'm going in right way... > As far as I review from now, seems it needs

[GitHub] [arrow] kszucs edited a comment on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs edited a comment on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202 @kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the

[GitHub] [arrow-datafusion] djKooks commented on pull request #442: Change return type of 'DataFrame.collect()'

djKooks commented on pull request #442: URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879483480 @alamb sure~ But because I'm still on reviewing the project, so want to make sure I'm going in right way... > As far as I review from now, seems it needs to fix

[GitHub] [arrow] github-actions[bot] commented on pull request #10718: ARROW-13331: [C++][Gandiva] Add format_number hive function to gandiva

github-actions[bot] commented on pull request #10718: URL: https://github.com/apache/arrow/pull/10718#issuecomment-879478708 https://issues.apache.org/jira/browse/ARROW-13331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] augustoasilva opened a new pull request #10718: ARROW-13331: [C++][Gandiva] Add format_number hive function to gandiva

augustoasilva opened a new pull request #10718: URL: https://github.com/apache/arrow/pull/10718 Formats the number X to a format like '#,###,###.##', rounded to D decimal places, and returns the result as a string. If D is 0, the result has no decimal point or fractional part. -- This

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

anthonylouisbsb commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669181293 ## File path: cpp/src/gandiva/CMakeLists.txt ## @@ -82,7 +82,7 @@ set(SRC_FILES hash_utils.cc llvm_generator.cc llvm_types.cc -

[GitHub] [arrow] jpedroantunes commented on a change in pull request #10516: ARROW-13049: [C++][Gandiva] Implement BIN Hive function on Gandiva

jpedroantunes commented on a change in pull request #10516: URL: https://github.com/apache/arrow/pull/10516#discussion_r669179317 ## File path: cpp/src/gandiva/precompiled/extended_math_ops.cc ## @@ -367,4 +367,36 @@ gdv_float64 get_scale_multiplier(gdv_int32 scale) {

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

anthonylouisbsb commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669179205 ## File path: cpp/src/gandiva/string_function_holder_test.cc ## @@ -212,6 +213,189 @@ TEST_F(TestLikeHolder, TestMultipleEscapeChar) { auto

[GitHub] [arrow] anthonylouisbsb commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

anthonylouisbsb commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669177954 ## File path: cpp/src/gandiva/string_function_holder_test.cc ## @@ -212,6 +213,189 @@ TEST_F(TestLikeHolder, TestMultipleEscapeChar) { auto

[GitHub] [arrow] rok commented on a change in pull request #10610: ARROW-13033: [C++] Kernel to localize naive timestamps to a timezone (preserving clock-time)

rok commented on a change in pull request #10610: URL: https://github.com/apache/arrow/pull/10610#discussion_r669166367 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] westonpace commented on a change in pull request #10610: ARROW-13033: [C++] Kernel to localize naive timestamps to a timezone (preserving clock-time)

westonpace commented on a change in pull request #10610: URL: https://github.com/apache/arrow/pull/10610#discussion_r669164458 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] westonpace commented on a change in pull request #10610: ARROW-13033: [C++] Kernel to localize naive timestamps to a timezone (preserving clock-time)

westonpace commented on a change in pull request #10610: URL: https://github.com/apache/arrow/pull/10610#discussion_r669164458 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] westonpace commented on a change in pull request #10610: ARROW-13033: [C++] Kernel to localize naive timestamps to a timezone (preserving clock-time)

westonpace commented on a change in pull request #10610: URL: https://github.com/apache/arrow/pull/10610#discussion_r669163511 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] github-actions[bot] commented on pull request #10717: ARROW-13091: [Python] Added compression_level to IpcWriteOptions

github-actions[bot] commented on pull request #10717: URL: https://github.com/apache/arrow/pull/10717#issuecomment-879456403 https://issues.apache.org/jira/browse/ARROW-13091 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] westonpace opened a new pull request #10717: ARROW-13091: [Python] Added compression_level to IpcWriteOptions

westonpace opened a new pull request #10717: URL: https://github.com/apache/arrow/pull/10717 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] kevingurney commented on pull request #10614: ARROW-13100: [MATLAB] Integrate GoogleTest with MATLAB Interface C++ Code

kevingurney commented on pull request #10614: URL: https://github.com/apache/arrow/pull/10614#issuecomment-879449900 @kou we just pushed updates to `matlab/CMakeLists.txt` which enable building of the Arrow C++ libraries and bundled GoogleTest binaries automatically from source on macOS

[GitHub] [arrow] thisisnic commented on a change in pull request #10624: ARROW-12992: [R] bindings for substr(), substring(), str_sub()

thisisnic commented on a change in pull request #10624: URL: https://github.com/apache/arrow/pull/10624#discussion_r669142885 ## File path: r/src/compute.cpp ## @@ -316,6 +316,19 @@ std::shared_ptr make_compute_options( return std::make_shared(max_splits, reverse); }

[GitHub] [arrow] zeroshade opened a new pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

zeroshade opened a new pull request #10716: URL: https://github.com/apache/arrow/pull/10716 @emkornfield Thanks for merging the previous PR #10379 Here's the remaining files that we pulled out of that PR to shrink it down, including all the unit tests for the Encoding package. --

[GitHub] [arrow] github-actions[bot] commented on pull request #10716: ARROW-13330: [Go][Parquet] Add the rest of the Encoding package

github-actions[bot] commented on pull request #10716: URL: https://github.com/apache/arrow/pull/10716#issuecomment-879433836 https://issues.apache.org/jira/browse/ARROW-13330 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow-rs] alamb closed issue #343: Add a RecordBatch::split to split large batches into a set of smaller batches

alamb closed issue #343: URL: https://github.com/apache/arrow-rs/issues/343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-rs] alamb commented on issue #343: Add a RecordBatch::split to split large batches into a set of smaller batches

alamb commented on issue #343: URL: https://github.com/apache/arrow-rs/issues/343#issuecomment-879428117 Given we now have slice in https://github.com/apache/arrow-rs/issues/460 I don't think this adds much anymore -- This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] dianaclarke commented on a change in pull request #10650: ARROW-13058: This is a draft to provide save-report

dianaclarke commented on a change in pull request #10650: URL: https://github.com/apache/arrow/pull/10650#discussion_r669128039 ## File path: dev/archery/archery/crossbow/reports.py ## @@ -121,6 +121,61 @@ def show(self, outstream, asset_callback=None):

[GitHub] [arrow] rok commented on a change in pull request #10610: ARROW-13033: [C++] Kernel to localize naive timestamps to a timezone (preserving clock-time)

rok commented on a change in pull request #10610: URL: https://github.com/apache/arrow/pull/10610#discussion_r669127595 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] dianaclarke commented on a change in pull request #10650: ARROW-13058: This is a draft to provide save-report

dianaclarke commented on a change in pull request #10650: URL: https://github.com/apache/arrow/pull/10650#discussion_r669125627 ## File path: dev/archery/archery/crossbow/reports.py ## @@ -32,7 +33,6 @@ def __init__(self, job): def show(self): raise

[GitHub] [arrow] dianaclarke commented on a change in pull request #10650: ARROW-13058: This is a draft to provide save-report

dianaclarke commented on a change in pull request #10650: URL: https://github.com/apache/arrow/pull/10650#discussion_r669121940 ## File path: dev/archery/archery/crossbow/reports.py ## @@ -121,6 +121,61 @@ def show(self, outstream, asset_callback=None):

[GitHub] [arrow] westonpace commented on a change in pull request #10705: ARROW-13313: [C++][Compute] Add scalar aggregate node

westonpace commented on a change in pull request #10705: URL: https://github.com/apache/arrow/pull/10705#discussion_r669115135 ## File path: cpp/src/arrow/compute/exec/exec_plan.cc ## @@ -601,5 +618,215 @@ AsyncGenerator> MakeSinkNode(ExecNode* input, return out; }

[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

github-actions[bot] commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879407362 Revision: 10dbf02030fc431bf175826a51214e643a916042 Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879406726 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] rok commented on pull request #10647: ARROW-13174: [C++][Compute] Add strftime kernel

rok commented on pull request #10647: URL: https://github.com/apache/arrow/pull/10647#issuecomment-879403748 > Thanks for the changes. This looks good. I'm afraid I don't know the differences between `date.h` and the system equivalents. By system equivalents do you mean `ctime`? In that

[GitHub] [arrow-rs] alamb commented on a change in pull request #491: Minimal MapArray support

alamb commented on a change in pull request #491: URL: https://github.com/apache/arrow-rs/pull/491#discussion_r669078940 ## File path: arrow/Cargo.toml ## @@ -58,13 +58,15 @@ multiversion = "0.6.1" bitflags = "1.2.1" [features] -default = ["csv", "ipc"] +default = ["csv",

[GitHub] [arrow] rok commented on a change in pull request #10647: ARROW-13174: [C++][Compute] Add strftime kernel

rok commented on a change in pull request #10647: URL: https://github.com/apache/arrow/pull/10647#discussion_r669107412 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] kszucs edited a comment on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs edited a comment on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202 @kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the

[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879399202 @kou Interestingly we have [linker errors](https://github.com/ursacomputing/crossbow/runs/3060717856?check_suite_focus=true#step:8:654) in the universal2 build but the tests

[GitHub] [arrow-datafusion] alamb commented on pull request #524: Expose ExecutionContext.register_csv to the python bindings

alamb commented on pull request #524: URL: https://github.com/apache/arrow-datafusion/pull/524#issuecomment-879398069 Cool -- I am just trying to shepherd PRs that look like they got stale -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] bkietz closed pull request #10705: ARROW-13313: [C++][Compute] Add scalar aggregate node

bkietz closed pull request #10705: URL: https://github.com/apache/arrow/pull/10705 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #722: perf: improve performance of `SortPreservingMergeExec` operator

alamb commented on a change in pull request #722: URL: https://github.com/apache/arrow-datafusion/pull/722#discussion_r669104634 ## File path: datafusion/src/physical_plan/sort_preserving_merge.rs ## @@ -246,7 +274,19 @@ impl SortKeyCursor {

[GitHub] [arrow] lidavidm commented on a change in pull request #10705: ARROW-13313: [C++][Compute] Add scalar aggregate node

lidavidm commented on a change in pull request #10705: URL: https://github.com/apache/arrow/pull/10705#discussion_r669103875 ## File path: cpp/src/arrow/dataset/scanner_test.cc ## @@ -1323,5 +1323,86 @@ TEST(ScanNode, MaterializationOfVirtualColumn) {

[GitHub] [arrow] westonpace commented on a change in pull request #10647: ARROW-13174: [C++][Compute] Add strftime kernel

westonpace commented on a change in pull request #10647: URL: https://github.com/apache/arrow/pull/10647#discussion_r669098242 ## File path: r/configure.win ## @@ -44,7 +44,7 @@ else RWINLIB="../windows/$(ls windows/ | grep ^arrow- | tail -n 1)" fi OPENSSL_LIBS="-lcrypto

[GitHub] [arrow] lidavidm commented on pull request #10608: ARROW-13136: [C++] Add coalesce function

lidavidm commented on pull request #10608: URL: https://github.com/apache/arrow/pull/10608#issuecomment-879390751 I would kind of prefer to get all these kernels merged and consolidated before I start trying to microoptimize them, though, given they've been around for a while and all use

[GitHub] [arrow] lidavidm commented on pull request #10608: ARROW-13136: [C++] Add coalesce function

lidavidm commented on pull request #10608: URL: https://github.com/apache/arrow/pull/10608#issuecomment-879390143 Basically, there was a lot of overhead from the fallback loop of "for offset in range(block size), if bit is set, copy one element" because 1) the 'copy one element' function

[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

github-actions[bot] commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879378962 Revision: 3aa0df229a92a3425bcb9b5a7711853bcc49e53d Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879378309 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow-rs] codecov-commenter commented on pull request #545: Fix build, Make the js package a feature that can be enabled for wasm, rather than always on

codecov-commenter commented on pull request #545: URL: https://github.com/apache/arrow-rs/pull/545#issuecomment-879376748 #

[GitHub] [arrow] lidavidm commented on pull request #10663: ARROW-13253: [FlightRPC][C++] Fix segfault with large messages

lidavidm commented on pull request #10663: URL: https://github.com/apache/arrow/pull/10663#issuecomment-879371544 @cyb70289, might you have time to look at this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] lidavidm closed pull request #10712: ARROW-13307: [C++][Python][R] Use reflection-based enums for function options

lidavidm closed pull request #10712: URL: https://github.com/apache/arrow/pull/10712 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow] lidavidm commented on a change in pull request #10412: ARROW-9430: [C++] Implement replace_with_mask kernel

lidavidm commented on a change in pull request #10412: URL: https://github.com/apache/arrow/pull/10412#discussion_r669074742 ## File path: cpp/src/arrow/compute/kernels/vector_replace.cc ## @@ -0,0 +1,510 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] github-actions[bot] commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

github-actions[bot] commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879364310 Revision: 086b4582939f4aef8b5784ab45ba4276f438ed6d Submitted crossbow builds: [ursacomputing/crossbow @

[GitHub] [arrow] kszucs commented on pull request #10659: ARROW-12122: [Python] Cannot install via pip M1 mac

kszucs commented on pull request #10659: URL: https://github.com/apache/arrow/pull/10659#issuecomment-879363719 @github-actions crossbow submit -g wheel -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] lidavidm commented on pull request #10557: ARROW-13064: [C++] Implement select ('case when') function for fixed-width types

lidavidm commented on pull request #10557: URL: https://github.com/apache/arrow/pull/10557#issuecomment-879363403 Fixed docstrings and fixed a TODO I noticed about fully initializing the output buffer. Also added a benchmark case for when both the cond struct array and the child

[GitHub] [arrow-datafusion] kszucs commented on pull request #524: Expose ExecutionContext.register_csv to the python bindings

kszucs commented on pull request #524: URL: https://github.com/apache/arrow-datafusion/pull/524#issuecomment-879359345 Since https://github.com/apache/arrow-rs/pull/439 has been merged I can expose the `schema` argument as well, though we can defer that to a follow-up PR too. -- This

[GitHub] [arrow-datafusion] alamb commented on pull request #524: Expose ExecutionContext.register_csv to the python bindings

alamb commented on pull request #524: URL: https://github.com/apache/arrow-datafusion/pull/524#issuecomment-879357118 @jorgecarleitao / @kszucs -- what is the plan for this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow-datafusion] alamb commented on pull request #442: Change return type of 'DataFrame.collect()'

alamb commented on pull request #442: URL: https://github.com/apache/arrow-datafusion/pull/442#issuecomment-879356925 @djKooks do you plan to keep working on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow-datafusion] alamb commented on pull request #441: WIP: Add tokomak optimizer

alamb commented on pull request #441: URL: https://github.com/apache/arrow-datafusion/pull/441#issuecomment-879356559 @Dandandan do you still plan to work on this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] bkietz commented on pull request #8151: ARROW-9279: [C++] Implement PrettyPrint for Scalars

bkietz commented on pull request #8151: URL: https://github.com/apache/arrow/pull/8151#issuecomment-879355469 Closing this for now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [arrow] bkietz closed pull request #8151: ARROW-9279: [C++] Implement PrettyPrint for Scalars

bkietz closed pull request #8151: URL: https://github.com/apache/arrow/pull/8151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [arrow-rs] alamb commented on pull request #537: Implement `RecordBatch::concat`

alamb commented on pull request #537: URL: https://github.com/apache/arrow-rs/pull/537#issuecomment-879355147 Unless I hear different, I plan to merge this PR tomorrow (and include it in 5.0.0) -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] projjal commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

projjal commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669059415 ## File path: cpp/src/gandiva/string_function_holder_test.cc ## @@ -212,6 +213,189 @@ TEST_F(TestLikeHolder, TestMultipleEscapeChar) { auto status =

[GitHub] [arrow] projjal commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

projjal commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669058383 ## File path: cpp/src/gandiva/string_function_holder.h ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] projjal commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

projjal commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669058383 ## File path: cpp/src/gandiva/string_function_holder.h ## @@ -0,0 +1,140 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] pachadotdev commented on pull request #10650: ARROW-13058: This is a draft to provide save-report

pachadotdev commented on pull request #10650: URL: https://github.com/apache/arrow/pull/10650#issuecomment-879349226 I did a few changes regarding the task of adding a function to capture the nightly builds state in json before sending the emails i'm gonna need a second review on this

[GitHub] [arrow] ursabot edited a comment on pull request #10679: ARROW-13170 [C++] Reducing branching in compute/kernels/vector_selection.cc

ursabot edited a comment on pull request #10679: URL: https://github.com/apache/arrow/pull/10679#issuecomment-879314016 Benchmark runs are scheduled for baseline = cf6a7ff65f4e2920641d116a3ba1f578b2bd8a9e and contender = 38110e8e7ee598ddb0e8a3465d81ea7e24bafebc. Results will be available

[GitHub] [arrow] projjal commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

projjal commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669049315 ## File path: cpp/src/gandiva/CMakeLists.txt ## @@ -82,7 +82,7 @@ set(SRC_FILES hash_utils.cc llvm_generator.cc llvm_types.cc -

[GitHub] [arrow] projjal commented on a change in pull request #10518: ARROW-13052: [C++][Gandiva] Implements REGEXP_EXTRACT function

projjal commented on a change in pull request #10518: URL: https://github.com/apache/arrow/pull/10518#discussion_r669049098 ## File path: cpp/src/gandiva/string_function_holder_test.cc ## @@ -212,6 +213,189 @@ TEST_F(TestLikeHolder, TestMultipleEscapeChar) { auto status =

[GitHub] [arrow] bkietz commented on pull request #10608: ARROW-13136: [C++] Add coalesce function

bkietz commented on pull request #10608: URL: https://github.com/apache/arrow/pull/10608#issuecomment-879342845 > Trying an approach based on VisitSetBitRunsVoid IIUC this would require a varargs version of `OptionalBitBlockCounter` or `Bitmap::VisitWords`, which would probably be

[GitHub] [arrow] bkietz commented on a change in pull request #10412: ARROW-9430: [C++] Implement replace_with_mask kernel

bkietz commented on a change in pull request #10412: URL: https://github.com/apache/arrow/pull/10412#discussion_r669046761 ## File path: cpp/src/arrow/compute/kernels/vector_replace.cc ## @@ -0,0 +1,510 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow-rs] alamb opened a new pull request #545: Fix build, Make the js package a feature that can be enabled for wasm, rather than always on

alamb opened a new pull request #545: URL: https://github.com/apache/arrow-rs/pull/545 # Which issue does this PR close? Closes https://github.com/apache/arrow-rs/issues/544 # Rationale for this change We upgraded Arrow to the latest version of `rand` in

[GitHub] [arrow] bkietz commented on a change in pull request #10557: ARROW-13064: [C++] Implement select ('case when') function for fixed-width types

bkietz commented on a change in pull request #10557: URL: https://github.com/apache/arrow/pull/10557#discussion_r669034240 ## File path: docs/source/cpp/compute.rst ## @@ -859,50 +859,60 @@ Structural transforms

  1   2   3   >