Re: [PR] chore(csharp): use license expression [arrow-adbc]

2025-06-20 Thread via GitHub
kou commented on PR #3006: URL: https://github.com/apache/arrow-adbc/pull/3006#issuecomment-2993377982 @CurtHagenlocher Could you check that `csharp/` doesn't bundle any third-party code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [C++][Gandiva] DATE_TRUNC with DAY rounds up to next day sometimes [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #46841: URL: https://github.com/apache/arrow/issues/46841#issuecomment-2993376739 Issue resolved by pull request 46842 https://github.com/apache/arrow/pull/46842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] GH-46841 [C++][Gandiva] Fix date trunc edge case [arrow]

2025-06-20 Thread via GitHub
kou merged PR #46842: URL: https://github.com/apache/arrow/pull/46842 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-20 Thread via GitHub
kou commented on PR #43: URL: https://github.com/apache/arrow-swift/pull/43#issuecomment-2993370121 Could you rebase on main to use Swift 6.0 and 6.1 on CI? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: [PR] chore: Add CI jobs for Swift 6.0 and 6.1 [arrow-swift]

2025-06-20 Thread via GitHub
kou merged PR #41: URL: https://github.com/apache/arrow-swift/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or

Re: [PR] feat: Add CI jobs for Swift 6.0 and 6.1 [arrow-swift]

2025-06-20 Thread via GitHub
kou commented on PR #41: URL: https://github.com/apache/arrow-swift/pull/41#issuecomment-2993369880 I'll merge this for separated PRs such as #43. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] feat: Add CI jobs for Swift 6.0 and 6.1 [arrow-swift]

2025-06-20 Thread via GitHub
kou commented on PR #41: URL: https://github.com/apache/arrow-swift/pull/41#issuecomment-2993365059 Thanks. Let's add only CI jobs in this PR to check build/test results in separated PRs. Added CI jobs are ignored for now. Because we aren't ready for Swift 6.0 and 6.1 yet. --

Re: [PR] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
etseidl commented on code in PR #7724: URL: https://github.com/apache/arrow-rs/pull/7724#discussion_r2159882448 ## parquet/src/file/properties.rs: ## @@ -549,7 +556,8 @@ impl WriterPropertiesBuilder { /// Note: this is a best effort limit based on value of /// [`set_wr

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): OpenTelemetry tracing baseline [arrow-adbc]

2025-06-20 Thread via GitHub
birschick-bq commented on PR #2847: URL: https://github.com/apache/arrow-adbc/pull/2847#issuecomment-2993328363 > @birschick-bq - will you get a chance to resolve the merge conflicts? @davidhcoe Conflicts resolved -- This is an automated message from the Apache Git Service. To respo

Re: [I] [Python][Parquet] Expose ParquetWriter properties and arrow_properties [arrow]

2025-06-20 Thread via GitHub
SoundBot commented on issue #45902: URL: https://github.com/apache/arrow/issues/45902#issuecomment-2993311167 I can try taking a stab at it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

Re: [I] [GLib][Ruby] undefined method 'compute_initialize' for module Arrow (NoMethodError) [arrow]

2025-06-20 Thread via GitHub
otegami commented on issue #46875: URL: https://github.com/apache/arrow/issues/46875#issuecomment-2993307179 Not sure if this is related, but I noticed the module’s pkg-config file doesn’t include the compute CFLAGS lines: ``` Cflags: @ARROW_COMPUTE_PC_CFLAGS@ Cflags.private: @A

Re: [PR] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
XiangpengHao commented on code in PR #7724: URL: https://github.com/apache/arrow-rs/pull/7724#discussion_r2159848151 ## parquet/src/file/properties.rs: ## @@ -549,7 +556,8 @@ impl WriterPropertiesBuilder { /// Note: this is a best effort limit based on value of /// [`s

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): OpenTelemetry tracing baseline [arrow-adbc]

2025-06-20 Thread via GitHub
davidhcoe commented on PR #2847: URL: https://github.com/apache/arrow-adbc/pull/2847#issuecomment-2993294826 @birschick-bq - will you get a chance to resolve the merge conflicts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [PR] GH-46674: [C++] Construct Array from ExtensionType Scalar [arrow]

2025-06-20 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46675: URL: https://github.com/apache/arrow/pull/46675#issuecomment-2993223862 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit a9d2a12f6135b5595b71ec267dbff33a114a0b5e. There were 11

Re: [PR] [Variant] Introduce new type over &str for ShortString [arrow-rs]

2025-06-20 Thread via GitHub
friendlymatthew commented on code in PR #7718: URL: https://github.com/apache/arrow-rs/pull/7718#discussion_r2159804512 ## parquet-variant/src/variant.rs: ## @@ -29,6 +29,57 @@ mod list; mod metadata; mod object; +const MAX_SHORT_STRING_BYTES: usize = 0x3F; + +/// A Variant

Re: [PR] [Variant] Introduce new type over &str for ShortString [arrow-rs]

2025-06-20 Thread via GitHub
friendlymatthew commented on code in PR #7718: URL: https://github.com/apache/arrow-rs/pull/7718#discussion_r2159804451 ## parquet-variant/src/variant.rs: ## @@ -29,6 +29,57 @@ mod list; mod metadata; mod object; +const MAX_SHORT_STRING_BYTES: usize = 0x3F; + +/// A Variant

Re: [PR] [Variant] Use `BTreeMap` for `VariantBuilder.dict` and `ObjectBuilder.fields` to maintain invariants upon entry writes [arrow-rs]

2025-06-20 Thread via GitHub
friendlymatthew commented on code in PR #7720: URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2159790437 ## parquet-variant/src/builder.rs: ## @@ -540,7 +535,8 @@ impl<'a> ObjectBuilder<'a> { } // Write field offsets -for &(_, offset) i

Re: [PR] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
etseidl commented on code in PR #7724: URL: https://github.com/apache/arrow-rs/pull/7724#discussion_r2159761405 ## parquet/src/file/properties.rs: ## @@ -549,7 +556,8 @@ impl WriterPropertiesBuilder { /// Note: this is a best effort limit based on value of /// [`set_wr

Re: [PR] [Variant] Use `BTreeMap` for `VariantBuilder.dict` and `ObjectBuilder.fields` to maintain invariants upon entry writes [arrow-rs]

2025-06-20 Thread via GitHub
scovich commented on code in PR #7720: URL: https://github.com/apache/arrow-rs/pull/7720#discussion_r2159751831 ## parquet-variant/src/builder.rs: ## @@ -540,7 +535,8 @@ impl<'a> ObjectBuilder<'a> { } // Write field offsets -for &(_, offset) in &self.

Re: [PR] GH-46841 [C++][Gandiva] Fix date trunc edge case [arrow]

2025-06-20 Thread via GitHub
lriggs commented on code in PR #46842: URL: https://github.com/apache/arrow/pull/46842#discussion_r2159746516 ## cpp/src/gandiva/precompiled/time_test.cc: ## @@ -363,6 +363,46 @@ TEST(TestTime, TimeStampTrunc) { StringToTimestamp("2000-02-28 00:00:00")); EXPECT_E

Re: [PR] [Variant] Introduce new type over &str for ShortString [arrow-rs]

2025-06-20 Thread via GitHub
scovich commented on code in PR #7718: URL: https://github.com/apache/arrow-rs/pull/7718#discussion_r2159680416 ## parquet-variant/src/variant.rs: ## @@ -29,6 +29,57 @@ mod list; mod metadata; mod object; +const MAX_SHORT_STRING_BYTES: usize = 0x3F; + +/// A Variant [`ShortS

[PR] fix: Do not add null buffer for `NullArray` [arrow-rs]

2025-06-20 Thread via GitHub
comphead opened a new pull request, #7726: URL: https://github.com/apache/arrow-rs/pull/7726 # Which issue does this PR close? We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an i

Re: [PR] GH-44502: [R] Sub-day precision Date class must be converted to integers by floor, not trunc [arrow]

2025-06-20 Thread via GitHub
jonkeane commented on code in PR #46873: URL: https://github.com/apache/arrow/pull/46873#discussion_r2159742105 ## r/tests/testthat/test-Array.R: ## @@ -1397,3 +1397,9 @@ test_that("Can convert R integer/double to decimal (ARROW-11631)", { "Conversion to decimal from non-i

[I] Do not populate nulls for `NullArray` for `MutableArrayData` [arrow-rs]

2025-06-20 Thread via GitHub
comphead opened a new issue, #7725: URL: https://github.com/apache/arrow-rs/issues/7725 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** `MutableArrayData` unconditionally adding null buffers for `Null` datatype although it

Re: [PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-20 Thread via GitHub
dongjoon-hyun commented on PR #43: URL: https://github.com/apache/arrow-swift/pull/43#issuecomment-2993051803 The CI fails 3 times consecutively with the same step, `The process '/usr/bin/gpg' failed with exit code 2`. -- This is an automated message from the Apache Git Service. To respon

Re: [PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-20 Thread via GitHub
dongjoon-hyun commented on PR #43: URL: https://github.com/apache/arrow-swift/pull/43#issuecomment-2993045154 To @kou , the CI failure is a known bug of `setup-swift`. - https://github.com/swift-actions/setup-swift/pull/680 ``` /usr/bin/gpg --import /home/runner/work/_temp/2

[PR] feat: Make `ArrowTypeId` and `Info` enums `Sendable` [arrow-swift]

2025-06-20 Thread via GitHub
dongjoon-hyun opened a new pull request, #43: URL: https://github.com/apache/arrow-swift/pull/43 ## What's Changed This PR aims to make `ArrowTypeId` and `Info` enums `Sendable` explicitly in order to compile on Swift 6+ -- This is an automated message from the Apache Git Service.

Re: [PR] fix surrogate parsing panic [arrow-rs]

2025-06-20 Thread via GitHub
nicklan commented on code in PR #7721: URL: https://github.com/apache/arrow-rs/pull/7721#discussion_r2159686914 ## arrow-json/src/reader/tape.rs: ## @@ -705,9 +705,16 @@ fn err(b: u8, ctx: &str) -> ArrowError { /// Creates a character from an UTF-16 surrogate pair fn char_fr

Re: [I] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
XiangpengHao commented on issue #7723: URL: https://github.com/apache/arrow-rs/issues/7723#issuecomment-2993021504 I'm making a simple heuristic that increases the limit from 1MB -> 16MB **only for BYTE ARRAY columns**. This itself decreases the file size of uncompressed parquet by al

Re: [PR] feat: Add support for Swift 6.1 [arrow-swift]

2025-06-20 Thread via GitHub
dongjoon-hyun commented on PR #41: URL: https://github.com/apache/arrow-swift/pull/41#issuecomment-2993009535 I can help some except `ArrowCExporter.swift` and `ArrowCImporter.swift` part. Let me make smaller PRs to fill the gap before this, @kou . -- This is an automated message f

[PR] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
XiangpengHao opened a new pull request, #7724: URL: https://github.com/apache/arrow-rs/pull/7724 # Which issue does this PR close? #7723 Please see the issue for more details. We generally require a GitHub issue to be filed for all bug fixes and enhancements and thi

[I] Allow per-column parquet dictionary page size limit [arrow-rs]

2025-06-20 Thread via GitHub
XiangpengHao opened a new issue, #7723: URL: https://github.com/apache/arrow-rs/issues/7723 **Is your feature request related to a problem or challenge? Please describe what you are trying to do.** **Describe the solution you'd like** **Describe alternatives you've cons

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
zeroshade commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992998417 You could always have your driver implement the ADBC interfaces that are defined in the `adbc` module :smile: Alternately, you could add extra QueryContext functions that retu

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
jadewang-db commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992989743 ah, I am mainly thinking a wrapper for any database/sql driver to acting as a adbc driver, and with some extra interface to avoid arrow data conversion. On Fri, Jun 20, 202

Re: [I] Don't use u128 for BinaryView to support alignment < 16 [arrow-rs]

2025-06-20 Thread via GitHub
scsmithr commented on issue #7709: URL: https://github.com/apache/arrow-rs/issues/7709#issuecomment-2992989419 This is a perfect use case for a union. ```rust #[derive(Clone, Copy)] #[repr(C)] pub union BinaryView { inline: BinaryViewInline, reference: BinaryView

Re: [PR] fix surrogate parsing panic [arrow-rs]

2025-06-20 Thread via GitHub
nicklan commented on code in PR #7721: URL: https://github.com/apache/arrow-rs/pull/7721#discussion_r2159686914 ## arrow-json/src/reader/tape.rs: ## @@ -705,9 +705,16 @@ fn err(b: u8, ctx: &str) -> ArrowError { /// Creates a character from an UTF-16 surrogate pair fn char_fr

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
zeroshade commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992984324 Other way around, it does Arrow to row conversion. The use case is as an adapter on top of any ADBC driver to get a row oriented `database/sql` interface so you only have to provide

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
jadewang-db commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992979244 > We already have https://pkg.go.dev/github.com/apache/arrow-adbc/go/adbc@v1.6.0/sqldriver which is a wrapper around the ADBC interface which will provide a `database/sql` interfa

Re: [PR] fix surrogate parsing panic [arrow-rs]

2025-06-20 Thread via GitHub
scovich commented on code in PR #7721: URL: https://github.com/apache/arrow-rs/pull/7721#discussion_r2159678798 ## arrow-json/src/reader/tape.rs: ## @@ -705,9 +705,16 @@ fn err(b: u8, ctx: &str) -> ArrowError { /// Creates a character from an UTF-16 surrogate pair fn char_fr

Re: [PR] GH-17211: [C++] Add `hash32` and `hash64` scalar compute functions [arrow]

2025-06-20 Thread via GitHub
kszucs commented on PR #45001: URL: https://github.com/apache/arrow/pull/45001#issuecomment-2992970817 @kou sure, rebased. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

Re: [PR] feat(go/adbc/driver/snowflake): Add a static version number [arrow-adbc]

2025-06-20 Thread via GitHub
zeroshade closed pull request #2889: feat(go/adbc/driver/snowflake): Add a static version number URL: https://github.com/apache/arrow-adbc/pull/2889 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] feat(go/adbc/driver/snowflake): Add a static version number [arrow-adbc]

2025-06-20 Thread via GitHub
zeroshade commented on PR #2889: URL: https://github.com/apache/arrow-adbc/pull/2889#issuecomment-2992827628 I'm gonna close it, if the updates is insufficient, we can file a new issue/PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [I] [C#] BinaryArray.Builder Reserve/Resize methods are broken [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #25449: URL: https://github.com/apache/arrow/issues/25449#issuecomment-2992817376 I've removed the `Status: stale-warning` label. FYI: For repository move: https://github.com/apache/arrow/pull/46752#issuecomment-2968759580 -- This is an automated message from

Re: [PR] GH-46831: [C++][R] Remove some pending references to CMake < 3.25 (docs + minor CMake references) [arrow]

2025-06-20 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #46834: URL: https://github.com/apache/arrow/pull/46834#issuecomment-2992816493 After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 6822857775bafc765b9e75a09e0b7470ce1a957b. There were 11

Re: [I] [C#] Enhance TimeStampArray to support IANA/Olson TZ strings [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #25583: URL: https://github.com/apache/arrow/issues/25583#issuecomment-2992816311 I've removed the `Status: stale-warning` label. FYI: For repository move: https://github.com/apache/arrow/pull/46752#issuecomment-2968759580 -- This is an automated message from

Re: [I] [C++][Compute] Add scalar_hash function [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #17211: URL: https://github.com/apache/arrow/issues/17211#issuecomment-2992808288 I've removed the `Status: Stale-Warning` label. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] GH-17211: [C++] Add `hash32` and `hash64` scalar compute functions [arrow]

2025-06-20 Thread via GitHub
kou commented on PR #45001: URL: https://github.com/apache/arrow/pull/45001#issuecomment-2992804003 @kszucs Could you rebase on main? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] refactor: update linter and run it [arrow-go]

2025-06-20 Thread via GitHub
zeroshade merged PR #419: URL: https://github.com/apache/arrow-go/pull/419 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

Re: [PR] feat(c/driver_manager): add new function to allow loading by manifest [arrow-adbc]

2025-06-20 Thread via GitHub
paleolimbot commented on code in PR #2918: URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2159633823 ## c/driver_manager/adbc_driver_manager.cc: ## @@ -1716,6 +2176,12 @@ AdbcStatusCode AdbcLoadDriver(const char* driver_name, const char* entrypoint, return s

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
zeroshade commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992712433 We already have https://pkg.go.dev/github.com/apache/arrow-adbc/go/adbc@v1.6.0/sqldriver which is a wrapper around the ADBC interface which will provide a `database/sql` interface t

Re: [I] Potential regression in FileReader v18.3.0 [arrow-go]

2025-06-20 Thread via GitHub
zeroshade commented on issue #392: URL: https://github.com/apache/arrow-go/issues/392#issuecomment-2992703789 Released! https://github.com/apache/arrow-go/releases/tag/v18.3.1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] GH-46094: [C++][Docs] Add note to RleDecoder::Get's doc comment [arrow]

2025-06-20 Thread via GitHub
github-actions[bot] commented on PR #46874: URL: https://github.com/apache/arrow/pull/46874#issuecomment-2992698039 Revision: 593a63ad2dce93b69b352133bd15b8ff925f3e58 Submitted crossbow builds: [ursacomputing/crossbow @ actions-ebc2a97298](https://github.com/ursacomputing/crossbow/bra

Re: [I] [GLib][Ruby] undefined method 'compute_initialize' for module Arrow (NoMethodError) [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #46875: URL: https://github.com/apache/arrow/issues/46875#issuecomment-2992698631 It's strange because `ninja-debug-maximal` must have `ARROW_COMPUTE=ON`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Release arrow-rs / parquet Minor version `55.2.0` (June 2025) [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7394: URL: https://github.com/apache/arrow-rs/issues/7394#issuecomment-2992694995 I made a PR with version bump and release notes: - https://github.com/apache/arrow-rs/pull/7722 -- This is an automated message from the Apache Git Service. To respond to the mess

Re: [PR] GH-46094: [C++][Docs] Add note to RleDecoder::Get's doc comment [arrow]

2025-06-20 Thread via GitHub
kou commented on PR #46874: URL: https://github.com/apache/arrow/pull/46874#issuecomment-2992694636 @github-actions crossbow submit preview-docs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
jadewang-db commented on PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#issuecomment-2992691667 > > maybe extend the database/sql to have arrow functionality. > > Because `database/sql` is part of the Go standard library, it's not really possible to easily extend it. Th

Re: [PR] feat(go/adbc/driver/databricks): implement Databricks ADBC driver with comprehensive test suite [arrow-adbc]

2025-06-20 Thread via GitHub
jadewang-db commented on code in PR #2998: URL: https://github.com/apache/arrow-adbc/pull/2998#discussion_r2159613547 ## go/adbc/driver/databricks/statement.go: ## @@ -0,0 +1,475 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license ag

Re: [PR] GH-46094: [C++][Docs] Add note to RleDecoder::Get's doc comment [arrow]

2025-06-20 Thread via GitHub
github-actions[bot] commented on PR #46874: URL: https://github.com/apache/arrow/pull/46874#issuecomment-2992683493 :warning: GitHub issue #46094 **has been automatically assigned in GitHub** to PR creator. -- This is an automated message from the Apache Git Service. To respond to the mes

Re: [I] [C++][Parquet] RleDecoder::Get fails to return false on end for some bit widths [arrow]

2025-06-20 Thread via GitHub
kou commented on issue #46094: URL: https://github.com/apache/arrow/issues/46094#issuecomment-2992682512 We'll improve docstring. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] chore(csharp): use license expression [arrow-adbc]

2025-06-20 Thread via GitHub
kou commented on code in PR #3006: URL: https://github.com/apache/arrow-adbc/pull/3006#discussion_r2159605538 ## csharp/Directory.Build.props: ## @@ -53,7 +53,7 @@ The Apache Software Foundation feather.png Review Comment: If we use PackageLicenseExpression,

Re: [I] [Variant] Improve API for iterating over values of a VariantList [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7685: URL: https://github.com/apache/arrow-rs/issues/7685#issuecomment-2992676942 `label_issue.py` automatically added labels {'parquet'} from #7704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] `interleave_views` is really slow [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7688: URL: https://github.com/apache/arrow-rs/issues/7688#issuecomment-2992677053 `label_issue.py` automatically added labels {'arrow'} from #7695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Add min max aggregates for FixedSizeBinary [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7674: URL: https://github.com/apache/arrow-rs/issues/7674#issuecomment-2992676765 `label_issue.py` automatically added labels {'arrow'} from #7675 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] [Variant] Implement `VariantObject::field` and `VariantObject::fields` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7665: URL: https://github.com/apache/arrow-rs/issues/7665#issuecomment-2992676589 `label_issue.py` automatically added labels {'parquet'} from #7666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Deliver pyarrow as a standalone crate [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7668: URL: https://github.com/apache/arrow-rs/issues/7668#issuecomment-2992676692 `label_issue.py` automatically added labels {'arrow'} from #7694 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Miri test_native_type_pow test failing [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7641: URL: https://github.com/apache/arrow-rs/issues/7641#issuecomment-2992676477 `label_issue.py` automatically added labels {'arrow'} from #7646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] [Variant] Consider validating variants on creation (rather than read) [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7684: URL: https://github.com/apache/arrow-rs/issues/7684#issuecomment-2992676847 `label_issue.py` automatically added labels {'parquet'} from #7704 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] FlightSQL "GetDbSchemas" and "GetTables" schemas do not fully match the protocol [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7637: URL: https://github.com/apache/arrow-rs/issues/7637#issuecomment-2992676308 `label_issue.py` automatically added labels {'arrow'} from #7638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] FlightSQL "GetDbSchemas" and "GetTables" schemas do not fully match the protocol [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7637: URL: https://github.com/apache/arrow-rs/issues/7637#issuecomment-2992676395 `label_issue.py` automatically added labels {'arrow-flight'} from #7638 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] [Variant] Implement read support for remaining primitive types [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7630: URL: https://github.com/apache/arrow-rs/issues/7630#issuecomment-2992676211 `label_issue.py` automatically added labels {'parquet'} from #7644 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Feature Request: Encoding in `parquet-rewrite` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7575: URL: https://github.com/apache/arrow-rs/issues/7575#issuecomment-2992675182 `label_issue.py` automatically added labels {'parquet'} from #7576 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] `max_statistics_truncate_length` is ignored when writing statistics to data page headers [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7579: URL: https://github.com/apache/arrow-rs/issues/7579#issuecomment-2992675309 `label_issue.py` automatically added labels {'enhancement'} from #7555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

Re: [I] Unable to read `Dictionary(u8, FixedSizeBinary(_))` using datafusion. [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7545: URL: https://github.com/apache/arrow-rs/issues/7545#issuecomment-2992674499 `label_issue.py` automatically added labels {'parquet'} from #7585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Feature Request: BloomFilter Position Flexibility in `parquet-rewrite` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7552: URL: https://github.com/apache/arrow-rs/issues/7552#issuecomment-2992674701 `label_issue.py` automatically added labels {'parquet'} from #7550 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Truncate Parquet page data page statistics [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on PR #7555: URL: https://github.com/apache/arrow-rs/pull/7555#issuecomment-2992674939 `label_issue.py` automatically added labels {'next-major-release'} from #7594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [I] filter_record_batch panics with empty struct array. [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7538: URL: https://github.com/apache/arrow-rs/issues/7538#issuecomment-2992674396 `label_issue.py` automatically added labels {'arrow'} from #7539 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Create version of LexicographicalComparator that compares fixed number of columns [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7531: URL: https://github.com/apache/arrow-rs/issues/7531#issuecomment-2992674191 `label_issue.py` automatically added labels {'arrow'} from #7530 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Panic in `pretty_format` function when displaying DurationSecondsArray with `i64::MIN` / `i64::MAX` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7533: URL: https://github.com/apache/arrow-rs/issues/7533#issuecomment-2992674291 `label_issue.py` automatically added labels {'arrow'} from #7534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Bad min value in row group statistics in some special cases [arrow-rs]

2025-06-20 Thread via GitHub
alamb closed issue #7593: Bad min value in row group statistics in some special cases URL: https://github.com/apache/arrow-rs/issues/7593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Fast and ergonomic method to add metadata to a `RecordBatch` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7628: URL: https://github.com/apache/arrow-rs/issues/7628#issuecomment-2992676101 `label_issue.py` automatically added labels {'arrow'} from #7664 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] `encoding_stats` not present in Parquet generated by `parquet-rewrite` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7616: URL: https://github.com/apache/arrow-rs/issues/7616#issuecomment-2992676005 `label_issue.py` automatically added labels {'parquet'} from #7643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[I] Bad min value in row group statistics in some special cases [arrow-rs]

2025-06-20 Thread via GitHub
CookiePieWw opened a new issue, #7593: URL: https://github.com/apache/arrow-rs/issues/7593 **Describe the bug** As found in https://github.com/apache/arrow-rs/pull/7574#discussion_r2119243590, the row group statistics emit an empty string as the min value while there are no empty

Re: [I] Improve performance of `coalesce` and `concat` for views [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7615: URL: https://github.com/apache/arrow-rs/issues/7615#issuecomment-2992675896 `label_issue.py` automatically added labels {'arrow'} from #7614 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Add efficient way to change the keys of string dictionary builder [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7610: URL: https://github.com/apache/arrow-rs/issues/7610#issuecomment-2992675810 `label_issue.py` automatically added labels {'arrow'} from #7611 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Support `add_nulls` on additional builder types [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7605: URL: https://github.com/apache/arrow-rs/issues/7605#issuecomment-2992675743 `label_issue.py` automatically added labels {'arrow'} from #7606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Add `into_inner` for `AsyncArrowWriter` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7603: URL: https://github.com/apache/arrow-rs/issues/7603#issuecomment-2992675663 `label_issue.py` automatically added labels {'parquet'} from #7604 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Benchmark for filter+concat and take+concat into even sized record batches [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7589: URL: https://github.com/apache/arrow-rs/issues/7589#issuecomment-2992675487 `label_issue.py` automatically added labels {'arrow'} from #7597 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] `max_statistics_truncate_length` is ignored when writing statistics to data page headers [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7579: URL: https://github.com/apache/arrow-rs/issues/7579#issuecomment-2992675390 `label_issue.py` automatically added labels {'next-major-release'} from #7555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Add a `strong_count` method to `Buffer` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7568: URL: https://github.com/apache/arrow-rs/issues/7568#issuecomment-2992675068 `label_issue.py` automatically added labels {'arrow'} from #7569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [PR] Truncate Parquet page data page statistics [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on PR #7555: URL: https://github.com/apache/arrow-rs/pull/7555#issuecomment-2992674855 `label_issue.py` automatically added labels {'enhancement'} from #7594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] Parquet derive fails to build when Result is aliased [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7547: URL: https://github.com/apache/arrow-rs/issues/7547#issuecomment-2992674595 `label_issue.py` automatically added labels {'parquet-derive'} from #7548 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [I] Allow merging primitive dictionary values in concat and interleave kernels [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7518: URL: https://github.com/apache/arrow-rs/issues/7518#issuecomment-2992674075 `label_issue.py` automatically added labels {'arrow'} from #7519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Add efficient concatenation of StructArrays [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7516: URL: https://github.com/apache/arrow-rs/issues/7516#issuecomment-2992673978 `label_issue.py` automatically added labels {'arrow'} from #7517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Record API unable to parse TIME_MILLIS when encoded as INT32 [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7510: URL: https://github.com/apache/arrow-rs/issues/7510#issuecomment-2992673901 `label_issue.py` automatically added labels {'next-major-release'} from #7544 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Record API unable to parse TIME_MILLIS when encoded as INT32 [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7510: URL: https://github.com/apache/arrow-rs/issues/7510#issuecomment-2992673814 `label_issue.py` automatically added labels {'parquet'} from #7511 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [I] The `read_record_batch` func of the `RecordBatchDecoder` does not respect the `skip_validation` property [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7508: URL: https://github.com/apache/arrow-rs/issues/7508#issuecomment-2992673695 `label_issue.py` automatically added labels {'arrow'} from #7509 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Rename `flight-sql-experimental` to `flight-sql` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7498: URL: https://github.com/apache/arrow-rs/issues/7498#issuecomment-2992673450 `label_issue.py` automatically added labels {'next-major-release'} from #7551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [I] Rename `flight-sql-experimental` to `flight-sql` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7498: URL: https://github.com/apache/arrow-rs/issues/7498#issuecomment-2992673301 `label_issue.py` automatically added labels {'arrow-flight'} from #7551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHu

Re: [I] Rename `flight-sql-experimental` to `flight-sql` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7498: URL: https://github.com/apache/arrow-rs/issues/7498#issuecomment-2992673216 `label_issue.py` automatically added labels {'arrow'} from #7551 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and u

Re: [I] Files containing binary data with >=8_388_855 bytes per row written with `arrow-rs` can't be read with `pyarrow` [arrow-rs]

2025-06-20 Thread via GitHub
alamb commented on issue #7489: URL: https://github.com/apache/arrow-rs/issues/7489#issuecomment-2992673044 `label_issue.py` automatically added labels {'parquet'} from #7555 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

  1   2   3   4   5   >