paleolimbot commented on code in PR #2918:
URL: https://github.com/apache/arrow-adbc/pull/2918#discussion_r2159633823
##########
c/driver_manager/adbc_driver_manager.cc:
##########
@@ -1716,6 +2176,12 @@ AdbcStatusCode AdbcLoadDriver(const char* driver_name,
const char* entrypoint,
return status;
}
+AdbcStatusCode AdbcLoadDriver(const char* driver_name, const char* entrypoint,
+ int version, void* raw_driver, struct AdbcError*
error) {
+ return AdbcFindLoadDriver(driver_name, entrypoint, version,
ADBC_LOAD_FLAG_DEFAULT,
+ raw_driver, error);
+}
Review Comment:
Having no options enabled for the purposes of this PR is I think a good
idea...I think we'd use the new function in the R and Python bindings by
default, though, since those are examples where this behaviour makes sense. If
there's a compelling reason to update this function specifically it's an easy
change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
