kou commented on PR #47077:
URL: https://github.com/apache/arrow/pull/47077#issuecomment-3060885062
@github-actions crossbow submit --group verify-rc-source --param
release=21.0.0 --param rc=5
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kou opened a new pull request, #47077:
URL: https://github.com/apache/arrow/pull/47077
PR to verify Release Candidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
kou commented on PR #47073:
URL: https://github.com/apache/arrow/pull/47073#issuecomment-3060857547
The source archive isn't enough reproducible.
Let's try RC5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
kou closed pull request #47073: WIP: [Release] Verify release-21.0.0-rc4
URL: https://github.com/apache/arrow/pull/47073
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
kou merged PR #47076:
URL: https://github.com/apache/arrow/pull/47076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on issue #47074:
URL: https://github.com/apache/arrow/issues/47074#issuecomment-3060850229
Issue resolved by pull request 47076
https://github.com/apache/arrow/pull/47076
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou commented on PR #47076:
URL: https://github.com/apache/arrow/pull/47076#issuecomment-3060848727
+1
I'll try this for RC5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
kou commented on issue #190:
URL:
https://github.com/apache/arrow-flight-sql-postgresql/issues/190#issuecomment-3060748597
No. It seems that we can change it by the `POSTGRES_HOST_AUTH_METHOD`
environment variable:
https://hub.docker.com/_/postgres#postgres_host_auth_method
Could yo
github-actions[bot] commented on PR #47076:
URL: https://github.com/apache/arrow/pull/47076#issuecomment-3060732132
:warning: GitHub issue #47074 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47076:
URL: https://github.com/apache/arrow/pull/47076
### Rationale for this change
The current source archive creation is reproducible when we use the same Git
working tree.
But it's not reproducible when we use different Git working trees.
zhuqi-lucas commented on PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#issuecomment-3060692424
Interesting the Rustdocs check seems broken, not related to this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
klion26 commented on issue #6700:
URL: https://github.com/apache/arrow-rs/issues/6700#issuecomment-3060670367
@alamb, I have some questions after conducting an analysis; I'm not sure if
we need to make this change. Could you please help to confirm this? I can
submit a PR if this change is n
viirya commented on PR #7897:
URL: https://github.com/apache/arrow-rs/pull/7897#issuecomment-3060657413
Seems the CI was broken. Proposed the fix
https://github.com/apache/arrow-rs/pull/7898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
davidhewitt commented on PR #7716:
URL: https://github.com/apache/arrow-rs/pull/7716#issuecomment-3060657116
Wow CI has not been kind here! Merged main again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
viirya opened a new pull request, #7898:
URL: https://github.com/apache/arrow-rs/pull/7898
# Which issue does this PR close?
None
# Rationale for this change
Currently CI is failed:
https://github.com/apache/arrow-rs/actions/runs/16210835231/job/45770459574?pr=789
kou commented on PR #47073:
URL: https://github.com/apache/arrow/pull/47073#issuecomment-3060520336
Revision: apache-arrow-21.0.0-rc4
Submitted crossbow builds: [ursacomputing/crossbow @
release-21.0.0-rc4-1](https://github.com/ursacomputing/crossbow/branches/all?query=release-21.0.0-
abacef commented on issue #7297:
URL: https://github.com/apache/arrow-rs/issues/7297#issuecomment-3060513714
@jayzhan211 I am interested in working on this (if @ajita-asthana you are
not) but can you explain more what types of things should be benchmarked here?
Are you seeing that doing a f
github-actions[bot] commented on PR #47073:
URL: https://github.com/apache/arrow/pull/47073#issuecomment-3060506439
Revision: f2cf4007d42239d32969b19bd0e740b7d73682f3
Submitted crossbow builds: [ursacomputing/crossbow @
actions-21fb12996a](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #47073:
URL: https://github.com/apache/arrow/pull/47073#issuecomment-3060499544
@github-actions crossbow submit --group verify-rc-source --param
release=21.0.0 --param rc=4
--
This is an automated message from the Apache Git Service.
To respond to the message, please
kou opened a new pull request, #47073:
URL: https://github.com/apache/arrow/pull/47073
PR to verify Release Candidate
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
eitsupi commented on code in PR #3099:
URL: https://github.com/apache/arrow-adbc/pull/3099#discussion_r2199534491
##
rust/core/src/driver_manager.rs:
##
@@ -1310,3 +1645,506 @@ impl Drop for ManagedStatement {
unsafe { method(statement.deref_mut(), null_mut()) };
}
zhuqi-lucas commented on PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#issuecomment-3060291994
> Thank you @zhuqi-lucas -- I think this PR could be merged as is
>
> I think we could improve the safety of `process_views` / make it less
dangerous, but e could also do it as
zhuqi-lucas commented on PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#issuecomment-3060288344
> > 🤖: Benchmark completed
>
> 😮 -- very nuce
Amazing, 1.44 ~ 5.4 faster!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
zhuqi-lucas commented on code in PR #7873:
URL: https://github.com/apache/arrow-rs/pull/7873#discussion_r2199447035
##
arrow-array/src/array/byte_view_array.rs:
##
@@ -473,13 +473,78 @@ impl GenericByteViewArray {
/// Note: this function does not attempt to canonicalize / d
kou commented on issue #47071:
URL: https://github.com/apache/arrow/issues/47071#issuecomment-3060257706
Issue resolved by pull request 47072
https://github.com/apache/arrow/pull/47072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47072:
URL: https://github.com/apache/arrow/pull/47072
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #47072:
URL: https://github.com/apache/arrow/pull/47072#issuecomment-3060257390
+1
RC3 is failed by this problem. I'll try this fix with RC4.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
github-actions[bot] commented on PR #47046:
URL: https://github.com/apache/arrow/pull/47046#issuecomment-3060253979
Revision: ca78771d9f3055d37fe3ac07d2bccd1a2785450f
Submitted crossbow builds: [ursacomputing/crossbow @
actions-66624d6f27](https://github.com/ursacomputing/crossbow/bra
kou commented on PR #47046:
URL: https://github.com/apache/arrow/pull/47046#issuecomment-3060247548
@github-actions crossbow submit *fedora*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
Samyak2 commented on issue #7893:
URL: https://github.com/apache/arrow-rs/issues/7893#issuecomment-3060246629
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
Samyak2 commented on issue #7893:
URL: https://github.com/apache/arrow-rs/issues/7893#issuecomment-3060247795
I know we're waiting for https://github.com/apache/arrow-rs/pull/7884 to be
merged. But I'll have some proof of concept on top of that branch for now.
--
This is an automated mess
github-actions[bot] commented on PR #47072:
URL: https://github.com/apache/arrow/pull/47072#issuecomment-3060208037
:warning: GitHub issue #47071 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47072:
URL: https://github.com/apache/arrow/pull/47072
### Rationale for this change
Apache Rat doesn't like hard links.
### What changes are included in this PR?
Use `tar --hard-dereference`.
### Are these changes tested?
Yes
viirya commented on code in PR #7885:
URL: https://github.com/apache/arrow-rs/pull/7885#discussion_r2199385788
##
parquet-variant/src/variant/object.rs:
##
@@ -474,4 +474,78 @@ mod tests {
let fields: Vec<_> = variant_obj.iter().collect();
assert_eq!(fields.len
viirya opened a new pull request, #7897:
URL: https://github.com/apache/arrow-rs/pull/7897
# Which issue does this PR close?
None
# Rationale for this change
Address the comment
https://github.com/apache/arrow-rs/pull/7885#discussion_r2195436015.
# What changes ar
scovich commented on PR #7888:
URL: https://github.com/apache/arrow-rs/pull/7888#issuecomment-3060158047
Looks like [docs job is
broken](https://github.com/apache/arrow-rs/actions/runs/16210712671/job/45770109006?pr=7888)
upstream?
```
error: unnecessary parentheses around closure bod
alamb commented on PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#issuecomment-3060156882
> For example, the latest CI run displays errors like:
>
> > Documenting arrow-ord v55.2.0 (/__w/arrow-rs/arrow-rs/arrow-ord)
> > error: unnecessary parentheses around closure body
friendlymatthew commented on issue #7895:
URL: https://github.com/apache/arrow-rs/issues/7895#issuecomment-3060154117
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
friendlymatthew commented on PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#issuecomment-3060147909
For example, the latest CI run displays errors like:
> Documenting arrow-ord v55.2.0 (/__w/arrow-rs/arrow-rs/arrow-ord)
error: unnecessary parentheses around closure bod
alamb commented on PR #7303:
URL: https://github.com/apache/arrow-rs/pull/7303#issuecomment-3060147580
Thanks @waynexia and @Dandandan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
alamb commented on PR #7303:
URL: https://github.com/apache/arrow-rs/pull/7303#issuecomment-3060147455
🚀
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
alamb commented on code in PR #7885:
URL: https://github.com/apache/arrow-rs/pull/7885#discussion_r2199376309
##
parquet-variant/src/variant/object.rs:
##
@@ -474,4 +474,78 @@ mod tests {
let fields: Vec<_> = variant_obj.iter().collect();
assert_eq!(fields.len(
alamb commented on PR #7888:
URL: https://github.com/apache/arrow-rs/pull/7888#issuecomment-3060145386
I merged up from main to resolve a logical conflcit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
friendlymatthew commented on issue #7895:
URL: https://github.com/apache/arrow-rs/issues/7895#issuecomment-3060145062
Hi, I think this relates a lot to my current work. I didn't think about a
builder pattern, but that does seem like a very clever and safe way to build up
shredded variants.
odysa opened a new pull request, #7896:
URL: https://github.com/apache/arrow-rs/pull/7896
# Which issue does this PR close?
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issu
klion26 commented on code in PR #37877:
URL: https://github.com/apache/arrow/pull/37877#discussion_r2199372594
##
docs/source/format/Columnar.rst:
##
@@ -487,6 +499,103 @@ will be represented as follows: ::
|---|---|
alamb commented on PR #7888:
URL: https://github.com/apache/arrow-rs/pull/7888#issuecomment-3060139668
Looks like this PR has some clippy failures too -- once that is clean I'll
plan to merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
friendlymatthew commented on PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#issuecomment-3060140164
> Looks like there is one final CI check to fix and then I can merge this PR
in
https://github.com/apache/arrow-rs/actions/runs/16209770665/job/45767524794?pr=7878
>
> I c
alamb commented on PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#issuecomment-3060134025
Looks like there is one final CI check to fix and then I can merge this PR
in
https://github.com/apache/arrow-rs/actions/runs/16209770665/job/45767524794?pr=7878
I can't push to you
kou commented on issue #47069:
URL: https://github.com/apache/arrow/issues/47069#issuecomment-3060117570
Issue resolved by pull request 47070
https://github.com/apache/arrow/pull/47070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47070:
URL: https://github.com/apache/arrow/pull/47070
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #47070:
URL: https://github.com/apache/arrow/pull/47070#issuecomment-3060116506
+1
I confirmed that all jobs have correct `VERSION` and `RC`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
alamb commented on issue #7715:
URL: https://github.com/apache/arrow-rs/issues/7715#issuecomment-3060102336
> What if the the writer just passes a shredding schema? For example, if
they want to shred `v:c::INT`, they could provide:
This is an excellent idea and it seems consistent wit
alamb commented on issue #7715:
URL: https://github.com/apache/arrow-rs/issues/7715#issuecomment-3060099405
I wrote up an idea of how we might implement variant shredding here in a
ticket. The idea would be to create a builder that did the shredding on creation
- https://github.com/apache
alamb commented on issue #7895:
URL: https://github.com/apache/arrow-rs/issues/7895#issuecomment-3060098095
Note one important property of this design is that we could incrementally
build up shredded variant output from JSON directly, rather than having to
parse the json into a variant and
github-actions[bot] commented on PR #47070:
URL: https://github.com/apache/arrow/pull/47070#issuecomment-3060095399
:warning: GitHub issue #47069 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47070:
URL: https://github.com/apache/arrow/pull/47070
### Rationale for this change
We need `needs: target` for jobs that use the `target` job outputs.
### What changes are included in this PR?
Add missing `needs: target`s.
### Are
alamb opened a new issue, #7895:
URL: https://github.com/apache/arrow-rs/issues/7895
**Is your feature request related to a problem or challenge? Please describe
what you are trying to do.**
- part of https://github.com/apache/arrow-rs/issues/6736
- This is a follow up to https://githu
kou commented on PR #47068:
URL: https://github.com/apache/arrow/pull/47068#issuecomment-3060085072
+1
I'm trying verifying RC by workflow dispatch before we cut a RC3.
I found another problem: https://github.com/apache/arrow/issues/47069
--
This is an automated message from
kou commented on issue #47067:
URL: https://github.com/apache/arrow/issues/47067#issuecomment-3060085594
Issue resolved by pull request 47068
https://github.com/apache/arrow/pull/47068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47068:
URL: https://github.com/apache/arrow/pull/47068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
MichaelScofield commented on code in PR #7839:
URL: https://github.com/apache/arrow-rs/pull/7839#discussion_r2199335122
##
arrow-flight/examples/flight_sql_server.rs:
##
@@ -814,7 +814,7 @@ mod tests {
async fn bind_tcp() -> (TcpIncoming, SocketAddr) {
let listener
github-actions[bot] commented on PR #47068:
URL: https://github.com/apache/arrow/pull/47068#issuecomment-3060007328
:warning: GitHub issue #47067 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47068:
URL: https://github.com/apache/arrow/pull/47068
### Rationale for this change
We must use `inputs` not `input` for inputs for workflow dispatch:
https://docs.github.com/en/actions/reference/contexts-reference#inputs-context
### What change
kou commented on issue #47065:
URL: https://github.com/apache/arrow/issues/47065#issuecomment-3059985899
Issue resolved by pull request 47066
https://github.com/apache/arrow/pull/47066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47066:
URL: https://github.com/apache/arrow/pull/47066
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #47066:
URL: https://github.com/apache/arrow/pull/47066#issuecomment-3059985422
+1
RC2 is failed by this problem. I'll try this fix for RC3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
github-actions[bot] commented on PR #47066:
URL: https://github.com/apache/arrow/pull/47066#issuecomment-3059971798
:warning: GitHub issue #47065 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47066:
URL: https://github.com/apache/arrow/pull/47066
### Rationale for this change
We must use `timeout-minutes` not `timeout` for timeout.
### What changes are included in this PR?
Fix key.
### Are these changes tested?
No.
kou commented on issue #47047:
URL: https://github.com/apache/arrow/issues/47047#issuecomment-3059955664
Issue resolved by pull request 47048
https://github.com/apache/arrow/pull/47048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47048:
URL: https://github.com/apache/arrow/pull/47048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #47048:
URL: https://github.com/apache/arrow/pull/47048#issuecomment-3059952074
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
kou commented on issue #47063:
URL: https://github.com/apache/arrow/issues/47063#issuecomment-3059932962
Issue resolved by pull request 47064
https://github.com/apache/arrow/pull/47064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47064:
URL: https://github.com/apache/arrow/pull/47064
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
conbench-apache-arrow[bot] commented on PR #47060:
URL: https://github.com/apache/arrow/pull/47060#issuecomment-3059933148
After merging your PR, Conbench analyzed the 4 benchmarking runs that have
been run so far on merge-commit a23c2c7f5268c516a48b30940ae77c4137b4b495.
There were no
github-actions[bot] commented on PR #47064:
URL: https://github.com/apache/arrow/pull/47064#issuecomment-3059927098
:warning: GitHub issue #47063 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou commented on PR #47064:
URL: https://github.com/apache/arrow/pull/47064#issuecomment-3059926922
+1
RC1 is failed by this problem. I'll try this fix with RC2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use t
github-actions[bot] commented on PR #47064:
URL: https://github.com/apache/arrow/pull/47064#issuecomment-3059925443
:x: GitHub issue #470613 could not be retrieved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
kou opened a new pull request, #47064:
URL: https://github.com/apache/arrow/pull/47064
### Rationale for this change
`RELEASE_TARBALL` is registered to `GITHUB_ENV` but isn't defined in this
context.
### What changes are included in this PR?
Define `RELEASE_TARBARLL`.
friendlymatthew commented on code in PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#discussion_r2199265078
##
parquet-variant/src/variant/list.rs:
##
@@ -209,9 +208,35 @@ impl<'m, 'v> VariantList<'m, 'v> {
// by value to all the children (who would othe
friendlymatthew commented on code in PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#discussion_r2199265078
##
parquet-variant/src/variant/list.rs:
##
@@ -209,9 +208,35 @@ impl<'m, 'v> VariantList<'m, 'v> {
// by value to all the children (who would othe
friendlymatthew commented on code in PR #7878:
URL: https://github.com/apache/arrow-rs/pull/7878#discussion_r2199251737
##
parquet-variant/src/decoder.rs:
##
@@ -200,6 +200,24 @@ impl OffsetSizeBytes {
}
}
+pub(crate) fn map_bytes_to_offsets(
Review Comment:
Sounds g
kou commented on issue #47061:
URL: https://github.com/apache/arrow/issues/47061#issuecomment-3059876319
Issue resolved by pull request 47062
https://github.com/apache/arrow/pull/47062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kou merged PR #47062:
URL: https://github.com/apache/arrow/pull/47062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.or
kou commented on PR #47062:
URL: https://github.com/apache/arrow/pull/47062#issuecomment-3059857411
+1
RC0 failed by this problem. I'll try this fix as RC1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
adamreeve commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2199233416
##
parquet/src/file/properties.rs:
##
@@ -457,7 +457,7 @@ pub struct WriterPropertiesBuilder {
impl WriterPropertiesBuilder {
/// Returns default state of th
github-actions[bot] commented on PR #47062:
URL: https://github.com/apache/arrow/pull/47062#issuecomment-3059856832
:warning: GitHub issue #47061 **has been automatically assigned in GitHub**
to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the mes
kou opened a new pull request, #47062:
URL: https://github.com/apache/arrow/pull/47062
### Rationale for this change
We must use GPG key ID not GPG key itself for `gpg --local-user`.
### What changes are included in this PR?
Use `ARROW_GPG_KEY_UID`.
### Are these c
dinse commented on code in PR #46755:
URL: https://github.com/apache/arrow/pull/46755#discussion_r2199073574
##
python/pyarrow/includes/libarrow_python_config.pxd:
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
Review Comment:
I am new to C
lidavidm merged PR #3129:
URL: https://github.com/apache/arrow-adbc/pull/3129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
tustvold commented on code in PR #435:
URL:
https://github.com/apache/arrow-rs-object-store/pull/435#discussion_r2199018452
##
src/client/builder.rs:
##
@@ -181,9 +181,28 @@ impl HttpRequestBuilder {
pub(crate) fn query(mut self, query: &T) ->
Self {
let mut erro
lidavidm merged PR #3124:
URL: https://github.com/apache/arrow-adbc/pull/3124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
zeroshade commented on PR #3124:
URL: https://github.com/apache/arrow-adbc/pull/3124#issuecomment-3059554892
Looks good!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
davidhcoe commented on PR #3124:
URL: https://github.com/apache/arrow-adbc/pull/3124#issuecomment-3059550152
ok, all set. The PowerShell output looks like:
```
PS C:\[...]\pkg> make libadbc_driver_snowflake.dll
go build -buildvcs=true -tags driverlib -o libadbc_driver_snowflake.d
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198997136
##
cpp/src/arrow/array/array_test.cc:
##
@@ -4075,4 +4078,72 @@ TYPED_TEST(TestPrimitiveArray, IndexOperator) {
}
}
+class TestHalfFloatBuilder : public ::testing::
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198994780
##
docs/source/cpp/api/builder.rst:
##
@@ -34,6 +34,9 @@ Primitive
.. doxygenclass:: arrow::BooleanBuilder
:members:
+.. doxygenclass:: arrow::HalfFloatBuilder
Re
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198994601
##
cpp/src/arrow/array/builder_primitive.h:
##
@@ -384,6 +384,101 @@ using DurationBuilder = NumericBuilder;
/// @}
+class ARROW_EXPORT HalfFloatBuilder : public Num
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198992783
##
cpp/src/arrow/array/array_test.cc:
##
@@ -4075,4 +4078,72 @@ TYPED_TEST(TestPrimitiveArray, IndexOperator) {
}
}
+class TestHalfFloatBuilder : public ::testing::
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198992326
##
cpp/src/arrow/array/array_test.cc:
##
@@ -4075,4 +4078,72 @@ TYPED_TEST(TestPrimitiveArray, IndexOperator) {
}
}
+class TestHalfFloatBuilder : public ::testing::
dinse commented on code in PR #46981:
URL: https://github.com/apache/arrow/pull/46981#discussion_r2198990771
##
cpp/src/arrow/array/array_test.cc:
##
@@ -4075,4 +4078,72 @@ TYPED_TEST(TestPrimitiveArray, IndexOperator) {
}
}
+class TestHalfFloatBuilder : public ::testing::
1 - 100 of 322 matches
Mail list logo
