Re: [I] [Python][CI] vcpkg dependencies fail rebuilding [arrow]

2025-08-28 Thread via GitHub
kou commented on issue #47367: URL: https://github.com/apache/arrow/issues/47367#issuecomment-3235886883 > Would it be doable to patch vcpkg to integrate the snippet showed in this comment: [microsoft/vcpkg#30622 (comment)](https://github.com/microsoft/vcpkg/issues/30622#issuecomment-187213

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII [arrow-adbc]

2025-08-28 Thread via GitHub
birschick-bq commented on code in PR #3157: URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309119604 ## csharp/src/Drivers/BigQuery/BigQueryConnection.cs: ## @@ -136,30 +136,30 @@ internal BigQueryClient Open(string? projectId = null) if (p

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII [arrow-adbc]

2025-08-28 Thread via GitHub
birschick-bq commented on code in PR #3157: URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309121295 ## csharp/src/Drivers/Databricks/Reader/DatabricksReader.cs: ## @@ -62,7 +62,7 @@ public DatabricksReader(IHiveServer2Statement statement, Schema schema, IResp

Re: [PR] GH-41011: [C++][Compute] Fix the issue that comparison function could not handle decimal arguments with different scales [arrow]

2025-08-28 Thread via GitHub
zanmato1984 commented on code in PR #47459: URL: https://github.com/apache/arrow/pull/47459#discussion_r2309097408 ## cpp/src/arrow/compute/kernels/scalar_compare.cc: ## @@ -436,8 +436,8 @@ std::shared_ptr MakeCompareFunction(std::string name, FunctionDo for (const auto id

Re: [PR] GH-41011: [C++][Compute] Fix the issue that comparison function could not handle decimal arguments with different scales [arrow]

2025-08-28 Thread via GitHub
zanmato1984 commented on PR #47459: URL: https://github.com/apache/arrow/pull/47459#issuecomment-3235679374 @pitrou pretty easy fix (thanks to #47297), mind to take a look? Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] GH-41011: [C++][Compute] Fix the issue that comparison function could not handle decimal arguments with different scales [arrow]

2025-08-28 Thread via GitHub
zanmato1984 commented on code in PR #47459: URL: https://github.com/apache/arrow/pull/47459#discussion_r2309097408 ## cpp/src/arrow/compute/kernels/scalar_compare.cc: ## @@ -436,8 +436,8 @@ std::shared_ptr MakeCompareFunction(std::string name, FunctionDo for (const auto id

[PR] GH-41011: [C++][Compute] Fix the issue that comparison function could not handle decimal arguments with different scales [arrow]

2025-08-28 Thread via GitHub
zanmato1984 opened a new pull request, #47459: URL: https://github.com/apache/arrow/pull/47459 ### Rationale for this change We used to be not able to suppress the exact matching for decimal arguments with different scales, when a decimal comparison kernel who actually requires the s

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII [arrow-adbc]

2025-08-28 Thread via GitHub
davidhcoe commented on code in PR #3157: URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309081879 ## csharp/src/Drivers/Databricks/Reader/DatabricksReader.cs: ## @@ -62,7 +62,7 @@ public DatabricksReader(IHiveServer2Statement statement, Schema schema, IRespons

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII [arrow-adbc]

2025-08-28 Thread via GitHub
davidhcoe commented on code in PR #3157: URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309061440 ## csharp/src/Drivers/BigQuery/BigQueryConnection.cs: ## @@ -136,30 +136,30 @@ internal BigQueryClient Open(string? projectId = null) if (proj

Re: [PR] feat(csharp/src/Apache.Arrow.Adbc): ensure tracing redacts PII [arrow-adbc]

2025-08-28 Thread via GitHub
davidhcoe commented on code in PR #3157: URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309061440 ## csharp/src/Drivers/BigQuery/BigQueryConnection.cs: ## @@ -136,30 +136,30 @@ internal BigQueryClient Open(string? projectId = null) if (proj

Re: [PR] GH-47157: [Docs] Improve presentation of Other available packages section in build_system.rst [arrow]

2025-08-28 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #47411: URL: https://github.com/apache/arrow/pull/47411#issuecomment-3235538202 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ed77d25149569eb9a48f61f3694fd8ea4b9a411d. There weren't

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
paleolimbot commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308907768 ## c/driver/sqlite/sqlite.cc: ## @@ -51,6 +51,7 @@ constexpr std::string_view kConnectionOptionLoadExtensionEntrypoint = "adbc.sqlite.load_extension.entryp

Re: [PR] feat(c/driver/postgresql): bind arrow.json to JSON [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm merged PR #: URL: https://github.com/apache/arrow-adbc/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308976401 ## c/driver/sqlite/sqlite.cc: ## @@ -51,6 +51,7 @@ constexpr std::string_view kConnectionOptionLoadExtensionEntrypoint = "adbc.sqlite.load_extension.entrypoin

Re: [PR] GH-46908: add variant extension type docs [arrow]

2025-08-28 Thread via GitHub
paleolimbot commented on code in PR #47456: URL: https://github.com/apache/arrow/pull/47456#discussion_r2308951039 ## docs/source/format/CanonicalExtensions.rst: ## @@ -417,7 +421,585 @@ better zero-copy compatibility with various systems that also store booleans usi Metad

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#issuecomment-3235466046 @nathaniel-d-ef Thank you so much for getting this up. Overall this looks really good and your implementation is solid. I did leave a few comments related to ideas I had

Re: [PR] GH-44345: [C++][Parquet] Add Decimal32/64 support to Parquet [arrow]

2025-08-28 Thread via GitHub
HuaHuaY commented on code in PR #47427: URL: https://github.com/apache/arrow/pull/47427#discussion_r2308957729 ## docs/source/cpp/parquet.rst: ## @@ -460,8 +460,8 @@ physical type. +---+-+--+---+

Re: [PR] GH-45902: [Python][Parquet] Expose ParquetWriter properties and arrow_properties [arrow]

2025-08-28 Thread via GitHub
wgtmac commented on code in PR #47087: URL: https://github.com/apache/arrow/pull/47087#discussion_r2308950455 ## python/pyarrow/_parquet.pyx: ## @@ -2408,3 +2411,77 @@ cdef class ParquetWriter(_Weakrefable): return result raise RuntimeError( 'f

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] GH-44345: [C++][Parquet] Add Decimal32/64 support to Parquet [arrow]

2025-08-28 Thread via GitHub
wgtmac commented on code in PR #47427: URL: https://github.com/apache/arrow/pull/47427#discussion_r2308943365 ## docs/source/cpp/parquet.rst: ## @@ -460,8 +460,8 @@ physical type. +---+-+--+---+ |

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308925748 ## arrow-avro/src/schema.rs: ## @@ -478,15 +516,15 @@ pub struct SchemaStore { schemas: HashMap, } -impl TryFrom<&[AvroSchema]> for SchemaStore { +impl TryF

Re: [PR] GH-47434: [C++] Fix issue preventing running of tests on Windows [arrow]

2025-08-28 Thread via GitHub
wgtmac commented on PR #47455: URL: https://github.com/apache/arrow/pull/47455#issuecomment-3235457184 The failed test only runs for ORC version below 2.0 ``` TEST(TestAdapterReadWrite, ThrowWhenTZDBUnavaiable) { if (adapters::orc::GetOrcMajorVersion() >= 2) { GTEST_SKIP

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308912949 ## arrow-avro/src/reader/mod.rs: ## @@ -202,30 +202,50 @@ impl Decoder { } // Attempt to handle a single‑object‑encoding prefix at the current position

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308919759 ## arrow-avro/src/schema.rs: ## @@ -389,19 +412,17 @@ pub enum FingerprintAlgorithm { /// Currently only `Rabin` is supported Review Comment: You may want to u

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308916943 ## arrow-avro/src/reader/mod.rs: ## @@ -1791,18 +1917,18 @@ mod test { let expected = RecordBatch::try_from_iter_with_nullable([( "foo",

Re: [PR] feat(java/driver/jni): pass through all initial params [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm merged PR #3372: URL: https://github.com/apache/arrow-adbc/pull/3372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.a

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308915762 ## arrow-avro/src/reader/mod.rs: ## @@ -202,30 +202,50 @@ impl Decoder { } // Attempt to handle a single‑object‑encoding prefix at the current position

Re: [I] docs: change low-level usage warning in Python driver manager docs [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on issue #3363: URL: https://github.com/apache/arrow-adbc/issues/3363#issuecomment-3235435097 There's still the fact that the API is much more verbose/requires C Data Interface objects which is not quite as easy as the DBAPI interface. -- This is an automated message fr

Re: [PR] GH-46908: add variant extension type docs [arrow]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #47456: URL: https://github.com/apache/arrow/pull/47456#discussion_r2308896395 ## docs/source/format/CanonicalExtensions.rst: ## @@ -417,7 +421,585 @@ better zero-copy compatibility with various systems that also store booleans usi Metadata

[PR] Sort: Change lexsort comment from stable to unstable [arrow-rs]

2025-08-28 Thread via GitHub
mapleFU opened a new pull request, #8245: URL: https://github.com/apache/arrow-rs/pull/8245 # Which issue does this PR close? The doc for lexsort says it's stable. However, it's an unstable sort. # Rationale for this change Fix the document. # What changes are incl

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308902052 ## arrow-avro/src/reader/mod.rs: ## @@ -202,30 +202,50 @@ impl Decoder { } // Attempt to handle a single‑object‑encoding prefix at the current position

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308901566 ## arrow-avro/src/reader/mod.rs: ## @@ -202,30 +202,50 @@ impl Decoder { } // Attempt to handle a single‑object‑encoding prefix at the current position

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308891173 ## arrow-avro/benches/decoder.rs: ## @@ -447,6 +496,48 @@ fn bench_scenario( group.finish(); } +fn bench_scenario_id( +c: &mut Criterion, +name: &st

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308891173 ## arrow-avro/benches/decoder.rs: ## @@ -447,6 +496,48 @@ fn bench_scenario( group.finish(); } +fn bench_scenario_id( +c: &mut Criterion, +name: &st

Re: [PR] GH-47451: [Python][CI] Install tzdata-legacy in newer python-wheel-manylinux-test images [arrow]

2025-08-28 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #47452: URL: https://github.com/apache/arrow/pull/47452#issuecomment-3235404459 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a4cde2c65022f46a5fc04bedcc7b2e7c8a9d166e. There weren't

[PR] feat(java/driver/jni): pass through all initial params [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm opened a new pull request, #3372: URL: https://github.com/apache/arrow-adbc/pull/3372 Fixes #3371. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308879436 ## python/adbc_driver_manager/adbc_driver_manager/dbapi.py: ## @@ -721,10 +733,17 @@ def execute(self, operation: Union[bytes, str], parameters=None) -> None:

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308885235 ## arrow-avro/benches/decoder.rs: ## @@ -369,42 +405,55 @@ const MIX_SCHEMA: &str = r#"{"type":"record","name":"MixRec","fields":[{"name":" const NEST_SCHEMA: &st

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308882812 ## arrow-avro/benches/decoder.rs: ## @@ -369,42 +405,55 @@ const MIX_SCHEMA: &str = r#"{"type":"record","name":"MixRec","fields":[{"name":" const NEST_SCHEMA: &st

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308882812 ## arrow-avro/benches/decoder.rs: ## @@ -369,42 +405,55 @@ const MIX_SCHEMA: &str = r#"{"type":"record","name":"MixRec","fields":[{"name":" const NEST_SCHEMA: &st

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308879436 ## python/adbc_driver_manager/adbc_driver_manager/dbapi.py: ## @@ -721,10 +733,17 @@ def execute(self, operation: Union[bytes, str], parameters=None) -> None:

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308878805 ## arrow-avro/benches/decoder.rs: ## @@ -27,18 +27,33 @@ extern crate uuid; use apache_avro::types::Value; use apache_avro::{to_avro_datum, Decimal, Schema as A

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308833404 ## arrow-avro/Cargo.toml: ## @@ -59,6 +59,8 @@ strum_macros = "0.27" uuid = "1.17" indexmap = "2.10" rand = "0.9" +md5 = "0.8.0" +sha2 = "0.11.0-rc.0" Review Co

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308866841 ## arrow-avro/Cargo.toml: ## @@ -59,6 +59,8 @@ strum_macros = "0.27" uuid = "1.17" indexmap = "2.10" rand = "0.9" +md5 = "0.8.0" +sha2 = "0.11.0-rc.0" Review Co

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308866841 ## arrow-avro/Cargo.toml: ## @@ -59,6 +59,8 @@ strum_macros = "0.27" uuid = "1.17" indexmap = "2.10" rand = "0.9" +md5 = "0.8.0" +sha2 = "0.11.0-rc.0" Review Co

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
WillAyd commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308860877 ## python/adbc_driver_manager/adbc_driver_manager/dbapi.py: ## @@ -721,10 +733,17 @@ def execute(self, operation: Union[bytes, str], parameters=None) -> None:

Re: [PR] feat(go/adbc/driver/snowflake): Enable PAT and WIF auth [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #3366: URL: https://github.com/apache/arrow-adbc/pull/3366#discussion_r2308858855 ## python/adbc_driver_snowflake/adbc_driver_snowflake/__init__.py: ## @@ -104,6 +106,27 @@ class DatabaseOptions(enum.Enum): USE_HIGH_PRECISION = "adbc.snowfla

[PR] feat(java/driver/jni): implement parameter binding [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm opened a new pull request, #3370: URL: https://github.com/apache/arrow-adbc/pull/3370 The Java API lacks a way to bind a stream, due to the general lack of a good interface for a stream in Java. So that isn't supported. Fixes #3369. -- This is an automated message from th

Re: [PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
jecsand838 commented on code in PR #8242: URL: https://github.com/apache/arrow-rs/pull/8242#discussion_r2308833404 ## arrow-avro/Cargo.toml: ## @@ -59,6 +59,8 @@ strum_macros = "0.27" uuid = "1.17" indexmap = "2.10" rand = "0.9" +md5 = "0.8.0" +sha2 = "0.11.0-rc.0" Review Co

Re: [PR] Fix host handling for default HDFS URI (fix for #25324 when used via `from_uri()`) [arrow]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #47458: URL: https://github.com/apache/arrow/pull/47458#issuecomment-3235321609 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

[PR] Fix host handling for default HDFS URI (fix for #25324 when used via `from_uri()`) [arrow]

2025-08-28 Thread via GitHub
dsevilla opened a new pull request, #47458: URL: https://github.com/apache/arrow/pull/47458 In #25324 a fix is introduced for the python HadoopFileSystem, but it does not work if you use `from_uri()`, as it is passed to the underlying C++ implementation of the options parsing. The "default"

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
lidavidm commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308822035 ## c/driver/sqlite/sqlite_test.cc: ## @@ -826,6 +828,32 @@ TEST_F(SqliteReaderTest, InferTypedParams) { "[SQLite] Type mismatch in column 0: expe

Re: [PR] Update host validation for HDFS connection (correctly fix #25324) [arrow]

2025-08-28 Thread via GitHub
dsevilla closed pull request #47457: Update host validation for HDFS connection (correctly fix #25324) URL: https://github.com/apache/arrow/pull/47457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on PR #12865: URL: https://github.com/apache/arrow/pull/12865#issuecomment-3235291548 Thanks for the review @pitrou! I've addressed your comments, please do another pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308811734 ## cpp/src/arrow/compute/kernels/scalar_temporal_test.cc: ## @@ -772,32 +779,36 @@ TEST_F(ScalarTemporalTest, TestZoned1) { {"iso_year": 2008, "iso

[PR] pin comfy-table to 7.1.2 [arrow-rs]

2025-08-28 Thread via GitHub
zachschuermann opened a new pull request, #8244: URL: https://github.com/apache/arrow-rs/pull/8244 # Which issue does this PR close? - Closes #8243 . # What changes are included in this PR? pin `comfy-table` to release prior to 7.2.0's MSRV bump to 1.85 - included a TODO

[I] comfy-table release 7.2.0 breaks MSRV [arrow-rs]

2025-08-28 Thread via GitHub
zachschuermann opened a new issue, #8243: URL: https://github.com/apache/arrow-rs/issues/8243 comfy-table release 7.2.0 release bumps their MSRV to 1.85 + rust2024, arrow currently at 1.84 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308802893 ## cpp/src/arrow/compute/kernels/scalar_temporal_test.cc: ## @@ -2140,6 +2174,13 @@ TEST_F(ScalarTemporalTest, StrftimeCLocale) { utf8(), string_locale_

[PR] Update host validation for HDFS connection (correcly fix #25324) [arrow]

2025-08-28 Thread via GitHub
dsevilla opened a new pull request, #47457: URL: https://github.com/apache/arrow/pull/47457 Refactor host validation to allow 'hdfs://default' as a valid input to correctly fix #25324 when used via `from_uri()`. ### Rationale for this change While `fs.HadoopFileSystem()` could

Re: [PR] Update host validation for HDFS connection (correcly fix #25324) [arrow]

2025-08-28 Thread via GitHub
github-actions[bot] commented on PR #47457: URL: https://github.com/apache/arrow/pull/47457#issuecomment-3235236191 Thanks for opening a pull request! If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue f

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308758043 ## cpp/src/arrow/compute/kernels/scalar_temporal_test.cc: ## @@ -1872,33 +1883,46 @@ TEST_F(ScalarTemporalTest, TestLocalTimestamp) { times_seconds_pr

Re: [PR] GH-47268: [C++][Compute] Fix discarded bad status for call binding [arrow]

2025-08-28 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #47284: URL: https://github.com/apache/arrow/pull/47284#issuecomment-3235226833 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 4d90dd76622f8810a613d24306dead3127dd3948. There weren't

Re: [PR] [Variant] add strict mode to cast_to_variant [arrow-rs]

2025-08-28 Thread via GitHub
liamzwbao commented on code in PR #8233: URL: https://github.com/apache/arrow-rs/pull/8233#discussion_r2308739717 ## parquet-variant-compute/src/cast_to_variant.rs: ## @@ -2392,4 +2413,64 @@ mod tests { } } } + +fn run_test(values: ArrayRef, expect

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308737663 ## cpp/src/arrow/compute/kernels/temporal_internal.h: ## @@ -128,27 +183,30 @@ struct ZonedLocalizer { template struct TimestampFormatter { const char* format; - con

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308733742 ## cpp/src/arrow/compute/kernels/temporal_internal.h: ## @@ -40,15 +40,65 @@ using arrow_vendored::date::year_month_day; using arrow_vendored::date::zoned_time; using std

Re: [PR] ARROW-14477: [C++] Timezone-aware kernels should handle offset strings (e.g. "+04:30") [arrow]

2025-08-28 Thread via GitHub
rok commented on code in PR #12865: URL: https://github.com/apache/arrow/pull/12865#discussion_r2308732670 ## cpp/src/arrow/compute/kernels/temporal_internal.h: ## @@ -40,15 +40,65 @@ using arrow_vendored::date::year_month_day; using arrow_vendored::date::zoned_time; using std

[PR] Adds Confluent wire format handling to arrow-avro crate [arrow-rs]

2025-08-28 Thread via GitHub
nathaniel-d-ef opened a new pull request, #8242: URL: https://github.com/apache/arrow-rs/pull/8242 # Which issue does this PR close? - Part of https://github.com/apache/arrow-rs/issues/4886 - Extends work initiated in https://github.com/apache/arrow-rs/pull/8006 # Rationale f

Re: [PR] refactor(arrow): fourth increment of the Record -> RecordBatch migration [arrow-go]

2025-08-28 Thread via GitHub
zeroshade merged PR #486: URL: https://github.com/apache/arrow-go/pull/486 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[PR] [Variant]: Implement `DataType::ListView/LargeListView` support for `cast_to_variant` kernel [arrow-rs]

2025-08-28 Thread via GitHub
liamzwbao opened a new pull request, #8241: URL: https://github.com/apache/arrow-rs/pull/8241 # Which issue does this PR close? - Closes #8236. # Rationale for this change # What changes are included in this PR? This PR is based on #8235, and the real change is

Re: [PR] [Variant] Refactor `cast_to_variant` [arrow-rs]

2025-08-28 Thread via GitHub
liamzwbao commented on PR #8235: URL: https://github.com/apache/arrow-rs/pull/8235#issuecomment-3235097315 > Should we be intentional about which one merges first? This one will be super conflict-prone, so we probably need to merge it first or risk getting on a treadmill. Thanks for

Re: [PR] MINOR: [Doc][C++][Parquet] Update doc for LargeList support [arrow]

2025-08-28 Thread via GitHub
conbench-apache-arrow[bot] commented on PR #47450: URL: https://github.com/apache/arrow/pull/47450#issuecomment-3235093213 After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 0c280fd1a71fbea3f66e7c14adbb7278afdaeded. There weren't

Re: [PR] ci: change CI DB for snowflake tests [arrow-adbc]

2025-08-28 Thread via GitHub
zeroshade merged PR #3368: URL: https://github.com/apache/arrow-adbc/pull/3368 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.

Re: [PR] feat(go/adbc/driver/snowflake): Enable PAT and WIF auth [arrow-adbc]

2025-08-28 Thread via GitHub
zeroshade commented on code in PR #3366: URL: https://github.com/apache/arrow-adbc/pull/3366#discussion_r2308635877 ## docs/source/driver/snowflake.rst: ## @@ -351,6 +351,7 @@ These options map 1:1 with the Snowflake `Config object

Re: [PR] chore: bump version number [arrow-go]

2025-08-28 Thread via GitHub
zeroshade merged PR #487: URL: https://github.com/apache/arrow-go/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apac

[PR] chore: bump version number [arrow-go]

2025-08-28 Thread via GitHub
zeroshade opened a new pull request, #487: URL: https://github.com/apache/arrow-go/pull/487 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[PR] ci: change CI DB for snowflake tests [arrow-adbc]

2025-08-28 Thread via GitHub
zeroshade opened a new pull request, #3368: URL: https://github.com/apache/arrow-adbc/pull/3368 Switchover to ARROW_OSS_DB for the database name to use with CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

Re: [PR] GH-45902: [Python][Parquet] Expose ParquetWriter properties and arrow_properties [arrow]

2025-08-28 Thread via GitHub
SoundBot commented on PR #47087: URL: https://github.com/apache/arrow/pull/47087#issuecomment-3234965981 Hey folks, I suggest that if this code passes the sniff test, we merge it and address enhancements in later PRs. If not, let's list the concrete changes I need to make to get this over

Re: [I] [Parquet][Python] API to decrypt parquet file using one DEK and no metadata [arrow]

2025-08-28 Thread via GitHub
adamreeve commented on issue #47435: URL: https://github.com/apache/arrow/issues/47435#issuecomment-3234977585 For a bit more context, here's the old [mailing list discussion](https://lists.apache.org/thread/l7tltjf9w3lcjvngq35fzqsddmylkt3k) and [issue](https://github.com/apache/arrow/issue

Re: [PR] GH-20125: [Docs][Python] Restructure developers/python.rst [arrow]

2025-08-28 Thread via GitHub
thisisnic commented on PR #47334: URL: https://github.com/apache/arrow/pull/47334#issuecomment-3234928868 Sorry, mad busy week, but can take a look early next week. Excited to see where this has got to! -- This is an automated message from the Apache Git Service. To respond to the messag

Re: [I] [Variant] Support Shredded Lists/Array in `variant_get` [arrow-rs]

2025-08-28 Thread via GitHub
sdf-jkl commented on issue #8082: URL: https://github.com/apache/arrow-rs/issues/8082#issuecomment-3234923909 take -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

Re: [PR] GH-46522: [C++][FlightRPC] Add Arrow Flight SQL ODBC driver [arrow]

2025-08-28 Thread via GitHub
alinaliBQ commented on code in PR #40939: URL: https://github.com/apache/arrow/pull/40939#discussion_r2308498985 ## cpp/src/arrow/flight/sql/odbc/flight_sql/utils.h: ## @@ -0,0 +1,124 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor licen

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
amoeba commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308493892 ## c/driver/sqlite/sqlite_test.cc: ## @@ -826,6 +828,32 @@ TEST_F(SqliteReaderTest, InferTypedParams) { "[SQLite] Type mismatch in column 0: expect

Re: [PR] feat(c/driver/sqlite,python/adbc_driver_manager): bind params by name [arrow-adbc]

2025-08-28 Thread via GitHub
amoeba commented on code in PR #3362: URL: https://github.com/apache/arrow-adbc/pull/3362#discussion_r2308493892 ## c/driver/sqlite/sqlite_test.cc: ## @@ -826,6 +828,32 @@ TEST_F(SqliteReaderTest, InferTypedParams) { "[SQLite] Type mismatch in column 0: expect

Re: [PR] fix(csharp/src/Drivers/Databricks): Add instructions about driver config setup [arrow-adbc]

2025-08-28 Thread via GitHub
CurtHagenlocher merged PR #3367: URL: https://github.com/apache/arrow-adbc/pull/3367 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@

Re: [PR] GH-46522: [C++][FlightRPC] Add Arrow Flight SQL ODBC driver [arrow]

2025-08-28 Thread via GitHub
alinaliBQ commented on code in PR #40939: URL: https://github.com/apache/arrow/pull/40939#discussion_r2308475066 ## cpp/src/arrow/flight/sql/odbc/odbcabstraction/odbc_impl/odbc_statement.cc: ## @@ -0,0 +1,787 @@ +// Licensed to the Apache Software Foundation (ASF) under one +//

Re: [I] Range header causing AWS Signature issues [arrow-rs-object-store]

2025-08-28 Thread via GitHub
DrewMcArthur commented on issue #471: URL: https://github.com/apache/arrow-rs-object-store/issues/471#issuecomment-3234847998 I'm now able to use the `aws s3api` cli with the range option - this wasn't working yesterday (per the linked issue about) but now it is. Using this crate, and twe

[PR] add instructions about config override [arrow-adbc]

2025-08-28 Thread via GitHub
eric-wang-1990 opened a new pull request, #3367: URL: https://github.com/apache/arrow-adbc/pull/3367 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

Re: [PR] feat(go/adbc/driver/snowflake): Enable PAT auth [arrow-adbc]

2025-08-28 Thread via GitHub
ianmcook commented on code in PR #3366: URL: https://github.com/apache/arrow-adbc/pull/3366#discussion_r2308435515 ## docs/source/driver/snowflake.rst: ## @@ -351,6 +351,7 @@ These options map 1:1 with the Snowflake `Config object

[PR] feat(go/adbc/driver/snowflake): Enable PAT auth [arrow-adbc]

2025-08-28 Thread via GitHub
zeroshade opened a new pull request, #3366: URL: https://github.com/apache/arrow-adbc/pull/3366 Enable using PAT authentication for connecting with the Snowflake ADBC driver. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Re: [PR] GH-46908: add variant extension type docs [arrow]

2025-08-28 Thread via GitHub
ianmcook commented on code in PR #47456: URL: https://github.com/apache/arrow/pull/47456#discussion_r2308402452 ## docs/source/format/CanonicalExtensions.rst: ## @@ -417,7 +417,585 @@ better zero-copy compatibility with various systems that also store booleans usi Metadata

Re: [PR] GH-46908: add variant extension type docs [arrow]

2025-08-28 Thread via GitHub
ianmcook commented on PR #47456: URL: https://github.com/apache/arrow/pull/47456#issuecomment-3234761406 Higher up in this doc, can you please make this change: > The specification text to be added *must* follow these requirements: > 1. It *must* define a well-defined extension name

Re: [PR] GH-46908: add variant extension type docs [arrow]

2025-08-28 Thread via GitHub
ianmcook commented on PR #47456: URL: https://github.com/apache/arrow/pull/47456#issuecomment-3234762959 For uses of the word "variant" outside of code, please standardize the case on "Variant" or "variant" consistently. Right now it's a mix. -- This is an automated message from the Apach

Re: [I] [Docs] Improve presentation of Other available packages section in build_system.rst [arrow]

2025-08-28 Thread via GitHub
amoeba commented on issue #47157: URL: https://github.com/apache/arrow/issues/47157#issuecomment-3234759004 Issue resolved by pull request 47411 https://github.com/apache/arrow/pull/47411 -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] GH-47157: [Docs] Improve presentation of Other available packages section in build_system.rst [arrow]

2025-08-28 Thread via GitHub
amoeba commented on PR #47411: URL: https://github.com/apache/arrow/pull/47411#issuecomment-3234759512 Thanks @vidhyarbiji! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] GH-47157: [Docs] Improve presentation of Other available packages section in build_system.rst [arrow]

2025-08-28 Thread via GitHub
amoeba merged PR #47411: URL: https://github.com/apache/arrow/pull/47411 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache

  1   2   3   >