jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r484642205
##
File path: rust/datafusion/src/execution/dataframe_impl.rs
##
@@ -232,6 +241,50 @@ mod tests {
Ok(())
}
+#[test]
+fn
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483428265
##
File path: rust/datafusion/src/physical_plan/planner.rs
##
@@ -368,32 +368,22 @@ impl DefaultPhysicalPlanner {
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483427788
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -524,25 +524,18 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483418021
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -987,22 +1009,23 @@ mod tests {
Ok(Arc::new(add(l, r)?))
});
-
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483416817
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -975,7 +997,7 @@ mod tests {
let provider = MemTable::new(Arc::new(schema),
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483416817
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -975,7 +997,7 @@ mod tests {
let provider = MemTable::new(Arc::new(schema),
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r483416446
##
File path: rust/datafusion/src/logical_plan/mod.rs
##
@@ -268,18 +271,16 @@ pub enum Expr {
/// scalar function.
ScalarFunction {
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r475266986
##
File path: rust/datafusion/src/execution/physical_plan/planner.rs
##
@@ -306,32 +305,25 @@ impl DefaultPhysicalPlanner {
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r475266854
##
File path: rust/datafusion/src/execution/physical_plan/math_expressions.rs
##
@@ -103,56 +103,3 @@ pub fn scalar_functions() -> Vec {
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471688534
##
File path: rust/datafusion/tests/sql.rs
##
@@ -232,6 +326,55 @@ fn custom_sqrt(args: &[ArrayRef]) -> Result {
Ok(Arc::new(builder.finish()))
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471652148
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -515,27 +515,29 @@ impl SqlToRel {
}
_ => match
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471146570
##
File path: rust/datafusion/src/execution/physical_plan/math_expressions.rs
##
@@ -20,36 +20,62 @@
use crate::error::ExecutionError;
use
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r471134987
##
File path: rust/datafusion/src/execution/physical_plan/udf.rs
##
@@ -37,8 +37,11 @@ pub type ScalarUdf = Arc
Result + Send + Sync>;
pub struct
jorgecarleitao commented on a change in pull request #7967:
URL: https://github.com/apache/arrow/pull/7967#discussion_r470999040
##
File path: rust/datafusion/src/execution/physical_plan/math_expressions.rs
##
@@ -92,7 +122,7 @@ mod tests {
.build()?;
let
14 matches
Mail list logo
