[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-11 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-657110158 I adopted `SchemaRef` throughout the codebase also. I figure if we are going to use `SchemaRef` in some places we might as well adopt it universally.

[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-11 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-657109850 Ok, I think we are all in agreement. Thanks. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656856701 > I think the `schema` method is already returning a `Arc`, where is the `Rc` being used? IMHO if it is not too difficult to do we should consolidate on a single trait now

[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-09 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656306027 cc @maxburke @mcassels you might have opinions on this. This is an automated message from the Apache Git

[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-07 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-655100102 cc @houqp This is an automated message from the Apache Git Service. To respond to the message, please log on