paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656856701
> I think the `schema` method is already returning a `Arc<Schema>`, where is the `Rc` being used? IMHO if it is not too difficult to do we should consolidate on a single trait now instead of having to change it later again. It did occur to me that we could just have a single trait that uses `Arc` and not bother with the `Rc` version. I'm not sure what the performance of `Arc` is versus `Rc`. Obviously, there has to be some difference but is this important in the context of Arrow? I'm up for converting to one trait and using `Arc`. If users request it then we can add the `Rc` version later. What do others think? The `Rc` version is used in a few places but again I don't think it's that important to use `Rc<Schema>` over `Arc<Schema>`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
