rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r651772086
##
File path: docs/source/cpp/compute.rst
##
@@ -213,18 +213,23 @@ Aggregations
Notes:
-* \(1) Output is a ``{"min": input type, "max": input type}``
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r651771596
##
File path: cpp/src/arrow/compute/api_aggregate.h
##
@@ -201,30 +201,42 @@ Result MinMax(
/// \brief Test whether any element in a boolean array evaluates
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r651318115
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -166,32 +168,48 @@ struct BooleanAnyImpl : public ScalarAggregator {
Status
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r648471718
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -166,32 +168,48 @@ struct BooleanAnyImpl : public ScalarAggregator {
Status
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r648212025
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic.cc
##
@@ -166,32 +168,48 @@ struct BooleanAnyImpl : public ScalarAggregator {
Status
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647881835
##
File path: r/tests/testthat/test-compute-aggregate.R
##
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647629868
##
File path: r/tests/testthat/test-compute-aggregate.R
##
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and
rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647625730
##
File path: r/tests/testthat/test-compute-aggregate.R
##
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and
