rok commented on a change in pull request #10476:
URL: https://github.com/apache/arrow/pull/10476#discussion_r647625730
##########
File path: r/tests/testthat/test-compute-aggregate.R
##########
@@ -383,33 +383,30 @@ test_that("value_counts", {
})
test_that("any.Array and any.ChunkedArray", {
-
data <- c(1:10, NA, NA)
- expect_vector_equal(any(input > 5), data)
+ expect_vector_equal(any(input > 5, na.rm = TRUE), data)
Review comment:
It does indeed:
```R
Failure (test-compute-aggregate.R:388:3): any.Array and any.ChunkedArray
as.vector(x) not equal to `y`.
'is.NA' value mismatch: 0 in current 1 in target
Backtrace:
1. expect_vector_equal(any(input > 5), data) test-compute-aggregate.R:388:2
2. expect_as_vector(via_array, expected, ignore_attr, ...)
helper-expectation.R:174:4
3. testthat:::expect_fun(as.vector(x), y, ...) helper-expectation.R:24:2
Failure (test-compute-aggregate.R:388:3): any.Array and any.ChunkedArray
as.vector(x) not equal to `y`.
'is.NA' value mismatch: 0 in current 1 in target
Backtrace:
1. expect_vector_equal(any(input > 5), data) test-compute-aggregate.R:388:2
2. expect_as_vector(via_chunked, expected, ignore_attr, ...)
helper-expectation.R:187:4
3. testthat:::expect_fun(as.vector(x), y, ...) helper-expectation.R:24:2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
