[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2021-01-09 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-756833600 Now pulled in the commit from #8886 so that this uses `Converter::Extend()` instead of the R specific previous `AppendRange()`. I believe that for the chunker class

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2021-01-08 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-756833600 Now pulled in the commit from #8886 so that this uses `Converter::Extend()` instead of the R specific previous `AppendRange()`. I believe that for the chunker class

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2021-01-06 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-755350170 At the point now where I dropped the artificial `Rscalar` class and all goes through `AppendRange()` which is only slightly different from @kszucs take on #8886.

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2020-12-08 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-740504045 I believe `AppendMultiple()` is what I would be looking for. It would e.g. solve my dilemma about converting data frames to struct types ... I had missed the more

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2020-11-27 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-734843309 ping @kszucs @bkietz I don't necessarily need a full review at this point, as this is far from done and will need further changes, but perhaps you can have a look and let

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2020-11-27 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-734746906 This is still quite wip, as I navigate how the various `Converter` work together. It all feels a bit weird to operate in terms of single values, i.e. via the

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2020-11-13 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-726789546 ``` r library(arrow, warn.conflicts = FALSE) arrow:::vec_to_arrow(1:2, int32()) #> Array #> #> [ #> 1, #> 2 #> ]

[GitHub] [arrow] romainfrancois commented on pull request #8650: ARROW-10530: [R] Use Converter API to convert SEXP to Array/ChunkedArray

2020-11-13 Thread GitBox
romainfrancois commented on pull request #8650: URL: https://github.com/apache/arrow/pull/8650#issuecomment-726775206 Thanks @kszucs for the direct help. This is very far from done, but it's a start, and perhaps we can resume the conversation here. AFAIK, There is no R equivalent