[GitHub] [arrow] rymurr commented on pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

2020-07-03 Thread GitBox
rymurr commented on pull request #7275: URL: https://github.com/apache/arrow/pull/7275#issuecomment-653444220 > Thanks for the quick update @rymurr , it looks pretty good! Only a couple minor things. I see quite a few instances of `offsetBuffer.getLong/setLong(i * OFFSET_WIDTH)` that I bel

[GitHub] [arrow] rymurr commented on pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

2020-07-01 Thread GitBox
rymurr commented on pull request #7275: URL: https://github.com/apache/arrow/pull/7275#issuecomment-652323175 > Thanks for working on this @rymurr ! Apologies for taking so long to review.. It looks pretty good, but I saw what looked like inconsistencies in the `LargeListVector` APIs using

[GitHub] [arrow] rymurr commented on pull request #7275: ARROW-6110: [Java][Integration] Support LargeList Type and add integration test with C++

2020-06-02 Thread GitBox
rymurr commented on pull request #7275: URL: https://github.com/apache/arrow/pull/7275#issuecomment-637392636 > @rymurr looks like this needs a rebase Thanks for the reminder @emkornfield, done. This is an automated me