[GitHub] [arrow] wesm commented on a change in pull request #7635: ARROW-1587: [C++] implement fill null

wesm commented on a change in pull request #7635: URL: https://github.com/apache/arrow/pull/7635#discussion_r449802099 ## File path: cpp/src/arrow/compute/api_scalar.h ## @@ -259,6 +259,27 @@ Result IsValid(const Datum& values, ExecContext* ctx = NULLPTR); ARROW_EXPORT

[GitHub] [arrow] wesm commented on a change in pull request #7635: ARROW-1587: [C++] implement fill null

wesm commented on a change in pull request #7635: URL: https://github.com/apache/arrow/pull/7635#discussion_r449877611 ## File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc ## @@ -0,0 +1,223 @@ + +// Licensed to the Apache Software Foundation (ASF) under one +// or

[GitHub] [arrow] wesm commented on a change in pull request #7635: ARROW-1587: [C++] implement fill null

wesm commented on a change in pull request #7635: URL: https://github.com/apache/arrow/pull/7635#discussion_r449802049 ## File path: cpp/src/arrow/compute/api_scalar.cc ## @@ -126,5 +126,24 @@ Result Compare(const Datum& left, const Datum& right, CompareOptions opti