[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082867652 ## arrow-csv/src/writer.rs: ## @@ -672,4 +710,26 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.55500,23:46:03,foo let expected = nanosecond

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082816995 ## arrow-csv/src/writer.rs: ## @@ -88,6 +88,35 @@ where lexical_to_string(c.value(i)) } +fn invalid_cast_error(dt: String, col_index: usize, row_index: usize)

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-20 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082815909 ## arrow-csv/src/writer.rs: ## @@ -88,6 +88,35 @@ where lexical_to_string(c.value(i)) } +fn invalid_cast_error(dt: String, col_index: usize, row_index: usize)

[GitHub] [arrow-rs] comphead commented on a diff in pull request #3570: Remove unwrap on datetime cast for CSV writer

2023-01-19 Thread GitBox
comphead commented on code in PR #3570: URL: https://github.com/apache/arrow-rs/pull/3570#discussion_r1082064779 ## arrow-csv/src/writer.rs: ## @@ -672,4 +710,26 @@ sed do eiusmod tempor,-556132.25,1,,2019-04-18T02:45:55.55500,23:46:03,foo let expected = nanosecond