[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread via GitHub
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082903996 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(featur

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread via GitHub
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082903996 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(featur

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082867599 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(featur

[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3574: Add external variant to ParquetError (#3285)

2023-01-20 Thread GitBox
tustvold commented on code in PR #3574: URL: https://github.com/apache/arrow-rs/pull/3574#discussion_r1082574357 ## parquet/src/errors.rs: ## @@ -17,12 +17,13 @@ //! Common Parquet errors and macros. +use std::error::Error; use std::{cell, io, result, str}; #[cfg(featur