mbrobbel commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2072037773
> @mbrobbel If you have time, I think that you can work on the CI in
parallel (there shouldn't be any conflict)
#1749
--
This is an automated message from the Apache Git Ser
lidavidm commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2068331318
Augh, I forgot to edit out the pings from the commit message...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
lidavidm merged PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.a
lidavidm commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2065488929
I'll merge this in a day or two if there's no further comments. Thanks
@alexandreyc!
--
This is an automated message from the Apache Git Service.
To respond to the message, please l
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1571037221
##
rust2/Cargo.toml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
alexandreyc commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2063892369
Should be ready to merge now!
Next PR: full FFI bindings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570746494
##
rust2/drivers/dummy/src/lib.rs:
##
@@ -0,0 +1,890 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570637817
##
rust2/drivers/dummy/src/lib.rs:
##
@@ -0,0 +1,890 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements.
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570440217
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570348776
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570343548
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570211715
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570211715
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570211715
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1570101609
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,500 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569527028
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569418062
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569409474
##
rust2/core/Cargo.toml:
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the N
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569356502
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569199195
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569070430
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569030653
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569003762
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
lidavidm commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569013032
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
lidavidm commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569011077
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1569003762
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568866777
##
.github/workflows/rust.yml:
##
@@ -38,7 +38,7 @@ permissions:
defaults:
run:
-working-directory: rust
+working-directory: rust2
Review Comment:
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568861423
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568857747
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
lidavidm commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568835401
##
.github/workflows/rust.yml:
##
@@ -38,7 +38,7 @@ permissions:
defaults:
run:
-working-directory: rust
+working-directory: rust2
Review Comment:
paleolimbot commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568826885
##
.github/workflows/rust.yml:
##
@@ -38,7 +38,7 @@ permissions:
defaults:
run:
-working-directory: rust
+working-directory: rust2
Review Comment:
lidavidm commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568835003
##
.github/workflows/rust.yml:
##
@@ -38,7 +38,7 @@ permissions:
defaults:
run:
-working-directory: rust
+working-directory: rust2
Review Comment:
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568810336
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568810336
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568791830
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568799063
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568791830
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568783103
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568737932
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568710105
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568700678
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568706748
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,500 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568525770
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568529728
##
rust2/core/Cargo.toml:
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTI
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568501581
##
rust2/core/Cargo.toml:
##
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the N
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568491088
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the N
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568477669
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
lidavidm commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568455458
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,492 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See t
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568451821
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,492 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568400988
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,492 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See t
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568395445
##
rust2/core/src/options.rs:
##
@@ -0,0 +1,492 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. Se
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568362620
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568355944
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1568322398
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567958000
##
rust2/Cargo.toml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE fi
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567904488
##
rust2/Cargo.toml:
##
@@ -0,0 +1,31 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567845939
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567840868
##
rust2/core/src/ffi/constants.rs:
##
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567840868
##
rust2/core/src/ffi/constants.rs:
##
@@ -0,0 +1,101 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreement
mbrobbel commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567840458
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567822352
##
rust2/core/src/error.rs:
##
@@ -0,0 +1,166 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See
paleolimbot commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2059646029
> I'm not very familiar with Github Actions so I need a bit more time to
read doc before integrating the new folder to CI.
The final CI may be a bit different, but for the pu
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567611640
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567611640
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567611640
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
alexandreyc commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567610718
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See th
aljazerzen commented on code in PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#discussion_r1567526774
##
rust2/core/src/lib.rs:
##
@@ -0,0 +1,520 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the
alexandreyc commented on PR #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725#issuecomment-2059229798
Thanks for taking time to review!
I've added the licence header to all files. The CI is now green.
I'm not very familiar with Github Actions so I need a bit more time t
alexandreyc opened a new pull request, #1725:
URL: https://github.com/apache/arrow-adbc/pull/1725
Hey!
As discussed in #1723, here is the first PR of the new complete Rust
implementation.
It includes:
- Traits and structs definitions for the public abstract API
- An i
69 matches
Mail list logo