andygrove closed pull request #8233:
URL: https://github.com/apache/arrow/pull/8233
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on a change in pull request #8234:
URL: https://github.com/apache/arrow/pull/8234#discussion_r492378032
##
File path: LICENSE.txt
##
@@ -849,9 +849,9 @@ THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH
DAMAGE.
github-actions[bot] commented on pull request #8235:
URL: https://github.com/apache/arrow/pull/8235#issuecomment-696431010
https://issues.apache.org/jira/browse/ARROW-10059
This is an automated message from the Apache Git
josiahyan edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696381588
@jacques-n I haven't done very much investigation on other speedups - I just
happened to notice performance irregularities as compared to our other (legacy)
codepaths,
nealrichardson opened a new pull request #8235:
URL: https://github.com/apache/arrow/pull/8235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696456877
*Option 2 being the best case of the append-only builder style interface;
something like IntWriter, where direct access to the buffer was not
permissible, and so its safe to do
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696466268
> I'm clearly missing something. Why doesn't item 2 when directly in the
vector solve the same purpose as 1/3?
Sorry, I didn't realize that the ArrowBuf was that
jorgecarleitao commented on a change in pull request #8236:
URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876
##
File path: rust/datafusion/src/physical_plan/merge.rs
##
@@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec {
let
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
jorgecarleitao commented on a change in pull request #8236:
URL: https://github.com/apache/arrow/pull/8236#discussion_r492447876
##
File path: rust/datafusion/src/physical_plan/merge.rs
##
@@ -111,9 +111,9 @@ impl ExecutionPlan for MergeExec {
let
xhochy commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098976
> Uh... was Boost upgraded in the meantime? There are compile errors on
AppVeyor:
>
jorgecarleitao commented on pull request #8172:
URL: https://github.com/apache/arrow/pull/8172#issuecomment-695805702
@andygrove , that is great news! Really good to know that this stands a
stronger benchmark. Thanks a lot for taking the time to run it.
I rebased against master and
emkornfield commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696286568
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wesm closed issue #8217:
URL: https://github.com/apache/arrow/issues/8217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
bkietz commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696303007
Rewinding doesn't strike me as something which needs to be part of the C
stream protocol. APIs can still provide rewind and other semantics while using
a simple-as-possible stream
github-actions[bot] commented on pull request #8228:
URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829873
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-695873809
@josiahyan Thank you for the additional details.
I think one of your concern is that, the underlying buffers can be changed
unintentionally, which lefts the vector in an
emkornfield commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492461706
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
pitrou edited a comment on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696276591
Would `rewind` go back to the start of stream always?
This is an automated message from the Apache Git
andygrove closed pull request #8102:
URL: https://github.com/apache/arrow/pull/8102
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696450195
Here are the results of my testing. I'm not really that familiar with Arrow,
and some of the code is sloppy, so please check that what I'm doing matches up
with your
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696455205
Sorry, did you mean the specialized append interface (as Option 2), that
assumes buffer ownership? I mislabeled the options in the paragraph you quoted
(now corrected).
jacques-n commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696459730
> I think there are two opportunities here - simply optimizing setSafe,
which can be done by either specializing for the power-of-two size where
possible, or by caching sizes
jacques-n edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696459730
> I think there are two opportunities here - simply optimizing setSafe,
which can be done by either specializing for the power-of-two size where
possible, or by caching
wesm commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696357318
Another thing that occurred to me is whether we want to enable batch-level
metadata (which would be implementation-defined). This is supported in Flight
for example
lidavidm commented on pull request #8196:
URL: https://github.com/apache/arrow/pull/8196#issuecomment-696331234
CC @pitrou, this will finally let AppVeyor pass again :)
This is an automated message from the Apache Git
zeroshade commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-695894267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kszucs commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r491890396
##
File path: cpp/src/arrow/util/converter.h
##
@@ -0,0 +1,348 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
kszucs commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098116
Seems so, but that's a different issue.
This is an automated message from the Apache Git Service.
To respond to
pitrou closed pull request #8218:
URL: https://github.com/apache/arrow/pull/8218
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jacques-n commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696453930
> @lidavidm @liyafan82 @jacques-n
> Interpreting the results:
> This patch could be improved (performance wise) by more aggressive caching
(option 3), at the potential
lidavidm commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696458726
I think there are two opportunities here - simply optimizing setSafe, which
can be done by either specializing for the power-of-two size where possible, or
by caching sizes
jacques-n commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696458884
Why couldn't option 2 be done inside the vector (as opposed to in a wrapper
class). ArrowBuf doesn't support reallocation (addr is final). It does allow
downsizing but I'm not
lidavidm commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696463757
Sorry - I got too hung up on the idea of a builder, and was thinking
ArrowBuf could be reallocated-in-place, which it can't - option 2 and 3 are the
same, they just cache values
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
jorgecarleitao commented on issue #8217:
URL: https://github.com/apache/arrow/issues/8217#issuecomment-695783084
Hi @Zarca,
1. In any particular language?
2. Arrow is a columnar format. Thus, it is already formatted like you wrote.
If you mean is the transpose (i.e. `array[i]`
pitrou commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696183147
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
jorgecarleitao commented on pull request #8226:
URL: https://github.com/apache/arrow/pull/8226#issuecomment-695813581
fyi @andygrove : I pushed this to #8215, but I did not rebase #8172 against
#8215, and thus the error remained. I found this as I was rebasing PRs against
master.
pitrou commented on pull request #8177:
URL: https://github.com/apache/arrow/pull/8177#issuecomment-696148961
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8230:
URL: https://github.com/apache/arrow/pull/8230#issuecomment-695901406
https://issues.apache.org/jira/browse/ARROW-10050
This is an automated message from the Apache Git
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
jorisvandenbossche commented on a change in pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#discussion_r492271433
##
File path: python/pyarrow/_dataset.pyx
##
@@ -1013,27 +1013,38 @@ cdef class ParquetReadOptions(_Weakrefable):
dictionary_columns : list
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696096983
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#issuecomment-695918114
https://issues.apache.org/jira/browse/ARROW-10051
This is an automated message from the Apache Git
cyb70289 commented on pull request #8232:
URL: https://github.com/apache/arrow/pull/8232#issuecomment-695913785
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #8234:
URL: https://github.com/apache/arrow/pull/8234#issuecomment-696300434
https://issues.apache.org/jira/browse/ARROW-10035
This is an automated message from the Apache Git
xhochy removed a comment on pull request #8228:
URL: https://github.com/apache/arrow/pull/8228#issuecomment-695904892
@github-actions crossbow submit
conda-linux-gcc-py36-cpu
--
This is an automated
jacques-n edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696459730
> I think there are two opportunities here - simply optimizing setSafe,
which can be done by either specializing for the power-of-two size where
possible, or by caching
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
t829702 commented on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
josiahyan commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696065926
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nealrichardson closed pull request #8227:
URL: https://github.com/apache/arrow/pull/8227
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pitrou closed pull request #8205:
URL: https://github.com/apache/arrow/pull/8205
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jhorstmann commented on pull request #8223:
URL: https://github.com/apache/arrow/pull/8223#issuecomment-695831200
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
wesm commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492407465
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
}
jorisvandenbossche commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r488714572
##
File path: python/pyarrow/tests/test_types.py
##
@@ -280,6 +284,13 @@ def test_tzinfo_to_string_errors():
pitrou closed pull request #8178:
URL: https://github.com/apache/arrow/pull/8178
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vertexclique commented on pull request #8233:
URL: https://github.com/apache/arrow/pull/8233#issuecomment-696146358
Hi!
Would be nice if I can put this into upstream, there is a dependent
implementation I am currently working on. Is it possible to review?
@paddyhoran @andygrove
pitrou commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-696176912
Hmm, reading the mailing-list discussion again, I don't think we had agreed
on a design. The first question for me is what the end-user API should be.
* should the user calling
kszucs commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491975704
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+
hannesmuehleisen commented on pull request #8052:
URL: https://github.com/apache/arrow/pull/8052#issuecomment-696276127
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nealrichardson commented on a change in pull request #8227:
URL: https://github.com/apache/arrow/pull/8227#discussion_r492109660
##
File path: r/R/parquet.R
##
@@ -373,6 +380,9 @@ ParquetFileWriter$create <- function(schema,
sink,
trxcllnt commented on a change in pull request #8216:
URL: https://github.com/apache/arrow/pull/8216#discussion_r492260498
##
File path: .env
##
@@ -30,7 +30,7 @@ LLVM=10
CLANG_TOOLS=8
RUST=nightly-2020-04-22
GO=1.12
-NODE=11
+NODE=14
Review comment:
No we still
github-actions[bot] commented on pull request #8226:
URL: https://github.com/apache/arrow/pull/8226#issuecomment-695813753
https://issues.apache.org/jira/browse/ARROW-10048
This is an automated message from the Apache Git
xhochy commented on pull request #8228:
URL: https://github.com/apache/arrow/pull/8228#issuecomment-695829727
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
liyafan82 commented on pull request #8194:
URL: https://github.com/apache/arrow/pull/8194#issuecomment-695884515
Merging. Thanks for the PR @pwoody
This is an automated message from the Apache Git Service.
To respond to the
andygrove commented on a change in pull request #8172:
URL: https://github.com/apache/arrow/pull/8172#discussion_r491702697
##
File path: rust/datafusion/src/sql/planner.rs
##
@@ -343,7 +343,7 @@ impl<'a, S: SchemaProvider> SqlToRel<'a, S> {
match *limit {
jorgecarleitao closed pull request #8215:
URL: https://github.com/apache/arrow/pull/8215
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8236:
URL: https://github.com/apache/arrow/pull/8236#issuecomment-696484939
https://issues.apache.org/jira/browse/ARROW-10060
This is an automated message from the Apache Git
andygrove closed pull request #8118:
URL: https://github.com/apache/arrow/pull/8118
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8233:
URL: https://github.com/apache/arrow/pull/8233
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #8205:
URL: https://github.com/apache/arrow/pull/8205#issuecomment-696085494
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
emkornfield commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492465434
##
File path: cpp/src/parquet/arrow/path_internal.cc
##
@@ -871,6 +877,8 @@ class MultipathLevelBuilderImpl : public
MultipathLevelBuilder {
emkornfield commented on pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#issuecomment-696503073
@xhochy did you want to review?
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #8233:
URL: https://github.com/apache/arrow/pull/8233#issuecomment-696149597
https://issues.apache.org/jira/browse/ARROW-10055
This is an automated message from the Apache Git
josiahyan edited a comment on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-696381588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
andygrove commented on a change in pull request #8118:
URL: https://github.com/apache/arrow/pull/8118#discussion_r492065611
##
File path: rust/arrow/src/array/array.rs
##
@@ -834,7 +840,7 @@ impl From>> for BooleanArray {
fn from(data: Vec>) -> Self {
let
andygrove closed pull request #8226:
URL: https://github.com/apache/arrow/pull/8226
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jhorstmann commented on a change in pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#discussion_r491869035
##
File path: rust/datafusion/src/physical_plan/distinct_expressions.rs
##
@@ -0,0 +1,303 @@
+// Licensed to the Apache Software Foundation (ASF) under
wesm commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492407465
##
File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc
##
@@ -2360,6 +2361,49 @@ TEST(ArrowReadWrite, SingleColumnNullableStruct) {
3);
}
jorgecarleitao opened a new pull request #8236:
URL: https://github.com/apache/arrow/pull/8236
Just found this sneaky error while working on UDAFs...
This is an automated message from the Apache Git Service.
To respond to
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
t829702 edited a comment on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
xhochy commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r492031242
##
File path: ci/conda_env_cpp.yml
##
@@ -17,7 +17,7 @@
aws-sdk-cpp
benchmark=1.4.1
-boost-cpp>=1.68.0
Review comment:
The lower-limit is no
github-actions[bot] commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-695862390
https://issues.apache.org/jira/browse/ARROW-9579
This is an automated message from the Apache Git
emkornfield commented on a change in pull request #8177:
URL: https://github.com/apache/arrow/pull/8177#discussion_r492160325
##
File path: cpp/src/parquet/CMakeLists.txt
##
@@ -202,6 +203,19 @@ set(PARQUET_SRCS
stream_writer.cc
types.cc)
+if(CXX_SUPPORTS_AVX2)
+
pitrou commented on a change in pull request #8177:
URL: https://github.com/apache/arrow/pull/8177#discussion_r492084011
##
File path: cpp/src/parquet/CMakeLists.txt
##
@@ -202,6 +203,19 @@ set(PARQUET_SRCS
stream_writer.cc
types.cc)
+if(CXX_SUPPORTS_AVX2)
+ #
andygrove closed pull request #8221:
URL: https://github.com/apache/arrow/pull/8221
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
t829702 commented on pull request #2035:
URL: https://github.com/apache/arrow/pull/2035#issuecomment-696480501
> Providing a separate utility in Arrow to parse dates
I didn't mean to duplicate JS parsing code, but a way to provide a special
parser function to the constructor,
wesm commented on pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#issuecomment-696248994
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andygrove closed pull request #8172:
URL: https://github.com/apache/arrow/pull/8172
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on a change in pull request #8224:
URL: https://github.com/apache/arrow/pull/8224#discussion_r492069938
##
File path: rust/arrow/README.md
##
@@ -21,10 +21,62 @@
[![Coverage
liyafan82 closed pull request #8194:
URL: https://github.com/apache/arrow/pull/8194
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
vertexclique edited a comment on pull request #8233:
URL: https://github.com/apache/arrow/pull/8233#issuecomment-696146358
Hi!
Would be nice if I can merge this into upstream, there is a dependent
implementation I am currently working on. Is it possible to review it?
@paddyhoran
emkornfield commented on a change in pull request #8219:
URL: https://github.com/apache/arrow/pull/8219#discussion_r492259759
##
File path: cpp/src/parquet/arrow/path_internal.cc
##
@@ -838,10 +841,13 @@ class PathBuilder {
#undef NOT_IMPLEMENTED_VISIT
std::vector& paths()
emkornfield commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-696146448
Thank you for the PR this will likely need a great deal of review from both
code and design perspective. Before it is reviewed it should have thorough
unit tests. And since
github-actions[bot] commented on pull request #8227:
URL: https://github.com/apache/arrow/pull/8227#issuecomment-695821544
https://issues.apache.org/jira/browse/ARROW-9946
This is an automated message from the Apache Git
winningsix commented on pull request #8229:
URL: https://github.com/apache/arrow/pull/8229#issuecomment-696193668
@pitrou @emkornfield FYI. This is Java side PR.
https://github.com/apache/parquet-mr/pull/803/files
This
andygrove commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-695804292
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
1 - 100 of 226 matches
Mail list logo
