liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508273170
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java
##
@@ -119,34 +121,47 @@ public static boolean
github-actions[bot] commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-712699029
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508272146
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java
##
@@ -119,34 +121,47 @@ public static boolean
liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508283490
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508282258
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
liyafan82 commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508289499
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
xhochy commented on pull request #8491:
URL: https://github.com/apache/arrow/pull/8491#issuecomment-712711653
Crossbow also support using drone.io for running `aarch64` builds. That
could be an alternative to Travis.
This
liyafan82 commented on pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#issuecomment-712676570
> @liyafan82 I renamed to Decimal256, let me know if you have other comments
on the Java side. @pitrou I'm still working through your comments.
Made a first pass, and it
kszucs commented on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712797185
I see your points.
Keeping the main branch flat is important and the commits after the release
tag should have the right version numbers since git is not available in all
fxcoudert opened a new pull request #8492:
URL: https://github.com/apache/arrow/pull/8492
Homebrew now ships LLVM 11. This prevents us rebuilding arrow from source:
```
CMake Warning at cmake_modules/FindLLVMAlt.cmake:27 (find_package):
Could not find a configuration file for
liyafan82 commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508374040
##
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##
@@ -36,6 +35,7 @@
import org.apache.arrow.vector.types.pojo.ArrowType;
liyafan82 commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508448784
##
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##
@@ -36,6 +35,7 @@
import org.apache.arrow.vector.types.pojo.ArrowType;
andygrove commented on a change in pull request #8430:
URL: https://github.com/apache/arrow/pull/8430#discussion_r508527928
##
File path: rust/arrow/src/json/reader.rs
##
@@ -612,6 +644,240 @@ impl Reader {
arrays.and_then(|arr| RecordBatch::try_new(projected_schema,
pitrou edited a comment on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712844395
(TODO: improve parser benchmarks a bit) -> done
This is an automated message from the Apache Git Service.
andygrove commented on pull request #8430:
URL: https://github.com/apache/arrow/pull/8430#issuecomment-712875985
> @jorgecarleitao @nevi-me Can I push this out of the door peeps? I am kind
of blocked by this atm.
@vertexclique When I started contributing here I had similar feelings
HedgehogCode commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508412300
##
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##
@@ -36,6 +35,7 @@
import org.apache.arrow.vector.types.pojo.ArrowType;
pitrou opened a new pull request #8493:
URL: https://github.com/apache/arrow/pull/8493
Hide more implementation details from `parser.h`.
Interestingly, this increases performance on the CSV parser micro-benchmarks
(at least here with clang 10.0 on Ubuntu 20.04).
* before:
```
github-actions[bot] commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712843737
https://issues.apache.org/jira/browse/ARROW-10318
This is an automated message from the Apache Git
pitrou opened a new pull request #8494:
URL: https://github.com/apache/arrow/pull/8494
This library is 2x to 3x faster for parsing strings to binary floating-point
numbers.
This is an automated message from the Apache Git
pitrou commented on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712850295
After:
* Parsing raw values:
```
FloatParsing 11936 ns11934 ns 184367
items_per_second=83.7942M/s
FloatParsing 10989 ns10988 ns
pitrou commented on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712849550
Before:
* Parsing raw values:
```
FloatParsing 39763 ns39758 ns52350
items_per_second=25.152M/s
FloatParsing 29812 ns29808 ns
pitrou commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712844395
TODO: improve parser benchmarks a bit
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712858115
https://issues.apache.org/jira/browse/ARROW-10328
This is an automated message from the Apache Git
wesm commented on pull request #8481:
URL: https://github.com/apache/arrow/pull/8481#issuecomment-712895885
I agree with raising the matter on the mailing list -- this is a project
governance issue and so needs to be discussed there. We did not arise at the
current practices idly and
wesm commented on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712899016
Do we need to unvendor double-conversion?
This is an automated message from the Apache Git Service.
To respond to
pitrou commented on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712899431
No, we still use it for the other way round (float to string).
This is an automated message from the Apache Git
HedgehogCode commented on a change in pull request #8483:
URL: https://github.com/apache/arrow/pull/8483#discussion_r508571098
##
File path: java/vector/src/main/codegen/templates/DenseUnionVector.java
##
@@ -36,6 +35,7 @@
import org.apache.arrow.vector.types.pojo.ArrowType;
rdettai commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-712910596
> @rdettai are there still more changes that you intend on making, and
@alamb are all your queries and concerns addressed? Thanks for the detailed
review.
@nevi-me Depends on
rdettai edited a comment on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-712910596
> @rdettai are there still more changes that you intend on making, and
@alamb are all your queries and concerns addressed? Thanks for the detailed
review.
@nevi-me
jorgecarleitao closed pull request #8487:
URL: https://github.com/apache/arrow/pull/8487
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jorgecarleitao commented on a change in pull request #8473:
URL: https://github.com/apache/arrow/pull/8473#discussion_r508230895
##
File path: rust/datafusion/src/physical_plan/hash_aggregate.rs
##
@@ -331,72 +337,74 @@ impl GroupedHashAggregateIterator {
}
type
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508730344
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508730745
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
jorgecarleitao closed pull request #8473:
URL: https://github.com/apache/arrow/pull/8473
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508781568
##
File path: cpp/src/arrow/ipc/metadata_internal.cc
##
@@ -236,7 +236,8 @@ static inline TimeUnit::type
FromFlatbufferUnit(flatbuf::TimeUnit unit) {
xhochy commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713084588
Conda builds are fine, we sadly seem to be limited on drone.io and thus we
should ignore the `-aarch64` builds for now.
vertexclique commented on pull request #8430:
URL: https://github.com/apache/arrow/pull/8430#issuecomment-712937618
@andygrove
> @vertexclique When I started contributing here I had similar feelings but
there is no reason you should be blocked. You can maintain a branch in your
bkietz commented on pull request #8493:
URL: https://github.com/apache/arrow/pull/8493#issuecomment-712971264
CI failures are unrelated, merging
This is an automated message from the Apache Git Service.
To respond to the
bkietz closed pull request #8493:
URL: https://github.com/apache/arrow/pull/8493
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713087418
> Py3.7 looks like it's something wrong when testing the wheel (I'll see if
I can reproduce locally). I and I'm not sure what do do about llvm 10/11
bkietz commented on pull request #8472:
URL: https://github.com/apache/arrow/pull/8472#issuecomment-712950634
Updated description with build times and code sizes for a release build
This is an automated message from the
nealrichardson opened a new pull request #8495:
URL: https://github.com/apache/arrow/pull/8495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508781965
##
File path: cpp/src/arrow/python/decimal.cc
##
@@ -145,8 +146,9 @@ Status DecimalFromPythonDecimal(PyObject* python_decimal,
const DecimalType& arr
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508697896
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java
##
@@ -119,34 +121,47 @@ public static boolean
terencehonles edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713086735
Py3.7 looks like it's something wrong when testing the wheel (I'll see if I
can reproduce locally). I and I'm not sure what do do about llvm 10/11
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713086735
Py3.7 looks like it's something wrong when testing the wheel (I'll see if I
can reproduce locally). I and I'm not sure what do do about llvm 10
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508791339
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -254,67 +254,125 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508791783
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508693175
##
File path: cpp/src/arrow/util/decimal_benchmark.cc
##
@@ -191,6 +206,7 @@ static void BinaryBitOp(benchmark::State& state) { //
NOLINT non-const
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713004678
Revision: 77e3df3a4ba4b6c12c0f21ce3cfb7a4be28a7fcd
Submitted crossbow builds: [ursa-labs/crossbow @
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508693097
##
File path: cpp/src/parquet/arrow/reader_internal.cc
##
@@ -645,7 +645,9 @@ static Status DecimalIntegerTransfer(RecordReader* reader,
MemoryPool*
github-actions[bot] commented on pull request #8495:
URL: https://github.com/apache/arrow/pull/8495#issuecomment-713065960
https://issues.apache.org/jira/browse/ARROW-10358
This is an automated message from the Apache Git
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508698381
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/util/DecimalUtility.java
##
@@ -119,34 +121,47 @@ public static boolean
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508732622
##
File path:
java/vector/src/test/java/org/apache/arrow/vector/TestDecimal256Vector.java
##
@@ -0,0 +1,364 @@
+/*
+ * Licensed to the Apache Software
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508795520
##
File path: cpp/src/arrow/array/builder_decimal.h
##
@@ -58,6 +58,35 @@ class ARROW_EXPORT Decimal128Builder : public
FixedSizeBinaryBuilder {
terencehonles commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713099341
It looks like there are more changes needed since the builder is still
broken https://github.com/apache/arrow/pull/8492/checks?check_run_id=1279869182
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712992230
I'm definitely moving into very uncharted territory for me since I'm not
familiar with conda, but I believe it looks like numpy for Py39 was pinned to
1.16 here
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-712992643
@github-actions crossbow submit -g conda -g wheel
This is an automated message from the Apache Git Service.
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508777323
##
File path: cpp/src/arrow/array/array_dict_test.cc
##
@@ -857,40 +857,48 @@ TEST(TestDecimalDictionaryBuilder, Basic) {
sunchao commented on pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#issuecomment-712998318
Thanks @rdettai . I'll take a look at this PR today.
This is an automated message from the Apache Git Service.
To
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508779161
##
File path: cpp/src/arrow/array/array_test.cc
##
@@ -2426,7 +2433,43 @@ TEST_P(DecimalTest, WithNulls) {
this->TestCreate(precision, draw,
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508791783
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
pitrou edited a comment on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712849550
Before:
* Parsing raw values:
```
FloatParsing 39763 ns39758 ns52350
items_per_second=25.152M/s
FloatParsing 29812 ns
pitrou edited a comment on pull request #8494:
URL: https://github.com/apache/arrow/pull/8494#issuecomment-712850295
After:
* Parsing raw values:
```
FloatParsing 11936 ns11934 ns 184367
items_per_second=83.7942M/s
FloatParsing 10989 ns
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713261883
@github-actions crossbow submit -g conda -g wheel
This is an automated message from the Apache Git Service.
terencehonles edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713244425
I believe I identified the test on Python3.7 that is failing (same as
#3403), and going to see if that fixes things
kou commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713315228
@fxcoudert Thanks for sending feedback from Homebrew!
I think that we need more changes to support LLVM 11 like we did by
6a1cdbc66c5ddfaeb426ac4deea9da0ea284849f for LLVM 10.
sunchao commented on a change in pull request #8300:
URL: https://github.com/apache/arrow/pull/8300#discussion_r508895342
##
File path: rust/parquet/src/file/footer.rs
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713199449
> > Py3.7 looks like it's something wrong when testing the wheel (I'll see
if I can reproduce locally). I and I'm not sure what do do about llvm 10/11
jorgecarleitao closed pull request #8481:
URL: https://github.com/apache/arrow/pull/8481
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713262634
Revision: 1ed61c734d8aa9034dec75d290426f12b734bd3a
Submitted crossbow builds: [ursa-labs/crossbow @
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508887213
##
File path: cpp/src/arrow/c/bridge_test.cc
##
@@ -740,6 +741,7 @@ TEST_F(TestArrayExport, Primitive) {
TestPrimitive(large_utf8(), R"(["foo",
terencehonles commented on pull request #8492:
URL: https://github.com/apache/arrow/pull/8492#issuecomment-713201184
Following up after the discussion in
https://github.com/Homebrew/homebrew-core/pull/63177#issuecomment-713157947 it
looks like supporting LLVM 11 would be a good idea in
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713206837
@github-actions crossbow submit -g conda -g wheel
This is an automated message from the Apache Git Service.
emkornfield commented on a change in pull request #8475:
URL: https://github.com/apache/arrow/pull/8475#discussion_r508866742
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -775,4 +833,119 @@ int32_t BasicDecimal128::CountLeadingBinaryZeros() const {
}
}
+#if
nealrichardson closed pull request #8495:
URL: https://github.com/apache/arrow/pull/8495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713207879
Revision: 7c61d98dfc82c8cc557021c58c5eb5b70f69dc65
Submitted crossbow builds: [ursa-labs/crossbow @
terencehonles commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713244425
I believe I identified the test on Python3.7 that is failing, and going to
see if that fixes things
@github-actions crossbow submit -g conda -g wheel
terencehonles edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-713244425
I believe I identified the test on Python3.7 that is failing (same as
#3403), and going to see if that fixes things
@github-actions crossbow submit -g conda -g
nealrichardson commented on a change in pull request #7901:
URL: https://github.com/apache/arrow/pull/7901#discussion_r508855487
##
File path: cpp/src/arrow/json/converter.cc
##
@@ -123,13 +123,11 @@ class NumericConverter : public PrimitiveConverter {
80 matches
Mail list logo
