emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r472734667
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
kou closed pull request #7986:
URL: https://github.com/apache/arrow/pull/7986
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7986:
URL: https://github.com/apache/arrow/pull/7986#issuecomment-675866692
Thanks.
We can work on the issue as a separated task. (We will disable the test with
valgrind or disable AVX512 for valgrind build.)
I'll merge this.
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r472717430
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r472724359
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
emkornfield commented on a change in pull request #7885:
URL: https://github.com/apache/arrow/pull/7885#discussion_r472717430
##
File path: cpp/src/gandiva/precompiled/extended_math_ops.cc
##
@@ -111,6 +112,76 @@ LOG_WITH_BASE(float64, float64, float64)
POWER(float64,
github-actions[bot] commented on pull request #8001:
URL: https://github.com/apache/arrow/pull/8001#issuecomment-675853337
https://issues.apache.org/jira/browse/ARROW-9795
This is an automated message from the Apache Git
sagnikc-dremio opened a new pull request #8001:
URL: https://github.com/apache/arrow/pull/8001
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
emkornfield commented on pull request #7979:
URL: https://github.com/apache/arrow/pull/7979#issuecomment-675842493
actually, change might be invasive enough that this probably won't mitigate
risk, we can hold off until I get a little further.
jorgecarleitao commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472638005
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
jorgecarleitao commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472638005
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
ryannicholson commented on a change in pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#discussion_r472617468
##
File path:
java/flight/flight-core/src/main/java/org/apache/arrow/flight/auth/ClientBearerTokenMiddleware.java
##
@@ -0,0 +1,116 @@
+/*
+ *
andygrove commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-675827332
> Shouldn't we also align `LogicalPlan::Selection`?
Thanks. I missed that.
This is an automated message
jorgecarleitao commented on a change in pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#discussion_r472628286
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -966,11 +966,32 @@ impl fmt::Display for BinaryExpr {
impl
github-actions[bot] commented on pull request #8000:
URL: https://github.com/apache/arrow/pull/8000#issuecomment-675823978
https://issues.apache.org/jira/browse/ARROW-9793
This is an automated message from the Apache Git
jorgecarleitao commented on a change in pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#discussion_r472623554
##
File path: rust/datafusion/src/execution/physical_plan/filter.rs
##
@@ -80,31 +88,38 @@ impl ExecutionPlan for SelectionExec {
/// Represents
jorgecarleitao commented on a change in pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#discussion_r472623200
##
File path: rust/datafusion/src/execution/physical_plan/filter.rs
##
@@ -15,41 +15,49 @@
// specific language governing permissions and
jorgecarleitao commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-675822143
Shouldn't we also align `LogicalPlan::Selection`?
This is an automated message from the Apache Git
emkornfield commented on a change in pull request #7883:
URL: https://github.com/apache/arrow/pull/7883#discussion_r472621421
##
File path: cpp/src/gandiva/precompiled/string_ops.cc
##
@@ -567,6 +567,54 @@ const char* castVARCHAR_utf8_int64(gdv_int64 context,
const char*
jorgecarleitao commented on a change in pull request #8000:
URL: https://github.com/apache/arrow/pull/8000#discussion_r472617010
##
File path: rust/datafusion/src/optimizer/filter_push_down.rs
##
@@ -370,10 +368,9 @@ mod tests {
let plan =
jorgecarleitao opened a new pull request #8000:
URL: https://github.com/apache/arrow/pull/8000
FYI @andygrove
We did not rebased against master and run the tests, which caused some API
incompatibilities.
This is an
emkornfield commented on pull request #7979:
URL: https://github.com/apache/arrow/pull/7979#issuecomment-675817406
@pitrou that is the plan, but since there will be a decent amount of new
code, I think it is worth-while to provide the option. Once the new engine is
implemented that will
jianxind commented on pull request #7986:
URL: https://github.com/apache/arrow/pull/7986#issuecomment-675806083
The failed compute case is running with SimdLevel::AVX512(4), probably
Valgrind doesn't support AVX512?
```
==5971== Your program just tried to execute an instruction
andygrove closed pull request #7880:
URL: https://github.com/apache/arrow/pull/7880
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472583526
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
github-actions[bot] commented on pull request #7999:
URL: https://github.com/apache/arrow/pull/7999#issuecomment-675797627
https://issues.apache.org/jira/browse/ARROW-9792
This is an automated message from the Apache Git
andygrove opened a new pull request #7999:
URL: https://github.com/apache/arrow/pull/7999
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-675789705
Revision: ad77b8fdacb942cee7556e20b09fc8dcf82c5e1a
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-675789488
https://issues.apache.org/jira/browse/ARROW-9788
This is an automated message from the Apache Git
kou commented on a change in pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#discussion_r472571654
##
File path: dev/tasks/python-wheels/travis.osx.yml
##
@@ -21,6 +21,7 @@ language: generic
addons:
homebrew:
packages:
+ - aws-sdk-cpp
Review
kou commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-675789132
@github-actions crossbow submit wheel-osx-*
This is an automated message from the Apache Git Service.
To respond to
kou closed pull request #7995:
URL: https://github.com/apache/arrow/pull/7995
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou closed pull request #7982:
URL: https://github.com/apache/arrow/pull/7982
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7982:
URL: https://github.com/apache/arrow/pull/7982#issuecomment-675783743
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-675782864
Spark provides some synonyms, such as `where` as a synonym for `filter`,
and `orderBy` as a synonym for `sort`. I'm not sure if we want to do the same
thing or not?
andygrove commented on pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#issuecomment-675782137
@jorgecarleitao @alamb
This is an automated message from the Apache Git Service.
To respond to the message,
andygrove commented on a change in pull request #7998:
URL: https://github.com/apache/arrow/pull/7998#discussion_r472562916
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -966,11 +966,32 @@ impl fmt::Display for BinaryExpr {
impl PhysicalExpr
andygrove opened a new pull request #7998:
URL: https://github.com/apache/arrow/pull/7998
The use of the term "selection" rather than "filter" was the main
inconsistency that I am seeing in our APIs and was also different to the
terminology used in Spark and Pandas.
I had used the
github-actions[bot] commented on pull request #7997:
URL: https://github.com/apache/arrow/pull/7997#issuecomment-675756491
https://issues.apache.org/jira/browse/ARROW-9266
This is an automated message from the Apache Git
corleyma opened a new pull request #7997:
URL: https://github.com/apache/arrow/pull/7997
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
corleyma commented on pull request #7996:
URL: https://github.com/apache/arrow/pull/7996#issuecomment-675754738
accidentally had the wrong ticket number, which confused your jirabot.
trying again.
This is an automated
corleyma closed pull request #7996:
URL: https://github.com/apache/arrow/pull/7996
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7996:
URL: https://github.com/apache/arrow/pull/7996#issuecomment-675747987
https://issues.apache.org/jira/browse/ARROW-9517
This is an automated message from the Apache Git
corleyma opened a new pull request #7996:
URL: https://github.com/apache/arrow/pull/7996
This PR updates the `osx-build.sh` script to enable S3 when building the C++
dependencies and the python wheels, and updates the corresponding travis job
definition to include the requisite
nealrichardson commented on pull request #7875:
URL: https://github.com/apache/arrow/pull/7875#issuecomment-675727617
@lidavidm do you have any opinions about this?
This is an automated message from the Apache Git Service.
github-actions[bot] commented on pull request #7995:
URL: https://github.com/apache/arrow/pull/7995#issuecomment-675726294
https://issues.apache.org/jira/browse/ARROW-9789
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#discussion_r472493966
##
File path: ci/scripts/r_windows_build.sh
##
@@ -34,6 +34,12 @@ if [ "$RTOOLS_VERSION" = "35" ]; then
# lib-4.9.3 is for libraries compiled
nealrichardson edited a comment on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675712973
Googling the error pointed me back to our own JIRA. Looks like #456 fixed
this issue previously, but #2779 undid the fix. Unclear why we're seeing this
race
nealrichardson opened a new pull request #7995:
URL: https://github.com/apache/arrow/pull/7995
On ARROW-6437 (#7928) we saw occasional "File exists" errors on
`jemalloc_ep` on macOS. Googling the error message led back to ARROW-739
(#456), which fixed this before by forcing install with
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675712973
Googling the error pointed me back to our own JIRA. Looks like #456 fixed
this issue previously, but #2779 undid the fix. Unclear why we're seeing this
race condition only
alamb commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472482939
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
andygrove commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472425993
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
andygrove commented on a change in pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#discussion_r472425993
##
File path: rust/datafusion/src/dataframe.rs
##
@@ -174,4 +174,18 @@ pub trait DataFrame {
/// Return the logical plan represented by this
wesm commented on pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#issuecomment-675665511
This PR includes protocol changes. These will have to be discussed on the
mailing list to be accepted
This is an
github-actions[bot] commented on pull request #7994:
URL: https://github.com/apache/arrow/pull/7994#issuecomment-675665124
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
github-actions[bot] commented on pull request #7993:
URL: https://github.com/apache/arrow/pull/7993#issuecomment-675665151
https://issues.apache.org/jira/browse/ARROW-9760
This is an automated message from the Apache Git
jduo opened a new pull request #7994:
URL: https://github.com/apache/arrow/pull/7994
- Remove authentication payloads from the handshake protobuf messages
- Add server middleware which utilizes ServerAuthHandler instead of an
interceptor
- Change FlightClient builder to taken
jorgecarleitao opened a new pull request #7993:
URL: https://github.com/apache/arrow/pull/7993
FYI @andygrove and @alamb
I admit I find this API a bit counter-intuitive: coming from spark, I would
be expect a string when I call `df.explain()?`. However, I am following the
jorgecarleitao commented on a change in pull request #7984:
URL: https://github.com/apache/arrow/pull/7984#discussion_r472386086
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -337,40 +336,86 @@ impl AggregateExpr for Avg {
}
}
jorgecarleitao commented on a change in pull request #7984:
URL: https://github.com/apache/arrow/pull/7984#discussion_r472386086
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -337,40 +336,86 @@ impl AggregateExpr for Avg {
}
}
bkietz commented on a change in pull request #7921:
URL: https://github.com/apache/arrow/pull/7921#discussion_r472368169
##
File path: python/pyarrow/dataset.py
##
@@ -682,3 +683,70 @@ def dataset(source, schema=None, format=None,
filesystem=None,
'Expected a
bkietz commented on a change in pull request #7921:
URL: https://github.com/apache/arrow/pull/7921#discussion_r472368545
##
File path: python/pyarrow/dataset.py
##
@@ -682,3 +683,70 @@ def dataset(source, schema=None, format=None,
filesystem=None,
'Expected a
pitrou commented on a change in pull request #7992:
URL: https://github.com/apache/arrow/pull/7992#discussion_r472355484
##
File path: cpp/src/arrow/ipc/dictionary.h
##
@@ -21,34 +21,75 @@
#include
#include
-#include
#include
#include
-#include
pitrou closed pull request #7990:
URL: https://github.com/apache/arrow/pull/7990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on pull request #7990:
URL: https://github.com/apache/arrow/pull/7990#issuecomment-675604502
+1. This is a trivial change, will merge.
This is an automated message from the Apache Git Service.
To respond to
nevi-me commented on pull request #7917:
URL: https://github.com/apache/arrow/pull/7917#issuecomment-675595547
merged in the parquet branch
This is an automated message from the Apache Git Service.
To respond to the message,
nevi-me closed pull request #7917:
URL: https://github.com/apache/arrow/pull/7917
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kiszk commented on pull request #7986:
URL: https://github.com/apache/arrow/pull/7986#issuecomment-675593712
sounds good to me
This is an automated message from the Apache Git Service.
To respond to the message, please log
emkornfield commented on pull request #7973:
URL: https://github.com/apache/arrow/pull/7973#issuecomment-675585382
> Is it better to create an issue in PARQUET instead of ARROW?
It is a fine line. Generally, I use PARQUET for issues related to core
parquet reading (i.e. not arrow
emkornfield commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-675576763
@zhztheplayer based on ML discussion I think the consensus is to use
Bits.java to limit allocation (ideally with some sort of pre-reservation to
limit JNI calls). Do you
pitrou commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675573289
No idea. Perhaps you can find someone with CMake and macOS expertise... :-S
This is an automated message from the
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675565571
All green here but I got the file exists again on one of the autobrew
upstream builds:
https://travis-ci.org/github/autobrew/homebrew-core/jobs/718998685#L767
I
pitrou opened a new pull request #7992:
URL: https://github.com/apache/arrow/pull/7992
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7992:
URL: https://github.com/apache/arrow/pull/7992#issuecomment-675559545
https://issues.apache.org/jira/browse/ARROW-9660
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7990:
URL: https://github.com/apache/arrow/pull/7990#issuecomment-675551252
https://issues.apache.org/jira/browse/ARROW-9785
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7991:
URL: https://github.com/apache/arrow/pull/7991#issuecomment-675551251
https://issues.apache.org/jira/browse/ARROW-9718
This is an automated message from the Apache Git
nealrichardson commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r472278210
##
File path: r/tests/testthat/test-buffer.R
##
@@ -39,6 +39,7 @@ test_that("Buffer can be created from numeric vector", {
})
test_that("Buffer
pitrou opened a new pull request #7990:
URL: https://github.com/apache/arrow/pull/7990
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pitrou commented on a change in pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#discussion_r472277809
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -186,6 +187,42 @@ struct MultiplyChecked {
}
};
+struct Divide {
+ template
+
bkietz commented on a change in pull request #7921:
URL: https://github.com/apache/arrow/pull/7921#discussion_r472262132
##
File path: python/pyarrow/dataset.py
##
@@ -682,3 +683,68 @@ def dataset(source, schema=None, format=None,
filesystem=None,
'Expected a
bkietz commented on a change in pull request #7921:
URL: https://github.com/apache/arrow/pull/7921#discussion_r472259523
##
File path: python/pyarrow/_dataset.pyx
##
@@ -2022,3 +2022,66 @@ def _get_partition_keys(Expression partition_expression):
jorgecarleitao closed pull request #7974:
URL: https://github.com/apache/arrow/pull/7974
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
jorgecarleitao edited a comment on pull request #7971:
URL: https://github.com/apache/arrow/pull/7971#issuecomment-675520454
I am fine with either option we offer to our users. My concern at the moment
is not the public API, but the internal one: after spending some time working
on this
jorgecarleitao commented on pull request #7971:
URL: https://github.com/apache/arrow/pull/7971#issuecomment-675520454
I am fine with either option we offer to our users. My concern at the moment
is not the public API, but the internal one: after spending some time working
on this code
jorgecarleitao closed pull request #7971:
URL: https://github.com/apache/arrow/pull/7971
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675513283
Revision: 45705a93b94797dfb96f31bc5d83f08b61549a18
Submitted crossbow builds: [ursa-labs/crossbow @
bkietz commented on a change in pull request #7748:
URL: https://github.com/apache/arrow/pull/7748#discussion_r472240168
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -186,6 +187,42 @@ struct MultiplyChecked {
}
};
+struct Divide {
+ template
+
nealrichardson commented on pull request #7928:
URL: https://github.com/apache/arrow/pull/7928#issuecomment-675511987
@github-actions crossbow submit homebrew-r-autobrew
This is an automated message from the Apache Git
andygrove closed pull request #7988:
URL: https://github.com/apache/arrow/pull/7988
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
jorgecarleitao commented on a change in pull request #7988:
URL: https://github.com/apache/arrow/pull/7988#discussion_r472221795
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -363,8 +335,6 @@ pub enum Expr {
name: String,
/// List of expressions to
andygrove commented on a change in pull request #7988:
URL: https://github.com/apache/arrow/pull/7988#discussion_r472217735
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -379,7 +349,48 @@ impl Expr {
Expr::Literal(l) => l.get_datatype(),
alamb commented on a change in pull request #7988:
URL: https://github.com/apache/arrow/pull/7988#discussion_r472213122
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -363,8 +335,6 @@ pub enum Expr {
name: String,
/// List of expressions to feed to
github-actions[bot] commented on pull request #7989:
URL: https://github.com/apache/arrow/pull/7989#issuecomment-675488435
https://issues.apache.org/jira/browse/ARROW-9784
This is an automated message from the Apache Git
alamb opened a new pull request #7989:
URL: https://github.com/apache/arrow/pull/7989
While trying to ru the TPCH benchmark introduced in
https://github.com/apache/arrow/pull/7946/files, I found that the referenced
`tpch-dbgen` program did not produce files in the way that the benchmark
andygrove commented on pull request #7988:
URL: https://github.com/apache/arrow/pull/7988#issuecomment-675480952
@jorgecarleitao @alamb Could I get a review please
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7988:
URL: https://github.com/apache/arrow/pull/7988#issuecomment-675480647
https://issues.apache.org/jira/browse/ARROW-9783
This is an automated message from the Apache Git
andygrove opened a new pull request #7988:
URL: https://github.com/apache/arrow/pull/7988
This is a step towards cleaning up the handling of aggregate expressions and
acheives the following:
- It is now possible to construct a logical aggregate expression without
specifying a
github-actions[bot] commented on pull request #7987:
URL: https://github.com/apache/arrow/pull/7987#issuecomment-675473829
https://issues.apache.org/jira/browse/ARROW-9768
This is an automated message from the Apache Git
jorisvandenbossche opened a new pull request #7987:
URL: https://github.com/apache/arrow/pull/7987
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
alamb commented on a change in pull request #7984:
URL: https://github.com/apache/arrow/pull/7984#discussion_r472141713
##
File path: rust/datafusion/src/execution/physical_plan/expressions.rs
##
@@ -337,40 +336,86 @@ impl AggregateExpr for Avg {
}
}
-macro_rules!
1 - 100 of 119 matches
Mail list logo
