[GitHub] [arrow] github-actions[bot] commented on pull request #8076: ARROW-9885: [Rust][DataFusion] Minor code simplification

github-actions[bot] commented on pull request #8076: URL: https://github.com/apache/arrow/pull/8076#issuecomment-683233585 https://issues.apache.org/jira/browse/ARROW-9885 This is an automated message from the Apache Git

[GitHub] [arrow] jorgecarleitao opened a new pull request #8076: ARROW-9885: [Rust][DataFusion] Minor code simplification

jorgecarleitao opened a new pull request #8076: URL: https://github.com/apache/arrow/pull/8076 This is a small simplification of the code that I found while reviewing the code. There were two different problems being addressed at the same function, and there was some un-needed argument in

[GitHub] [arrow] kiszk commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI

kiszk commented on a change in pull request #7938: URL: https://github.com/apache/arrow/pull/7938#discussion_r479583274 ## File path: ci/scripts/java_build.sh ## @@ -23,9 +23,68 @@ source_dir=${1}/java cpp_build_dir=${2}/cpp/${ARROW_BUILD_TYPE:-debug} with_docs=${3:-false}

[GitHub] [arrow] kiszk commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI

kiszk commented on a change in pull request #7938: URL: https://github.com/apache/arrow/pull/7938#discussion_r479583338 ## File path: java/pom.xml ## @@ -193,7 +193,7 @@ 1.8 2048m false - true + false Review comment:

[GitHub] [arrow] github-actions[bot] commented on pull request #8075: ARROW-9884: [R] Bindings for writing datasets to Parquet

github-actions[bot] commented on pull request #8075: URL: https://github.com/apache/arrow/pull/8075#issuecomment-683172785 https://issues.apache.org/jira/browse/ARROW-9884 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #8075: ARROW-9884: [R] Bindings for writing datasets to Parquet

nealrichardson opened a new pull request #8075: URL: https://github.com/apache/arrow/pull/8075 Rebase after #8066 merges This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] kou commented on a change in pull request #7938: ARROW-9701: [CI][Java] Add a job for s390x Java on TravisCI

kou commented on a change in pull request #7938: URL: https://github.com/apache/arrow/pull/7938#discussion_r479554130 ## File path: java/pom.xml ## @@ -193,7 +193,7 @@ 1.8 2048m false - true + false Review comment: Do

[GitHub] [arrow] kou closed pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

kou closed pull request #8049: URL: https://github.com/apache/arrow/pull/8049 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #8049: ARROW-9851: [C++] Disable AVX512 runtime paths with Valgrind

kou commented on pull request #8049: URL: https://github.com/apache/arrow/pull/8049#issuecomment-683163747 OK. I merge this. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] github-actions[bot] commented on pull request #8074: ARROW-9883: [R] Fix linuxlibs.R install script for R < 3.6

github-actions[bot] commented on pull request #8074: URL: https://github.com/apache/arrow/pull/8074#issuecomment-683160742 https://issues.apache.org/jira/browse/ARROW-9883 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson edited a comment on issue #8062: dQuote error during installation in R 3.5.1

nealrichardson edited a comment on issue #8062: URL: https://github.com/apache/arrow/issues/8062#issuecomment-683160233 Fixing in #8074 (ARROW-9883) This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] nealrichardson commented on issue #8062: dQuote error during installation in R 3.5.1

nealrichardson commented on issue #8062: URL: https://github.com/apache/arrow/issues/8062#issuecomment-683160233 Fixing in #8074 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] nealrichardson closed issue #8062: dQuote error during installation in R 3.5.1

nealrichardson closed issue #8062: URL: https://github.com/apache/arrow/issues/8062 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nealrichardson closed pull request #8070: Update linuxlibs.R

nealrichardson closed pull request #8070: URL: https://github.com/apache/arrow/pull/8070 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson commented on pull request #8070: Update linuxlibs.R

nealrichardson commented on pull request #8070: URL: https://github.com/apache/arrow/pull/8070#issuecomment-683159874 Looks like there's a syntax error there. In any case, since `dQuote` with `useFancyQuotes = FALSE` is just `paste0('"', x, '"')`, I went with a simpler fix in #8074.

[GitHub] [arrow] nealrichardson opened a new pull request #8074: ARROW-9883: [R] Fix linuxlibs.R install script for R < 3.6

nealrichardson opened a new pull request #8074: URL: https://github.com/apache/arrow/pull/8074 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] kou closed pull request #8021: ARROW-9823: [CI][C++][MinGW] Enable S3

kou closed pull request #8021: URL: https://github.com/apache/arrow/pull/8021 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #8021: ARROW-9823: [CI][C++][MinGW] Enable S3

kou commented on pull request #8021: URL: https://github.com/apache/arrow/pull/8021#issuecomment-683151982 +1 No objection. This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [arrow] kou closed pull request #8068: ARROW-9876: [C++] Faster ARM build on Travis-CI

kou closed pull request #8068: URL: https://github.com/apache/arrow/pull/8068 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] bkietz commented on a change in pull request #8037: ARROW-9827: [C++][Dataset] Skip parsing RowGroup metadata statistics when there is no filter

bkietz commented on a change in pull request #8037: URL: https://github.com/apache/arrow/pull/8037#discussion_r479471053 ## File path: cpp/src/arrow/dataset/file_parquet.cc ## @@ -357,12 +357,14 @@ Result ParquetFileFormat::ScanFile(std::shared_ptrsource(), options.get(),

[GitHub] [arrow] github-actions[bot] commented on pull request #8073: WIP: ARROW-9882: [C++/Python] Update OSX build to conda-forge-ci-setup=3

github-actions[bot] commented on pull request #8073: URL: https://github.com/apache/arrow/pull/8073#issuecomment-683058851 Revision: 04cb740af819d72599cb84f7964ebb302a338999 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] xhochy commented on pull request #8073: WIP: ARROW-9882: [C++/Python] Update OSX build to conda-forge-ci-setup=3

xhochy commented on pull request #8073: URL: https://github.com/apache/arrow/pull/8073#issuecomment-683056319 @github-actions crossbow submit conda-osx-clang-py36 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] xhochy opened a new pull request #8073: WIP: ARROW-9882: [C++/Python] Update OSX build to conda-forge-ci-setup=3

xhochy opened a new pull request #8073: URL: https://github.com/apache/arrow/pull/8073 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] andygrove edited a comment on pull request #7967: ARROW-9751: [Rust] [DataFusion] Allow UDFs to accept multiple data types per argument

andygrove edited a comment on pull request #7967: URL: https://github.com/apache/arrow/pull/7967#issuecomment-682868097 Thanks @Jorge it seems like I misunderstood the scope of the change. I will review your response this weekend to make sure I understand. > What I struggle a

[GitHub] [arrow] andygrove commented on pull request #7967: ARROW-9751: [Rust] [DataFusion] Allow UDFs to accept multiple data types per argument

andygrove commented on pull request #7967: URL: https://github.com/apache/arrow/pull/7967#issuecomment-682868097 Thanks @Jorge Cardoso Leitão it seems like I misunderstood the scope of the change. I will review your response this weekend to make sure I understand. > What I

[GitHub] [arrow] jorgecarleitao commented on pull request #7967: ARROW-9751: [Rust] [DataFusion] Allow UDFs to accept multiple data types per argument

jorgecarleitao commented on pull request #7967: URL: https://github.com/apache/arrow/pull/7967#issuecomment-682832105 The discussion for me is not so much about the return type of the function `sqrt`. I am fine with `sqrt_f32`. My issue is with the output of the function `array`,

[GitHub] [arrow] nealrichardson closed pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

nealrichardson closed pull request #8071: URL: https://github.com/apache/arrow/pull/8071 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] andygrove commented on pull request #7967: ARROW-9751: [Rust] [DataFusion] Allow UDFs to accept multiple data types per argument

andygrove commented on pull request #7967: URL: https://github.com/apache/arrow/pull/7967#issuecomment-682598627 Hi @jorgecarleitao and @alamb I've been thinking about this specific change some more, and I am not sure it is such a good idea to have dynamic typing when it comes to the

[GitHub] [arrow] github-actions[bot] commented on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

github-actions[bot] commented on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-682483973 Revision: 2d1c8a970c1822a71704c4360814291905e8a287 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] jianxind commented on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind commented on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-682483304 @github-actions crossbow submit homebrew-cpp This is an automated message from the Apache Git Service. To

[GitHub] [arrow] fjetter commented on pull request #7891: ARROW-9629: [Python] Fix kartothek integration tests by fixing dependencies

fjetter commented on pull request #7891: URL: https://github.com/apache/arrow/pull/7891#issuecomment-682471147 @jorisvandenbossche Kartothek 3.14.0 is out and should be compatible with pandas and arrow now. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

github-actions[bot] commented on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-682465926 Revision: e6a0aa6d5c23def7842774afc089ecc3a13f18ef Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] jianxind commented on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind commented on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-682465343 @github-actions crossbow submit homebrew-cpp This is an automated message from the Apache Git Service. To

[GitHub] [arrow] jianxind removed a comment on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind removed a comment on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-68241 I always has issue with "archery lint --cmake-format", not sure why:( This is an automated message from

[GitHub] [arrow] github-actions[bot] commented on pull request #8072: ARROW-9879: [Python] Add support for numpy scalars to ChunkedArray.__getitem__

github-actions[bot] commented on pull request #8072: URL: https://github.com/apache/arrow/pull/8072#issuecomment-682434733 https://issues.apache.org/jira/browse/ARROW-9879 This is an automated message from the Apache Git

[GitHub] [arrow] xhochy opened a new pull request #8072: ARROW-9879: [Python] Add support for numpy scalars to ChunkedArray.__getitem__

xhochy opened a new pull request #8072: URL: https://github.com/apache/arrow/pull/8072 FYI @marc9595 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [arrow] liyafan82 commented on a change in pull request #7326: ARROW-9010: [Java] Framework and interface changes for RecordBatch IPC buffer compression

liyafan82 commented on a change in pull request #7326: URL: https://github.com/apache/arrow/pull/7326#discussion_r479017596 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ipc/message/ArrowRecordBatch.java ## @@ -194,12 +190,17 @@ public int

[GitHub] [arrow] jianxind commented on pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind commented on pull request #8071: URL: https://github.com/apache/arrow/pull/8071#issuecomment-68241 I always has issue with "archery lint --cmake-format", not sure why:( This is an automated message from the

[GitHub] [arrow] jianxind commented on a change in pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind commented on a change in pull request #8071: URL: https://github.com/apache/arrow/pull/8071#discussion_r478941556 ## File path: cpp/src/arrow/util/cpu_info.h ## @@ -71,8 +78,8 @@ class ARROW_EXPORT CpuInfo { /// Returns all the flags for this cpu int64_t

[GitHub] [arrow] jianxind commented on a change in pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

jianxind commented on a change in pull request #8071: URL: https://github.com/apache/arrow/pull/8071#discussion_r478897639 ## File path: cpp/cmake_modules/SetupCxxFlags.cmake ## @@ -47,8 +47,8 @@ if(ARROW_CPU_FLAG STREQUAL "x86") else() set(ARROW_SSE4_2_FLAG

[GitHub] [arrow] pitrou commented on a change in pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

pitrou commented on a change in pull request #8071: URL: https://github.com/apache/arrow/pull/8071#discussion_r478881032 ## File path: cpp/src/arrow/util/cpu_info.h ## @@ -71,8 +78,8 @@ class ARROW_EXPORT CpuInfo { /// Returns all the flags for this cpu int64_t

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8044: ARROW-7663: [Python] Raise better error message when passing mixed-type (int/string) Pandas dataframe to pyarrow Table

jorisvandenbossche commented on a change in pull request #8044: URL: https://github.com/apache/arrow/pull/8044#discussion_r478880416 ## File path: cpp/src/arrow/python/python_to_arrow.cc ## @@ -106,7 +106,12 @@ struct ValueConverter> { static inline Result

[GitHub] [arrow] pitrou commented on a change in pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

pitrou commented on a change in pull request #8071: URL: https://github.com/apache/arrow/pull/8071#discussion_r478880260 ## File path: cpp/cmake_modules/SetupCxxFlags.cmake ## @@ -47,8 +47,8 @@ if(ARROW_CPU_FLAG STREQUAL "x86") else() set(ARROW_SSE4_2_FLAG "-msse4.2")

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8044: ARROW-7663: [Python] Raise better error message when passing mixed-type (int/string) Pandas dataframe to pyarrow Table

jorisvandenbossche commented on a change in pull request #8044: URL: https://github.com/apache/arrow/pull/8044#discussion_r478879571 ## File path: python/pyarrow/tests/test_compute.py ## @@ -562,7 +562,7 @@ def test_is_null(): def test_fill_null(): arr = pa.array([1, 2,

[GitHub] [arrow] pitrou commented on a change in pull request #8071: ARROW-9877: [C++] Fix homebrew-cpp build fail on AVX512

pitrou commented on a change in pull request #8071: URL: https://github.com/apache/arrow/pull/8071#discussion_r478879104 ## File path: cpp/cmake_modules/SetupCxxFlags.cmake ## @@ -47,8 +47,8 @@ if(ARROW_CPU_FLAG STREQUAL "x86") else() set(ARROW_SSE4_2_FLAG "-msse4.2")

[GitHub] [arrow] jorisvandenbossche commented on pull request #6676: ARROW-8175: [Python] Setup type checking with mypy

jorisvandenbossche commented on pull request #6676: URL: https://github.com/apache/arrow/pull/6676#issuecomment-682369873 Yes, I think it will be a strict improvement, but it might also not be doing much validation yet, since a lot of the pyarrow objects / functions will just be typed

[GitHub] [arrow] jorisvandenbossche commented on pull request #8067: ARROW-9875: [Python] Let FileSystem.get_file_info accept a single path

jorisvandenbossche commented on pull request #8067: URL: https://github.com/apache/arrow/pull/8067#issuecomment-682365331 > The reason it doesn't accept pathlib.Path is that pathlib represents local paths. Ah, yes, I always forget that part ..

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8067: ARROW-9875: [Python] Let FileSystem.get_file_info accept a single path

jorisvandenbossche commented on a change in pull request #8067: URL: https://github.com/apache/arrow/pull/8067#discussion_r478871227 ## File path: python/pyarrow/_fs.pyx ## @@ -419,17 +420,27 @@ cdef class FileSystem(_Weakrefable): vector[c_string] paths