emkornfield merged pull request #8281:
URL: https://github.com/apache/arrow/pull/8281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
emkornfield opened a new pull request #8281:
URL: https://github.com/apache/arrow/pull/8281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
jorgecarleitao commented on a change in pull request #8199:
URL: https://github.com/apache/arrow/pull/8199#discussion_r495409403
##
File path: rust/arrow/src/compute/kernels/substring.rs
##
@@ -0,0 +1,262 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or
jorgecarleitao commented on a change in pull request #8280:
URL: https://github.com/apache/arrow/pull/8280#discussion_r495394022
##
File path: rust/arrow/src/compute/util.rs
##
@@ -71,6 +71,47 @@ pub(super) fn combine_option_bitmap(
}
}
+/// Compares the null bitmaps
jorgecarleitao commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-699274727
I agree with your reasoning.
AFAIK, `scalar` in the context of Arrow is not a mathematical scalar like
`f64`: `scalar` is a "1-element representation of an Arrow
github-actions[bot] commented on pull request #8280:
URL: https://github.com/apache/arrow/pull/8280#issuecomment-699272912
https://issues.apache.org/jira/browse/ARROW-10103
This is an automated message from the Apache Git
nevi-me commented on a change in pull request #8280:
URL: https://github.com/apache/arrow/pull/8280#discussion_r495375649
##
File path: rust/arrow/src/compute/kernels/comparison.rs
##
@@ -555,11 +557,159 @@ where
compare_op_scalar!(left, right, |a, b| a >= b)
}
+///
nevi-me commented on pull request #8280:
URL: https://github.com/apache/arrow/pull/8280#issuecomment-699270344
This is extracted from #6770,
PTAL @alamb @jorgecarleitao @jhorstmann
CC @mcassels @maxburke
nevi-me opened a new pull request #8280:
URL: https://github.com/apache/arrow/pull/8280
Checks if a list contains a value in either a primitive or string
Large lists are also supported
This is an automated message
github-actions[bot] commented on pull request #8279:
URL: https://github.com/apache/arrow/pull/8279#issuecomment-699255507
https://issues.apache.org/jira/browse/ARROW-10102
This is an automated message from the Apache Git
nevi-me commented on pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-699255325
> @nevi-me did your other PRs supercede this?
I hadn't seen this @emkornfield. No, I've only been focusing on the writer,
so I'll still want to merge this into the branch
nevi-me commented on pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-699254549
This has sadly fallen behind significantly from the main branch. I've spent
a few hours trying to rebase, but because it looks like the PR contained
changes for the below, it's a
bkietz commented on a change in pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#discussion_r495353620
##
File path: cpp/src/arrow/dataset/scanner.h
##
@@ -73,7 +73,7 @@ class ARROW_DS_EXPORT ScanOptions {
RecordBatchProjector projector;
// Maximum
bkietz commented on a change in pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#discussion_r495353791
##
File path: ci/scripts/python_test.sh
##
@@ -29,4 +29,4 @@ export LD_LIBRARY_PATH=${ARROW_HOME}/lib:${LD_LIBRARY_PATH}
# Enable some checks inside Python
bkietz commented on a change in pull request #8188:
URL: https://github.com/apache/arrow/pull/8188#discussion_r495353478
##
File path: cpp/src/parquet/arrow/reader.cc
##
@@ -856,18 +856,32 @@ Status FileReaderImpl::GetRecordBatchReader(const
std::vector& row_groups,
bkietz commented on pull request #8264:
URL: https://github.com/apache/arrow/pull/8264#issuecomment-699251775
https://travis-ci.org/github/bkietz/arrow/builds/730424920
This is an automated message from the Apache Git
MingyuZhong commented on a change in pull request #8279:
URL: https://github.com/apache/arrow/pull/8279#discussion_r495351658
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -248,40 +248,64 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
return
bkietz commented on a change in pull request #8264:
URL: https://github.com/apache/arrow/pull/8264#discussion_r495351571
##
File path: cpp/src/arrow/testing/gtest_util.h
##
@@ -108,9 +108,9 @@
} while (false);
#define ASSIGN_OR_HANDLE_ERROR_IMPL(handle_error,
bkietz closed pull request #8088:
URL: https://github.com/apache/arrow/pull/8088
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Luminarys closed pull request #8266:
URL: https://github.com/apache/arrow/pull/8266
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Luminarys opened a new pull request #8279:
URL: https://github.com/apache/arrow/pull/8279
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Luminarys commented on pull request #8266:
URL: https://github.com/apache/arrow/pull/8266#issuecomment-699249538
Closing this in favor of https://github.com/apache/arrow/pull/8279.
This is an automated message from the
Luminarys commented on a change in pull request #8266:
URL: https://github.com/apache/arrow/pull/8266#discussion_r495349095
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -248,40 +247,50 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
return
Luminarys commented on a change in pull request #8266:
URL: https://github.com/apache/arrow/pull/8266#discussion_r495346728
##
File path: cpp/src/arrow/util/basic_decimal.cc
##
@@ -248,40 +247,50 @@ BasicDecimal128& BasicDecimal128::operator>>=(uint32_t
bits) {
return
nealrichardson commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-699207051
Here's what I'm talking about in the failure in the 32 bit build:
```
lto-wrapper.exe: fatal error: C:\rtools40\mingw32\bin\g++.exe returned 1
exit status
drusso edited a comment on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-699164097
@andygrove (cc @jorgecarleitao):
My apologies, I don't have the changes ready yet. Though I did have some
time today to look into integrating this with #8172/master.
drusso commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-699164097
@andygrove (cc @jorgecarleitao):
My apologies, I don't have the changes ready yet. Though I did have some
time today to look into integrating this with #8172/master.
github-actions[bot] commented on pull request #8278:
URL: https://github.com/apache/arrow/pull/8278#issuecomment-699162153
https://issues.apache.org/jira/browse/ARROW-10101
This is an automated message from the Apache Git
lidavidm opened a new pull request #8278:
URL: https://github.com/apache/arrow/pull/8278
This is an attempt at a Tensor contrib module. It hard-codes a single
implementation for doubles only. If the overall API looks OK, I could then
apply the FreeMarker templates (like the Vector module)
nealrichardson closed pull request #8277:
URL: https://github.com/apache/arrow/pull/8277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nealrichardson commented on pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#issuecomment-699156330
@bkietz you can probably just push to it, or whatever you want. AFAICT
that's the only outstanding issue and I'll merge when it is resolved (since
it's earlier in the day
bkietz commented on pull request #8246:
URL: https://github.com/apache/arrow/pull/8246#issuecomment-699153455
@romainfrancois yes, should I make a PR to your branch?
This is an automated message from the Apache Git Service.
wesm closed pull request #8272:
URL: https://github.com/apache/arrow/pull/8272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm commented on pull request #8272:
URL: https://github.com/apache/arrow/pull/8272#issuecomment-699122927
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
nealrichardson commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-699122339
No luck. One possibility is that we aren't getting the right 32/64 bit
versions of the tools: there are two versions of each,
github-actions[bot] commented on pull request #8277:
URL: https://github.com/apache/arrow/pull/8277#issuecomment-699121141
https://issues.apache.org/jira/browse/ARROW-10098
This is an automated message from the Apache Git
pitrou commented on pull request #8200:
URL: https://github.com/apache/arrow/pull/8200#issuecomment-699117248
Remember to update the [implementation
status](https://github.com/apache/arrow/blob/master/docs/source/status.rst)
when done ;-)
nealrichardson opened a new pull request #8277:
URL: https://github.com/apache/arrow/pull/8277
Somehow #8187 had a passing build but it didn't regenerate the R docs, so R
builds are failing on master because the doc signature doesn't match the code.
andygrove commented on pull request #8222:
URL: https://github.com/apache/arrow/pull/8222#issuecomment-699113117
Hi @drusso I would like to review and merge this DF PR next. Would you mind
rebasing?
This is an automated
andygrove closed pull request #8276:
URL: https://github.com/apache/arrow/pull/8276
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8275:
URL: https://github.com/apache/arrow/pull/8275
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #8180:
URL: https://github.com/apache/arrow/pull/8180
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-699078267
路 I'll try Makevars
This is an automated message from the Apache Git Service.
To respond to the message,
xhochy commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-699075688
No, that is what I thought. The logs indicate though that still the wrong
tools are used: https://github.com/apache/arrow/runs/1166696816#step:11:180
Maybe this needs to go
nealrichardson closed pull request #8197:
URL: https://github.com/apache/arrow/pull/8197
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nealrichardson commented on pull request #8197:
URL: https://github.com/apache/arrow/pull/8197#issuecomment-699074276
I'm going to merge this and we can follow up with UX questions in the next
PR.
This is an automated
nealrichardson commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-699073582
@xhochy that did not seem to work, it still says plugin not found, though
maybe I misunderstood what you were suggesting
nealrichardson commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r495148711
##
File path: r/src/arrow_exports.h
##
@@ -22,6 +22,7 @@
#include "./arrow_cpp11.h"
#if defined(ARROW_R_WITH_ARROW)
+#include
Review comment:
romainfrancois commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-699054273
I'd like to make the `..dispatch()` methods go away. So I guess the question
is when a C++ function returns an Array that in fact is a StructArray, should
the R object be
romainfrancois commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r495128561
##
File path: r/src/arrow_exports.h
##
@@ -22,6 +22,7 @@
#include "./arrow_cpp11.h"
#if defined(ARROW_R_WITH_ARROW)
+#include
Review comment:
nevi-me commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-699046916
I just noticed that there's more breaking changes on the branch :(. I'll
address them shortly
This is an
github-actions[bot] commented on pull request #8276:
URL: https://github.com/apache/arrow/pull/8276#issuecomment-699044452
https://issues.apache.org/jira/browse/ARROW-9981
This is an automated message from the Apache Git
carols10cents commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-699043524
Thanks so much! I'm going to take a look at writing dictionary types :)
This is an automated message from
nevi-me opened a new pull request #8276:
URL: https://github.com/apache/arrow/pull/8276
Allows flight users to specify IpcWriteOptions for Arrow to Flight
conversions
This is an automated message from the Apache Git
nevi-me commented on a change in pull request #8199:
URL: https://github.com/apache/arrow/pull/8199#discussion_r495116844
##
File path: rust/arrow/src/compute/kernels/substring.rs
##
@@ -0,0 +1,262 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
pitrou commented on a change in pull request #8264:
URL: https://github.com/apache/arrow/pull/8264#discussion_r495106328
##
File path: cpp/src/arrow/testing/gtest_util.h
##
@@ -108,9 +108,9 @@
} while (false);
#define ASSIGN_OR_HANDLE_ERROR_IMPL(handle_error,
github-actions[bot] commented on pull request #8275:
URL: https://github.com/apache/arrow/pull/8275#issuecomment-699025441
https://issues.apache.org/jira/browse/ARROW-10096
This is an automated message from the Apache Git
xubinlaile commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699021063
> > may this help:
> >
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
>
> Maybe I didn't read it carefully but
xubinlaile removed a comment on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699019657
> > may this help:
> >
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
>
> Maybe I didn't read it
jorgecarleitao opened a new pull request #8275:
URL: https://github.com/apache/arrow/pull/8275
A minor clean up
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
xubinlaile commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699019657
> > may this help:
> >
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
>
> Maybe I didn't read it carefully but
arw2019 edited a comment on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699010092
> may this help:
>
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
Maybe I didn't read it carefully but
xubinlaile removed a comment on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699009005
may this help:
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
xubinlaile commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699011960
> Thanks for the report!
>
> Can you provide a copy-pastable example so we can reproduce the issue
locally and investigate? See
nealrichardson closed pull request #8235:
URL: https://github.com/apache/arrow/pull/8235
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nevi-me closed pull request #8274:
URL: https://github.com/apache/arrow/pull/8274
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
arw2019 commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699010092
> may this help:
>
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
Maybe I didn't read it carefully but that does
nevi-me commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-699010120
Merged, I'll rebase on the branch shortly
This is an automated message from the Apache Git Service.
To respond to
xubinlaile commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699009005
may this help:
https://stackoverflow.com/questions/50916422/python-typeerror-object-of-type-int64-is-not-json-serializable
github-actions[bot] commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-699007819
https://issues.apache.org/jira/browse/ARROW-10095
This is an automated message from the Apache Git
arw2019 commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699006533
Thanks for the report!
Can you provide a copy-pastable example so we can reproduce the issue
locally and investigate? See
nevi-me commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-699005892
Hi Carol
Thanks, I would definitely appreciate your help and expertise with the
writer. I forgot to open a JIRA for the IPC changes, as I saw them after I had
rebased.
xubinlaile removed a comment on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699003981
maybe this help：
class NpEncoder(json.JSONEncoder):
def default(self, obj):
if isinstance(obj, np.integer):
return int(obj)
kszucs commented on pull request #8267:
URL: https://github.com/apache/arrow/pull/8267#issuecomment-699004209
Thanks for fixing it!
This is an automated message from the Apache Git Service.
To respond to the message, please
xubinlaile commented on issue #8270:
URL: https://github.com/apache/arrow/issues/8270#issuecomment-699003981
maybe this help：
class NpEncoder(json.JSONEncoder):
def default(self, obj):
if isinstance(obj, np.integer):
return int(obj)
nealrichardson closed pull request #8267:
URL: https://github.com/apache/arrow/pull/8267
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #8274:
URL: https://github.com/apache/arrow/pull/8274#issuecomment-698997435
https://issues.apache.org/jira/browse/ARROW-8421
This is an automated message from the Apache Git
nealrichardson commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698996362
> I'm not clear yet about the classes that are currently handled with
`$..dispatch()` methods in R.
I can think of a few possibilities (as I'm sure you can):
nealrichardson commented on a change in pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#discussion_r495061853
##
File path: r/src/arrow_exports.h
##
@@ -22,6 +22,7 @@
#include "./arrow_cpp11.h"
#if defined(ARROW_R_WITH_ARROW)
+#include
Review comment:
carols10cents opened a new pull request #8274:
URL: https://github.com/apache/arrow/pull/8274
Note that this PR is deliberately filed against the
rust-parquet-arrow-writer branch, not master!!
Hi! I'm looking to help out with the rust-parquet-arrow-writer branch, and
I just
romainfrancois commented on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698983439
started to get away from the R function `shared_ptr()`. Not handling all
cases yet, eventually this:
```cpp
template
SEXP as_sexp(const std::shared_ptr& ptr)
xhochy commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-698970205
@nealrichardson If you have time to continue this, I guess you need to set
`NM=` & co in the environment for `R CMD INSTALL`. I wonder whether the
Rtools40 setup should do this
xhochy commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-698969024
Ok, this got us a bit further...
This is an automated message from the Apache Git Service.
To respond to the
nevi-me closed pull request #8223:
URL: https://github.com/apache/arrow/pull/8223
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nevi-me commented on pull request #8223:
URL: https://github.com/apache/arrow/pull/8223#issuecomment-698963093
Hey @jhorstmann, I haven't had time to look, but maybe I'm confused. What I
recall is that I needed a way of converting a Buffer to a `Vec` when I
write to Parquet. It might even
bkietz commented on a change in pull request #8088:
URL: https://github.com/apache/arrow/pull/8088#discussion_r495026946
##
File path: cpp/src/arrow/python/python_to_arrow.cc
##
@@ -329,985 +303,649 @@ struct ValueConverter {
default:
return
kszucs closed pull request #8273:
URL: https://github.com/apache/arrow/pull/8273
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698948177
> missing license header?
Yes, https://github.com/apache/arrow/pull/8273 should fix that.
This is an
kszucs edited a comment on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698948177
> missing license header?
Yes, https://github.com/apache/arrow/pull/8273 should fix that.
xhochy commented on pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#issuecomment-698938651
@nealrichardson I would rather guess the the issue comes from using the
wrong ar/ranlib/nm. There should be a `gcc-ar` / `gcc-nm` / `gcc-ranlib` or so
available that can handle
github-actions[bot] commented on pull request #8272:
URL: https://github.com/apache/arrow/pull/8272#issuecomment-698936380
https://issues.apache.org/jira/browse/ARROW-8601
This is an automated message from the Apache Git
xhochy commented on a change in pull request #8153:
URL: https://github.com/apache/arrow/pull/8153#discussion_r495001612
##
File path: ci/scripts/PKGBUILD
##
@@ -76,8 +76,10 @@ build() {
export CPPFLAGS="${CPPFLAGS} -I${MINGW_PREFIX}/include"
export
emkornfield merged pull request #8268:
URL: https://github.com/apache/arrow/pull/8268
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
xhochy closed pull request #8257:
URL: https://github.com/apache/arrow/pull/8257
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
romainfrancois edited a comment on pull request #8256:
URL: https://github.com/apache/arrow/pull/8256#issuecomment-698808913
``` r
library(tidyverse)
brio::read_lines("~/git/apache/arrow/r/src/arrowExports.cpp") %>%
str_subset("^std::[a-z]+_ptr<") %>%
str_remove("
jhorstmann commented on a change in pull request #8260:
URL: https://github.com/apache/arrow/pull/8260#discussion_r494974111
##
File path: rust/arrow/src/compute/kernels/length.rs
##
@@ -17,52 +17,56 @@
//! Defines kernel for length of a string array
-use crate::array::*;
kszucs commented on pull request #8175:
URL: https://github.com/apache/arrow/pull/8175#issuecomment-698922798
```
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat license violation: go/arrow/flight/example_flight_server_test.go
```
These files
cyb70289 edited a comment on pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#issuecomment-698754806
Dev / Lint ci failure looks not related.
```
INFO:archery:Running Docker linter
apache-rat license violation: go/arrow/flight/Flight_grpc.pb.go
apache-rat
github-actions[bot] commented on pull request #8273:
URL: https://github.com/apache/arrow/pull/8273#issuecomment-698936382
https://issues.apache.org/jira/browse/ARROW-10092
This is an automated message from the Apache Git
wesm opened a new pull request #8272:
URL: https://github.com/apache/arrow/pull/8272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
1 - 100 of 198 matches
Mail list logo
