romainfrancois edited a comment on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-726577844
It does look like `Rf_mkCharLenCE()` is generating the error:
``` r
cpp11::cpp_eval('Rf_mkCharLenCE("camer\\0a", 7, CE_UTF8)')
#> Error in f(): embedded
romainfrancois commented on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-726577844
It does look like `Rf_mkCharLenCE()` is generating the error:
``` r
cpp11::cpp_eval('Rf_mkCharLenCE("camer\\0a", 6, CE_UTF8)')
#> Error in f(): embedded nul in
emkornfield commented on pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#issuecomment-726557997
@zhztheplayer I think I saw you requested a re-review is that accurate? Is
the CI failure related to your changes?
github-actions[bot] commented on pull request #8657:
URL: https://github.com/apache/arrow/pull/8657#issuecomment-726557932
https://issues.apache.org/jira/browse/ARROW-7363
This is an automated message from the Apache Git
arw2019 opened a new pull request #8657:
URL: https://github.com/apache/arrow/pull/8657
As discussed on JIRA we currently don't have a convenience method that
converts `ChunkedArray` into a non-chunked `Array`. `flatten` doesn't do this
when called on a `ChunkedArray` instance so this PR
kiszk commented on a change in pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#discussion_r522675532
##
File path: java/performance/pom.xml
##
@@ -169,10 +173,17 @@
${benchmark.filter}
-f
emkornfield commented on a change in pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#discussion_r522673324
##
File path: cpp/src/parquet/encoding.cc
##
@@ -127,6 +129,21 @@ class PlainEncoder : public EncoderImpl, virtual public
TypedEncoder {
}
kiszk commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-726544148
The following commands should work:
```
archery benchmark list --langauge=java
archery benchmark run --langauge=java
archery benchmark diff --langauge=java
```
kiszk commented on pull request #8210:
URL: https://github.com/apache/arrow/pull/8210#issuecomment-726543626
@liyafan82 @fsaintjacques @kszucs Would it be possible to review this?
This is an automated message from the Apache
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726538652
Revision: fcb561bf960f23d3c1b85c791bb2acff8e2575a6
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726531918
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
Bei-z commented on pull request #8542:
URL: https://github.com/apache/arrow/pull/8542#issuecomment-726531615
> Thanks for the updates. Can you look at the errors on CI and fix them?
Thanks!
Thank you for reviewing! The errors on CI are fixed now.
jorgecarleitao edited a comment on pull request #8645:
URL: https://github.com/apache/arrow/pull/8645#issuecomment-726510728
Ok, I confirm that this error is due to a wrong pointer offset on the
`set_bits_raw` and that this undefined behavior is already present in `master`:
```
jorgecarleitao edited a comment on pull request #8645:
URL: https://github.com/apache/arrow/pull/8645#issuecomment-726510728
Ok, I confirm that this error is due to a wrong pointer offset on the
`set_bits_raw` and that this undefined behavior is already present in `master`:
```
arw2019 edited a comment on pull request #8474:
URL: https://github.com/apache/arrow/pull/8474#issuecomment-720653983
Ready for re-review. CI all green
This is an automated message from the Apache Git Service.
To respond to
jorgecarleitao commented on pull request #8645:
URL: https://github.com/apache/arrow/pull/8645#issuecomment-726510728
Ok, I confirm that this error is due to a wrong byte offset on the
`set_bits_raw` and that this undefined behavior is already present in `master`:
```
Switched to
github-actions[bot] commented on pull request #8656:
URL: https://github.com/apache/arrow/pull/8656#issuecomment-726490144
https://issues.apache.org/jira/browse/ARROW-10575
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726488735
Revision: 5226bf79241b66866ed71e1f89699211843dc0dc
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726488347
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726474135
Revision: 59da36b94b931ae1c72b7896f1aa847e904b011c
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726473740
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
liyafan82 commented on pull request #8605:
URL: https://github.com/apache/arrow/pull/8605#issuecomment-726470885
> @liyafan82 good idea, added test case to PR.
> Also tested together with C++ in my demo project:
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726433072
Revision: 797da2423e1b82473af3140c2c6d8ac048ed7d7b
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #8655:
URL: https://github.com/apache/arrow/pull/8655#issuecomment-726432824
https://issues.apache.org/jira/browse/ARROW-10526
This is an automated message from the Apache Git
lidavidm commented on pull request #8585:
URL: https://github.com/apache/arrow/pull/8585#issuecomment-726423866
Ah sorry, I think I got what you mean now - updated.
This is an automated message from the Apache Git Service.
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726419694
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
jduo opened a new pull request #8655:
URL: https://github.com/apache/arrow/pull/8655
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wesm commented on pull request #8644:
URL: https://github.com/apache/arrow/pull/8644#issuecomment-726416818
Hm. Unaligned buffers are not compliant with the Arrow specification. This
optimization is only useful in the extraordinarily narrow use case where all of
the columns in the
BryanCutler commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r522508039
##
File path:
java/memory/memory-netty/src/test/java/io/netty/buffer/TestUnsafeDirectLittleEndian.java
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the
BryanCutler commented on a change in pull request #8057:
URL: https://github.com/apache/arrow/pull/8057#discussion_r522507327
##
File path:
java/memory/memory-netty/src/main/java/io/netty/buffer/UnsafeDirectLittleEndian.java
##
@@ -170,6 +166,66 @@ public ByteBuf
github-actions[bot] commented on pull request #8644:
URL: https://github.com/apache/arrow/pull/8644#issuecomment-726395783
https://issues.apache.org/jira/browse/ARROW-10573
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726352589
Revision: 63de89b280184ae5ca7f785b181b7a01634c1d06
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726349174
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726329638
Revision: 3806d8c58ce2158a266cfe54c3029d46d7b6b0c8
Submitted crossbow builds: [ursa-labs/crossbow @
bkietz commented on a change in pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#discussion_r522384657
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -392,96 +376,159 @@ Status ValidateArray(const Array& array) {
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726306020
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
bkietz commented on pull request #8582:
URL: https://github.com/apache/arrow/pull/8582#issuecomment-726304419
@pitrou rebased, PTAL
This is an automated message from the Apache Git Service.
To respond to the message, please
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726295496
Revision: d9abeb78e20ab9a28a5180c2c5001851a53dfb4a
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #8654:
URL: https://github.com/apache/arrow/pull/8654#issuecomment-726283784
https://issues.apache.org/jira/browse/ARROW-10572
This is an automated message from the Apache Git
kou commented on pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#issuecomment-726283347
Umm, they may have a problem in finalization...
This is an automated message from the Apache Git Service.
To respond
bkietz closed pull request #8591:
URL: https://github.com/apache/arrow/pull/8591
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726278539
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
pitrou commented on a change in pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#discussion_r522346840
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -392,96 +376,159 @@ Status ValidateArray(const Array& array) {
pitrou commented on a change in pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#discussion_r522345946
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -392,96 +376,159 @@ Status ValidateArray(const Array& array) {
pitrou commented on a change in pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#discussion_r522344042
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -38,195 +39,172 @@ namespace internal {
namespace {
-struct ValidateArrayVisitor {
- Status
Dandandan opened a new pull request #8654:
URL: https://github.com/apache/arrow/pull/8654
Use ahash https://github.com/tkaitchuck/aHash for hashing algorithm.
Difference is mainly visible in group_by benches:
```
aggregate_query_group_by 15 12
pitrou commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522341768
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -860,6 +860,16 @@ def test_fill_null():
expected = pa.array([None, None, None, None])
github-actions[bot] commented on pull request #8653:
URL: https://github.com/apache/arrow/pull/8653#issuecomment-726273781
https://issues.apache.org/jira/browse/ARROW-10560
This is an automated message from the Apache Git
pitrou commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522341491
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -1058,6 +1058,22 @@ ArrayKernelExec
GenerateTypeAgnosticPrimitive(detail::GetTypeId
pitrou opened a new pull request #8653:
URL: https://github.com/apache/arrow/pull/8653
Error out cleanly if an individual string is larger than 2**31 bytes when
creating a binary or string array.
This is an automated
bkietz commented on a change in pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#discussion_r522302828
##
File path: cpp/src/arrow/array/validate.cc
##
@@ -38,195 +39,172 @@ namespace internal {
namespace {
-struct ValidateArrayVisitor {
- Status
lidavidm commented on pull request #8649:
URL: https://github.com/apache/arrow/pull/8649#issuecomment-726262837
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lidavidm closed pull request #8649:
URL: https://github.com/apache/arrow/pull/8649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-726261100
https://issues.apache.org/jira/browse/ARROW-10530
This is an automated message from the Apache Git
maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522327950
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -1058,6 +1058,22 @@ ArrayKernelExec
maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522327624
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -153,6 +153,60 @@ void AddBasicFillNullKernels(ScalarKernel kernel,
maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522326005
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -1058,6 +1058,22 @@ ArrayKernelExec
maartenbreddels commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522325504
##
File path: python/pyarrow/tests/test_compute.py
##
@@ -860,6 +860,16 @@ def test_fill_null():
expected = pa.array([None, None, None, None])
pitrou closed pull request #8627:
URL: https://github.com/apache/arrow/pull/8627
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou commented on a change in pull request #8628:
URL: https://github.com/apache/arrow/pull/8628#discussion_r522312822
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -153,6 +153,60 @@ void AddBasicFillNullKernels(ScalarKernel kernel,
ScalarFunction*
pitrou closed pull request #8638:
URL: https://github.com/apache/arrow/pull/8638
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou closed pull request #8651:
URL: https://github.com/apache/arrow/pull/8651
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #8652:
URL: https://github.com/apache/arrow/pull/8652#issuecomment-726240920
https://issues.apache.org/jira/browse/ARROW-10566
This is an automated message from the Apache Git
pitrou commented on pull request #8591:
URL: https://github.com/apache/arrow/pull/8591#issuecomment-726239188
Can you rebase to get a clean ASAN build?
This is an automated message from the Apache Git Service.
To respond to
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726238225
Revision: e4874a84fdb589391713c596e9c16c0ef2b168df
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-726237202
What you describe (including using GetView) is essentially what we now have
on master:
https://github.com/apache/arrow/blob/master/r/src/array_to_vector.cpp#L290-L321
bkietz commented on a change in pull request #8461:
URL: https://github.com/apache/arrow/pull/8461#discussion_r522287090
##
File path: python/pyarrow/includes/libgandiva.pxd
##
@@ -58,6 +67,31 @@ cdef extern from "gandiva/selection_vector.h" namespace
"gandiva" nogil:
pitrou opened a new pull request #8652:
URL: https://github.com/apache/arrow/pull/8652
Having to construct an Array from ArrayData entails various assertions which
may fail.
It is therefore safer to be able to validate the data *before*.
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726230804
@github-actions crossbow submit wheel-win-cp39
This is an automated message from the Apache Git Service.
To respond
bkietz commented on pull request #8365:
URL: https://github.com/apache/arrow/pull/8365#issuecomment-726224318
@romainfrancois that looks good to me. I'd recommend using `GetView` instead
of `GetString` to avoid allocating an unnecessary temporary for non-short
strings
pitrou commented on pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#issuecomment-726224610
@kou Well, the Python tests sometimes seem to time out on MinGW...
This is an automated message from the Apache
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726218308
Revision: 3488e1c6fc6b6d5393daa26549a3ea023a627512
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726217209
@github-actions crossbow submit wheel-win-*
This is an automated message from the Apache Git Service.
To respond to
kou commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726217045
Thanks!
> Is this newly introduced by github?
It seems that it's introduced at 2020-06-03:
kou commented on pull request #8632:
URL: https://github.com/apache/arrow/pull/8632#issuecomment-726215438
Yes. It's normal.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #8651:
URL: https://github.com/apache/arrow/pull/8651#issuecomment-726178310
https://issues.apache.org/jira/browse/ARROW-10568
This is an automated message from the Apache Git
Kopilov commented on pull request #8605:
URL: https://github.com/apache/arrow/pull/8605#issuecomment-726169585
@liyafan82 good idea, added test case to PR.
Also tested together with C++ in my demo project:
wesm commented on issue #8646:
URL: https://github.com/apache/arrow/issues/8646#issuecomment-726169236
Would you mind asking this question on the dev@ or user@ mailing list?
Thanks!
This is an automated message from the
kiszk commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r522218040
##
File path: cpp/src/arrow/type.h
##
@@ -1604,13 +1605,26 @@ class ARROW_EXPORT FieldRef {
//
josiahyan opened a new pull request #8651:
URL: https://github.com/apache/arrow/pull/8651
…initializing Parquet writer when arrow::io::OutputStream::Tell() fails
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8649:
URL: https://github.com/apache/arrow/pull/8649#issuecomment-726156692
https://issues.apache.org/jira/browse/ARROW-10567
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #8650:
URL: https://github.com/apache/arrow/pull/8650#issuecomment-726156395
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
romainfrancois opened a new pull request #8650:
URL: https://github.com/apache/arrow/pull/8650
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
wesm opened a new pull request #8649:
URL: https://github.com/apache/arrow/pull/8649
I've found that these benchmarks have high variance on the Linux platforms
(Ubuntu 18.04-based) where I've tested, and increasing the number of iterations
of the test produces more precise results
pitrou commented on a change in pull request #7507:
URL: https://github.com/apache/arrow/pull/7507#discussion_r522162456
##
File path: cpp/src/arrow/type.h
##
@@ -1604,13 +1605,26 @@ class ARROW_EXPORT FieldRef {
//
pitrou commented on pull request #8585:
URL: https://github.com/apache/arrow/pull/8585#issuecomment-726122921
I meant a separate function, not a method. The host doesn't necessarily come
from a URI.
This is an automated
pitrou commented on pull request #8542:
URL: https://github.com/apache/arrow/pull/8542#issuecomment-726122152
Thanks for the updates. Can you look at the errors on CI and fix them?
Thanks!
This is an automated message from
alamb commented on a change in pull request #8401:
URL: https://github.com/apache/arrow/pull/8401#discussion_r522108476
##
File path: rust/arrow-c-integration/README.md
##
@@ -0,0 +1,57 @@
+
+
+# Arrow c integration
+
+This is a Rust crate that tests compatibility between
kszucs commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726088673
@kou enabled the workflow scope and it works now.
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726084117
Revision: 3488e1c6fc6b6d5393daa26549a3ea023a627512
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726083122
@github-actions crossbow submit wheel-win-cp38
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726078878
Revision: 3488e1c6fc6b6d5393daa26549a3ea023a627512
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726077812
@github-actions crossbow submit wheel-win-cp38
This is an automated message from the Apache Git Service.
To
alamb commented on pull request #8635:
URL: https://github.com/apache/arrow/pull/8635#issuecomment-726041730
Thanks again for this @vertexclique -- it is much appreciated
This is an automated message from the Apache Git
alamb closed pull request #8635:
URL: https://github.com/apache/arrow/pull/8635
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726029641
Revision: 3488e1c6fc6b6d5393daa26549a3ea023a627512
Submitted crossbow builds: [ursa-labs/crossbow @
pitrou closed pull request #8637:
URL: https://github.com/apache/arrow/pull/8637
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726028859
@github-actions crossbow submit wheel-win-cp38
This is an automated message from the Apache Git Service.
To
kszucs edited a comment on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726026294
> It's not a problem that `actions-XXX` branch doesn't have GitHub Actions
config.
> It's a problem that `actions-XXX-github-YYY` branch isn't created.
Correct.
kszucs commented on pull request #8386:
URL: https://github.com/apache/arrow/pull/8386#issuecomment-726026294
> It's not a problem that `actions-XXX` branch doesn't have GitHub Actions
config.
> It's a problem that `actions-XXX-github-YYY` branch isn't created.
Correct.
>
> It
1 - 100 of 113 matches
Mail list logo
