romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-697232130
This returns too early, I believe this needs to be `RETURN_NOT_OK` instead
of `return`:
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-697227723
I added some tests for `ReadRowGroup(s)()` and clarified about 0-based.
I'm getting a weird error in some cases with `ReadRowGroups()`:
``` r
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-696593899
The methods of `ParquetFileReader` no longer use tidyselect, i.e. you can
use `$ReadTable()` or `$ReadTable(column_indices)` with an 0-based integer
vector so this does
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-696593899
The methods of `ParquetFileReader` no longer use tidyselect, i.e. you can
use `$ReadTable()` or `$ReadTable(column_indices)` with an 0-based integer
vector so this does
romainfrancois commented on pull request #8122:
URL: https://github.com/apache/arrow/pull/8122#issuecomment-688284689
also, I guess `$ReadTable()` could either be simplified to only use column
indices (as in the C++ function)
```cpp
virtual ::arrow::Status ReadTable(const