[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-14 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r593899532 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -686,90 +815,124 @@ pub fn lexsort_to_indices(columns: &[SortColumn]) -> Result { };

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-14 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r593899532 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -686,90 +815,124 @@ pub fn lexsort_to_indices(columns: &[SortColumn]) -> Result { };

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-14 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r593899532 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -686,90 +815,124 @@ pub fn lexsort_to_indices(columns: &[SortColumn]) -> Result { };

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-06 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r588974704 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -37,10 +37,33 @@ use TimeUnit::*; /// Returns an `ArrowError::ComputeError(String)` if the

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-06 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r588964696 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -1560,7 +1891,14 @@ mod tests { Some(2), Some(17), ])) as

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-04 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r587330687 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -517,20 +650,32 @@ where }, ); -if !options.descending { -

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586975774 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586975774 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586975774 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586975774 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] sundy-li commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-01 Thread GitBox
sundy-li commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r585214440 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -36,8 +36,12 @@ use TimeUnit::*; /// /// Returns an `ArrowError::ComputeError(String)` if the