[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-10-22 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r510399380 ## File path: cpp/src/arrow/json/converter.cc ## @@ -123,13 +123,11 @@ class NumericConverter : public PrimitiveConverter {

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465751971 ## File path: cpp/src/arrow/util/formatting.cc ## @@ -36,38 +31,29 @@ const char digit_pairs[] = "6061626364656667686970717273747576777879"

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465750819 ## File path: cpp/src/arrow/util/formatting.cc ## @@ -36,38 +31,29 @@ const char digit_pairs[] = "6061626364656667686970717273747576777879"

[GitHub] [arrow] bkietz commented on a change in pull request #7901: ARROW-9543: [C++] Simplify parsing/formatting utilities

2020-08-05 Thread GitBox
bkietz commented on a change in pull request #7901: URL: https://github.com/apache/arrow/pull/7901#discussion_r465748964 ## File path: cpp/src/arrow/util/formatting.h ## @@ -40,12 +40,51 @@ namespace arrow { namespace internal { /// \brief The entry point for conversion to