[GitHub] [arrow] fsaintjacques commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-29 Thread GitBox
fsaintjacques commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r417348377 ## File path: python/pyarrow/_dataset.pyx ## @@ -270,19 +425,20 @@ cdef class FileSystemDataset(Dataset): CFileSystemDataset* filesystem_data

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-29 Thread GitBox
fsaintjacques commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r417218364 ## File path: cpp/src/arrow/scalar.cc ## @@ -252,6 +270,100 @@ Result> Scalar::Parse(const std::shared_ptr& t return ScalarParseImpl{type, s}.Fini

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-29 Thread GitBox
fsaintjacques commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r417218364 ## File path: cpp/src/arrow/scalar.cc ## @@ -252,6 +270,100 @@ Result> Scalar::Parse(const std::shared_ptr& t return ScalarParseImpl{type, s}.Fini

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-29 Thread GitBox
fsaintjacques commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r417240015 ## File path: python/pyarrow/_dataset.pyx ## @@ -270,19 +425,20 @@ cdef class FileSystemDataset(Dataset): CFileSystemDataset* filesystem_data