fsaintjacques commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r417240015
##########
File path: python/pyarrow/_dataset.pyx
##########
@@ -270,19 +425,20 @@ cdef class FileSystemDataset(Dataset):
CFileSystemDataset* filesystem_dataset
def __init__(self, paths_or_selector, schema=None, format=None,
- filesystem=None, partitions=None, root_partition=None):
+ filesystem=None, partitions=None, root_partition=_true):
Review comment:
Correct, expressions are not mutable, until they are because of a
refactor. The point is, this is an anti-pattern in python due to odd
side-effect of default argument behavior, on top of being non-idiomatic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
