[GitHub] [arrow] fsaintjacques commented on a change in pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
fsaintjacques commented on a change in pull request #7073: URL: https://github.com/apache/arrow/pull/7073#discussion_r418564299 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -83,131 +83,67 @@ Result FileFragment::Scan(std::shared_ptr options

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
fsaintjacques commented on a change in pull request #7073: URL: https://github.com/apache/arrow/pull/7073#discussion_r418556583 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -221,42 +157,34 @@ Result> FileSystemDataset::Write( filesystem = std::make_shared();

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
fsaintjacques commented on a change in pull request #7073: URL: https://github.com/apache/arrow/pull/7073#discussion_r418556583 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -221,42 +157,34 @@ Result> FileSystemDataset::Write( filesystem = std::make_shared();

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7073: ARROW-8318: [C++][Dataset] Construct FileSystemDataset from fragments

2020-05-01 Thread GitBox
fsaintjacques commented on a change in pull request #7073: URL: https://github.com/apache/arrow/pull/7073#discussion_r418554202 ## File path: cpp/src/arrow/dataset/file_base.cc ## @@ -83,131 +83,67 @@ Result FileFragment::Scan(std::shared_ptr options