[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r522327950 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -1058,6 +1058,22 @@ ArrayKernelExec

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r522327624 ## File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc ## @@ -153,6 +153,60 @@ void AddBasicFillNullKernels(ScalarKernel kernel,

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r522326005 ## File path: cpp/src/arrow/compute/kernels/codegen_internal.h ## @@ -1058,6 +1058,22 @@ ArrayKernelExec

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r522325504 ## File path: python/pyarrow/tests/test_compute.py ## @@ -860,6 +860,16 @@ def test_fill_null(): expected = pa.array([None, None, None, None])

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r520776198 ## File path: python/pyarrow/tests/test_compute.py ## @@ -860,6 +860,17 @@ def test_fill_null(): expected = pa.array([None, None, None, None])

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r520769300 ## File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc ## @@ -84,6 +84,52 @@ struct FillNullFunctor::value>> { } }; +template

[GitHub] [arrow] maartenbreddels commented on a change in pull request #8628: ARROW-9489: [C++] Add fill_null kernel implementation for (array[string], scalar[string])

maartenbreddels commented on a change in pull request #8628: URL: https://github.com/apache/arrow/pull/8628#discussion_r520701716 ## File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc ## @@ -84,6 +84,52 @@ struct FillNullFunctor::value>> { } }; +template