[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r492005479 ## File path: cpp/src/arrow/util/atomic_shared_ptr.h ## @@ -89,5 +89,25 @@ inline void atomic_store( *p = r; } +template +inline bool

[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r492006265 ## File path: cpp/src/arrow/type_traits.h ## @@ -22,7 +22,7 @@ #include #include -#include "arrow/type_fwd.h" +#include "arrow/type.h" Review

[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r492005479 ## File path: cpp/src/arrow/util/atomic_shared_ptr.h ## @@ -89,5 +89,25 @@ inline void atomic_store( *p = r; } +template +inline bool

[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r492005479 ## File path: cpp/src/arrow/util/atomic_shared_ptr.h ## @@ -89,5 +89,25 @@ inline void atomic_store( *p = r; } +template +inline bool

[GitHub] [arrow] pitrou commented on a change in pull request #8205: ARROW-9775: [C++] Automatic S3 region selection

pitrou commented on a change in pull request #8205: URL: https://github.com/apache/arrow/pull/8205#discussion_r489628588 ## File path: cpp/src/arrow/util/atomic_shared_ptr.h ## @@ -89,5 +89,25 @@ inline void atomic_store( *p = r; } +template Review comment: