[GitHub] [arrow] sunchao commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-12 Thread GitBox
sunchao commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-657268017 Merged. @andygrove feel free to leave comments in case you had time for a full review on this. I tagged this as 1.0.0 but not sure whether it can make it. ---

[GitHub] [arrow] sunchao commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
sunchao commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656889046 > The Rc version is used in a few places but again I don't think it's that important to use Rc over Arc. Agreed. I don't see any performance implication for this, as `schema

[GitHub] [arrow] sunchao commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
sunchao commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656802087 Thanks @paddyhoran . > It was mentioned on the JIRA that we could just use a single trait and allow users to implement Send/Sync as necessary. The fact the the schema method