sunchao commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656802087
Thanks @paddyhoran . > It was mentioned on the JIRA that we could just use a single trait and allow users to implement Send/Sync as necessary. The fact the the schema method returns a reference counted type makes this hard to do (Rc vs Arc) so I settled on two different traits. This seemed like the easiest to do in advance of 1.0, maybe we can improve on this. I think the `schema` method is already returning a `Arc<Schema>`, where is the `Rc` being used? IMHO if it is not too difficult to do we should consolidate on a single trait now instead of having to change it later again. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org