tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766361051
I'm still seeing a mix of inconsistent performance hits/bumps after the
rebase.
```
critcmp master-67d0c2e38 array-slice-83b8938af -t 10
group
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766288246
I've rebased locally and will be running benchmarks overnight.
This is an automated message from the Apache Git
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766153344
The 10% performance impact looks like mostly improvements:
```
critcmp master-499b6d0c array-slice-78f360b7c -t 10
group array-slice-78f360b7c
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-766105862
current 10% perf impact looks like:
```
critcmp master-499b6d0c array-slice-41c29bc4 -t 10
grouparray-slice-41c29bc4
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-764164139
Rebased. But I didn't hit the merge conflicts during... I can see that a
number of tests were swapped to use Buffer::from_slice_ref()... so I'll add
another commit to switch to
tyrelr commented on pull request #9215:
URL: https://github.com/apache/arrow/pull/9215#issuecomment-764164139
Rebased. But I didn't hit the merge conflicts during... I can see that a
number of tests were swapped to use Buffer::from_slice_ref()... so I'll add
another commit to switch to
