[GitHub] [beam] reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders

2020-03-25 Thread GitBox
reuvenlax commented on issue #10883: [BEAM-9331] Add better Row builders URL: https://github.com/apache/beam/pull/10883#issuecomment-604235650 Run Java PreCommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] y1chi removed a comment on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions

2020-03-25 Thread GitBox
y1chi removed a comment on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions URL: https://github.com/apache/beam/pull/10870#issuecomment-604231462 retest this please This is an automated message from

[GitHub] [beam] y1chi commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions

2020-03-25 Thread GitBox
y1chi commented on issue #10870: [BEAM-9263] Bump up sdk dataflow environment major versions URL: https://github.com/apache/beam/pull/10870#issuecomment-604231462 retest this please This is an automated message from the

[GitHub] [beam] Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
Hannah-Jiang commented on issue #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#issuecomment-604214566 I made following changes with Python scripts. 1. License files will not be checked in. They will be generated from scratch every time

[GitHub] [beam] Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies

2020-03-25 Thread GitBox
Hannah-Jiang commented on a change in pull request #11067: [BEAM-9136]Add licenses for dependencies URL: https://github.com/apache/beam/pull/11067#discussion_r398298311 ## File path: sdks/python/container/py2/build.gradle ## @@ -51,6 +51,11 @@ task

[GitHub] [beam] amaliujia commented on issue #11226: [BEAM-9557] Fix timer window boundary checking

2020-03-25 Thread GitBox
amaliujia commented on issue #11226: [BEAM-9557] Fix timer window boundary checking URL: https://github.com/apache/beam/pull/11226#issuecomment-604211801 Run Java PreCommit This is an automated message from the Apache Git

[GitHub] [beam] lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604195239 Run Java Flink PortableValidatesRunner Batch This is an

[GitHub] [beam] lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604196167 Run PythonLint PreCommit This is an automated message

[GitHub] [beam] lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik removed a comment on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604195288 Run Java Flink PortableValidatesRunner Streaming This is

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604198250 Run Java Flink PortableValidatesRunner Streaming This is an

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604198209 Run Java Flink PortableValidatesRunner Batch This is an automated

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604196167 Run PythonLint PreCommit This is an automated message from the

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604195239 Run Java Flink PortableValidatesRunner Batch This is an automated

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604195288 Run Java Flink PortableValidatesRunner Streaming This is an

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604194840 While this is getting reviewed, I'm going to start working on testing/updating the Google codebase to reflect this backwards

[GitHub] [beam] lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on issue #11184: [BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#issuecomment-604194556 R: @ajamato for Java/Python R: @lostluck for Go This is an

[GitHub] [beam] stale[bot] closed pull request #10369: [BEAM-8933] BigQueryIO Arrow for read

2020-03-25 Thread GitBox
stale[bot] closed pull request #10369: [BEAM-8933] BigQueryIO Arrow for read URL: https://github.com/apache/beam/pull/10369 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] stale[bot] commented on issue #10369: [BEAM-8933] BigQueryIO Arrow for read

2020-03-25 Thread GitBox
stale[bot] commented on issue #10369: [BEAM-8933] BigQueryIO Arrow for read URL: https://github.com/apache/beam/pull/10369#issuecomment-604193882 This pull request has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive

[GitHub] [beam] ibzib commented on issue #11214: [BEAM-9600] Move GetJobMetrics into superclass.

2020-03-25 Thread GitBox
ibzib commented on issue #11214: [BEAM-9600] Move GetJobMetrics into superclass. URL: https://github.com/apache/beam/pull/11214#issuecomment-604191652 This will need more work. Closing for now. This is an automated message

[GitHub] [beam] aaltay commented on a change in pull request #11232: [BEAM-8280] Document Python 3 annotations support

2020-03-25 Thread GitBox
aaltay commented on a change in pull request #11232: [BEAM-8280] Document Python 3 annotations support URL: https://github.com/apache/beam/pull/11232#discussion_r398281648 ## File path: website/src/documentation/sdks/python-type-safety.md ## @@ -64,22 +84,75 @@ To specify

[GitHub] [beam] ibzib closed pull request #11214: [BEAM-9600] Move GetJobMetrics into superclass.

2020-03-25 Thread GitBox
ibzib closed pull request #11214: [BEAM-9600] Move GetJobMetrics into superclass. URL: https://github.com/apache/beam/pull/11214 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ibzib closed pull request #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

2020-03-25 Thread GitBox
ibzib closed pull request #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

2020-03-25 Thread GitBox
ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604185790 Fix for root cause is in #11214, making this not so necessary. This is

[GitHub] [beam] lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398275201 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398275219 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398275209 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398275235 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -126,15 +134,18 @@

[GitHub] [beam] udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-604183688 I disabled the test; it still needs fixing (see bug for error)

[GitHub] [beam] lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lukecwik commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398273798 ## File path: model/pipeline/src/main/proto/metrics.proto ## @@ -52,38 +55,157 @@ message

[GitHub] [beam] udim merged pull request #11234: [BEAM-8078] Disable test_streaming_wordcount_it

2020-03-25 Thread GitBox
udim merged pull request #11234: [BEAM-8078] Disable test_streaming_wordcount_it URL: https://github.com/apache/beam/pull/11234 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] udim commented on issue #11234: [BEAM-8078] Disable test_streaming_wordcount_it

2020-03-25 Thread GitBox
udim commented on issue #11234: [BEAM-8078] Disable test_streaming_wordcount_it URL: https://github.com/apache/beam/pull/11234#issuecomment-604179290 R: @TheNeuralBit This is an automated message from the Apache Git Service.

[GitHub] [beam] udim opened a new pull request #11234: [BEAM-8078] Disable test_streaming_wordcount_it

2020-03-25 Thread GitBox
udim opened a new pull request #11234: [BEAM-8078] Disable test_streaming_wordcount_it URL: https://github.com/apache/beam/pull/11234 I mistakenly thought this test was passing when it wasn't and merged it. Thank you for your contribution! Follow

[GitHub] [beam] ibzib opened a new pull request #11233: Add notes to change log.

2020-03-25 Thread GitBox
ibzib opened a new pull request #11233: Add notes to change log. URL: https://github.com/apache/beam/pull/11233 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate

[GitHub] [beam] udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-604173860 Yeah, sorry about that. Got confused by the UI This is an

[GitHub] [beam] udim commented on issue #11232: [BEAM-8280] Document Python 3 annotations support

2020-03-25 Thread GitBox
udim commented on issue #11232: [BEAM-8280] Document Python 3 annotations support URL: https://github.com/apache/beam/pull/11232#issuecomment-604170679 R: @robertwb @aaltay This is an automated message from the Apache Git

[GitHub] [beam] udim opened a new pull request #11232: [BEAM-8280] Document Python 3 annotations support

2020-03-25 Thread GitBox
udim opened a new pull request #11232: [BEAM-8280] Document Python 3 annotations support URL: https://github.com/apache/beam/pull/11232 Also updates snippets, but since snippets are taken from Beam's Github repo from master please imagine they look like they do in this PR.

[GitHub] [beam] ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

2020-03-25 Thread GitBox
ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604169079 Tests are failing because in some places, `JobServiceStub` instead of `JobServiceServicer`. `JobServiceStub` does not accept the

[GitHub] [beam] lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK

2020-03-25 Thread GitBox
lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK URL: https://github.com/apache/beam/pull/11231#issuecomment-604162515 This code drifts slightly from https://github.com/apache/beam/pull/11184, which removes the OneOf in favour of always using the payload format. This

[GitHub] [beam] lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398253068 ## File path: model/pipeline/src/main/proto/metrics.proto ## @@ -52,38 +55,157 @@ message

[GitHub] [beam] lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK

2020-03-25 Thread GitBox
lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK URL: https://github.com/apache/beam/pull/11231#issuecomment-604159898 Run Go Postcommit This is an automated message from the Apache Git Service. To

[GitHub] [beam] lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK

2020-03-25 Thread GitBox
lostluck commented on issue #11231: [BEAM-4374] Shortids for the Go SDK URL: https://github.com/apache/beam/pull/11231#issuecomment-604159962 R: @lukecwik This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] lostluck opened a new pull request #11231: [BEAM-4374] Shortids for the Go SDK

2020-03-25 Thread GitBox
lostluck opened a new pull request #11231: [BEAM-4374] Shortids for the Go SDK URL: https://github.com/apache/beam/pull/11231 A quick unblocker for current proto changes. Adds Short ID handling for the Go SDK. There are likely some performance improvements that can go in around the

[GitHub] [beam] ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics.

2020-03-25 Thread GitBox
ibzib commented on issue #11213: [BEAM-9214] Add missing argument to GetJobMetrics. URL: https://github.com/apache/beam/pull/11213#issuecomment-604159640 > Could you elaborate on why this change is needed? @kamilwu Check out the

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-604156803 Run XVR_Spark PostCommit This is an automated message from the Apache Git

[GitHub] [beam] amaliujia commented on issue #11228: add @RequiresTimeSortedInput to CHANGES.md

2020-03-25 Thread GitBox
amaliujia commented on issue #11228: add @RequiresTimeSortedInput to CHANGES.md URL: https://github.com/apache/beam/pull/11228#issuecomment-604152735 LGTM This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] amaliujia merged pull request #11228: add @RequiresTimeSortedInput to CHANGES.md

2020-03-25 Thread GitBox
amaliujia merged pull request #11228: add @RequiresTimeSortedInput to CHANGES.md URL: https://github.com/apache/beam/pull/11228 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] amaliujia commented on issue #11228: add @RequiresTimeSortedInput to CHANGES.md

2020-03-25 Thread GitBox
amaliujia commented on issue #11228: add @RequiresTimeSortedInput to CHANGES.md URL: https://github.com/apache/beam/pull/11228#issuecomment-604152700 thanks! This is an automated message from the Apache Git Service. To

[GitHub] [beam] amaliujia commented on issue #11220: [BEAM-9573][release-2.20] Correct computing of watermark hold for timer output timestamp

2020-03-25 Thread GitBox
amaliujia commented on issue #11220: [BEAM-9573][release-2.20] Correct computing of watermark hold for timer output timestamp URL: https://github.com/apache/beam/pull/11220#issuecomment-604152523 @mxm any additional tests should run?

[GitHub] [beam] lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398239033 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398238942 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -126,15 +134,18 @@

[GitHub] [beam] lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398239079 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo.

2020-03-25 Thread GitBox
lostluck commented on a change in pull request #11184: [WIP][BEAM-4374] Update protos related to MonitoringInfo. URL: https://github.com/apache/beam/pull/11184#discussion_r398239127 ## File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go ## @@ -80,36 +84,40 @@

[GitHub] [beam] TheNeuralBit commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-604147467 This test seems to be failing on jenkins: https://builds.apache.org/job/beam_PostCommit_Python2/2057/

[GitHub] [beam] youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225#issuecomment-604145810 Btw, made a Jira for adding a test: BEAM-9611 This is an

[GitHub] [beam] robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java.

2020-03-25 Thread GitBox
robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java. URL: https://github.com/apache/beam/pull/11221#issuecomment-604145371 Run Python PreCommit This is an automated

[GitHub] [beam] robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java.

2020-03-25 Thread GitBox
robertwb commented on issue #11221: Add base SDK version to environment capabilities for Python and Java. URL: https://github.com/apache/beam/pull/11221#issuecomment-604145339 Run Java PreCommit This is an automated message

[GitHub] [beam] robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.

2020-03-25 Thread GitBox
robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator. URL: https://github.com/apache/beam/pull/11224#issuecomment-604145091 Run Java PreCommit This is an automated message from

[GitHub] [beam] robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator.

2020-03-25 Thread GitBox
robertwb commented on issue #11224: [BEAM-9340] Validate pipeline requirements in PipelineValidator. URL: https://github.com/apache/beam/pull/11224#issuecomment-604144495 Run Java PreCommit This is an automated message from

[GitHub] [beam] tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro

2020-03-25 Thread GitBox
tvalentyn commented on a change in pull request #11086: [BEAM-8910] Make custom BQ source read from Avro URL: https://github.com/apache/beam/pull/11086#discussion_r398232108 ## File path: sdks/python/apache_beam/io/gcp/bigquery_read_it_test.py ## @@ -236,11 +251,12 @@ def

[GitHub] [beam] youngoli merged pull request #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
youngoli merged pull request #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] pabloem commented on issue #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner

2020-03-25 Thread GitBox
pabloem commented on issue #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner URL: https://github.com/apache/beam/pull/11229#issuecomment-604139704 r: @robertwb I've added two classes under `execution`: - `FnApiExecutionContext`, which manages runner-related

[GitHub] [beam] tvalentyn closed pull request #10277: [BEAM-8575] Reenable passing VR tests.

2020-03-25 Thread GitBox
tvalentyn closed pull request #10277: [BEAM-8575] Reenable passing VR tests. URL: https://github.com/apache/beam/pull/10277 This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] robertwb commented on a change in pull request #11222: [BEAM-4150] Don't window PCollection coders.

2020-03-25 Thread GitBox
robertwb commented on a change in pull request #11222: [BEAM-4150] Don't window PCollection coders. URL: https://github.com/apache/beam/pull/11222#discussion_r398221421 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py ## @@ -882,66

[GitHub] [beam] lostluck merged pull request #11230: Update Go Protos

2020-03-25 Thread GitBox
lostluck merged pull request #11230: Update Go Protos URL: https://github.com/apache/beam/pull/11230 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [beam] lukecwik commented on issue #11230: Update Go Protos

2020-03-25 Thread GitBox
lukecwik commented on issue #11230: Update Go Protos URL: https://github.com/apache/beam/pull/11230#issuecomment-604128183 Still LGTM This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r398215206 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HttpHealthcareApiClient.java

[GitHub] [beam] lostluck opened a new pull request #11230: Update Go Protos

2020-03-25 Thread GitBox
lostluck opened a new pull request #11230: Update Go Protos URL: https://github.com/apache/beam/pull/11230 Catching up the go protos to the current head. Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r398200394 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] pabloem opened a new pull request #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner

2020-03-25 Thread GitBox
pabloem opened a new pull request #11229: [BEAM-9608] Increasing scope of context managers for FnApiRunner URL: https://github.com/apache/beam/pull/11229 **Please** add a meaningful description for your change here Thank you for your contribution!

[GitHub] [beam] pabloem merged pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem merged pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227 This is an automated message from the Apache Git

[GitHub] [beam] je-ik opened a new pull request #11228: add @RequiresTimeSortedInput to CHANGES.md

2020-03-25 Thread GitBox
je-ik opened a new pull request #11228: add @RequiresTimeSortedInput to CHANGES.md URL: https://github.com/apache/beam/pull/11228 Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r398200394 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
jaketf commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r398200394 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@ -0,0

[GitHub] [beam] lostluck commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
lostluck commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225#issuecomment-604107438 Run Go Postcommit This is an automated message from the

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604100957 Run Python PreCommit This is an

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099816 retest this please This is

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099693 retest this please This is an

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604099649 thanks Sam! This is an automated

[GitHub] [beam] brianlucier commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
brianlucier commented on a change in pull request #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#discussion_r398180848 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HL7v2IO.java ## @@

[GitHub] [beam] iemejia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB

2020-03-25 Thread GitBox
iemejia commented on a change in pull request #11028: BEAM-2546 Beam IO for InfluxDB URL: https://github.com/apache/beam/pull/11028#discussion_r397962741 ## File path: .test-infra/jenkins/job_PerformanceTests_InfluxDBIO_IT.groovy ## @@ -0,0 +1,54 @@ +/* + * Licensed to

[GitHub] [beam] rohdesamuel commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
rohdesamuel commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#discussion_r398175950 ## File path:

[GitHub] [beam] pabloem merged pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers

2020-03-25 Thread GitBox
pabloem merged pull request #11202: [BEAM-9608] Refactoring FnApiRunner to have more context managers URL: https://github.com/apache/beam/pull/11202 This is an automated message from the Apache Git Service. To respond to

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604080895 run java precommit This is an automated message from the Apache Git Service.

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604080851 run sql postcommit This is an automated message from the Apache Git Service.

[GitHub] [beam] lostluck edited a comment on issue #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lostluck edited a comment on issue #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#issuecomment-604071322 Not yet. @youngoli can handle that when the execution layer is submitted. Currently just the validation is in, without any way to execute.

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in

[GitHub] [beam] amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators

2020-03-25 Thread GitBox
amaliujia commented on a change in pull request #11204: [BEAM-9579] Fix numpy logic operators URL: https://github.com/apache/beam/pull/11204#discussion_r398151570 ## File path: CHANGES.md ## @@ -116,6 +116,7 @@ ## Bugfixes +* Fixed numpy operators in

[GitHub] [beam] chamikaramj commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment

2020-03-25 Thread GitBox
chamikaramj commented on issue #11039: [BEAM-9383] Staging Dataflow artifacts from environment URL: https://github.com/apache/beam/pull/11039#issuecomment-604072538 Retest this please This is an automated message from the

[GitHub] [beam] lostluck commented on issue #11211: Go changes for model updates.

2020-03-25 Thread GitBox
lostluck commented on issue #11211: Go changes for model updates. URL: https://github.com/apache/beam/pull/11211#issuecomment-604071322 Not yet. @youngoli can handle that when im the execution later is submitted. Currently just the validation is in, without any way to execute.

[GitHub] [beam] pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io

2020-03-25 Thread GitBox
pabloem commented on issue #11151: [BEAM-9468] Hl7v2 io URL: https://github.com/apache/beam/pull/11151#issuecomment-604060180 retest this please This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform

2020-03-25 Thread GitBox
TheNeuralBit commented on issue #10055: [BEAM-8603] Add Python SqlTransform URL: https://github.com/apache/beam/pull/10055#issuecomment-604052011 Run XVR_Flink PostCommit This is an automated message from the Apache Git

[GitHub] [beam] udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test

2020-03-25 Thread GitBox
udim commented on issue #10914: [BEAM-8078] streaming_wordcount_debugging.py is missing a test URL: https://github.com/apache/beam/pull/10914#issuecomment-604051436 Opened https://issues.apache.org/jira/browse/BEAM-9610 for the flaky postcommit test

[GitHub] [beam] pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on a change in pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#discussion_r398120887 ## File path:

[GitHub] [beam] pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
pabloem commented on issue #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227#issuecomment-604045227 retest this please This is an

[GitHub] [beam] rohdesamuel opened a new pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature

2020-03-25 Thread GitBox
rohdesamuel opened a new pull request #11227: [BEAM-9601] Skip the streaming wordcount test because it uses a Python3.5.3+ feature URL: https://github.com/apache/beam/pull/11227 Change-Id: I9caaf395fd0fc58565e54a8458e8289af761815f The InteractiveRunner requires Python3.5.3+. We have

[GitHub] [beam] steveniemitz commented on issue #11226: [BEAM-9557] Fix timer window boundary checking

2020-03-25 Thread GitBox
steveniemitz commented on issue #11226: [BEAM-9557] Fix timer window boundary checking URL: https://github.com/apache/beam/pull/11226#issuecomment-604042702 can we add a unit test to validate this behavior as well? This is

[GitHub] [beam] reuvenlax opened a new pull request #11226: [BEAM-9557] Fix timer window boundary checking

2020-03-25 Thread GitBox
reuvenlax opened a new pull request #11226: [BEAM-9557] Fix timer window boundary checking URL: https://github.com/apache/beam/pull/11226 R: @steveniemitz This is an automated message from the Apache Git Service. To respond

[GitHub] [beam] apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2

2020-03-25 Thread GitBox
apilloud commented on issue #11223: [BEAM-9609] Upgrade to ZetaSQL 2020.03.2 URL: https://github.com/apache/beam/pull/11223#issuecomment-604034756 run sql postcommit This is an automated message from the Apache Git Service.

[GitHub] [beam] youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec.

2020-03-25 Thread GitBox
youngoli commented on issue #11225: [BEAM-3301] Fix another bug in DoFn validation, in exec. URL: https://github.com/apache/beam/pull/11225#issuecomment-604033853 R: @lostluck As a note for the future, does it seem valuable to add an integration test that catches this case? It

  1   2   >