youngoli merged pull request #11763:
URL: https://github.com/apache/beam/pull/11763
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031586
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031469
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429031354
##
File path: runners/portability/java/build.gradle
##
@@ -31,9 +45,123 @@ dependencies {
compile project(path: ":sdks:java:harness",
kennknowles commented on a change in pull request #11792:
URL: https://github.com/apache/beam/pull/11792#discussion_r429029786
##
File path: runners/portability/java/build.gradle
##
@@ -1,3 +1,13 @@
+import groovy.json.JsonOutput
+
+import java.nio.file.FileSystems
Review
kennknowles opened a new pull request #11792:
URL: https://github.com/apache/beam/pull/11792
WIP! Do not merge. (it is harmless but not successful)
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
youngoli commented on a change in pull request #11763:
URL: https://github.com/apache/beam/pull/11763#discussion_r429026079
##
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF)
youngoli commented on a change in pull request #11763:
URL: https://github.com/apache/beam/pull/11763#discussion_r429025895
##
File path: sdks/go/pkg/beam/io/rtrackers/offsetrange/offsetrange_test.go
##
@@ -0,0 +1,212 @@
+// Licensed to the Apache Software Foundation (ASF)
youngoli commented on pull request #11791:
URL: https://github.com/apache/beam/pull/11791#issuecomment-632451757
For reference, the tests I'm trying to match:
https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/worker/bundle_processor_test.py#L61
youngoli commented on pull request #11791:
URL: https://github.com/apache/beam/pull/11791#issuecomment-632451211
R: @lostluck
CC: @robertwb @lukecwik @boyuanzz
This is an automated message from the Apache Git Service.
youngoli opened a new pull request #11791:
URL: https://github.com/apache/beam/pull/11791
Adds code to more closely align with the implementations of splitting in
Python and Java. Note that not all cases are implemented. There is no
measurement of sub-element progress yet, nor is
darshanj commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632447130
@apilloud @aaltay Looks like passing a class instead of partitionFn makes
Partition Transform unserializable. I have reverted that changes for
suggestion. Serializing a
epicfaace opened a new pull request #11790:
URL: https://github.com/apache/beam/pull/11790
[draft - in progress]
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ]
epicfaace opened a new pull request #11789:
URL: https://github.com/apache/beam/pull/11789
Fix typo. R: @pabloem
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
epicfaace opened a new pull request #11788:
URL: https://github.com/apache/beam/pull/11788
Add Python 3.8 postcommit tests.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632437689
Staged site:
http://apache-beam-website-pull-requests.storage.googleapis.com/11780/community/mascot/index.html
aijamalnk commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632437739
@iemejia could you review please?
This is an automated message from the Apache Git Service.
To respond to the
iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632434300
Thanks for answering and for the clear explaination @boyuanzz
I would have tended towards having the additional complexity in
`OffsetRangeTracker` just because it is the
udim commented on pull request #11070:
URL: https://github.com/apache/beam/pull/11070#issuecomment-632433800
I've squashed the commits to more easily rename the file. Optimistically
merging by May 26! :)
This is an
udim commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r428996230
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date: 2020-03-06
udim commented on a change in pull request #11070:
URL: https://github.com/apache/beam/pull/11070#discussion_r428993726
##
File path: website/src/_posts/2020-03-06-python-typing.md
##
@@ -0,0 +1,117 @@
+---
+layout: post
+title: "Python SDK Typing Changes"
+date: 2020-03-06
robertwb opened a new pull request #11787:
URL: https://github.com/apache/beam/pull/11787
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
TheNeuralBit commented on pull request #11786:
URL: https://github.com/apache/beam/pull/11786#issuecomment-632412040
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit opened a new pull request #11786:
URL: https://github.com/apache/beam/pull/11786
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink |
robertwb commented on pull request #11785:
URL: https://github.com/apache/beam/pull/11785#issuecomment-632408257
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb opened a new pull request #11785:
URL: https://github.com/apache/beam/pull/11785
It's not a perfect signal, but will still cover a lot of doctests.
(It's also a bit hacky, but the TestRunner doesn't offer very good hooks for
customization here.)
boyuanzz commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632408026
> What is the intrinsic limitation that did not allow old
`OffsetRangeTracker` to be refactored for this use case? or why we want to have
both?
>
ibzib commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-632405988
> Yes we probably need those jenkins uber jobs (Flink too). Other use case
where this script proves really handy would be users asking committers to
trigger tests, maybe worth to
iemejia commented on pull request #11755:
URL: https://github.com/apache/beam/pull/11755#issuecomment-632404805
Yes we probably need those jenkins uber jobs (Flink too). Other use case
where this script proves really handy would be users asking committers to
trigger tests, maybe worth to
ibzib commented on pull request #11784:
URL: https://github.com/apache/beam/pull/11784#issuecomment-632403660
Run Java Spark PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To respond
ibzib opened a new pull request #11784:
URL: https://github.com/apache/beam/pull/11784
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
chamikaramj merged pull request #11771:
URL: https://github.com/apache/beam/pull/11771
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
iemejia commented on pull request #11715:
URL: https://github.com/apache/beam/pull/11715#issuecomment-632402839
Now that this is merged. Can I ask a question. What is the intrinsic
limitation that did not allow old `OffsetRangeTracker` to be refactored for
this use case? or why we want to
angoenka merged pull request #11783:
URL: https://github.com/apache/beam/pull/11783
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632400825
Tests passed
This is an automated message from the Apache Git Service.
To respond to the message, please log on
aaltay commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-632398599
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb closed pull request #11608:
URL: https://github.com/apache/beam/pull/11608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #11632:
URL: https://github.com/apache/beam/pull/11632#issuecomment-632398759
Ping.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632397951
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632396377
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632390617
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
robertwb commented on a change in pull request #11765:
URL: https://github.com/apache/beam/pull/11765#discussion_r428960780
##
File path: sdks/python/apache_beam/transforms/ptransform.py
##
@@ -270,11 +256,19 @@ def get_named_nested_pvalues(pvalueish):
tagged_values =
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632382830
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj merged pull request #11360:
URL: https://github.com/apache/beam/pull/11360
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632381115
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on pull request #11610:
URL: https://github.com/apache/beam/pull/11610#issuecomment-632377843
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #10165:
URL: https://github.com/apache/beam/pull/10165#issuecomment-632377660
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632372278
Thanks!
Will wait for the tests to pass.
This is an automated message from the Apache Git Service.
To
tvalentyn commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632371565
LGTM if tests pass.
This is an automated message from the Apache Git Service.
To respond to the message,
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632370504
R: @ibzib
This is an automated message from the Apache Git Service.
To respond to the message, please log on
angoenka commented on pull request #11783:
URL: https://github.com/apache/beam/pull/11783#issuecomment-632370590
R: @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message, please log
angoenka opened a new pull request #11783:
URL: https://github.com/apache/beam/pull/11783
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
TheNeuralBit merged pull request #11625:
URL: https://github.com/apache/beam/pull/11625
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632361896
Java precommit failed in the last 2 runs. Could you look at the logs? Is it
related to this change?
This is an
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632350790
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632349170
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632347848
LGTM. Thanks.
Ran the Kafka test few times and it seems to be working.
This is an automated message
lukecwik commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632342320
Test coverage is by existing IOs that enable these features which we don't
have enough of in Beam (since it requires portable runners to implement SDF to
a greater extent then
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632335832
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632335607
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632335448
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
reuvenlax commented on a change in pull request #11456:
URL: https://github.com/apache/beam/pull/11456#discussion_r428901750
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/logicaltypes/MillisInstant.java
##
@@ -0,0 +1,44 @@
+/*
+ * Licensed to the
robinyqiu commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632331823
> are there any tests that use the DATE Type in an aggregation (e.g. MAX)?
No. Thanks for bringing this up. I think it is likely to run into the
problem.
apilloud commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632330703
Interesting question. You should probably add a test for JOIN as well, which
will have a similar class of problems.
TheNeuralBit edited a comment on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533
Something just occurred to me - are there any tests that use the DATE Type
in an aggregation (e.g. MAX)?
I'd think that would run into the same issue I have in
TheNeuralBit commented on pull request #11272:
URL: https://github.com/apache/beam/pull/11272#issuecomment-632327533
Something just occurred to me - are there any tests that use the DATE Type
in an aggregation (e.g. MAX)?
I'd think that would run into the same issue I have in #11456
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632318843
Got it, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632314627
I'm doing a manual validation for now.
This is an automated message from the Apache Git Service.
To respond
chamikaramj commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632314521
I suspect test coverage will be internal to Dataflow (hence during import).
This is an automated message
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632313262
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #11682:
URL: https://github.com/apache/beam/pull/11682#issuecomment-632313052
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on a change in pull request #11086:
URL: https://github.com/apache/beam/pull/11086#discussion_r428877884
##
File path: sdks/python/apache_beam/io/gcp/bigquery.py
##
@@ -610,7 +611,8 @@ def __init__(
coder=None,
use_standard_sql=False,
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632309156
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
lostluck opened a new pull request #11782:
URL: https://github.com/apache/beam/pull/11782
We were a bit too strict for CoGBKs with multiple value streams with
Structural DoFns. This PR expands the validation to support precise validation
at construction time, and relaxes the execution
lostluck commented on pull request #11782:
URL: https://github.com/apache/beam/pull/11782#issuecomment-632304959
R: @youngoli
This is an automated message from the Apache Git Service.
To respond to the message, please log
TheNeuralBit commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632304060
Is there any test coverage of this?
This is an automated message from the Apache Git Service.
To respond to
lukecwik commented on pull request #11781:
URL: https://github.com/apache/beam/pull/11781#issuecomment-632303098
R: @ihji @chamikaramj
CC: @TheNeuralBit (cherry pick into 2.22)
This is an automated message from the
lukecwik opened a new pull request #11781:
URL: https://github.com/apache/beam/pull/11781
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
rohdesamuel commented on pull request #11745:
URL: https://github.com/apache/beam/pull/11745#issuecomment-632301124
R: @pabloem thanks Pablo!
This is an automated message from the Apache Git Service.
To respond to the
rohdesamuel commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-632299883
R: @robertwb
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11780:
URL: https://github.com/apache/beam/pull/11780#issuecomment-632296533
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit commented on pull request #11770:
URL: https://github.com/apache/beam/pull/11770#issuecomment-632296307
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib merged pull request #11764:
URL: https://github.com/apache/beam/pull/11764
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aijamalnk opened a new pull request #11780:
URL: https://github.com/apache/beam/pull/11780
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632279237
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632278144
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11086:
URL: https://github.com/apache/beam/pull/11086#issuecomment-632277003
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
udim commented on a change in pull request #11661:
URL: https://github.com/apache/beam/pull/11661#discussion_r428838484
##
File path: sdks/python/test-suites/dataflow/common.gradle
##
@@ -109,4 +109,21 @@ task validatesRunnerStreamingTests {
args '-c', ".
kmjung commented on pull request #11580:
URL: https://github.com/apache/beam/pull/11580#issuecomment-632272486
The next step is to merge this PR, I believe. I don't believe there's
anything blocking other than a review from @chamikaramj.
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632271987
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
chamikaramj commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632272181
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay commented on pull request #11580:
URL: https://github.com/apache/beam/pull/11580#issuecomment-632271494
@kmjung - What is the next step for this PR?
This is an automated message from the Apache Git Service.
To respond
aaltay commented on pull request #8457:
URL: https://github.com/apache/beam/pull/8457#issuecomment-632270901
There are still failing tests on https://github.com/apache/beam/pull/11295.
@mf2199 - What is the next step for this PR?
tedromer opened a new pull request #11779:
URL: https://github.com/apache/beam/pull/11779
Add --region to python examples where it was missing.
R: ibzib
This is an automated message from the Apache Git Service.
To
TheNeuralBit commented on pull request #11778:
URL: https://github.com/apache/beam/pull/11778#issuecomment-632260642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
veblush opened a new pull request #11778:
URL: https://github.com/apache/beam/pull/11778
Backport of #11651
CC: @theneuralbit
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
ihji commented on pull request #11771:
URL: https://github.com/apache/beam/pull/11771#issuecomment-632251342
> WDYT about [ihji#1](https://github.com/ihji/beam/pull/1) ?
> (only change is to Environments.java other changes should go away if you
rebase)
It will add 36 characters +
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632251027
Run Java Flink PortableValidatesRunner Batch
This is an automated message from the Apache Git Service.
To
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632250772
retest all please
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz commented on pull request #11756:
URL: https://github.com/apache/beam/pull/11756#issuecomment-632250883
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
1 - 100 of 156 matches
Mail list logo
