henryken commented on a change in pull request #11883:
URL: https://github.com/apache/beam/pull/11883#discussion_r434997866
##
File path: learning/katas/go/Core Transforms/Combine/CombineFn/pkg/task/task.go
##
@@ -0,0 +1,55 @@
+// Licensed to the Apache Software Foundation
robertwb commented on pull request #11835:
URL: https://github.com/apache/beam/pull/11835#issuecomment-638591806
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
robertwb commented on pull request #11835:
URL: https://github.com/apache/beam/pull/11835#issuecomment-638591762
Run Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
lukecwik merged pull request #11917:
URL: https://github.com/apache/beam/pull/11917
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on a change in pull request #11495:
URL: https://github.com/apache/beam/pull/11495#discussion_r434945430
##
File path: sdks/python/apache_beam/options/pipeline_options.py
##
@@ -425,6 +425,24 @@ def _add_argparse_args(cls, parser):
help='Whether
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-638545151
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on pull request #11916:
URL: https://github.com/apache/beam/pull/11916#issuecomment-638541628
Last time someone started adding this feature, we decided to call it
ReadModifyWrite state.
This is an
TheNeuralBit edited a comment on pull request #11917:
URL: https://github.com/apache/beam/pull/11917#issuecomment-638530705
I grepped the build.gradle files to look for any other instances of adding
the direct runner as a dependency dynamically, and couldn't find anything else:
```
TheNeuralBit commented on pull request #11917:
URL: https://github.com/apache/beam/pull/11917#issuecomment-638530705
I grepped the build.gradle files to look for any other instances of adding
the direct runner as a dependency dynamically, and couldn't find anything else:
```
❯
TheNeuralBit opened a new pull request #11917:
URL: https://github.com/apache/beam/pull/11917
R: @lukecwik
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex |
y1chi opened a new pull request #11916:
URL: https://github.com/apache/beam/pull/11916
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
y1chi commented on pull request #11916:
URL: https://github.com/apache/beam/pull/11916#issuecomment-638528628
R: @angoenka @robertwb
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia merged pull request #11895:
URL: https://github.com/apache/beam/pull/11895
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
TheNeuralBit commented on a change in pull request #11787:
URL: https://github.com/apache/beam/pull/11787#discussion_r434919303
##
File path: sdks/python/apache_beam/dataframe/doctests.py
##
@@ -66,30 +93,19 @@ def __init__(self):
self._all_frames = {}
def
xinyuiscool commented on pull request #11915:
URL: https://github.com/apache/beam/pull/11915#issuecomment-638522514
Sure, I will take a look.
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on a change in pull request #11766:
URL: https://github.com/apache/beam/pull/11766#discussion_r434916844
##
File path: sdks/python/apache_beam/dataframe/expressions.py
##
@@ -85,16 +87,10 @@ def evaluate_at(self, session): # type: (Session) -> T
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-638516729
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-638514897
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib merged pull request #11914:
URL: https://github.com/apache/beam/pull/11914
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Zhangyx39 commented on pull request #11915:
URL: https://github.com/apache/beam/pull/11915#issuecomment-638497048
@xinyuiscool would you like to take a look at this pr?
This is an automated message from the Apache Git
Zhangyx39 opened a new pull request #11915:
URL: https://github.com/apache/beam/pull/11915
Samza runner heavily uses MetricKey.toString() and MetricName.toString() to
update Samza metrics. We found that the toString methods have high CPU cost.
And according to this article:
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434890835
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##
@@ -817,6 +847,24 @@ public void setValueDeserializer(String
damondouglas commented on pull request #11883:
URL: https://github.com/apache/beam/pull/11883#issuecomment-638488229
@lostluck I was waiting on @henryken approval. Should I just go ahead and
update stepik and commit the `*-remote.yaml` to this PR?
vmarquez commented on a change in pull request #10546:
URL: https://github.com/apache/beam/pull/10546#discussion_r434870508
##
File path:
sdks/java/io/cassandra/src/main/java/org/apache/beam/sdk/io/cassandra/CassandraIO.java
##
@@ -1170,4 +898,44 @@ private void
ibzib commented on a change in pull request #11739:
URL: https://github.com/apache/beam/pull/11739#discussion_r434869939
##
File path:
sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/ParDoTest.java
##
@@ -3539,6 +3539,7 @@ public void onTimer() {}
@Category({
lostluck commented on pull request #11883:
URL: https://github.com/apache/beam/pull/11883#issuecomment-638471588
@damondouglas Has stepik been updated? Is this clear to merge?
This is an automated message from the Apache Git
lostluck merged pull request #11881:
URL: https://github.com/apache/beam/pull/11881
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434850943
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
KevinGG commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-638458752
> Run Java PreCommit
Thanks Pablo!
This is an automated message from the Apache Git Service.
To respond
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-638457890
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-638458169
I'm ready to merge. I jsut want to confirm whether the Fhir import test is
flaky, or if you've fixed it in your last commit? @jaketf
pabloem merged pull request #11896:
URL: https://github.com/apache/beam/pull/11896
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
TheNeuralBit commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434847753
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
ibzib commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434844066
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
chamikaramj commented on pull request #11846:
URL: https://github.com/apache/beam/pull/11846#issuecomment-638451041
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #11914:
URL: https://github.com/apache/beam/pull/11914#discussion_r434840793
##
File path: release/src/main/scripts/build_release_candidate.sh
##
@@ -106,9 +106,7 @@ if [[ $confirmation = "y" ]]; then
ibzib opened a new pull request #11914:
URL: https://github.com/apache/beam/pull/11914
R: @TheNeuralBit @amaliujia
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ]
boyuanzz commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-638439090
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on pull request #11912:
URL: https://github.com/apache/beam/pull/11912#issuecomment-638439054
R: @angoenka
This is an automated message from the Apache Git Service.
To respond to the message, please log
robertwb commented on pull request #11913:
URL: https://github.com/apache/beam/pull/11913#issuecomment-638438893
R: @kennknowles
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb opened a new pull request #11913:
URL: https://github.com/apache/beam/pull/11913
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
robertwb opened a new pull request #11912:
URL: https://github.com/apache/beam/pull/11912
The Java portable runner only fetches messages and looks for errors after
the pipeline returns failure.
Thank you for your contribution! Follow this checklist
chamikaramj commented on pull request #11911:
URL: https://github.com/apache/beam/pull/11911#issuecomment-638427486
Retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
chamikaramj commented on pull request #11911:
URL: https://github.com/apache/beam/pull/11911#issuecomment-638427096
R: @lukecwik
This is an automated message from the Apache Git Service.
To respond to the message, please
chamikaramj opened a new pull request #11911:
URL: https://github.com/apache/beam/pull/11911
Send an error to the runner for certain split and progress request failures.
This is needed to prevent runner from waiting unnecessarily and timing out
for progress and split requests that
amaliujia commented on pull request #11895:
URL: https://github.com/apache/beam/pull/11895#issuecomment-638424051
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638416678
Run PythonLint PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #11904:
URL: https://github.com/apache/beam/pull/11904#discussion_r434800889
##
File path: website/www/site/content/en/get-started/downloads.md
##
@@ -87,6 +87,13 @@ versions denoted `0.x.y`.
## Releases
+### 2.22.0
TheNeuralBit merged pull request #11903:
URL: https://github.com/apache/beam/pull/11903
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on pull request #11903:
URL: https://github.com/apache/beam/pull/11903#issuecomment-638410392
CI failure is unrelated. I'll go ahead and merge.
This is an automated message from the Apache Git Service.
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638403555
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638403708
thanks @chunyang ! this LGTM. I'll merge after lint passes
This is an automated message from the Apache Git
TheNeuralBit merged pull request #11900:
URL: https://github.com/apache/beam/pull/11900
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on a change in pull request #11910:
URL: https://github.com/apache/beam/pull/11910#discussion_r434786163
##
File path: website/www/site/content/en/blog/beam-2.22.0.md
##
@@ -0,0 +1,53 @@
+---
+title: "Apache Beam 2.21.0"
+date: 2020-05-27 00:00:01
TheNeuralBit opened a new pull request #11910:
URL: https://github.com/apache/beam/pull/11910
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink |
aaltay commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-638395828
Could we make it such that:
- we have a cron job that builds nightly (like a snapshot release)
- and a way to manually trigger this from the release branch, so that the
tvalentyn commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r434779681
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
TheNeuralBit commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434772179
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -74,3 +77,8 @@ def __init__(self, query, dialect=None):
thinhha commented on pull request #11873:
URL: https://github.com/apache/beam/pull/11873#issuecomment-638380598
Thanks @lukecwik. I've updated the change.
I thought I had changed it back to your suggestion before!
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434766297
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434746269
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIOUtils.java
##
@@ -0,0 +1,146 @@
+/*
+ * Licensed to the Apache
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434745710
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##
@@ -906,19 +955,110 @@ public void
aromanenko-dev commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-638348082
Also, please, take a look on SpotBugs issues.
This is an automated message from the Apache Git Service.
aromanenko-dev commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434717019
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##
@@ -817,6 +847,24 @@ public void
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434739659
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
robertwb commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434734464
##
File path: sdks/python/apache_beam/typehints/opcodes.py
##
@@ -120,7 +120,7 @@ def get_iter(state, unused_arg):
def symmetric_binary_op(state,
robertwb commented on a change in pull request #11901:
URL: https://github.com/apache/beam/pull/11901#discussion_r434734784
##
File path: sdks/python/apache_beam/transforms/sql.py
##
@@ -74,3 +77,8 @@ def __init__(self, query, dialect=None):
robertwb commented on a change in pull request #11835:
URL: https://github.com/apache/beam/pull/11835#discussion_r434730606
##
File path: sdks/python/apache_beam/transforms/trigger_test.py
##
@@ -518,6 +519,28 @@ def format_result(k_v):
'B-3': {10, 15, 16},
aaltay commented on a change in pull request #11877:
URL: https://github.com/apache/beam/pull/11877#discussion_r434724157
##
File path: .github/workflows/build_wheels.yml
##
@@ -0,0 +1,141 @@
+name: Build python wheels
+
+on:
+ push:
+branches:
+ - master
+ -
tysonjh commented on a change in pull request #11856:
URL: https://github.com/apache/beam/pull/11856#discussion_r434721022
##
File path: .test-infra/jenkins/job_LoadTests_SideInput_Python.groovy
##
@@ -0,0 +1,187 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF)
ibzib commented on pull request #11902:
URL: https://github.com/apache/beam/pull/11902#issuecomment-638332379
> Do you think its worth filing a jira to track that?
I don't think so. The release _is_ signed, by the release manager's Apache
email, which may or may not be the same as
mik-laj commented on pull request #11331:
URL: https://github.com/apache/beam/pull/11331#issuecomment-638324836
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit commented on pull request #11902:
URL: https://github.com/apache/beam/pull/11902#issuecomment-638319768
Do you think its worth filing a jira to track that?
This is an automated message from the Apache Git
pabloem commented on pull request #11898:
URL: https://github.com/apache/beam/pull/11898#issuecomment-638315417
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-638315244
A test seems to be flaky?
https://builds.apache.org/job/beam_PostCommit_Java_PR/394/
https://builds.apache.org/job/beam_PostCommit_Java_PR/395/
pabloem commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-638314655
Run Java PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638314463
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib merged pull request #11907:
URL: https://github.com/apache/beam/pull/11907
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mwalenia merged pull request #11331:
URL: https://github.com/apache/beam/pull/11331
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638310807
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
chunyang commented on pull request #11896:
URL: https://github.com/apache/beam/pull/11896#issuecomment-638301892
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
nfisher commented on pull request #11732:
URL: https://github.com/apache/beam/pull/11732#issuecomment-638299088
@echauchot sorry little crazy with work at the moment. Was hoping to get to
the remainder of it this weekend.
iemejia commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434666700
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
iemejia commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434666700
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
iemejia commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434666700
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
iemejia commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434666700
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
iemejia commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r434666700
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/ReadFromKafkaViaSDF.java
##
@@ -0,0 +1,697 @@
+/*
+ * Licensed to the Apache
kamilwu commented on pull request #11909:
URL: https://github.com/apache/beam/pull/11909#issuecomment-638261657
R: @iemejia @mxm Let me know what do you think. I put a link to dashboards
in the description.
Our InfluxDB has yearly retention policy, which means data older than one
kamilwu opened a new pull request #11909:
URL: https://github.com/apache/beam/pull/11909
Adds Grafana dashboards for Nexmark tests.
Dashboards can be previewed on http://metrics.beam.apache.org
Thank you for your contribution! Follow this checklist
jaketf commented on pull request #11893:
URL: https://github.com/apache/beam/pull/11893#issuecomment-638253812
looks like post commit got stuck in the queue
This is an automated message from the Apache Git Service.
To
TobKed edited a comment on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-638238507
cc @kamilwu @damgad @aaltay @tysonjh
This is an automated message from the Apache Git Service.
To respond
TobKed commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-638238507
cc @kamilwu @damgad @aaltay
This is an automated message from the Apache Git Service.
To respond to the message,
echauchot commented on pull request #11732:
URL: https://github.com/apache/beam/pull/11732#issuecomment-638214566
@nfisher you seem to lack time, don't worry I'll do the final touches. I
will manually merge your commit to master alongside with one of my own and
close the PR
rmannibucau commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-638200730
@iemejia yes and no, 1. it is quite clear in europe and affects US based
entities + 2 ASF can't justify to need this file (side note: it can trivially
be replaced by GH API
mxm commented on a change in pull request #11889:
URL: https://github.com/apache/beam/pull/11889#discussion_r434568958
##
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkBatchTransformTranslators.java
##
@@ -476,16 +476,15 @@ public void
mxm merged pull request #11889:
URL: https://github.com/apache/beam/pull/11889
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
iemejia commented on pull request #11886:
URL: https://github.com/apache/beam/pull/11886#issuecomment-638194592
For extra info the discussion on `privacy-discuss@` on how to handle these
cases (conclusion nothing is clear and we do not have real ASF recommendations
yet)
iemejia merged pull request #11908:
URL: https://github.com/apache/beam/pull/11908
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
iemejia opened a new pull request #11908:
URL: https://github.com/apache/beam/pull/11908
R: @mwalenia
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
iemejia commented on pull request #11908:
URL: https://github.com/apache/beam/pull/11908#issuecomment-638176382
Staged site:
http://apache-beam-website-pull-requests.storage.googleapis.com/11908/community/mascot/index.html
1 - 100 of 133 matches
Mail list logo
