lostluck commented on pull request #11870:
URL: https://github.com/apache/beam/pull/11870#issuecomment-642414004
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lostluck commented on a change in pull request #11976:
URL: https://github.com/apache/beam/pull/11976#discussion_r438475207
##
File path: sdks/go/pkg/beam/core/util/reflectx/functions_test.go
##
@@ -41,3 +45,19 @@ func TestLoadFunction(t *testing.T) {
rezarokni commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-642368157
@reuvenlax @pabloem
The latest commit covers most of the points now, with the exception of the
three open questions I raised.
- Return of the Schema that failed.
rezarokni commented on a change in pull request #11929:
URL: https://github.com/apache/beam/pull/11929#discussion_r438508022
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java
##
@@ -116,4 +131,267 @@ private ObjectMapper objectMapper() {
rezarokni commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-642367042
@TheNeuralBit If you have time, would be great if you could scan the
ParseResult and see if the API would suite all the things PubSubIO needs.
ibzib commented on pull request #11987:
URL: https://github.com/apache/beam/pull/11987#issuecomment-642360956
R: @aaltay @udim
This is an automated message from the Apache Git Service.
To respond to the message, please log
ibzib commented on pull request #11977:
URL: https://github.com/apache/beam/pull/11977#issuecomment-642359468
Thanks for doing this Kenn.
Another one:
ibzib opened a new pull request #11987:
URL: https://github.com/apache/beam/pull/11987
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
youngoli commented on a change in pull request #11870:
URL: https://github.com/apache/beam/pull/11870#discussion_r438490190
##
File path: sdks/go/pkg/beam/testing/passert/count.go
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
TheNeuralBit commented on pull request #11985:
URL: https://github.com/apache/beam/pull/11985#issuecomment-642346883
R: @chamikaramj
This is an automated message from the Apache Git Service.
To respond to the message,
youngoli opened a new pull request #11986:
URL: https://github.com/apache/beam/pull/11986
This transform counts the number of elements in a PTransform.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
youngoli commented on pull request #11986:
URL: https://github.com/apache/beam/pull/11986#issuecomment-642346309
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
TheNeuralBit opened a new pull request #11985:
URL: https://github.com/apache/beam/pull/11985
I'm seeing occasional timeouts when TestPubsub creates a subscription. It
looks like the [official pubsub
ibzib edited a comment on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642336725
PythonDocker is failing with a license issue:
```
File "/tmp/license_scripts/pull_licenses_py.py", line 149, in
py_ver=py_ver,
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642340383
Run PythonDocker PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
codeBehindMe commented on pull request #11976:
URL: https://github.com/apache/beam/pull/11976#issuecomment-642339945
R: @damondouglas
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642336725
I'm getting a weird license issue too:
```
File "/tmp/license_scripts/pull_licenses_py.py", line 149, in
py_ver=py_ver,
TheNeuralBit opened a new pull request #11984:
URL: https://github.com/apache/beam/pull/11984
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex | Dataflow | Flink | Samza
TheNeuralBit commented on pull request #11984:
URL: https://github.com/apache/beam/pull/11984#issuecomment-642335762
R: @reuvenlax
This is an automated message from the Apache Git Service.
To respond to the message, please
ibzib opened a new pull request #11983:
URL: https://github.com/apache/beam/pull/11983
I also yapf'd it while I was at it.
R: @udim
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-642331957
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-642331818
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-642331889
Run Portable_Python PreCommit
This is an automated message from the Apache Git Service.
To respond to the
TheNeuralBit commented on pull request #11929:
URL: https://github.com/apache/beam/pull/11929#issuecomment-642330786
FYI `PubsubJsonTableProvider` has support for writing to a dead letter
pubsub topic:
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-642327786
I've tested this on my machine
This is an automated message from the Apache Git Service.
To respond to the
rezarokni commented on pull request #11955:
URL: https://github.com/apache/beam/pull/11955#issuecomment-642327425
Thanx for FYI @pabloem .
This is awesome! we are also looking to add deadletter pattern to JsonToRow:
https://github.com/apache/beam/pull/11929
The null
rezarokni commented on a change in pull request #11929:
URL: https://github.com/apache/beam/pull/11929#discussion_r438470939
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/JsonToRow.java
##
@@ -72,10 +79,44 @@
@Experimental(Kind.SCHEMAS)
public
pabloem commented on pull request #11982:
URL: https://github.com/apache/beam/pull/11982#issuecomment-642327079
r: @udim
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pabloem opened a new pull request #11982:
URL: https://github.com/apache/beam/pull/11982
Following the logic from Java
pabloem commented on pull request #11955:
URL: https://github.com/apache/beam/pull/11955#issuecomment-642325514
and assigned BEAM-7624
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11955:
URL: https://github.com/apache/beam/pull/11955#issuecomment-642325342
Added @reubenvanammers as contributor!
This is an automated message from the Apache Git Service.
To respond to
pabloem commented on pull request #11955:
URL: https://github.com/apache/beam/pull/11955#issuecomment-642325145
fyi @rezarokni @reuvenlax
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #11955:
URL: https://github.com/apache/beam/pull/11955#issuecomment-642323660
I went to assign BEAM-7624 to you, but it looks like you need to be added as
a Beam contributor first. @pabloem could you add Reuben on jira?
TheNeuralBit opened a new pull request #11981:
URL: https://github.com/apache/beam/pull/11981
R: @reuvenlax
CC: @nevillelyh
Post-Commit Tests Status (on master branch)
TheNeuralBit commented on pull request #11980:
URL: https://github.com/apache/beam/pull/11980#issuecomment-642320833
CC: @robertwb
This is an automated message from the Apache Git Service.
To respond to the message, please
TheNeuralBit opened a new pull request #11980:
URL: https://github.com/apache/beam/pull/11980
Adds batching of schema'd PCollections into dataframes based on
BatchElements transform.
Post-Commit Tests Status (on master branch)
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642320097
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
damondouglas opened a new pull request #11979:
URL: https://github.com/apache/beam/pull/11979
This pull requests adds a Partition lesson to the Go SDK katas. I would
like to request the following reviewers:
(R: @lostluck )
(R: @henryken )
If accepted by both reviewers,
amaliujia commented on pull request #11975:
URL: https://github.com/apache/beam/pull/11975#issuecomment-642302788
also cc @Mark-Zeng.
This is an automated message from the Apache Git Service.
To respond to the message,
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642301092
Looks like a bug from new rsa pypi release, filed BEAM-10232
This is an automated message from the Apache Git
amaliujia commented on pull request #11975:
URL: https://github.com/apache/beam/pull/11975#issuecomment-642300874
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
kennknowles opened a new pull request #11978:
URL: https://github.com/apache/beam/pull/11978
Replacing a direct link by i.p. with our new domain name
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642294606
> Thanks for the explanation! Please run tox -e py3-yapf to fix pylint.
I ran `tox -e py3-yapf` already, but pylint is still failing.
`Execution failed for task
kennknowles opened a new pull request #11977:
URL: https://github.com/apache/beam/pull/11977
For context, see:
- https://tools.ietf.org/html/draft-knodel-terminology-01
-
https://developers.google.com/style/inclusive-documentation#features-and-users
Blocked by
udim edited a comment on pull request #7017:
URL: https://github.com/apache/beam/pull/7017#issuecomment-642292563
My notes from around that time:
```
pip install google-apitools[cli]
.../VIRTUALENV_PATH/bin/gen_client --discovery_url storage.v1 \
--overwrite --outdir=out
udim commented on pull request #7017:
URL: https://github.com/apache/beam/pull/7017#issuecomment-642292563
My notes from around that times:
```
pip install google-apitools[cli]
.../VIRTUALENV_PATH/bin/gen_client --discovery_url storage.v1 \
--overwrite --outdir=out
udim edited a comment on pull request #7017:
URL: https://github.com/apache/beam/pull/7017#issuecomment-642292563
My notes from around that time:
```
pip install google-apitools[cli]
.../VIRTUALENV_PATH/bin/gen_client --discovery_url storage.v1 \
--overwrite
lukecwik commented on pull request #11938:
URL: https://github.com/apache/beam/pull/11938#issuecomment-642291285
Won't be able to get to this for a little while as I'm on the customer
support rotation currently.
This is an
codeBehindMe commented on pull request #11976:
URL: https://github.com/apache/beam/pull/11976#issuecomment-642290717
@damondouglas If you could give me some feedback that'll be nice.
This is an automated message from the
codeBehindMe removed a comment on pull request #11976:
URL: https://github.com/apache/beam/pull/11976#issuecomment-642290142
@damondouglas Hey mate, could you give this a quick once over.
This is an automated message from
codeBehindMe commented on pull request #11976:
URL: https://github.com/apache/beam/pull/11976#issuecomment-642290142
@damondouglas Hey mate, could you give this a quick once over.
This is an automated message from the
codeBehindMe opened a new pull request #11976:
URL: https://github.com/apache/beam/pull/11976
Previously, when a mismatch of the dimensions emitted by the DoFn and the
dimensions emitted by the ParDo was encountered, a less than helpful message of
`expected 1 output. Found: []` was
kennknowles commented on pull request #7017:
URL: https://github.com/apache/beam/pull/7017#issuecomment-642285619
Ping? Can you comment here with a link to the documentation on regenerating
these?
This is an automated
jhnmora000 commented on pull request #11975:
URL: https://github.com/apache/beam/pull/11975#issuecomment-642285036
R:@amaliujia
This is an automated message from the Apache Git Service.
To respond to the message, please log
jhnmora000 opened a new pull request #11975:
URL: https://github.com/apache/beam/pull/11975
An concept-proof implementation for a cumulative sum using Analytic
functions.
Implemented in: BeamAnalyticFunctionsExperimentTest.testOverCumulativeSum()
lostluck merged pull request #11936:
URL: https://github.com/apache/beam/pull/11936
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
damondouglas commented on pull request #11936:
URL: https://github.com/apache/beam/pull/11936#issuecomment-642274790
This is ready to merge now. Thank you @lostluck and @henryken.
This is an automated message from the
lostluck commented on a change in pull request #11870:
URL: https://github.com/apache/beam/pull/11870#discussion_r438411053
##
File path: sdks/go/pkg/beam/testing/passert/count.go
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
lostluck commented on a change in pull request #11870:
URL: https://github.com/apache/beam/pull/11870#discussion_r438411053
##
File path: sdks/go/pkg/beam/testing/passert/count.go
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
pabloem commented on a change in pull request #11702:
URL: https://github.com/apache/beam/pull/11702#discussion_r438404800
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##
@@ -1173,4 +1276,339 @@ public void
pabloem commented on a change in pull request #11702:
URL: https://github.com/apache/beam/pull/11702#discussion_r438403098
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/FhirIO.java
##
@@ -155,17 +168,53 @@
*
youngoli commented on pull request #11870:
URL: https://github.com/apache/beam/pull/11870#issuecomment-642253483
I added unit tests and changed the error message.
I spent a bunch of time moving the Count code to Beam (specifically the
stats package), but ended up having to scrap it
youngoli commented on a change in pull request #11870:
URL: https://github.com/apache/beam/pull/11870#discussion_r438401382
##
File path: sdks/go/pkg/beam/testing/passert/count.go
##
@@ -0,0 +1,52 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+//
robertwb commented on pull request #11963:
URL: https://github.com/apache/beam/pull/11963#issuecomment-642251071
CC: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on pull request #11974:
URL: https://github.com/apache/beam/pull/11974#issuecomment-642250609
CC: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
boyuanzz commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642246885
Thanks for the explanation! Please run `tox -e py3-yapf` to fix pylint.
This is an automated message
robertwb merged pull request #11935:
URL: https://github.com/apache/beam/pull/11935
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on a change in pull request #11935:
URL: https://github.com/apache/beam/pull/11935#discussion_r438395866
##
File path: sdks/python/apache_beam/runners/portability/artifact_service.py
##
@@ -55,272 +52,6 @@
from typing import Iterable
from typing import
kennknowles merged pull request #11960:
URL: https://github.com/apache/beam/pull/11960
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642236775
We've got enough LGTM and test greenness.
This is an automated message from the Apache Git Service.
To
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642237210
> Can you also fix the state one as well
(beam/sdks/python/apache_beam/runners/worker/sdk_worker.py Line 691)?
Good catch. Fixed
TheNeuralBit merged pull request #11973:
URL: https://github.com/apache/beam/pull/11973
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
TheNeuralBit commented on pull request #11973:
URL: https://github.com/apache/beam/pull/11973#issuecomment-642236509
Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
amaliujia commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642236503
Re-trigger the Java_Examples_Dataflow_Java11. Now it seems get scheduled.
This is an automated message from
amaliujia commented on pull request #11960:
URL: https://github.com/apache/beam/pull/11960#issuecomment-642236279
Run Java_Examples_Dataflow_Java11 Precommit
This is an automated message from the Apache Git Service.
To
amaliujia commented on pull request #11973:
URL: https://github.com/apache/beam/pull/11973#issuecomment-642234960
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lukecwik commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642233639
> > I'm curious with which runner we will run into this issue.
>
> All portable runners as far as I know (confirmed for Flink, Spark,
Dataflow Python streaming).
>
ibzib commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642232521
> I'm curious with which runner we will run into this issue.
All portable runners as far as I know (confirmed for Flink, Spark, Dataflow
Python streaming).
> The
InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r438368619
##
File path: sdks/python/apache_beam/transforms/combiners.py
##
@@ -66,8 +66,21 @@ class Mean(object):
"""Combiners for computing arithmetic means of
ihji commented on a change in pull request #11935:
URL: https://github.com/apache/beam/pull/11935#discussion_r438370617
##
File path: sdks/python/apache_beam/runners/portability/artifact_service.py
##
@@ -55,272 +52,6 @@
from typing import Iterable
from typing import
amaliujia merged pull request #11971:
URL: https://github.com/apache/beam/pull/11971
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amaliujia commented on pull request #11971:
URL: https://github.com/apache/beam/pull/11971#issuecomment-642227049
Thank you Robin!
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik commented on a change in pull request #11972:
URL: https://github.com/apache/beam/pull/11972#discussion_r438371296
##
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##
@@ -819,7 +819,8 @@ def __init__(self,
# There is no guarantee that the
lukecwik commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642224159
> Thanks, Kyle!
>
> I'm curious with which runner we will run into this issue. Based on the
proto, the `url` should be required for `ApiServiceDescriptor`:
>
>
pabloem commented on a change in pull request #11950:
URL: https://github.com/apache/beam/pull/11950#discussion_r438284843
##
File path:
sdks/java/io/splunk/src/main/java/org/apache/beam/sdk/io/splunk/SplunkEventWriter.java
##
@@ -0,0 +1,395 @@
+/*
+ * Licensed to the Apache
InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r438368619
##
File path: sdks/python/apache_beam/transforms/combiners.py
##
@@ -66,8 +66,21 @@ class Mean(object):
"""Combiners for computing arithmetic means of
InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r438366946
##
File path: sdks/python/apache_beam/transforms/combiners_test.py
##
@@ -105,6 +109,16 @@ def test_builtin_combines(self):
InigoSJ commented on a change in pull request #11943:
URL: https://github.com/apache/beam/pull/11943#discussion_r438366434
##
File path: sdks/python/apache_beam/transforms/combiners_test.py
##
@@ -97,6 +100,7 @@ def test_builtin_combines(self):
vals = [6, 3, 1, 1, 9, 1,
pabloem edited a comment on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-642210806
Note the spotless complaints:
https://builds.apache.org/job/beam_PreCommit_Spotless_Commit/9383/console
you can run `./gradlew :my-project...:spotlessApply` to fix
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-642210806
Note the spotless complaints:
https://builds.apache.org/job/beam_PreCommit_Spotless_Commit/9383/console
you can run `./gradlew :my-project...:spotlessApply` to fix those
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-642210975
Note some build errors:
https://builds.apache.org/job/beam_PreCommit_JavaPortabilityApi_Commit/8189/console
pabloem commented on pull request #11969:
URL: https://github.com/apache/beam/pull/11969#issuecomment-642208223
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb merged pull request #11949:
URL: https://github.com/apache/beam/pull/11949
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
udim commented on pull request #11966:
URL: https://github.com/apache/beam/pull/11966#issuecomment-642205856
> Jenkins hooks are mad at me.
Dependencies are still broken so it won't help
This is an automated message
TheNeuralBit opened a new pull request #11973:
URL: https://github.com/apache/beam/pull/11973
R: @aaltay
Post-Commit Tests Status (on master branch)
Lang | SDK | Apex |
boyuanzz commented on pull request #11972:
URL: https://github.com/apache/beam/pull/11972#issuecomment-642199648
Thanks, Kyle!
I'm curious with which runner we will run into this issue. Based on the
proto, the `url` should be required for `ApiServiceDescriptor`:
aromanenko-dev merged pull request #11396:
URL: https://github.com/apache/beam/pull/11396
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
robertwb commented on pull request #11949:
URL: https://github.com/apache/beam/pull/11949#issuecomment-642188187
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
ibzib opened a new pull request #11972:
URL: https://github.com/apache/beam/pull/11972
This is possibly a naive solution, please let me know if you think there is
a greater underlying issue.
R: @boyuanzz
cc: @robertwb
Thank you for your
kamilwu removed a comment on pull request #11956:
URL: https://github.com/apache/beam/pull/11956#issuecomment-642144427
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
1 - 100 of 177 matches
Mail list logo
