jalmeidaa opened a new pull request #12131:
URL: https://github.com/apache/beam/pull/12131
**Please** add a meaningful description for your change here
@aromanenko-dev Please take a look.
Thank you for your contribution! Follow this checklist to help us
abhiy13 commented on pull request #12097:
URL: https://github.com/apache/beam/pull/12097#issuecomment-651547875
PTAL @rezarokni @tvalentyn
This is an automated message from the Apache Git Service.
To respond to the message,
ajamato commented on pull request #12130:
URL: https://github.com/apache/beam/pull/12130#issuecomment-651543155
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log on
ajamato opened a new pull request #12130:
URL: https://github.com/apache/beam/pull/12130
[BEAM-10381] Increase retries in pull_licenses_java.py from 3 to 9.
Thank you for your contribution! Follow this checklist to help us
incorporate your
ajamato commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-651539363
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
youngoli commented on a change in pull request #12127:
URL: https://github.com/apache/beam/pull/12127#discussion_r447385783
##
File path: sdks/go/pkg/beam/core/graph/coder/bytes_test.go
##
@@ -0,0 +1,61 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447392924
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##
@@ -99,6 +100,10 @@
*/
public
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447384216
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -383,6 +383,12 @@ message StandardPTransforms {
//
// Input:
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447387903
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##
@@ -99,6 +100,10 @@
*/
public
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447375156
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##
@@ -99,6 +100,10 @@
*/
public
aaltay commented on a change in pull request #12088:
URL: https://github.com/apache/beam/pull/12088#discussion_r447379446
##
File path: sdks/python/apache_beam/transforms/util.py
##
@@ -741,6 +741,7 @@ def WithKeys(pcoll, k):
@experimental()
aaltay commented on pull request #12129:
URL: https://github.com/apache/beam/pull/12129#issuecomment-651494619
R: @davidcavazos - Do you know how I need to update groupintobatches_test if
I am changing GroupIntoBatches transform. I updated the expected output but I
am not sure if this is
aaltay opened a new pull request #12129:
URL: https://github.com/apache/beam/pull/12129
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447375763
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -574,6 +578,99 @@ public Instant timestamp(DoFn
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447375156
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##
@@ -99,6 +100,10 @@
*/
public
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447374186
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java
##
@@ -113,6 +113,8 @@
rose-rong-liu commented on pull request #12128:
URL: https://github.com/apache/beam/pull/12128#issuecomment-651473077
Thanks Ahmet! I think it would be very nice to have it commonly available in
beam.
On tfx part, as we have other libraries (e.g. TFMA) that depends on the
shared
aaltay opened a new pull request #12128:
URL: https://github.com/apache/beam/pull/12128
R: @rose-rong-liu @katsiapis
I would like to move Shared from
(https://github.com/tensorflow/tfx-bsl/blob/master/tfx_bsl/beam/shared.py) to
Beam, since it is probably generally useful for other
aaltay commented on a change in pull request #12088:
URL: https://github.com/apache/beam/pull/12088#discussion_r447358864
##
File path: sdks/python/apache_beam/transforms/util.py
##
@@ -741,6 +741,7 @@ def WithKeys(pcoll, k):
@experimental()
suztomo commented on pull request #11919:
URL: https://github.com/apache/beam/pull/11919#issuecomment-651451801
An email thread shared https://issues.apache.org/jira/browse/BEAM-10381 for
the license script error.
This
aaltay commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-651444557
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447337646
##
File path: sdks/python/apache_beam/transforms/core.py
##
@@ -320,6 +320,22 @@ def split_and_size(self, element, restriction):
for part in
damondouglas commented on a change in pull request #12113:
URL: https://github.com/apache/beam/pull/12113#discussion_r447334926
##
File path: learning/katas/go/Core
Transforms/Branching/Branching/pkg/task/task.go
##
@@ -0,0 +1,58 @@
+// Licensed to the Apache Software
pabloem commented on pull request #12119:
URL: https://github.com/apache/beam/pull/12119#issuecomment-651438019
it seems that we need to fix the precommits first
This is an automated message from the Apache Git Service.
To
KevinGG commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-651437608
> can you rebase please?
Rebased!
This is an automated message from the Apache Git Service.
To respond to
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447331663
##
File path: sdks/python/apache_beam/transforms/core.py
##
@@ -622,6 +638,16 @@ class DoFn(WithTypeHints, HasDisplayData,
urns.RunnerApiFn):
def
lostluck commented on a change in pull request #12124:
URL: https://github.com/apache/beam/pull/12124#discussion_r447317094
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource.go
##
@@ -302,12 +302,23 @@ func (n *DataSource) Split(splits []int64, frac float64,
bufSize
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447327762
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -829,6 +917,68 @@ private void
TheNeuralBit commented on a change in pull request #12090:
URL: https://github.com/apache/beam/pull/12090#discussion_r447326025
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonTableProvider.java
##
@@
TheNeuralBit commented on a change in pull request #12090:
URL: https://github.com/apache/beam/pull/12090#discussion_r447326025
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonTableProvider.java
##
@@
pabloem commented on a change in pull request #12123:
URL: https://github.com/apache/beam/pull/12123#discussion_r447325724
##
File path: sdks/python/apache_beam/metrics/metric_test.py
##
@@ -162,7 +161,7 @@ def process(self, element):
# Verify user counter.
aaltay commented on pull request #12116:
URL: https://github.com/apache/beam/pull/12116#issuecomment-651428858
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-651427458
java precommits look to be having troubles
This is an automated message from the Apache Git Service.
To respond
robinyqiu commented on pull request #12120:
URL: https://github.com/apache/beam/pull/12120#issuecomment-651426652
The new ZetaSQL `DATE` and `TIME` types use Beam logical types. Currently
Beam SQL transforms operate on the **base types** of logical types. This
produces incorrect result
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-651426642
Ok I think I'm finally done churning on this. Sorry for all the changes.
What I have now stores the component ids in a `ComponentIdContext` object
stored on the Pipeline.
pabloem commented on pull request #12125:
URL: https://github.com/apache/beam/pull/12125#issuecomment-651425370
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
dpcollins-google commented on pull request #11919:
URL: https://github.com/apache/beam/pull/11919#issuecomment-651420702
test error is some unrelated test failing at head AFAICT.
This is an automated message from the Apache
robinyqiu commented on pull request #12120:
URL: https://github.com/apache/beam/pull/12120#issuecomment-651419850
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
lostluck commented on pull request #12127:
URL: https://github.com/apache/beam/pull/12127#issuecomment-651419471
R: @youngoli @tysonjh
This is an automated message from the Apache Git Service.
To respond to the message,
lostluck opened a new pull request #12127:
URL: https://github.com/apache/beam/pull/12127
Add bytes, bool, and iterable coders to the graph/coders package.
This is in preparation of the next PR which has the first pass at the row
encoder, so these building blocks can be reviewed
amaliujia edited a comment on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-651418090
@Imfuyuwei
can you revert changes in `BeamBuiltinAggregations.java ` and
`BeamSqlDslAggregationTest.java`?
TheNeuralBit commented on pull request #12032:
URL: https://github.com/apache/beam/pull/12032#issuecomment-651418048
@angoenka agreed it would be best if we could just fix BEAM-10274. But I
think that's a tricky problem that requires some design work.
Currently this is a mismatch
amaliujia commented on pull request #12110:
URL: https://github.com/apache/beam/pull/12110#issuecomment-651418090
@Imfuyuwei
can you revert changes in `BeamBuiltinAggregations.java ` and
`BeamSqlDslAggregationTest.java`
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447311084
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/RestrictionTracker.java
##
@@ -99,6 +100,10 @@
*/
public
TheNeuralBit commented on pull request #12067:
URL: https://github.com/apache/beam/pull/12067#issuecomment-651416156
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
TheNeuralBit commented on pull request #12035:
URL: https://github.com/apache/beam/pull/12035#issuecomment-651415998
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on pull request #12090:
URL: https://github.com/apache/beam/pull/12090#issuecomment-651415868
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
y1chi commented on pull request #12116:
URL: https://github.com/apache/beam/pull/12116#issuecomment-651412703
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-651411593
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
corvin-quodai commented on pull request #12116:
URL: https://github.com/apache/beam/pull/12116#issuecomment-651409708
Thanks guys! Will just add you both directly for future PRs on this.
This is an automated message from
pabloem commented on pull request #12125:
URL: https://github.com/apache/beam/pull/12125#issuecomment-651404069
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
aaltay opened a new pull request #12126:
URL: https://github.com/apache/beam/pull/12126
Update docs for Reshuffle to remove the reference for "deduplication by id".
**Please** add a meaningful description for your change here
Thank you for your
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-651404146
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem opened a new pull request #12125:
URL: https://github.com/apache/beam/pull/12125
…ed once per bundle. With this change, it will be queried once per worker
thread. This will help with throughput for BQ streaming inserts
**Please** add a meaningful description for your change
pabloem commented on pull request #11582:
URL: https://github.com/apache/beam/pull/11582#issuecomment-651401099
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #11824:
URL: https://github.com/apache/beam/pull/11824#issuecomment-651399432
should I look into it? Will you? @epicfaace LMK : )
This is an automated message from the Apache Git Service.
To
pabloem commented on pull request #11765:
URL: https://github.com/apache/beam/pull/11765#issuecomment-651396398
can you rebase this?
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12087:
URL: https://github.com/apache/beam/pull/12087#issuecomment-651396481
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
udim edited a comment on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-651395927
retest this please
This is an automated message from the Apache Git Service.
To respond to the message,
udim commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-651396234
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please log
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-651396253
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12103:
URL: https://github.com/apache/beam/pull/12103#issuecomment-651396219
makes sense. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please
udim commented on pull request #12009:
URL: https://github.com/apache/beam/pull/12009#issuecomment-651395927
adsfdf
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
youngoli commented on pull request #12124:
URL: https://github.com/apache/beam/pull/12124#issuecomment-651395753
R: @lostluck
This is an automated message from the Apache Git Service.
To respond to the message, please log
aaltay commented on a change in pull request #12123:
URL: https://github.com/apache/beam/pull/12123#discussion_r447282378
##
File path: sdks/python/apache_beam/metrics/metric_test.py
##
@@ -162,7 +161,7 @@ def process(self, element):
# Verify user counter.
youngoli opened a new pull request #12124:
URL: https://github.com/apache/beam/pull/12124
Adding sub-element progress to the splitting logic in DataSource.
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution
ajamato commented on pull request #12084:
URL: https://github.com/apache/beam/pull/12084#issuecomment-651394625
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12082:
URL: https://github.com/apache/beam/pull/12082#issuecomment-651394186
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447281112
##
File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java
##
@@ -1051,7 +1092,7 @@ public Duration getAllowedTimestampSkew() {
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447275211
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java
##
@@ -113,6 +113,8 @@
y1chi commented on pull request #12116:
URL: https://github.com/apache/beam/pull/12116#issuecomment-651382272
Run Python MongoDBIO_IT
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #12107:
URL: https://github.com/apache/beam/pull/12107#issuecomment-651378069
can you rebase please?
This is an automated message from the Apache Git Service.
To respond to the message,
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447264730
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -574,6 +578,99 @@ public Instant timestamp(DoFn
boyuanzz commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447263762
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/splittabledofn/GrowableOffsetRangeTracker.java
##
@@ -140,4 +140,9 @@ public
aaltay commented on pull request #12116:
URL: https://github.com/apache/beam/pull/12116#issuecomment-651368289
R: @y1chi - Could you review this?
@corvin-quodai - Thank you for the PR! I added Yichi here for the review, he
worked on the initial mongodb implementation.
aaltay commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-651366970
Nice, thank you!
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r447253967
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -0,0 +1,138 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under
rainwoodman commented on pull request #12123:
URL: https://github.com/apache/beam/pull/12123#issuecomment-651366435
R: @aaltay
This is an automated message from the Apache Git Service.
To respond to the message, please log
aaltay commented on pull request #12118:
URL: https://github.com/apache/beam/pull/12118#issuecomment-651365358
Potential people who could help with the review: @chamikaramj @pabloem @udim
This is an automated message from
rainwoodman opened a new pull request #12123:
URL: https://github.com/apache/beam/pull/12123
This change would encourage reusing predefined metric objects in
metric queries.
Querying with the metric object may result more maintainable code
than duplicating the name and
amaliujia closed pull request #12122:
URL: https://github.com/apache/beam/pull/12122
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pabloem commented on pull request #12114:
URL: https://github.com/apache/beam/pull/12114#issuecomment-651363070
hm yeah I don't think this is right. @lakshmanok can you share some context
about why you're proposing this change?
pabloem commented on pull request #12087:
URL: https://github.com/apache/beam/pull/12087#issuecomment-651362425
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
pabloem commented on pull request #12119:
URL: https://github.com/apache/beam/pull/12119#issuecomment-651360897
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
amaliujia opened a new pull request #12122:
URL: https://github.com/apache/beam/pull/12122
Reverts apache/beam#12079
It turns out that on direct runner, NULL will not be passed to CombineFn
thus all NULL inputs are ignored. And then if there is any non-null inputs,
bit_and
mik-laj commented on pull request #11877:
URL: https://github.com/apache/beam/pull/11877#issuecomment-651359183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447190465
##
File path:
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/help-buildReleaseOptions.html
##
@@ -0,0 +1,4 @@
+
+
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447181488
##
File path: beam-ci/pom.xml
##
@@ -0,0 +1,45 @@
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
TheNeuralBit commented on pull request #12090:
URL: https://github.com/apache/beam/pull/12090#issuecomment-651355353
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447190465
##
File path:
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/help-buildReleaseOptions.html
##
@@ -0,0 +1,4 @@
+
+
TheNeuralBit commented on pull request #12035:
URL: https://github.com/apache/beam/pull/12035#issuecomment-651309044
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
TheNeuralBit commented on a change in pull request #12022:
URL: https://github.com/apache/beam/pull/12022#discussion_r447186177
##
File path: sdks/java/container/Dockerfile
##
@@ -27,6 +27,7 @@ ADD target/beam-sdks-java-harness.jar /opt/apache/beam/jars/
# TODO May be removed
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447190738
##
File path: sdks/python/apache_beam/transforms/core.py
##
@@ -622,6 +638,16 @@ class DoFn(WithTypeHints, HasDisplayData,
urns.RunnerApiFn):
def
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447190465
##
File path:
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/help-buildReleaseOptions.html
##
@@ -0,0 +1,4 @@
+
+
lukecwik commented on a change in pull request #12016:
URL: https://github.com/apache/beam/pull/12016#discussion_r447190738
##
File path: sdks/python/apache_beam/transforms/core.py
##
@@ -622,6 +638,16 @@ class DoFn(WithTypeHints, HasDisplayData,
urns.RunnerApiFn):
def
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447190465
##
File path:
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/help-buildReleaseOptions.html
##
@@ -0,0 +1,4 @@
+
+
JustineKoa commented on a change in pull request #12042:
URL: https://github.com/apache/beam/pull/12042#discussion_r447186469
##
File path:
beam-ci/src/main/resources/io/jenkins/plugins/ExecuteBeamPipelineOnDataflowBuilder/config.jelly
##
@@ -0,0 +1,36 @@
+
Review comment:
TheNeuralBit commented on a change in pull request #12023:
URL: https://github.com/apache/beam/pull/12023#discussion_r447171092
##
File path: sdks/python/apache_beam/io/external/xlang_jdbcio_it_test.py
##
@@ -0,0 +1,138 @@
+#
+# Licensed to the Apache Software Foundation (ASF)
shollyman commented on a change in pull request #12118:
URL: https://github.com/apache/beam/pull/12118#discussion_r447182339
##
File path:
examples/java/src/main/java/org/apache/beam/examples/snippets/transforms/io/gcp/bigquery/BigQueryWriteToTable.java
##
@@ -0,0 +1,65 @@
lukecwik merged pull request #12051:
URL: https://github.com/apache/beam/pull/12051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 155 matches
Mail list logo
