kennknowles commented on pull request #12254:
URL: https://github.com/apache/beam/pull/12254#issuecomment-659152184
JFYI "Beam-" is mean to refer to a specific Jira id, in case you are
fixing a bug. In this case there is no bug (and none needed) so we can leave it
off.
kennknowles commented on a change in pull request #12271:
URL: https://github.com/apache/beam/pull/12271#discussion_r455494897
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
##
@@ -609,24 +604,34 @@ public static void
robinyqiu commented on a change in pull request #12266:
URL: https://github.com/apache/beam/pull/12266#discussion_r455494296
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubSchemaCapableIOProvider.java
##
@@ -155,16
robinyqiu commented on a change in pull request #12266:
URL: https://github.com/apache/beam/pull/12266#discussion_r455492426
##
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/pubsub/PubsubSchemaCapableIOProvider.java
##
@@ -264,4
lukecwik commented on pull request #12275:
URL: https://github.com/apache/beam/pull/12275#issuecomment-659135889
R: @youngoli @boyuanzz
CC: @robertwb
This is an automated message from the Apache Git Service.
To respond
robinyqiu commented on a change in pull request #12271:
URL: https://github.com/apache/beam/pull/12271#discussion_r455483223
##
File path:
sdks/java/core/src/main/java/org/apache/beam/sdk/util/common/ReflectHelpers.java
##
@@ -74,16 +74,12 @@ public String apply(@Nonnull
youngoli commented on pull request #12215:
URL: https://github.com/apache/beam/pull/12215#issuecomment-659134956
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lukecwik opened a new pull request #12275:
URL: https://github.com/apache/beam/pull/12275
This removes the unused window from pair with restriction allowing for
window observing splittable dofns to be exercised.
Thank you for your contribution! Follow
kennknowles merged pull request #12272:
URL: https://github.com/apache/beam/pull/12272
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robinyqiu commented on pull request #12274:
URL: https://github.com/apache/beam/pull/12274#issuecomment-659117349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
ibzib merged pull request #12243:
URL: https://github.com/apache/beam/pull/12243
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ibzib commented on pull request #12243:
URL: https://github.com/apache/beam/pull/12243#issuecomment-659098051
Java precommit flakes (of course).
BEAM-10472 and BEAM-10508 (new one)
This is an automated message from
ZijieSong946 commented on pull request #12174:
URL: https://github.com/apache/beam/pull/12174#issuecomment-659090461
> Internally we got 398 tests passing.
>
> Note that this PR turned on `LanguageFeature.FEATURE_NUMERIC_TYPE` so
there are new tests enabled but are not currently
ZijieSong946 edited a comment on pull request #12174:
URL: https://github.com/apache/beam/pull/12174#issuecomment-659090461
> Internally we got 398 tests passing.
>
> Note that this PR turned on `LanguageFeature.FEATURE_NUMERIC_TYPE` so
there are new tests enabled but are not
chamikaramj commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455446367
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
ihji commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455446568
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
robertwb commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455444790
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
chamikaramj merged pull request #12164:
URL: https://github.com/apache/beam/pull/12164
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
chamikaramj commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455441379
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
ihji commented on pull request #12164:
URL: https://github.com/apache/beam/pull/12164#issuecomment-659084291
@chamikaramj @robertwb Any other feedback before we merge this?
This is an automated message from the Apache Git
robinyqiu opened a new pull request #12274:
URL: https://github.com/apache/beam/pull/12274
Post-Commit Tests Status (on master branch)
Lang | SDK | Dataflow | Flink | Samza |
robertwb commented on a change in pull request #12164:
URL: https://github.com/apache/beam/pull/12164#discussion_r455430204
##
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##
@@ -864,7 +867,7 @@ def run_GroupByKey(self, transform_node, options):
kennknowles commented on pull request #12273:
URL: https://github.com/apache/beam/pull/12273#issuecomment-659071343
The level of flakiness right now is quite bad. This PR clearly did not cause
those known flakes, and it unblocks other value adding work. I don't think
kicking the build a
kennknowles merged pull request #12273:
URL: https://github.com/apache/beam/pull/12273
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
kennknowles commented on pull request #12273:
URL: https://github.com/apache/beam/pull/12273#issuecomment-659070317
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kennknowles commented on pull request #12243:
URL: https://github.com/apache/beam/pull/12243#issuecomment-659067344
Is it still deadlocking? I've actually just been doing other things and
didn't even read the logs the last few times.
kennknowles commented on pull request #12243:
URL: https://github.com/apache/beam/pull/12243#issuecomment-659067153
Re-opening because why not also just bump this up and eliminate it from
consideration.
This is an automated
aaltay merged pull request #12252:
URL: https://github.com/apache/beam/pull/12252
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay merged pull request #12269:
URL: https://github.com/apache/beam/pull/12269
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
apilloud merged pull request #12240:
URL: https://github.com/apache/beam/pull/12240
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles commented on pull request #12272:
URL: https://github.com/apache/beam/pull/12272#issuecomment-659050891
Flakes in this run:
- https://issues.apache.org/jira/browse/BEAM-10460
`SparkPortableExecutionTest`
- https://issues.apache.org/jira/browse/BEAM-10471
robinyqiu merged pull request #12174:
URL: https://github.com/apache/beam/pull/12174
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robinyqiu commented on pull request #12174:
URL: https://github.com/apache/beam/pull/12174#issuecomment-659049262
Internally we got 398 tests passing.
Note that this PR turned on `LanguageFeature.FEATURE_NUMERIC_TYPE` so there
are new tests enabled but are not currently supported.
robinyqiu commented on pull request #12261:
URL: https://github.com/apache/beam/pull/12261#issuecomment-659048335
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
kennknowles commented on pull request #12271:
URL: https://github.com/apache/beam/pull/12271#issuecomment-659040809
Based on the quality of null handling in zetasketch, pinging you on other
similar PRs @robinyqiu
This is
kennknowles merged pull request #12126:
URL: https://github.com/apache/beam/pull/12126
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
amaliujia commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r455392148
##
File path:
sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/rel/BeamMatchRelTest.java
##
@@ -0,0 +1,75 @@
+/*
+ *
amaliujia commented on pull request #12232:
URL: https://github.com/apache/beam/pull/12232#issuecomment-659039166
@Mark-Zeng thanks for your update on this PR. Let me know when you think
this PR is ready for review again.
apilloud commented on pull request #12240:
URL: https://github.com/apache/beam/pull/12240#issuecomment-659037813
Failure is BEAM-9187
This is an automated message from the Apache Git Service.
To respond to the message,
apilloud commented on pull request #12240:
URL: https://github.com/apache/beam/pull/12240#issuecomment-659037902
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tysonjh commented on a change in pull request #8558:
URL: https://github.com/apache/beam/pull/8558#discussion_r455362373
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##
@@ -17,6 +17,7 @@
*/
package
kennknowles commented on pull request #12273:
URL: https://github.com/apache/beam/pull/12273#issuecomment-659028721
Added illegal import to checkstyle configuration. Confirmed that with the
commit reverted it fails: https://gradle.com/s/5dv5sua4hj2n6
kennknowles commented on pull request #12273:
URL: https://github.com/apache/beam/pull/12273#issuecomment-659026632
I imagine if javax Nullable did the trick, then the checker folks would not
have created their own.
This is
kennknowles commented on pull request #12273:
URL: https://github.com/apache/beam/pull/12273#issuecomment-659026520
@tysonjh yea you cannot use javax Nullable at "type use" so you cannot have
e.g. `List<@Nullable Foo>`. And there are a few other cases.
tysonjh commented on a change in pull request #8558:
URL: https://github.com/apache/beam/pull/8558#discussion_r455362373
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##
@@ -17,6 +17,7 @@
*/
package
robinyqiu commented on a change in pull request #12267:
URL: https://github.com/apache/beam/pull/12267#discussion_r455362415
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/pubsub/PubsubJsonTableProvider.java
##
@@ -17,63
ibzib commented on pull request #12270:
URL: https://github.com/apache/beam/pull/12270#issuecomment-659021482
testMultiOutputParDoWithSideInputsIsCumulative is an unrelated flake.
This is an automated message from the Apache
ibzib merged pull request #12270:
URL: https://github.com/apache/beam/pull/12270
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kennknowles commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-659022248
There's a real build break. #12273 to fix it and/or you can cherrypick the
commit here.
This is an
kennknowles commented on a change in pull request #8558:
URL: https://github.com/apache/beam/pull/8558#discussion_r455360189
##
File path:
runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkTranslationContext.java
##
@@ -17,6 +17,7 @@
*/
package
kennknowles edited a comment on pull request #12272:
URL: https://github.com/apache/beam/pull/12272#issuecomment-659014899
And may I say @robinyqiu very nice work. This is the cleanest module I have
encountered probably in my career. All I did was add trivial annotations, and
the module
kennknowles edited a comment on pull request #12272:
URL: https://github.com/apache/beam/pull/12272#issuecomment-659014899
And may I say @robinyqiu very nice work. This is the cleanest module I have
encountered probably in my career. All I did was add trivial annotations, and
the module
kennknowles commented on pull request #12272:
URL: https://github.com/apache/beam/pull/12272#issuecomment-659014899
And may I say @robinyqiu very nice work. This is the cleanest module I have
encountered probably in my career. All I did was add trivial annotations, and
the module was
kennknowles opened a new pull request #12272:
URL: https://github.com/apache/beam/pull/12272
This enables the checker analyzer in the Zetasketch extension, preventing
nullability errors in this module.
In this PR is an independent commit that prepares `Combine` for other
modules to
robinyqiu commented on a change in pull request #12267:
URL: https://github.com/apache/beam/pull/12267#discussion_r455351279
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java
##
@@
robinyqiu commented on a change in pull request #12267:
URL: https://github.com/apache/beam/pull/12267#discussion_r455351279
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/meta/provider/SchemaCapableIOTableProviderWrapper.java
##
@@
robinyqiu commented on pull request #12247:
URL: https://github.com/apache/beam/pull/12247#issuecomment-659010570
Tested internally.
This is an automated message from the Apache Git Service.
To respond to the message, please
udim commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r455342332
##
File path: website/www/site/content/en/documentation/sdks/python-type-safety.md
##
@@ -90,6 +91,15 @@ The following code declares an `int` input and a
robinyqiu commented on pull request #12261:
URL: https://github.com/apache/beam/pull/12261#issuecomment-659008094
Ah, thanks for catching that. Test added.
This is an automated message from the Apache Git Service.
To respond
kennknowles opened a new pull request #12271:
URL: https://github.com/apache/beam/pull/12271
The total number of nullability issues in `:sdks:java:core` is very high.
These are some baby steps towards embracing nullability typing. While not
discovering any latent NPE this time, it did
kennknowles commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658995800
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kennknowles commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658994369
Oddly enough, the test failure did not get uploaded in the gradle scan. The
scan is just for the license pull.
ibzib commented on pull request #12270:
URL: https://github.com/apache/beam/pull/12270#issuecomment-658993658
Run Samza ValidatesRunner
This is an automated message from the Apache Git Service.
To respond to the message,
pabloem commented on pull request #12262:
URL: https://github.com/apache/beam/pull/12262#issuecomment-658991901
thanks Luke! It looks nice! : P
This is an automated message from the Apache Git Service.
To respond to the
pabloem merged pull request #12262:
URL: https://github.com/apache/beam/pull/12262
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
iemejia merged pull request #12265:
URL: https://github.com/apache/beam/pull/12265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
ibzib opened a new pull request #12270:
URL: https://github.com/apache/beam/pull/12270
The Samza runner is already excluding all the other tests annotated
`UsesUnboundedPCollections`.
Before: 226 tests completed, 1 failed, 2 skipped
After: 225 tests completed, 0 failed, 2 skipped
lukecwik commented on pull request #12262:
URL: https://github.com/apache/beam/pull/12262#issuecomment-658980867
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
tysonjh commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658979464
R: @kennknowles
I added some license comments just to be cautious.
This is an automated message from the
kennknowles commented on a change in pull request #12254:
URL: https://github.com/apache/beam/pull/12254#discussion_r455302615
##
File path: website/www/site/content/en/documentation/dsls/sql/overview.md
##
@@ -55,8 +55,12 @@ For more information on the ZetaSQL features in
tysonjh commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658963802
Run JavaPortabilityApiJava11 PreCommit
This is an automated message from the Apache Git Service.
To respond to
tysonjh commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658963480
Run Java_Examples_Dataflow_Java11 PreCommit
This is an automated message from the Apache Git Service.
To respond
tysonjh commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658963276
Run Java_Examples_Dataflow_Java11 PreCommit please
This is an automated message from the Apache Git Service.
To
robertwb closed pull request #12259:
URL: https://github.com/apache/beam/pull/12259
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #12259:
URL: https://github.com/apache/beam/pull/12259#issuecomment-658956391
R: @ibzib Could you take a look at this?
This is an automated message from the Apache Git Service.
To respond
davidcavazos edited a comment on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658939252
I also noticed that the output tags were a little misleading now since we
are showing the stdout instead of an output PCollection.
Opened #12269 for that
davidcavazos opened a new pull request #12269:
URL: https://github.com/apache/beam/pull/12269
**No content changes**
Now that we are displaying the `stdout` content instead of the `PCollection`
contents, the previous output tag was a little misleading. This just goes
through all
tysonjh commented on pull request #12268:
URL: https://github.com/apache/beam/pull/12268#issuecomment-658940970
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
davidcavazos commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658939252
I also noticed that the output tags were a little misleading now since we
are showing the stdout instead of an output PCollection
davidcavazos commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658937924
@aaltay I've addressed the comments
This is an automated message from the Apache Git Service.
To respond to
tysonjh opened a new pull request #12268:
URL: https://github.com/apache/beam/pull/12268
Add JAXB core/impl as test dependency.
In Java 9 many EE modules were removed from core Java. This change
reintroduces the JAXB modules, updates their minor versions, in
preparation for
robinyqiu commented on pull request #12247:
URL: https://github.com/apache/beam/pull/12247#issuecomment-658934753
> I know of at least one customer use case where they are disabling
BeamZetaSqlCalcRel so they can avoid JNI. We also have plans to turn
BeamCalcRel back on for simple
lukecwik commented on pull request #12262:
URL: https://github.com/apache/beam/pull/12262#issuecomment-658934055
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay merged pull request #1:
URL: https://github.com/apache/beam/pull/1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #1:
URL: https://github.com/apache/beam/pull/1#issuecomment-658930446
LGTM. Let's merge this. Thank you.
This is an automated message from the Apache Git Service.
To respond to the
aaltay commented on pull request #12252:
URL: https://github.com/apache/beam/pull/12252#issuecomment-658929492
(Please ping me once the open comments are addressed.)
This is an automated message from the Apache Git Service.
aaltay merged pull request #12217:
URL: https://github.com/apache/beam/pull/12217
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
sclukas77 opened a new pull request #12267:
URL: https://github.com/apache/beam/pull/12267
Created generalized table and tableprovider wrappers in Beam SQL,
implementing for Pubsub.
Additional info on project:
robinyqiu commented on pull request #12261:
URL: https://github.com/apache/beam/pull/12261#issuecomment-658919794
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
davidcavazos commented on pull request #12118:
URL: https://github.com/apache/beam/pull/12118#issuecomment-658918522
There are some errors saying `SLF4J: Failed to load class
"org.slf4j.impl.StaticLoggerBinder".`
Does anyone know what they mean and how to fix them?
aaltay commented on pull request #12233:
URL: https://github.com/apache/beam/pull/12233#issuecomment-658916388
> @aaltay thanks for merging :)
>
> Actually I was wrong with statement: "workflows are run only when they
merged to master".
> It is possible to run workflows not
pabloem commented on pull request #12074:
URL: https://github.com/apache/beam/pull/12074#issuecomment-658915637
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
robinyqiu commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r455235874
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@
ZijieSong946 commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r455234860
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@
robinyqiu commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r455233394
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/translation/ExpressionConverter.java
##
@@
robinyqiu commented on a change in pull request #12174:
URL: https://github.com/apache/beam/pull/12174#discussion_r455231610
##
File path:
sdks/java/extensions/sql/zetasql/src/main/java/org/apache/beam/sdk/extensions/sql/zetasql/ZetaSqlTypesUtils.java
##
@@ -0,0 +1,42 @@
+/*
saavannanavati commented on a change in pull request #12009:
URL: https://github.com/apache/beam/pull/12009#discussion_r455230574
##
File path: website/www/site/content/en/documentation/sdks/python-type-safety.md
##
@@ -90,6 +91,15 @@ The following code declares an `int` input
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r455218522
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/CEPTypeName.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r455218522
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/CEPTypeName.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed
Mark-Zeng commented on a change in pull request #12232:
URL: https://github.com/apache/beam/pull/12232#discussion_r455213949
##
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/impl/cep/CEPTypeName.java
##
@@ -0,0 +1,33 @@
+/*
+ * Licensed
1 - 100 of 162 matches
Mail list logo
