pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-668367941
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12203:
URL: https://github.com/apache/beam/pull/12203#issuecomment-668367716
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
ihji commented on pull request #12325:
URL: https://github.com/apache/beam/pull/12325#issuecomment-668359376
Run Python 3.7 PostCommit
This is an automated message from the Apache Git Service.
To respond to the message,
ihji commented on pull request #12325:
URL: https://github.com/apache/beam/pull/12325#issuecomment-668359113
Thanks, looks good to me overall.
Is there any way to share the pipeline codes in `CrossLanguageKafkaIOTest`
and `CrossLanguageKafkaIO`? Could we share the pipeline codes and
amaliujia commented on pull request #12461:
URL: https://github.com/apache/beam/pull/12461#issuecomment-668356948
R: @ibzib
This is an automated message from the Apache Git Service.
To respond to the message, please log on
amaliujia opened a new pull request #12461:
URL: https://github.com/apache/beam/pull/12461
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
damondouglas commented on a change in pull request #12448:
URL: https://github.com/apache/beam/pull/12448#discussion_r464765533
##
File path:
learning/katas/go/core_transforms/additional_parameters/additional_parameters/task.md
##
@@ -0,0 +1,84 @@
+
+
+# Additional Parameters
TheNeuralBit commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464732307
##
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##
@@ -855,10 +855,21 @@ message StandardCoders {
// BOOLEAN:
TheNeuralBit commented on pull request #12454:
URL: https://github.com/apache/beam/pull/12454#issuecomment-668302572
Oh also it looks like the Java PreCommit failure may be due to a legitimate
issue in spotbugs, you may want to check that locally.
TheNeuralBit commented on a change in pull request #12454:
URL: https://github.com/apache/beam/pull/12454#discussion_r464726158
##
File path:
sdks/java/expansion-service/src/main/java/org/apache/beam/sdk/expansion/service/ExpansionService.java
##
@@ -107,39 +107,39 @@
youngoli commented on pull request #12350:
URL: https://github.com/apache/beam/pull/12350#issuecomment-668301428
Run Go PostCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
lostluck commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r464717996
##
File path: sdks/go/examples/xlang/wordcount/xlang_wordcount.go
##
@@ -0,0 +1,100 @@
+package main
+
+import (
+ "context"
+ "flag"
+
KevinGG commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r464721910
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_runner_test.py
##
@@ -66,6 +66,7 @@ class InteractiveRunnerTest(unittest.TestCase):
TheNeuralBit commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r464721198
##
File path: sdks/python/apache_beam/testing/datatype_inference_test.py
##
@@ -174,6 +175,7 @@ def test_infer_typehints_schema(self, _, data,
aaltay merged pull request #12304:
URL: https://github.com/apache/beam/pull/12304
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #12304:
URL: https://github.com/apache/beam/pull/12304#issuecomment-668292310
Merging. @kennknowles @xinyuiscool - if you have additional comments please
fix it with a new pr.
This is an
aaltay commented on a change in pull request #12452:
URL: https://github.com/apache/beam/pull/12452#discussion_r464716197
##
File path: sdks/python/apache_beam/runners/portability/portable_runner_test.py
##
@@ -284,6 +284,7 @@ def create_options(self):
return options
TheNeuralBit merged pull request #12456:
URL: https://github.com/apache/beam/pull/12456
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
danielxjd commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r464705615
##
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##
@@ -230,12 +281,271 @@ public ReadFiles
TheNeuralBit commented on a change in pull request #12422:
URL: https://github.com/apache/beam/pull/12422#discussion_r464702259
##
File path:
sdks/java/io/kinesis/src/test/java/org/apache/beam/sdk/io/kinesis/KinesisIOIT.java
##
@@ -99,28 +116,101 @@ private void runRead() {
danielxjd commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r464701869
##
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##
@@ -230,12 +281,271 @@ public ReadFiles
danielxjd commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r464700678
##
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##
@@ -177,6 +214,10 @@ public Read from(String
leiyiz commented on pull request #12365:
URL: https://github.com/apache/beam/pull/12365#issuecomment-668277274
> oops sorry what happened in this PR after all?
I closed this draft and had opened a PR here:
https://github.com/apache/beam/pull/12427
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699645
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1193,6 +1328,7 @@ public Object restriction() {
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699501
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464699157
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
boyuanzz commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464697946
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
robertwb commented on a change in pull request #12352:
URL: https://github.com/apache/beam/pull/12352#discussion_r464679106
##
File path: sdks/python/apache_beam/runners/worker/operations.py
##
@@ -238,6 +247,7 @@ def __init__(self,
self.execution_context = None # type:
boyuanzz commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464686872
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -1035,6 +1046,130 @@ private Progress getProgress()
lukecwik commented on a change in pull request #12430:
URL: https://github.com/apache/beam/pull/12430#discussion_r464673014
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -515,6 +515,9 @@
&&
apilloud commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-668260372
LGTM. There is a script `sdks/java/build-tools/beam-linkage-check.sh` that
is suppose to validate version changes don't introduce new compatibility
issues. Can you run it and
boyuanzz merged pull request #12371:
URL: https://github.com/apache/beam/pull/12371
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
chamikaramj commented on a change in pull request #12445:
URL: https://github.com/apache/beam/pull/12445#discussion_r464672379
##
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/ValidateRunnerXlangTest.java
##
@@ -177,6
aaltay commented on a change in pull request #12444:
URL: https://github.com/apache/beam/pull/12444#discussion_r464672903
##
File path: .test-infra/jenkins/job_PreCommit_Whitespace.groovy
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+
lukecwik commented on a change in pull request #12419:
URL: https://github.com/apache/beam/pull/12419#discussion_r464651698
##
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##
@@ -515,15 +515,18 @@
&&
boyuanzz commented on pull request #11749:
URL: https://github.com/apache/beam/pull/11749#issuecomment-668251029
Based on the [readAll
discussion](https://lists.apache.org/thread.html/rcb7538d5a2955d12e6d5f37a24830b929e5d65155d84f6d999801432%40%3Cdev.beam.apache.org%3E),
I decided to go
robertwb commented on pull request #12459:
URL: https://github.com/apache/beam/pull/12459#issuecomment-668251189
R: @apilloud
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chamikaramj commented on a change in pull request #12223:
URL: https://github.com/apache/beam/pull/12223#discussion_r464659415
##
File path:
sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java
##
@@ -177,6 +214,10 @@ public Read from(String
boyuanzz commented on a change in pull request #11749:
URL: https://github.com/apache/beam/pull/11749#discussion_r464667015
##
File path:
sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaIO.java
##
@@ -906,19 +926,89 @@ public void
amaliujia edited a comment on pull request #12232:
URL: https://github.com/apache/beam/pull/12232#issuecomment-668147610
Interesting. I used the squash and merge button but it seems just create a
merge commit. It might not matter that much.
pabloem commented on pull request #12442:
URL: https://github.com/apache/beam/pull/12442#issuecomment-668240989
thanks Ning!
This is an automated message from the Apache Git Service.
To respond to the message, please log on
pabloem merged pull request #12442:
URL: https://github.com/apache/beam/pull/12442
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pabloem merged pull request #12339:
URL: https://github.com/apache/beam/pull/12339
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
KevinGG commented on a change in pull request #12339:
URL: https://github.com/apache/beam/pull/12339#discussion_r464658479
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -364,26 +382,37 @@ def get_background_caching_job(self,
chamikaramj commented on pull request #12071:
URL: https://github.com/apache/beam/pull/12071#issuecomment-668237855
Seems like commit history got messed up.
This is an automated message from the Apache Git Service.
To
KevinGG commented on a change in pull request #12339:
URL: https://github.com/apache/beam/pull/12339#discussion_r464657824
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -364,26 +382,37 @@ def get_background_caching_job(self,
robertwb opened a new pull request #12459:
URL: https://github.com/apache/beam/pull/12459
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
pabloem commented on pull request #12331:
URL: https://github.com/apache/beam/pull/12331#issuecomment-668233131
LGTM. I'll merge once tests pass.
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on a change in pull request #12339:
URL: https://github.com/apache/beam/pull/12339#discussion_r464650111
##
File path:
sdks/python/apache_beam/runners/interactive/interactive_environment.py
##
@@ -364,26 +382,37 @@ def get_background_caching_job(self,
lostluck commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464647966
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
rosetn commented on pull request #12380:
URL: https://github.com/apache/beam/pull/12380#issuecomment-668225776
LGTM
FYI @davidcavazos
This is an automated message from the Apache Git Service.
To respond to the
pabloem commented on pull request #12365:
URL: https://github.com/apache/beam/pull/12365#issuecomment-668225000
oops sorry what happened in this PR after all?
This is an automated message from the Apache Git Service.
To
chamikaramj commented on pull request #12438:
URL: https://github.com/apache/beam/pull/12438#issuecomment-668219156
Yeah, probably better to make INET6 a fallback.
This is an automated message from the Apache Git Service.
To
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464636772
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
amaliujia merged pull request #12436:
URL: https://github.com/apache/beam/pull/12436
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
robertwb commented on a change in pull request #12455:
URL: https://github.com/apache/beam/pull/12455#discussion_r464634785
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -1163,7 +1180,7 @@ Use reporter.apache.org to seed the information about the
lostluck commented on a change in pull request #12350:
URL: https://github.com/apache/beam/pull/12350#discussion_r464552611
##
File path: sdks/go/pkg/beam/core/runtime/exec/datasource_test.go
##
@@ -18,6 +18,7 @@ package exec
import (
"context"
"fmt"
+
robertwb merged pull request #12458:
URL: https://github.com/apache/beam/pull/12458
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb merged pull request #12391:
URL: https://github.com/apache/beam/pull/12391
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
robertwb commented on pull request #12391:
URL: https://github.com/apache/beam/pull/12391#issuecomment-668214822
The one failure looks like BEAM-10252.
This is an automated message from the Apache Git Service.
To respond to
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464632452
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
George-Wu commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464632452
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
robertwb commented on pull request #12391:
URL: https://github.com/apache/beam/pull/12391#issuecomment-668213773
Run Java PreCommit
This is an automated message from the Apache Git Service.
To respond to the message, please
tysonjh commented on pull request #12416:
URL: https://github.com/apache/beam/pull/12416#issuecomment-668212843
R: @apilloud
Could you take a look at this please?
This is an automated message from the Apache Git
pabloem commented on a change in pull request #12331:
URL: https://github.com/apache/beam/pull/12331#discussion_r464624146
##
File path: sdks/python/apache_beam/io/gcp/dicomio.py
##
@@ -0,0 +1,572 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
kkucharc commented on a change in pull request #12151:
URL: https://github.com/apache/beam/pull/12151#discussion_r464628091
##
File path:
sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeStreamingServiceConfig.java
##
@@ -20,26 +20,51 @@
TheNeuralBit commented on pull request #12454:
URL: https://github.com/apache/beam/pull/12454#issuecomment-668206369
Run XVR_Flink PostCommit
This is an automated message from the Apache Git Service.
To respond to the
purbanow commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-668198426
Locally `./gradlew :sdks:java:io:snowflake:compileJava` is passing:
rohdesamuel commented on pull request #12411:
URL: https://github.com/apache/beam/pull/12411#issuecomment-668194153
R: @pabloem
This is an automated message from the Apache Git Service.
To respond to the message, please log
lostluck commented on a change in pull request #12448:
URL: https://github.com/apache/beam/pull/12448#discussion_r464583093
##
File path:
learning/katas/go/core_transforms/additional_parameters/additional_parameters/task.md
##
@@ -0,0 +1,84 @@
+
+
+# Additional Parameters -
Imfuyuwei removed a comment on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668190838
retest this please
This is an automated message from the Apache Git Service.
To respond to the
Imfuyuwei commented on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668190838
retest this please
This is an automated message from the Apache Git Service.
To respond to the message, please
aaltay commented on pull request #12453:
URL: https://github.com/apache/beam/pull/12453#issuecomment-668189188
LGTM. I can merge if there are not additional comments. Could you review the
failing test?
@lakshmanok @datancoffee @santhh - Do you have additional feedback on this
PR?
Borzoo commented on pull request #12304:
URL: https://github.com/apache/beam/pull/12304#issuecomment-668186826
@aaltay Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
chamikaramj commented on pull request #12149:
URL: https://github.com/apache/beam/pull/12149#issuecomment-668184765
Seems like failure is related ?
08:54:30 * What went wrong:
08:54:30 Execution failed for task ':sdks:java:io:snowflake:compileJava'.
08:54:30 > Compilation
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183674
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183158
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
KevinGG commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668183021
> LGTM. Would it make sense to announce this on the dev@ list? Or do you
think this is will sufficiently have minimal impact.
Once we merge it, I'll check if new PRs would
aaltay merged pull request #12437:
URL: https://github.com/apache/beam/pull/12437
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay merged pull request #12457:
URL: https://github.com/apache/beam/pull/12457
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
y1chi commented on pull request #12458:
URL: https://github.com/apache/beam/pull/12458#issuecomment-668178733
R: @tvalentyn @udim
This is an automated message from the Apache Git Service.
To respond to the message, please
y1chi opened a new pull request #12458:
URL: https://github.com/apache/beam/pull/12458
**Please** add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly
aaltay merged pull request #12409:
URL: https://github.com/apache/beam/pull/12409
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aaltay commented on pull request #12444:
URL: https://github.com/apache/beam/pull/12444#issuecomment-668175310
LGTM. Would it make sense to announce this on the dev@ list? Or do you think
this is will sufficiently have minimal impact.
boyuanzz commented on pull request #12430:
URL: https://github.com/apache/beam/pull/12430#issuecomment-668168142
Currently `Truncate` didn't report progress via
`addProgressRequestCallback`. It would result in incorrect progress when
`Truncate` observing windows. If `Truncate` reports
lukecwik commented on a change in pull request #12371:
URL: https://github.com/apache/beam/pull/12371#discussion_r464580334
##
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/SplittableParDoExpander.java
##
@@ -214,39
rosetn commented on pull request #12437:
URL: https://github.com/apache/beam/pull/12437#issuecomment-668165492
LGTM
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
saavannanavati commented on pull request #12242:
URL: https://github.com/apache/beam/pull/12242#issuecomment-668157896
R: @udim
R: @robertwb
PTAL - this is ready for review
This is an automated message from the
aaltay commented on a change in pull request #12455:
URL: https://github.com/apache/beam/pull/12455#discussion_r464570198
##
File path: website/www/site/content/en/contribute/release-guide.md
##
@@ -244,7 +247,21 @@ __Attention__: Only PMC has permission to perform this. If
robertwb commented on a change in pull request #12440:
URL: https://github.com/apache/beam/pull/12440#discussion_r464566521
##
File path: sdks/python/apache_beam/dataframe/doctests.py
##
@@ -290,34 +298,60 @@ def to_callable(cond):
super(BeamDataframeDoctestRunner,
amaliujia commented on a change in pull request #12436:
URL: https://github.com/apache/beam/pull/12436#discussion_r464567320
##
File path: settings.gradle
##
@@ -179,3 +179,4 @@ include "beam-test-tools"
project(":beam-test-tools").dir = file(".test-infra/tools")
include
amaliujia commented on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668151996
Run Spotless PreCommit
This is an automated message from the Apache Git Service.
To respond to the message,
amaliujia commented on pull request #12436:
URL: https://github.com/apache/beam/pull/12436#issuecomment-668151777
Run Python2_PVR_Flink PreCommit
This is an automated message from the Apache Git Service.
To respond to the
davidcavazos opened a new pull request #12457:
URL: https://github.com/apache/beam/pull/12457
Add `Min` code snippets.
R: @aaltay
R: @rosetn
Staged:
amaliujia commented on pull request #12232:
URL: https://github.com/apache/beam/pull/12232#issuecomment-668147610
Interesting. I used the squash and merge button but it seems just create a
merge pull request. It might not matter that much.
robertwb commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464556809
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
amaliujia merged pull request #12232:
URL: https://github.com/apache/beam/pull/12232
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
lukecwik merged pull request #12450:
URL: https://github.com/apache/beam/pull/12450
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kanterov commented on pull request #12456:
URL: https://github.com/apache/beam/pull/12456#issuecomment-668145076
R: @TheNeuralBit
This is an automated message from the Apache Git Service.
To respond to the message, please
robertwb commented on a change in pull request #12426:
URL: https://github.com/apache/beam/pull/12426#discussion_r464554560
##
File path: sdks/python/apache_beam/coders/coder_impl.py
##
@@ -530,6 +530,88 @@ def estimate_size(self, unused_value, nested=False):
return 1
1 - 100 of 163 matches
Mail list logo