[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] leiyiz opened a new pull request #12808: add readme file to python nexmark

2020-09-09 Thread GitBox
leiyiz opened a new pull request #12808: URL: https://github.com/apache/beam/pull/12808 this readme file contains the instruction for running the nexmark suite for python Thank you for your contribution! Follow this checklist to help us incorporate

[GitHub] [beam] codecov[bot] commented on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
codecov[bot] commented on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689997960 # [Codecov](https://codecov.io/gh/apache/beam/pull/12807?src=pr=h1) Report > Merging [#12807](https://codecov.io/gh/apache/beam/pull/12807?src=pr=desc) into

[GitHub] [beam] monicadsong commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
monicadsong commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r486076366 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -41,355 +41,88 @@ from apache_beam.transforms.display import DisplayData from

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] leiyiz commented on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
leiyiz commented on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689995629 Run PythonLint PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] leiyiz opened a new pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
leiyiz opened a new pull request #12807: URL: https://github.com/apache/beam/pull/12807 implemented query 10, now query 10 is still not runnable because it seems like Beam team hasn't made up mind about what to do with this query.

[GitHub] [beam] leiyiz commented on pull request #12807: [BEAM-2855] implement query 10

2020-09-09 Thread GitBox
leiyiz commented on pull request #12807: URL: https://github.com/apache/beam/pull/12807#issuecomment-689990552 R: @y1chi R: @pabloem This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] boyuanzz opened a new pull request #12806: [BEAM-10869] Use PubsubMessagePayloadOnlyCoder when writing to Pubsub.

2020-09-09 Thread GitBox
boyuanzz opened a new pull request #12806: URL: https://github.com/apache/beam/pull/12806 **Please** add a meaningful description for your change here Thank you for your contribution! Follow this checklist to help us incorporate your contribution

[GitHub] [beam] qinyeli commented on pull request #12686: Removing dead code from Interactive Beam.

2020-09-09 Thread GitBox
qinyeli commented on pull request #12686: URL: https://github.com/apache/beam/pull/12686#issuecomment-689955735 Is this something that happens often? Do you know how we can resolve this? This is an automated message from the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] pheonixblade9 opened a new pull request #12805: [BEAM-10867] Add file generation to GcsPath

2020-09-09 Thread GitBox
pheonixblade9 opened a new pull request #12805: URL: https://github.com/apache/beam/pull/12805 Add generation as an option for GcsPath in order to better support different file versions. Thank you for your contribution! Follow this checklist to help

[GitHub] [beam] youngoli commented on pull request #12792: [DO NOT MERGE] Run Python RC Validation Tests

2020-09-09 Thread GitBox
youngoli commented on pull request #12792: URL: https://github.com/apache/beam/pull/12792#issuecomment-689911697 Run Python ReleaseCandidate This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-689905869 Please resolve the conflict. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-689905821 LGTM. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689904222 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] chamikaramj commented on a change in pull request #12638: [BEAM-10769] Clarify Avro IO documentation.

2020-09-09 Thread GitBox
chamikaramj commented on a change in pull request #12638: URL: https://github.com/apache/beam/pull/12638#discussion_r485998552 ## File path: sdks/python/apache_beam/io/avroio.py ## @@ -90,7 +78,7 @@ def __init__( file_pattern=None, min_bundle_size=0,

[GitHub] [beam] chamikaramj commented on pull request #12611: [BEAM-10139][BEAM-10140] Add cross-language support for Java SpannerIO with python wrapper

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12611: URL: https://github.com/apache/beam/pull/12611#issuecomment-689900820 cc: @allenpradeep @nielm This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] yifanmai commented on pull request #12804: Fix translations.optimize_pipeline() failure on empty pipelines

2020-09-09 Thread GitBox
yifanmai commented on pull request #12804: URL: https://github.com/apache/beam/pull/12804#issuecomment-689900832 R: @robertwb This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] yifanmai opened a new pull request #12804: Fix translations.optimize_pipeline() failure on empty pipelines

2020-09-09 Thread GitBox
yifanmai opened a new pull request #12804: URL: https://github.com/apache/beam/pull/12804 Previously, `translations.optimize_pipeline()` failed on an empty pipeline because the `leaf_transform_stages()` returned no stages for an empty pipeline. This change makes `leaf_transform_stages()`

[GitHub] [beam] chamikaramj commented on a change in pull request #12767: Remove experimental annotations for BQ storage API source

2020-09-09 Thread GitBox
chamikaramj commented on a change in pull request #12767: URL: https://github.com/apache/beam/pull/12767#discussion_r485996726 ## File path: website/www/site/content/en/documentation/io/built-in/google-bigquery.md ## @@ -322,21 +322,17 @@ in the following example: ### Using

[GitHub] [beam] codecov[bot] edited a comment on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-682258884 # [Codecov](https://codecov.io/gh/apache/beam/pull/12695?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@1019ef3`). [Click

[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-09-09 Thread GitBox
nehsyc commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r485993132 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java ## @@ -100,8 +99,7 @@ public long getBatchSize() {

[GitHub] [beam] allenpradeep commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-09-09 Thread GitBox
allenpradeep commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-689895773 > Allen, are you doing further updates here ? If not we can merge. Hi Cham, I'll a few more tests and rebase this.

[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-689895432 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #12255: [BEAM-9910]Add mutation byte counters to SpannerIO.write

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12255: URL: https://github.com/apache/beam/pull/12255#issuecomment-689895246 Allen, are you doing further updates here ? If not we can merge. This is an automated message from the

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689894543 Seems like failure is related:

[GitHub] [beam] nehsyc commented on a change in pull request #12678: [BEAM-10703] Add a step property for shardable states during Dataflow graph translation (Java)

2020-09-09 Thread GitBox
nehsyc commented on a change in pull request #12678: URL: https://github.com/apache/beam/pull/12678#discussion_r485991869 ## File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java ## @@ -1264,6 +1268,10 @@

[GitHub] [beam] ibzib commented on pull request #12803: [BEAM-10762] Fix artifact staging bug in Flink/Spark uber jar runners.

2020-09-09 Thread GitBox
ibzib commented on pull request #12803: URL: https://github.com/apache/beam/pull/12803#issuecomment-689891332 cc: @charlesccychen This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] ibzib opened a new pull request #12803: [BEAM-10762] Fix artifact staging bug in Flink/Spark uber jar runners.

2020-09-09 Thread GitBox
ibzib opened a new pull request #12803: URL: https://github.com/apache/beam/pull/12803 - Replace the obsolete artifact staging token with the NO ARTIFACTS placeholder. - Add a test that verifies pipelines pass when no artifacts are staged. R: @robertwb

[GitHub] [beam] monicadsong commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
monicadsong commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485985580 ## File path: sdks/python/container/license_scripts/dep_urls_py.yaml ## @@ -77,8 +77,6 @@ pip_dependencies: license:

[GitHub] [beam] monicadsong commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
monicadsong commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485985426 ## File path: sdks/python/container/license_scripts/dep_urls_py.yaml ## @@ -77,8 +77,6 @@ pip_dependencies: license:

[GitHub] [beam] aaltay commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
aaltay commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485984077 ## File path: sdks/python/container/license_scripts/dep_urls_py.yaml ## @@ -77,8 +77,6 @@ pip_dependencies: license:

[GitHub] [beam] tvalentyn commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
tvalentyn commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485983860 ## File path: sdks/python/container/license_scripts/dep_urls_py.yaml ## @@ -77,8 +77,6 @@ pip_dependencies: license:

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
tvalentyn commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485982785 ## File path: sdks/python/apache_beam/transforms/stats_test.py ## @@ -41,355 +41,88 @@ from apache_beam.transforms.display import DisplayData from

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12782: Overriding Dataflow Native BQSource.

2020-09-09 Thread GitBox
pabloem commented on pull request #12782: URL: https://github.com/apache/beam/pull/12782#issuecomment-689880624 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] aaltay commented on a change in pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
aaltay commented on a change in pull request #12756: URL: https://github.com/apache/beam/pull/12756#discussion_r485976987 ## File path: sdks/python/container/base_image_requirements.txt ## @@ -57,6 +57,7 @@ google-cloud-datastore==1.7.4 cython==0.29.13

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] robertwb commented on pull request #12802: Deprecate obsolete CombineFn.add_inputs.

2020-09-09 Thread GitBox
robertwb commented on pull request #12802: URL: https://github.com/apache/beam/pull/12802#issuecomment-689874792 R: @iindyk This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] codecov[bot] edited a comment on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-683610379 # [Codecov](https://codecov.io/gh/apache/beam/pull/12656?src=pr=h1) Report > Merging [#12656](https://codecov.io/gh/apache/beam/pull/12656?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12756: [BEAM-10824] [BEAM-7654] Change hash function in ApproximateUniqueCombineFn

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12756: URL: https://github.com/apache/beam/pull/12756#issuecomment-685255075 # [Codecov](https://codecov.io/gh/apache/beam/pull/12756?src=pr=h1) Report > Merging [#12756](https://codecov.io/gh/apache/beam/pull/12756?src=pr=desc) into

[GitHub] [beam] robertwb opened a new pull request #12802: Deprecate obsolete CombineFn.add_inputs.

2020-09-09 Thread GitBox
robertwb opened a new pull request #12802: URL: https://github.com/apache/beam/pull/12802 This clarifies and cleans up the code. Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689053328 # [Codecov](https://codecov.io/gh/apache/beam/pull/12760?src=pr=h1) Report > Merging [#12760](https://codecov.io/gh/apache/beam/pull/12760?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689864226 Retest this please This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #12760: [BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12760: URL: https://github.com/apache/beam/pull/12760#issuecomment-689864084 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr=desc) into

[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689853466 Thanks. I'll merge this after post-commits pass. This is an automated message from the Apache Git Service.

[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689853251 Run Dataflow ValidatesRunner This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689853077 Run Java PostCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689852377 Let's run post-commits as well. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689852290 Run Python 3.8 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] chamikaramj commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
chamikaramj commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689852212 Run Python 3.5 PostCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12801: URL: https://github.com/apache/beam/pull/12801#issuecomment-689841091 # [Codecov](https://codecov.io/gh/apache/beam/pull/12801?src=pr=h1) Report > Merging [#12801](https://codecov.io/gh/apache/beam/pull/12801?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12801: URL: https://github.com/apache/beam/pull/12801#issuecomment-689841091 # [Codecov](https://codecov.io/gh/apache/beam/pull/12801?src=pr=h1) Report > Merging [#12801](https://codecov.io/gh/apache/beam/pull/12801?src=pr=desc) into

[GitHub] [beam] udim commented on pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
udim commented on pull request #12801: URL: https://github.com/apache/beam/pull/12801#issuecomment-689843714 R: @robertwb @saavannanavati This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] KevinGG commented on a change in pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
KevinGG commented on a change in pull request #12770: URL: https://github.com/apache/beam/pull/12770#discussion_r485945215 ## File path: sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts ## @@ -0,0 +1,120 @@ +// Licensed

[GitHub] [beam] KevinGG commented on a change in pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
KevinGG commented on a change in pull request #12770: URL: https://github.com/apache/beam/pull/12770#discussion_r485945371 ## File path: sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/style/mdc-theme.css ## @@ -0,0 +1,43 @@ +/* + *

[GitHub] [beam] KevinGG commented on a change in pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
KevinGG commented on a change in pull request #12770: URL: https://github.com/apache/beam/pull/12770#discussion_r485945032 ## File path: sdks/python/apache_beam/runners/interactive/extensions/apache-beam-jupyterlab-sidepanel/src/SidePanel.ts ## @@ -0,0 +1,120 @@ +// Licensed

[GitHub] [beam] codecov[bot] edited a comment on pull request #12770: [BEAM-10545] Assembled the extension with components

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12770: URL: https://github.com/apache/beam/pull/12770#issuecomment-686768654 # [Codecov](https://codecov.io/gh/apache/beam/pull/12770?src=pr=h1) Report > Merging [#12770](https://codecov.io/gh/apache/beam/pull/12770?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12801: URL: https://github.com/apache/beam/pull/12801#issuecomment-689841091 # [Codecov](https://codecov.io/gh/apache/beam/pull/12801?src=pr=h1) Report > Merging [#12801](https://codecov.io/gh/apache/beam/pull/12801?src=pr=desc) into

[GitHub] [beam] ihji merged pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
ihji merged pull request #12786: URL: https://github.com/apache/beam/pull/12786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [beam] yifanmai commented on a change in pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-09 Thread GitBox
yifanmai commented on a change in pull request #12787: URL: https://github.com/apache/beam/pull/12787#discussion_r485943641 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -704,6 +705,64 @@ def fix_side_input_pcoll_coders(stages,

[GitHub] [beam] yifanmai commented on a change in pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-09 Thread GitBox
yifanmai commented on a change in pull request #12787: URL: https://github.com/apache/beam/pull/12787#discussion_r485943483 ## File path: sdks/python/apache_beam/runners/portability/fn_api_runner/translations.py ## @@ -704,6 +705,64 @@ def fix_side_input_pcoll_coders(stages,

[GitHub] [beam] yifanmai commented on pull request #12656: [BEAM-10781] Add PTransformOverride.get_replacement_transform_for_applied_ptransform()

2020-09-09 Thread GitBox
yifanmai commented on pull request #12656: URL: https://github.com/apache/beam/pull/12656#issuecomment-689841127 @chamikaramj Can this be merged? This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] commented on pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
codecov[bot] commented on pull request #12801: URL: https://github.com/apache/beam/pull/12801#issuecomment-689841091 # [Codecov](https://codecov.io/gh/apache/beam/pull/12801?src=pr=h1) Report > Merging [#12801](https://codecov.io/gh/apache/beam/pull/12801?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12787: [BEAM-10641] Add eliminate_common_key_with_none graph optimizer

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12787: URL: https://github.com/apache/beam/pull/12787#issuecomment-689105076 # [Codecov](https://codecov.io/gh/apache/beam/pull/12787?src=pr=h1) Report > Merging [#12787](https://codecov.io/gh/apache/beam/pull/12787?src=pr=desc) into

[GitHub] [beam] udim commented on pull request #12768: Change coveralls badge to codecov

2020-09-09 Thread GitBox
udim commented on pull request #12768: URL: https://github.com/apache/beam/pull/12768#issuecomment-689834823 Also, you code label this PR as part of BEAM-10701 for tracking This is an automated message from the Apache Git

[GitHub] [beam] udim opened a new pull request #12801: [BEAM-10701] Fix Python coverage reporting

2020-09-09 Thread GitBox
udim opened a new pull request #12801: URL: https://github.com/apache/beam/pull/12801 - `run_pytest.sh` runs pytest twice. The second run was overwriting the first's results. - Simplified argument passing to run_pytest.sh. - Use the default coverage.xml report (was generating both

[GitHub] [beam] terryxian78 commented on pull request #12695: [BEAM-8758] Google-cloud-spanner upgrade to 1.59.0 and google_cloud_bigtable_client_core to 1.16.0

2020-09-09 Thread GitBox
terryxian78 commented on pull request #12695: URL: https://github.com/apache/beam/pull/12695#issuecomment-689829063 @chamikaramj, ping... I've resolved all concerns (no objection on GcpAPISurfaceTest), pls let me know if it is okay to merge? I have another PR which you asked me to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-689776953 # [Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr=h1) Report > Merging [#12588](https://codecov.io/gh/apache/beam/pull/12588?src=pr=desc) into

[GitHub] [beam] runningcode commented on a change in pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-09 Thread GitBox
runningcode commented on a change in pull request #12776: URL: https://github.com/apache/beam/pull/12776#discussion_r485916221 ## File path: runners/flink/build.gradle ## @@ -0,0 +1,32 @@ +/* Review comment: This is an optimization, but it is also required in order to

[GitHub] [beam] runningcode commented on a change in pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-09 Thread GitBox
runningcode commented on a change in pull request #12776: URL: https://github.com/apache/beam/pull/12776#discussion_r485916221 ## File path: runners/flink/build.gradle ## @@ -0,0 +1,32 @@ +/* Review comment: This is an optimization, but it is also required in order to

[GitHub] [beam] lostluck commented on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-09 Thread GitBox
lostluck commented on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-689814660 Run Go PostCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] danielxjd commented on pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
danielxjd commented on pull request #12786: URL: https://github.com/apache/beam/pull/12786#issuecomment-689812448 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] mxm commented on a change in pull request #12776: [BEAM-9456] Upgrade Gradle to 6.6.1 (smaller version of #12568)

2020-09-09 Thread GitBox
mxm commented on a change in pull request #12776: URL: https://github.com/apache/beam/pull/12776#discussion_r485910049 ## File path: runners/flink/build.gradle ## @@ -0,0 +1,32 @@ +/* Review comment: Is this merely an optimization to avoid running Spotless for each

[GitHub] [beam] udim commented on pull request #12798: [BEAM-10833] Fix type inference for BUILD_MAP.

2020-09-09 Thread GitBox
udim commented on pull request #12798: URL: https://github.com/apache/beam/pull/12798#issuecomment-689810083 Fails on py27-cloud: ``` self = def testBuildMap(self): self.assertReturnType( typehints.Dict[typehints.Any, typehints.Any],

[GitHub] [beam] codecov[bot] edited a comment on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-689776953 # [Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr=h1) Report > Merging [#12588](https://codecov.io/gh/apache/beam/pull/12588?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-689776953 # [Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr=h1) Report > Merging [#12588](https://codecov.io/gh/apache/beam/pull/12588?src=pr=desc) into

[GitHub] [beam] danielxjd commented on a change in pull request #12786: [BEAM-7925]Add Column Projection to ParquetIO

2020-09-09 Thread GitBox
danielxjd commented on a change in pull request #12786: URL: https://github.com/apache/beam/pull/12786#discussion_r485891627 ## File path: sdks/java/io/parquet/src/main/java/org/apache/beam/sdk/io/parquet/ParquetIO.java ## @@ -135,6 +135,16 @@ * ... * } * + * Reading

[GitHub] [beam] codecov[bot] edited a comment on pull request #12588: [BEAM-7009] Add Go SDK Standard Coders yaml tests.

2020-09-09 Thread GitBox
codecov[bot] edited a comment on pull request #12588: URL: https://github.com/apache/beam/pull/12588#issuecomment-689776953 # [Codecov](https://codecov.io/gh/apache/beam/pull/12588?src=pr=h1) Report > Merging [#12588](https://codecov.io/gh/apache/beam/pull/12588?src=pr=desc) into

  1   2   >