[GitHub] [beam] codecov[bot] edited a comment on pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12914: URL: https://github.com/apache/beam/pull/12914#issuecomment-697498651 # [Codecov](https://codecov.io/gh/apache/beam/pull/12914?src=pr=h1) Report > Merging [#12914](https://codecov.io/gh/apache/beam/pull/12914?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12912: [BEAM-10938] Adds support for writing a footer to Python WriteToText

2020-09-23 Thread GitBox
pabloem commented on pull request #12912: URL: https://github.com/apache/beam/pull/12912#issuecomment-697924159 this looks good to me! thanks @milancermak Can you please resolve the one formatting issue marked here:

[GitHub] [beam] codecov[bot] edited a comment on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697896263 # [Codecov](https://codecov.io/gh/apache/beam/pull/12524?src=pr=h1) Report > Merging [#12524](https://codecov.io/gh/apache/beam/pull/12524?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
TheNeuralBit commented on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697922861 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697896263 # [Codecov](https://codecov.io/gh/apache/beam/pull/12524?src=pr=h1) Report > Merging [#12524](https://codecov.io/gh/apache/beam/pull/12524?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on pull request #12921: [BEAM-10009] Document micros_instant

2020-09-23 Thread GitBox
TheNeuralBit commented on pull request #12921: URL: https://github.com/apache/beam/pull/12921#issuecomment-697913682 Note support for micros_instant was added in https://github.com/apache/beam/pull/12764 This is an

[GitHub] [beam] TheNeuralBit commented on pull request #12921: [BEAM-10009] Document micros_instant

2020-09-23 Thread GitBox
TheNeuralBit commented on pull request #12921: URL: https://github.com/apache/beam/pull/12921#issuecomment-697912832 R: @lukecwik This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] TheNeuralBit opened a new pull request #12921: [BEAM-10009] Document micros_instant

2020-09-23 Thread GitBox
TheNeuralBit opened a new pull request #12921: URL: https://github.com/apache/beam/pull/12921 Post-Commit Tests Status (on master branch) Lang | SDK | Dataflow | Flink | Samza | Spark

[GitHub] [beam] codecov[bot] edited a comment on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697872427 # [Codecov](https://codecov.io/gh/apache/beam/pull/12920?src=pr=h1) Report > Merging [#12920](https://codecov.io/gh/apache/beam/pull/12920?src=pr=desc) into

[GitHub] [beam] reuvenlax commented on a change in pull request #12915: [BEAM-7386] Introduce temporal inner join.

2020-09-23 Thread GitBox
reuvenlax commented on a change in pull request #12915: URL: https://github.com/apache/beam/pull/12915#discussion_r493832669 ## File path: sdks/java/extensions/join-library/src/main/java/org/apache/beam/sdk/extensions/joinlibrary/Join.java ## @@ -350,6 +368,276 @@ public void

[GitHub] [beam] codecov[bot] edited a comment on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697896263 # [Codecov](https://codecov.io/gh/apache/beam/pull/12524?src=pr=h1) Report > Merging [#12524](https://codecov.io/gh/apache/beam/pull/12524?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697908458 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] reuvenlax commented on pull request #12915: [BEAM-7386] Introduce temporal inner join.

2020-09-23 Thread GitBox
reuvenlax commented on pull request #12915: URL: https://github.com/apache/beam/pull/12915#issuecomment-697906615 Out of curiosity, why are you adding this here instead of the schema join library (which SQL uses)? This is

[GitHub] [beam] kileys commented on pull request #12899: [BEAM-8024] Add JPMS E2E test

2020-09-23 Thread GitBox
kileys commented on pull request #12899: URL: https://github.com/apache/beam/pull/12899#issuecomment-697905316 @kennknowles can you run the seed job so I can test the new job? This is an automated message from the Apache Git

[GitHub] [beam] tvalentyn commented on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697901840 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] tvalentyn merged pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn merged pull request #12911: URL: https://github.com/apache/beam/pull/12911 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] codecov[bot] commented on pull request #12524: [BEAM-10586] Remove Python 2.7 and Python 3.5 support in Dataflow runner.

2020-09-23 Thread GitBox
codecov[bot] commented on pull request #12524: URL: https://github.com/apache/beam/pull/12524#issuecomment-697896263 # [Codecov](https://codecov.io/gh/apache/beam/pull/12524?src=pr=h1) Report > Merging [#12524](https://codecov.io/gh/apache/beam/pull/12524?src=pr=desc) into

[GitHub] [beam] TheNeuralBit commented on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
TheNeuralBit commented on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697896600 Run PythonDocker PreCommit This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] tvalentyn commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697895137 Opened https://issues.apache.org/jira/browse/BEAM-10955 for Java Flink runner flake. Merging based on passing precommit singals and prior green test signals to unblock testing

[GitHub] [beam] codecov[bot] edited a comment on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697872427 # [Codecov](https://codecov.io/gh/apache/beam/pull/12920?src=pr=h1) Report > Merging [#12920](https://codecov.io/gh/apache/beam/pull/12920?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12918: URL: https://github.com/apache/beam/pull/12918#issuecomment-697859700 # [Codecov](https://codecov.io/gh/apache/beam/pull/12918?src=pr=h1) Report > Merging [#12918](https://codecov.io/gh/apache/beam/pull/12918?src=pr=desc) into

[GitHub] [beam] pabloem commented on pull request #12912: [BEAM-10938] Adds support for writing a footer to Python WriteToText

2020-09-23 Thread GitBox
pabloem commented on pull request #12912: URL: https://github.com/apache/beam/pull/12912#issuecomment-697881373 happy to take a look. Thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12918: URL: https://github.com/apache/beam/pull/12918#issuecomment-697859700 # [Codecov](https://codecov.io/gh/apache/beam/pull/12918?src=pr=h1) Report > Merging [#12918](https://codecov.io/gh/apache/beam/pull/12918?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697872427 # [Codecov](https://codecov.io/gh/apache/beam/pull/12920?src=pr=h1) Report > Merging [#12920](https://codecov.io/gh/apache/beam/pull/12920?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
codecov[bot] commented on pull request #12920: URL: https://github.com/apache/beam/pull/12920#issuecomment-697872427 # [Codecov](https://codecov.io/gh/apache/beam/pull/12920?src=pr=h1) Report > Merging [#12920](https://codecov.io/gh/apache/beam/pull/12920?src=pr=desc) into

[GitHub] [beam] iemejia merged pull request #12917: [BEAM-2546] InfluxDbIO: update CHANGES.md and add some checks

2020-09-23 Thread GitBox
iemejia merged pull request #12917: URL: https://github.com/apache/beam/pull/12917 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12780: [BEAM-5504] Add Pubsub Avro table provider

2020-09-23 Thread GitBox
TheNeuralBit commented on a change in pull request #12780: URL: https://github.com/apache/beam/pull/12780#discussion_r493808986 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/DropFields.java ## @@ -85,9 +85,8 @@ private

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12780: [BEAM-5504] Add Pubsub Avro table provider

2020-09-23 Thread GitBox
TheNeuralBit commented on a change in pull request #12780: URL: https://github.com/apache/beam/pull/12780#discussion_r493808821 ## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/schemas/transforms/DropFields.java ## @@ -85,9 +85,8 @@ private

[GitHub] [beam] codecov[bot] edited a comment on pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12918: URL: https://github.com/apache/beam/pull/12918#issuecomment-697859700 # [Codecov](https://codecov.io/gh/apache/beam/pull/12918?src=pr=h1) Report > Merging [#12918](https://codecov.io/gh/apache/beam/pull/12918?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
codecov[bot] commented on pull request #12918: URL: https://github.com/apache/beam/pull/12918#issuecomment-697859700 # [Codecov](https://codecov.io/gh/apache/beam/pull/12918?src=pr=h1) Report > Merging [#12918](https://codecov.io/gh/apache/beam/pull/12918?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] Vasu7052 commented on pull request #12919: [BEAM-10832] Fixed ClickhouseIO's getTableSchema method is called before Pipeline Starts

2020-09-23 Thread GitBox
Vasu7052 commented on pull request #12919: URL: https://github.com/apache/beam/pull/12919#issuecomment-697847935 R:@kanterov This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [beam] TheNeuralBit opened a new pull request #12920: [BEAM-9547] Roll forward #12858

2020-09-23 Thread GitBox
TheNeuralBit opened a new pull request #12920: URL: https://github.com/apache/beam/pull/12920 This is a roll forward of #12858 (rolled back in #12910), but with an additional commit. It removes the ability for `_WriteToPandas.__ror__` to accept and convert a `DeferredBase` as this

[GitHub] [beam] Vasu7052 opened a new pull request #12919: [BEAM-10832] Fixed ClickhouseIO's getTableSchema method is called before Pipeline Starts

2020-09-23 Thread GitBox
Vasu7052 opened a new pull request #12919: URL: https://github.com/apache/beam/pull/12919 Have Moved **getTableSchema** method from expand to setup in ClickHouseIO so that **getTableSchema** method is executed only when pipeline starts not at the time of deployment.

[GitHub] [beam] chamikaramj commented on a change in pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
chamikaramj commented on a change in pull request #12888: URL: https://github.com/apache/beam/pull/12888#discussion_r493800318 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -992,6 +1012,43 @@ def expand(self, pcoll): 'A sink must inherit iobase.Sink,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-692876818 # [Codecov](https://codecov.io/gh/apache/beam/pull/12806?src=pr=h1) Report > Merging [#12806](https://codecov.io/gh/apache/beam/pull/12806?src=pr=desc) into

[GitHub] [beam] milancermak commented on pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
milancermak commented on pull request #12918: URL: https://github.com/apache/beam/pull/12918#issuecomment-697829038 R: @pabloem This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] milancermak opened a new pull request #12918: BEAM-10910: Validate the BigQuery table name before creating one

2020-09-23 Thread GitBox
milancermak opened a new pull request #12918: URL: https://github.com/apache/beam/pull/12918 Resolves [BEAM-10910](https://issues.apache.org/jira/browse/BEAM-10910) by raising a `ValueError` when the table name is invalid (too long or contains invalid characters).

[GitHub] [beam] pabloem merged pull request #12800: [BEAM-10603] Add the ib.recordings API

2020-09-23 Thread GitBox
pabloem merged pull request #12800: URL: https://github.com/apache/beam/pull/12800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] boyuanzz commented on a change in pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
boyuanzz commented on a change in pull request #12888: URL: https://github.com/apache/beam/pull/12888#discussion_r493782709 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -992,6 +1012,43 @@ def expand(self, pcoll): 'A sink must inherit iobase.Sink,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696562704 # [Codecov](https://codecov.io/gh/apache/beam/pull/12888?src=pr=h1) Report > Merging [#12888](https://codecov.io/gh/apache/beam/pull/12888?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493772077 ## File path: sdks/python/apache_beam/__init__.py ## @@ -94,9 +86,8 @@ pass else: raise RuntimeError( - 'The Apache Beam SDK for Python is

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
TheNeuralBit commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493771788 ## File path: release/src/main/python-release/python_release_automation_utils.sh ## @@ -78,22 +78,18 @@ function get_version() { #

[GitHub] [beam] tvalentyn commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493772077 ## File path: sdks/python/apache_beam/__init__.py ## @@ -94,9 +86,8 @@ pass else: raise RuntimeError( - 'The Apache Beam SDK for Python is

[GitHub] [beam] tvalentyn commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493771284 ## File path: release/src/main/python-release/python_release_automation_utils.sh ## @@ -78,22 +78,18 @@ function get_version() { # BEAM_PYTHON_SDK*

[GitHub] [beam] codecov[bot] edited a comment on pull request #12800: [BEAM-10603] Add the ib.recordings API

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12800: URL: https://github.com/apache/beam/pull/12800#issuecomment-696921394 # [Codecov](https://codecov.io/gh/apache/beam/pull/12800?src=pr=h1) Report > Merging [#12800](https://codecov.io/gh/apache/beam/pull/12800?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493769512 ## File path: .test-infra/jenkins/README.md ## @@ -109,7 +109,6 @@ Beam Jenkins overview page: [link](https://ci-beam.apache.org/) |

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] tvalentyn commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697752658 Noting that all tests passed. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [beam] codecov[bot] edited a comment on pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12727: URL: https://github.com/apache/beam/pull/12727#issuecomment-683229966 # [Codecov](https://codecov.io/gh/apache/beam/pull/12727?src=pr=h1) Report > Merging [#12727](https://codecov.io/gh/apache/beam/pull/12727?src=pr=desc) into

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493764967 ## File path: sdks/python/apache_beam/transforms/environments.py ## @@ -252,6 +254,13 @@ def from_runner_api_parameter(payload, capabilities, artifacts,

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493764637 ## File path: sdks/python/apache_beam/options/pipeline_options.py ## @@ -1003,6 +1003,13 @@ def _add_argparse_args(cls, parser): 'environment.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] y1chi commented on a change in pull request #12727: [BEAM-10844] Add experiment option prebuild_sdk_container to prebuild python sdk container with dependencies.

2020-09-23 Thread GitBox
y1chi commented on a change in pull request #12727: URL: https://github.com/apache/beam/pull/12727#discussion_r493760627 ## File path: sdks/python/apache_beam/runners/portability/sdk_container_builder.py ## @@ -0,0 +1,279 @@ +# +# Licensed to the Apache Software Foundation

[GitHub] [beam] codecov[bot] edited a comment on pull request #12800: [BEAM-10603] Add the ib.recordings API

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12800: URL: https://github.com/apache/beam/pull/12800#issuecomment-696921394 # [Codecov](https://codecov.io/gh/apache/beam/pull/12800?src=pr=h1) Report > Merging [#12800](https://codecov.io/gh/apache/beam/pull/12800?src=pr=desc) into

[GitHub] [beam] aromanenko-dev opened a new pull request #12917: [BEAM-2546] InfluxDbIO: update CHANGES.md and add some checks

2020-09-23 Thread GitBox
aromanenko-dev opened a new pull request #12917: URL: https://github.com/apache/beam/pull/12917 R: @iemejia Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily: - [x] [**Choose

[GitHub] [beam] chamikaramj commented on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
chamikaramj commented on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-697727612 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] codecov[bot] edited a comment on pull request #12800: [BEAM-10603] Add the ib.recordings API

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12800: URL: https://github.com/apache/beam/pull/12800#issuecomment-696921394 # [Codecov](https://codecov.io/gh/apache/beam/pull/12800?src=pr=h1) Report > Merging [#12800](https://codecov.io/gh/apache/beam/pull/12800?src=pr=desc) into

[GitHub] [beam] pabloem closed pull request #12800: [BEAM-10603] Add the ib.recordings API

2020-09-23 Thread GitBox
pabloem closed pull request #12800: URL: https://github.com/apache/beam/pull/12800 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [beam] rincon-santi opened a new pull request #12916: Added explanation and examples for dynamic destination data writing to big query (python)

2020-09-23 Thread GitBox
rincon-santi opened a new pull request #12916: URL: https://github.com/apache/beam/pull/12916 I have found that now it's possible to apply dynamic destination with python when saving in big query tables through IO, and updated the documentation accordingly. Source:

[GitHub] [beam] rosetn commented on pull request #12892: [BEAM-10937] Add first introductory notebook

2020-09-23 Thread GitBox
rosetn commented on pull request #12892: URL: https://github.com/apache/beam/pull/12892#issuecomment-697683282 SGTM. I'm in favor of placements that lets users know where they can find all of the interactive notebooks at try them out. Querying "apache beam notebooks" on the Google search

[GitHub] [beam] ajamato commented on a change in pull request #12852: [BEAM-10890] Log error counts to debug BigQuery streaming insert requ…

2020-09-23 Thread GitBox
ajamato commented on a change in pull request #12852: URL: https://github.com/apache/beam/pull/12852#discussion_r493738743 ## File path: sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/StreamingWriteFn.java ## @@ -150,24 +143,42 @@ public

[GitHub] [beam] TheNeuralBit commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
TheNeuralBit commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697671253 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
TheNeuralBit commented on a change in pull request #12911: URL: https://github.com/apache/beam/pull/12911#discussion_r493737145 ## File path: sdks/python/apache_beam/__init__.py ## @@ -94,9 +86,8 @@ pass else: raise RuntimeError( - 'The Apache Beam SDK for Python

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] davidcavazos commented on pull request #12892: [BEAM-10937] Add first introductory notebook

2020-09-23 Thread GitBox
davidcavazos commented on pull request #12892: URL: https://github.com/apache/beam/pull/12892#issuecomment-697663116 I was thinking on the "Get Started" section, and probably replace the "Try Beam" button in the main landing page with the "Tour of Beam" page once it's done. The "Try Beam"

[GitHub] [beam] tvalentyn commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697659016 cc: @robinyqiu This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tvalentyn commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697658614 Run Seed Job This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] rosetn commented on pull request #12892: [BEAM-10937] Add first introductory notebook

2020-09-23 Thread GitBox
rosetn commented on pull request #12892: URL: https://github.com/apache/beam/pull/12892#issuecomment-697653820 Where were we planning on hosting this? On the main landing page https://beam.apache.org/ or Documentation landing page https://beam.apache.org/documentation/ ?

[GitHub] [beam] tvalentyn commented on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
tvalentyn commented on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697651001 > Run XVR_Direct PostCommit @TheNeuralBit we'd need to re-run a seed job first > 09:25:42 Could not determine the dependencies of task

[GitHub] [beam] chamikaramj closed pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
chamikaramj closed pull request #12914: URL: https://github.com/apache/beam/pull/12914 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [beam] chamikaramj commented on a change in pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
chamikaramj commented on a change in pull request #12888: URL: https://github.com/apache/beam/pull/12888#discussion_r493728664 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -992,6 +1012,43 @@ def expand(self, pcoll): 'A sink must inherit iobase.Sink,

[GitHub] [beam] codecov[bot] edited a comment on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696562704 # [Codecov](https://codecov.io/gh/apache/beam/pull/12888?src=pr=h1) Report > Merging [#12888](https://codecov.io/gh/apache/beam/pull/12888?src=pr=desc) into

[GitHub] [beam] codecov[bot] edited a comment on pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12911: URL: https://github.com/apache/beam/pull/12911#issuecomment-697122845 # [Codecov](https://codecov.io/gh/apache/beam/pull/12911?src=pr=h1) Report > Merging [#12911](https://codecov.io/gh/apache/beam/pull/12911?src=pr=desc) into

[GitHub] [beam] sambvfx commented on a change in pull request #12905: [BEAM-8660] Use PortableOptions.artifact_endpoint if provided over value reported from jobserver

2020-09-23 Thread GitBox
sambvfx commented on a change in pull request #12905: URL: https://github.com/apache/beam/pull/12905#discussion_r493726113 ## File path: sdks/python/apache_beam/runners/portability/portable_runner.py ## @@ -105,9 +106,11 @@ def submit(self, proto_pipeline): Submit and run

[GitHub] [beam] codecov[bot] edited a comment on pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12888: URL: https://github.com/apache/beam/pull/12888#issuecomment-696562704 # [Codecov](https://codecov.io/gh/apache/beam/pull/12888?src=pr=h1) Report > Merging [#12888](https://codecov.io/gh/apache/beam/pull/12888?src=pr=desc) into

[GitHub] [beam] aromanenko-dev commented on pull request #12850: [BEAM-10481] Ensure registration of the accumulator occurs.

2020-09-23 Thread GitBox
aromanenko-dev commented on pull request #12850: URL: https://github.com/apache/beam/pull/12850#issuecomment-697635483 @ibzib I see that `beam_PostCommit_Java_PVR_Spark_Streaming_PR` fails for this PR. Do you think it could be related to this change or it's just flaky tests?

[GitHub] [beam] TheNeuralBit commented on a change in pull request #12882: [BEAM-10814][BEAM-10570] DataframeTransform outputs elements

2020-09-23 Thread GitBox
TheNeuralBit commented on a change in pull request #12882: URL: https://github.com/apache/beam/pull/12882#discussion_r493712516 ## File path: build.gradle ## @@ -199,7 +199,6 @@ task goIntegrationTests() { task pythonPreCommit() { dependsOn

[GitHub] [beam] lukecwik commented on pull request #12874: [BEAM-10930] Use dense JSON responses for BigQueryIO interactions

2020-09-23 Thread GitBox
lukecwik commented on pull request #12874: URL: https://github.com/apache/beam/pull/12874#issuecomment-697597588 Run Java PreCommit This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] lukecwik edited a comment on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-23 Thread GitBox
lukecwik edited a comment on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-697552813 Based upon the python precommit results, this PR is blocked until the updated Dataflow runner v2 gets released containing your changes. I believe @angoenka is

[GitHub] [beam] lukecwik commented on pull request #12806: [BEAM-10869] Make WriteToPubsub output serialized PubsubMessage proto bytes when using runner v2

2020-09-23 Thread GitBox
lukecwik commented on pull request #12806: URL: https://github.com/apache/beam/pull/12806#issuecomment-697552813 Based upon the python precommit results, this PR is blocked until the updated Dataflow runner v2 gets released containing your changes.

[GitHub] [beam] codecov[bot] edited a comment on pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12914: URL: https://github.com/apache/beam/pull/12914#issuecomment-697498651 # [Codecov](https://codecov.io/gh/apache/beam/pull/12914?src=pr=h1) Report > Merging [#12914](https://codecov.io/gh/apache/beam/pull/12914?src=pr=desc) into

[GitHub] [beam] tysonjh commented on pull request #12915: [BEAM-7386] Introduce temporal inner join.

2020-09-23 Thread GitBox
tysonjh commented on pull request #12915: URL: https://github.com/apache/beam/pull/12915#issuecomment-697542150 /cc @kennknowles This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] tysonjh commented on pull request #12915: [BEAM-7386] Introduce temporal inner join.

2020-09-23 Thread GitBox
tysonjh commented on pull request #12915: URL: https://github.com/apache/beam/pull/12915#issuecomment-697541038 R: @reuvenlax This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [beam] tysonjh opened a new pull request #12915: [BEAM-7386] Introduce temporal inner join.

2020-09-23 Thread GitBox
tysonjh opened a new pull request #12915: URL: https://github.com/apache/beam/pull/12915 Similar to other inner joins except it includes a temporal predicate, allowing users to join unbounded PCollections in the GlobalWindow. Thank you for your

[GitHub] [beam] codecov[bot] edited a comment on pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
codecov[bot] edited a comment on pull request #12914: URL: https://github.com/apache/beam/pull/12914#issuecomment-697498651 # [Codecov](https://codecov.io/gh/apache/beam/pull/12914?src=pr=h1) Report > Merging [#12914](https://codecov.io/gh/apache/beam/pull/12914?src=pr=desc) into

[GitHub] [beam] codecov[bot] commented on pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
codecov[bot] commented on pull request #12914: URL: https://github.com/apache/beam/pull/12914#issuecomment-697498651 # [Codecov](https://codecov.io/gh/apache/beam/pull/12914?src=pr=h1) Report > Merging [#12914](https://codecov.io/gh/apache/beam/pull/12914?src=pr=desc) into

[GitHub] [beam] chamikaramj opened a new pull request #12914: [BEAM-10861] Revert "[BEAM-10861] Adds URNs and payloads to PubSub transforms to allow runner-native overrides"

2020-09-23 Thread GitBox
chamikaramj opened a new pull request #12914: URL: https://github.com/apache/beam/pull/12914 Reverts apache/beam#12760 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [beam] chamikaramj commented on a change in pull request #12888: [BEAM-10861]Moves PubSub Runner API encoding to Read/Write transforms

2020-09-23 Thread GitBox
chamikaramj commented on a change in pull request #12888: URL: https://github.com/apache/beam/pull/12888#discussion_r493650482 ## File path: sdks/python/apache_beam/io/iobase.py ## @@ -992,6 +1012,43 @@ def expand(self, pcoll): 'A sink must inherit iobase.Sink,

[GitHub] [beam] milancermak commented on pull request #12913: Minor fixes to the get-started/wordcount-example webpage.

2020-09-23 Thread GitBox
milancermak commented on pull request #12913: URL: https://github.com/apache/beam/pull/12913#issuecomment-697440509 Not sure who the reviewer should be here. Maybe @melap or @rakeshcusat? This is an automated message from

[GitHub] [beam] milancermak opened a new pull request #12913: Minor fixes to the get-started/wordcount-example webpage.

2020-09-23 Thread GitBox
milancermak opened a new pull request #12913: URL: https://github.com/apache/beam/pull/12913 As I was going through the [wordcount example](https://beam.apache.org/get-started/wordcount-example/) in the Get started tutorial, I've noticed two minor issues. 1) In the Python example

[GitHub] [beam] milancermak commented on pull request #12912: [BEAM-10938] Adds support for writing a footer to Python WriteToText

2020-09-23 Thread GitBox
milancermak commented on pull request #12912: URL: https://github.com/apache/beam/pull/12912#issuecomment-697367111 @pabloem Hi, could you please review this PR? I chose you since you're in the OWNERS file and your name came up in git blame on the `textio.py` file. I hope it's ok. If not,

[GitHub] [beam] milancermak opened a new pull request #12912: [BEAM-10938] Adds support for writing a footer to Python WriteToText

2020-09-23 Thread GitBox
milancermak opened a new pull request #12912: URL: https://github.com/apache/beam/pull/12912 Implementation of [BEAM-10938](https://issues.apache.org/jira/browse/BEAM-10938) Adds support for writing a footer to the `WriteToText` transform.

<    1   2   3   >