[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-641674257 Thanks all for patiently reviewing this PR and providing valuable feedback. This is an automated message from

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-629979195 Failed org.apache.beam.examples.WordCountIT > testE2EWordCount FAILED Task :runners:google-cloud-dataflow-java:examples-streaming:windmillPreCommit FAILED @amaliujia

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-628329202 Thanks @amaliujia I have create a JIRA: https://issues.apache.org/jira/browse/BEAM-9992 based on my understanding of what is required to be implemented Can you add more

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-626458097 @amaliujia @robertwb : Do we verify WindowFns for all pCollections to be the same with first in the list? This

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-626165907 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-625633642 > > > Thanks! > > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624558849 retest this please This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-624484915 > Thanks! > > In terms of naming, I found it surprising that union (for example) does deduplication. Maybe name them distinctUnion and multisetUnion or something like

[GitHub] [beam] darshanj commented on pull request #11610: [BEAM-9825] | Implement Intersect,Union,Except transforms

darshanj commented on pull request #11610: URL: https://github.com/apache/beam/pull/11610#issuecomment-623929233 @amaliujia This is an automated message from the Apache Git Service. To respond to the message, please log on