[GitHub] [beam] mxm commented on pull request #12385: [BEAM-10527] Migrate Flink and Spark tests to pytest.

2020-10-01 Thread GitBox
mxm commented on pull request #12385: URL: https://github.com/apache/beam/pull/12385#issuecomment-702305517 This looks good to me after rebasing. Thanks for porting this to pytest! This is an automated message from the

[GitHub] [beam] mxm commented on pull request #12385: [BEAM-10527] Migrate Flink and Spark tests to pytest.

2020-08-11 Thread GitBox
mxm commented on pull request #12385: URL: https://github.com/apache/beam/pull/12385#issuecomment-672090815 > > > I have already spent a long time trying to fix quotes, so I can't help but wondering: why do we need flinkCompatibilityMatrixPROCESS in the first place, when it is not being

[GitHub] [beam] mxm commented on pull request #12385: [BEAM-10527] Migrate Flink and Spark tests to pytest.

2020-08-03 Thread GitBox
mxm commented on pull request #12385: URL: https://github.com/apache/beam/pull/12385#issuecomment-667895488 Thanks for fixing the quoting issue! > I got `flinkCompatibilityMatrixPROCESS` to pass on my machine by escaping the arguments via `${1@Q}`. Apparently whatever shell Jenkins