[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-30 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r463273363 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeStreamingServiceConfig.java ## @@ -20,26 +20,51 @@

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-30 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r463219932 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -719,7 +906,9 @@ private void checkArguments()

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-14 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r454524365 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -684,14 +819,61 @@ private void

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-13 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r453845146 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeStreamingServiceImpl.java ## @@ -0,0 +1,68 @@ +/* +

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-08 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r451303970 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeBatchServiceConfig.java ## @@ -0,0 +1,120 @@ +/* +

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-08 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r451303970 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/services/SnowflakeBatchServiceConfig.java ## @@ -0,0 +1,120 @@ +/* +

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-08 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r451294464 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -684,14 +819,61 @@ private void

[GitHub] [beam] pabloem commented on a change in pull request #12151: [BEAM-9896] Add streaming for SnowflakeIO.Write to Java SDK

2020-07-08 Thread GitBox
pabloem commented on a change in pull request #12151: URL: https://github.com/apache/beam/pull/12151#discussion_r451286482 ## File path: sdks/java/io/snowflake/src/main/java/org/apache/beam/sdk/io/snowflake/SnowflakeIO.java ## @@ -644,6 +747,26 @@ public void