[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-16 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-693300538 Run Python PreCommit This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-14 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-692507849 @chamikaramj ping This is an automated message from the Apache Git Service. To respond to the message, p

[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-09 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-690007059 @chamikaramj Done This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-04 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-686969979 > Please keep this in apache_beam.io instead of apache_beam.io.external. There's not much value in differentiating cross-language IO connectors from other connectors. If

[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-03 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-686495631 > Please keep this in apache_beam.io instead of apache_beam.io.external. There's not much value in differentiating cross-language IO connectors from other connectors. If

[GitHub] [beam] piotr-szuberski commented on pull request #12758: [BEAM-9898] Move snowflake.py from apache_beam.io to apache_beam.io.external for backwards compatibility

2020-09-02 Thread GitBox
piotr-szuberski commented on pull request #12758: URL: https://github.com/apache/beam/pull/12758#issuecomment-685849924 @chamikaramj Could I ask you for review and for the decision what is the preferable approach? Move snowflake.py to .io.external or leave it in .io and do the same thing a